Attention is currently required from: Paul Menzel.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76042?usp=email )
Change subject: util/qemu: Add config for AArch64
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76042/comment/149497cb_c3c1612f :
PS2, Line 11:
> > Maybe document how to run it? […]
Probably should have added it to `make help` in the
first place. I'm just used to look into Makefiles for
make targets :)
Let's decide where's the best place and put that into
a follow up?
--
To view, visit https://review.coreboot.org/c/coreboot/+/76042?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id7f23918a786bc126188d5caf285e9f532dbb0ed
Gerrit-Change-Number: 76042
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Thu, 22 Jun 2023 10:00:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Paul Menzel.
Hello Arthur Heymans, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/76042?usp=email
to look at the new patch set (#3).
Change subject: util/qemu: Add config for AArch64
......................................................................
util/qemu: Add config for AArch64
Most arguments taken from the Kconfig help. RAM needs to be >= 531M,
as coreboot is linked to reside between 512M..531M.
Tested `make qemu` with QEMU 7.2.0.
Change-Id: Id7f23918a786bc126188d5caf285e9f532dbb0ed
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
---
M util/qemu/Makefile.inc
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/76042/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/76042?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id7f23918a786bc126188d5caf285e9f532dbb0ed
Gerrit-Change-Number: 76042
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Christian Walter, Julius Werner, Tim Crawford.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75997?usp=email )
Change subject: UNTESTED: security/crtm: Don't measure anything on S3 resume
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
> This is causing a full boot but still somehow reporting it as S3 Resume.
>
> Here is the log from system76/oryp11: https://dpaste.org/NMYjV
>
> Note: This is still on a 4.19 base.
I'm not sure I understand. Is a cold boot being reported as S3 resume?
Latest CL should now skip creating a digest on S3 resume.
--
To view, visit https://review.coreboot.org/c/coreboot/+/75997?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic4ed5a3ca8bb2f82931e08348754c173d7a78c53
Gerrit-Change-Number: 75997
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Thu, 22 Jun 2023 09:27:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Crawford <tcrawford(a)system76.com>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Christian Walter.
Hello Christian Walter, Tim Crawford, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75997?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: UNTESTED: security/crtm: Don't measure anything on S3 resume
......................................................................
UNTESTED: security/crtm: Don't measure anything on S3 resume
To quote the TCG PC Client Platform Firmware Profile
Specification:
"7.3.9 S3 (Sleep) to S0 (Working)
This transition is a resume from an S3 suspend state. Host Platform
Reset and TPM_INIT are asserted. The SRTM issues the TPM2_Startup(STATE)
command, loading the previously saved state, without re-measuring Pre-OS
components. The SRTM passes2395 control to the OS. If there are any
changes to the Host Platform’s components or configuration, measuring
these changes is the responsibility of the OS"
Therefore coreboot should not measure anything in either the logs or PCR
on S3 resume.
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
Change-Id: Ic4ed5a3ca8bb2f82931e08348754c173d7a78c53
---
M src/lib/cbfs.c
M src/security/tpm/tspi/crtm.c
2 files changed, 9 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/75997/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/75997?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic4ed5a3ca8bb2f82931e08348754c173d7a78c53
Gerrit-Change-Number: 75997
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Attention is currently required from: Pratikkumar V Prajapati, Tarun Tuli.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75999?usp=email )
Change subject: soc/intel/meteorlake: Rename shared sram aliases
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75999/comment/e3511813_7aa0b00d :
PS2, Line 7: sram
nit: `SRAM`. Here and below in the commit message
https://review.coreboot.org/c/coreboot/+/75999/comment/37ef45fe_cbee8578 :
PS2, Line 19: TEST=Able to build.
I'd suggest at least using util/abuild tests on affected boards: `util/abuild/abuild -p none -t google/rex -x -a` (requires `make crossgcc-i386`)
--
To view, visit https://review.coreboot.org/c/coreboot/+/75999?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I02a8cacc075f396549703d7a008382e76258f865
Gerrit-Change-Number: 75999
Gerrit-PatchSet: 2
Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com>
Gerrit-Comment-Date: Thu, 22 Jun 2023 08:19:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Paul Menzel.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76042?usp=email )
Change subject: util/qemu: Add config for AArch64
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76042/comment/9af4cc1f_cecb5b51 :
PS2, Line 11:
> Maybe document how to run it?
>
> What QEMU version did you test with?
The comments above say it: 'make qemu' ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/76042?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id7f23918a786bc126188d5caf285e9f532dbb0ed
Gerrit-Change-Number: 76042
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Thu, 22 Jun 2023 07:31:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Nico Huber.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76042?usp=email )
Change subject: util/qemu: Add config for AArch64
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76042/comment/26d89428_5ce4e1e5 :
PS2, Line 11:
Maybe document how to run it?
What QEMU version did you test with?
--
To view, visit https://review.coreboot.org/c/coreboot/+/76042?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id7f23918a786bc126188d5caf285e9f532dbb0ed
Gerrit-Change-Number: 76042
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Thu, 22 Jun 2023 07:29:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, Pratikkumar V Prajapati, Tarun Tuli.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75999?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/intel/meteorlake: Rename shared sram aliases
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75999/comment/bae5901b_9f4f2642 :
PS2, Line 9: share
share*d*?
https://review.coreboot.org/c/coreboot/+/75999/comment/6d8846c1_61b9052c :
PS2, Line 9: Rename share sram aliases for IOE and PMC to make them
: more readable.
Fits in one line (72 characters).
https://review.coreboot.org/c/coreboot/+/75999/comment/5561bb22_952ce7ba :
PS2, Line 11:
Maybe explicitly list the old/new keywords:
1. shared_sram
1. shared_sram2 → …
--
To view, visit https://review.coreboot.org/c/coreboot/+/75999?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I02a8cacc075f396549703d7a008382e76258f865
Gerrit-Change-Number: 75999
Gerrit-PatchSet: 2
Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com>
Gerrit-Comment-Date: Thu, 22 Jun 2023 07:28:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Elyes Haouas.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76048?usp=email )
Change subject: device/resource_allocator_v4: Restor back indentation
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76048/comment/9393e988_404ccade :
PS1, Line 7: Restor back indentation
Maybe:
> Restore alignment of log message
https://review.coreboot.org/c/coreboot/+/76048/comment/a8592ad5_254b766e :
PS1, Line 9: Change-Id: I3ff2081 breaks an indenration in a log message.
Please use “commit … (…)”.
--
To view, visit https://review.coreboot.org/c/coreboot/+/76048?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I377b84bc7c8be32a697cdb6af1823b43c4451a81
Gerrit-Change-Number: 76048
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Thu, 22 Jun 2023 07:26:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Sean Rhodes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/74915?usp=email )
Change subject: mb/starlabs/lite: Remove SMI workaround
......................................................................
Abandoned
Not needed
--
To view, visit https://review.coreboot.org/c/coreboot/+/74915?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8f91754e4cfc5718c1d0e471a8d647a7e78fb6c2
Gerrit-Change-Number: 74915
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: abandon