Attention is currently required from: Dinesh Gehlot, Lance Zhao, Subrata Banik, Tarun Tuli.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70502?usp=email )
Change subject: device/device.h: Drop acpi_inject_dsdt
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> isn't this a good feature ? we are discussing something with Intel where we proposed to use DSDT injection logic rather SSDT. Typically any SoC fixed configuration like PCI devices alway stayed inside DSDT .
DSDT is for static code that can be generated based on ASL. SSDT is for runtime genrated code. There should never be a reason why something generated at runtime needs to enter DSDT directly. You can refer to it with External.
--
To view, visit https://review.coreboot.org/c/coreboot/+/70502?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id1e100cf650b3654240dbf19e1ee3069980fbe93
Gerrit-Change-Number: 70502
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Comment-Date: Thu, 22 Jun 2023 13:01:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Lance Zhao, Tim Wawrzynczak.
Hello Lance Zhao, Tim Wawrzynczak, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75904?usp=email
to look at the new patch set (#4).
Change subject: acpi: Load DSDT directly into target location
......................................................................
acpi: Load DSDT directly into target location
Instead of first mapping DSDT and then copying it into the target
location, load it straight away.
This changes DSDT injections to be appended to DSDT file instead of
prepended.
This makes compressing DSDT possible on platforms where cbfs_map only
does return a pointer to a memory mapped medium. On platforms that are
not doing memory mapping this avoid copying DSDT twice in memory (first
cbfs_map, second memcpy to current).
TESTED work on Foxconn G41M & Google Vilboz.
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
Change-Id: I8f5e01da6ab33869c61801de1e7364bb680f44eb
---
M src/acpi/acpi.c
1 file changed, 43 insertions(+), 48 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/75904/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/75904?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8f5e01da6ab33869c61801de1e7364bb680f44eb
Gerrit-Change-Number: 75904
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Lance Zhao, Tim Wawrzynczak.
Hello Lance Zhao, Tim Wawrzynczak, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/76000?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: acpi: Swap XSDT and RSDT in acpi_add_table()
......................................................................
acpi: Swap XSDT and RSDT in acpi_add_table()
If ACPI is above 4G it's not possible to have a valid RSDT pointer in
RSDP, therefore swap RSDT and XSDT. Both are always generated on x86.
On other architectures RSDT is often skipped, e.g. aarch64. On top of
that the OS looks at XSDT first. So unconditionally using XSDT and not
RSDT is fine.
This also deal with the ACPI pointer being above 4G. This currently
never happens with x86 platforms.
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
Change-Id: I6588676186faa896b6076f871d7f8f633db21e70
---
M src/acpi/acpi.c
1 file changed, 25 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/76000/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/76000?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6588676186faa896b6076f871d7f8f633db21e70
Gerrit-Change-Number: 76000
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Lance Zhao, Tim Wawrzynczak.
Hello Lance Zhao, Tim Wawrzynczak, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/76000?usp=email
to look at the new patch set (#4).
Change subject: acpi: Swap XSDT and RSDT in acpi_add_table()
......................................................................
acpi: Swap XSDT and RSDT in acpi_add_table()
If ACPI is above 4G it's not possible to have a valid RSDT pointer in
RSDP, therefore swap RSDT and XSDT. Both are always generated on x86.
On other architectures RSDT is often skipped, e.g. aarch64. On top of
that the OS looks at XSDT first. So unconditionally using XSDT and not
RSDT is fine.
This also deal with the ACPI pointer being above 4G. This currently
never happens with x86 platforms.
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
Change-Id: I6588676186faa896b6076f871d7f8f633db21e70
---
M src/acpi/acpi.c
1 file changed, 25 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/76000/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/76000?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6588676186faa896b6076f871d7f8f633db21e70
Gerrit-Change-Number: 76000
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Lance Zhao, Tim Wawrzynczak.
Hello Lance Zhao, Tim Wawrzynczak, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/76000?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: acpi: Swap XSDT and RSDT in acpi_add_table()
......................................................................
acpi: Swap XSDT and RSDT in acpi_add_table()
If ACPI is above 4G it's not possible to have a valid RSDT pointer in
RSDP, therefore swap RSDT and XSDT. Both are always generated on x86.
On other architecures RSDT is often skipped, e.g. aarch64. On top of
that the OS looks at XSDT first. So unconditionally using XSDT and not
RSDT is fine.
This also deal with the ACPI pointer being above 4G. This currently
never happens with x86 platforms.
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
Change-Id: I6588676186faa896b6076f871d7f8f633db21e70
---
M src/acpi/acpi.c
1 file changed, 25 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/76000/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/76000?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6588676186faa896b6076f871d7f8f633db21e70
Gerrit-Change-Number: 76000
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun Tuli.
Hello Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun Tuli, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75924?usp=email
to look at the new patch set (#4).
Change subject: mb/google/rex: Enable audio BT offload with soundwire audio
......................................................................
mb/google/rex: Enable audio BT offload with soundwire audio
This patch enables BT offload feature on Rex over SSP1.
BT mode is selected via FW_CONFIG and corresponding VGPIOs are
programmed.
Change-Id: I99df78787d9f54c91bcedf6f70352890a715cdb3
Signed-off-by: Uday M Bhat <uday.m.bhat(a)intel.com>
---
M src/mainboard/google/rex/variants/rex0/fw_config.c
M src/mainboard/google/rex/variants/rex0/variant.c
2 files changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/75924/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/75924?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I99df78787d9f54c91bcedf6f70352890a715cdb3
Gerrit-Change-Number: 75924
Gerrit-PatchSet: 4
Gerrit-Owner: Uday Bhat <uday.m.bhat(a)intel.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-MessageType: newpatchset