coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[XS] Change in coreboot[master]: acpi/acpigen.c: Be explicit about char sign
by Arthur Heymans (Code Review) 22 Jun '23

22 Jun '23

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76006?usp=email ) Change subject: acpi/acpigen.c: Be explicit about char sign ...................................................................... acpi/acpigen.c: Be explicit about char sign The sign of 'char' is not standardized and with GCC is architecture dependent. This fixes warnings when compiling this file on arm64. Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: I53b99835b2ffec5d752fc531fd59e4715f61aced --- M src/acpi/acpigen.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/76006/1 diff --git a/src/acpi/acpigen.c b/src/acpi/acpigen.c index fb92b89..e61954f 100644 --- a/src/acpi/acpigen.c +++ b/src/acpi/acpigen.c @@ -187,7 +187,7 @@ acpigen_write_len_f(); acpigen_write_integer(len); for (size_t i = 0; i < len; i++) { - const char c = string[i]; + const signed char c = string[i]; /* Simple ASCII to UTF-16 conversion, replace non ASCII characters */ acpigen_emit_word(c >= 0 ? c : '?'); } -- To view, visit https://review.coreboot.org/c/coreboot/+/76006?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I53b99835b2ffec5d752fc531fd59e4715f61aced Gerrit-Change-Number: 76006 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: [UNTESTED] soc/amd/common/block/acpi/ivrs: conditionally generate eMM...
by Fred Reitberger (Code Review) 22 Jun '23

22 Jun '23

Attention is currently required from: Arthur Heymans, Felix Held, Jason Glenesk, Matt DeVillier, Raul Rangel. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75933?usp=email ) Change subject: [UNTESTED] soc/amd/common/block/acpi/ivrs: conditionally generate eMMC entry ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/75933?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00865cb7caf82547e89eb5e77817e3d8ca5d35dd Gerrit-Change-Number: 75933 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 22 Jun 2023 18:06:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/qemu-aarch64: Move probing dram to read_resources
by Arthur Heymans (Code Review) 22 Jun '23

22 Jun '23

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76004?usp=email ) Change subject: mb/qemu-aarch64: Move probing dram to read_resources ...................................................................... mb/qemu-aarch64: Move probing dram to read_resources Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: Iaaee41aec7806287ef1881372ec8ec47a4cd57d9 --- M src/mainboard/emulation/qemu-aarch64/mainboard.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/76004/1 diff --git a/src/mainboard/emulation/qemu-aarch64/mainboard.c b/src/mainboard/emulation/qemu-aarch64/mainboard.c index 09b983f..4e00b74 100644 --- a/src/mainboard/emulation/qemu-aarch64/mainboard.c +++ b/src/mainboard/emulation/qemu-aarch64/mainboard.c @@ -13,8 +13,6 @@ static void mainboard_enable(struct device *dev) { - int ram_size_mb = probe_ramsize((uintptr_t)_dram, CONFIG_DRAM_SIZE_MB); - ram_resource_kb(dev, 0, (uintptr_t)_dram / KiB, ram_size_mb * KiB); } struct chip_operations mainboard_ops = { @@ -44,6 +42,9 @@ res->flags = IORESOURCE_MEM | IORESOURCE_ASSIGNED; mmio_range(dev, index++, VIRT_PCIE_ECAM_BASE, VIRT_PCIE_ECAM_SIZE); + + int ram_size_mb = probe_ramsize((uintptr_t)_dram, CONFIG_DRAM_SIZE_MB); + ram_resource_kb(dev, index++, (uintptr_t)_dram / KiB, ram_size_mb * KiB); } struct device_operations qemu_aarch64_pci_domain_ops = { -- To view, visit https://review.coreboot.org/c/coreboot/+/76004?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaaee41aec7806287ef1881372ec8ec47a4cd57d9 Gerrit-Change-Number: 76004 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[master]: mb/google/rex: Enable GPIO for BT I2S offload for soundwire config
by Subrata Banik (Code Review) 22 Jun '23

22 Jun '23

Attention is currently required from: Jakub Czapiga, Kapil Porwal, Tarun Tuli, Uday Bhat. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76003?usp=email ) Change subject: mb/google/rex: Enable GPIO for BT I2S offload for soundwire config ...................................................................... Patch Set 3: (2 comments) File src/mainboard/google/rex/variants/rex0/fw_config.c: https://review.coreboot.org/c/coreboot/+/76003/comment/f3fa52ac_fff20720 : PS3, Line 94: BT I2S offload shouldn't this is SNDW ? merge this with previous CL. https://review.coreboot.org/c/coreboot/+/76003/comment/20a6eab8_ac12b62c : PS3, Line 99: printk(BIOS_INFO, "Configure GPIOs for BT offload mode.\n"); Configure GPIOs for BT offload mode with I2S audio ? keep this change alone part of current CL. -- To view, visit https://review.coreboot.org/c/coreboot/+/76003?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I65eae8839d72b266f5239a694c7e57cec856eedf Gerrit-Change-Number: 76003 Gerrit-PatchSet: 3 Gerrit-Owner: Uday Bhat <uday.m.bhat(a)intel.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Uday Bhat <uday.m.bhat(a)intel.com> Gerrit-Comment-Date: Thu, 22 Jun 2023 17:37:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/brya: Add new GFX devices with custom _PLD
by Won Chung (Code Review) 22 Jun '23

22 Jun '23

Attention is currently required from: Subrata Banik, Tarun Tuli. Won Chung has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74407?usp=email ) Change subject: mb/google/brya/var/brya: Add new GFX devices with custom _PLD ...................................................................... Patch Set 10: (1 comment) Patchset: PS10: @subratabanik@google.com Could you take a look at this patch for a review? -- To view, visit https://review.coreboot.org/c/coreboot/+/74407?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia756f842943b8e1f1877db7433641e6bbd05f45b Gerrit-Change-Number: 74407 Gerrit-PatchSet: 10 Gerrit-Owner: Won Chung <wonchung(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Benson Leung <bleung(a)google.com> Gerrit-CC: Prashant Malani <pmalani(a)chromium.org> Gerrit-CC: Sean Paul <seanpaul(a)chromium.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Thu, 22 Jun 2023 17:33:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/brya/var/skolas: Add new GFX devices with custom _PLD
by Won Chung (Code Review) 22 Jun '23

22 Jun '23

Attention is currently required from: Subrata Banik, Tarun Tuli. Won Chung has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74368?usp=email ) Change subject: mb/google/brya/var/skolas: Add new GFX devices with custom _PLD ...................................................................... Patch Set 11: (1 comment) Patchset: PS11: @subratabanik@google.com Could you take a look at this patch for a review? -- To view, visit https://review.coreboot.org/c/coreboot/+/74368?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I889db739d6e006c1753eb8c0d208cf471d09f18d Gerrit-Change-Number: 74368 Gerrit-PatchSet: 11 Gerrit-Owner: Won Chung <wonchung(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Benson Leung <bleung(a)google.com> Gerrit-CC: Prashant Malani <pmalani(a)chromium.org> Gerrit-CC: Sean Paul <seanpaul(a)chromium.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Thu, 22 Jun 2023 17:33:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: new port for Lenovo L420 laptop
by Nicolas Provost (Code Review) 22 Jun '23

22 Jun '23

Attention is currently required from: Alexander Couzens, Felix Singer. Nicolas Provost has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75992?usp=email ) Change subject: new port for Lenovo L420 laptop ...................................................................... Patch Set 7: (15 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/75992/comment/51eec87e_3b4f825a : PS3, Line 6: > Subject line should not end with a period. Please fix. Patchset: PS4: > Hi Nicolas. Thanks for your contribution and welcome to coreboot! 😊 […] Hi Felix. Thanks, I will check this. File src/mainboard/lenovo/l420/Kconfig: https://review.coreboot.org/c/coreboot/+/75992/comment/d2519e48_07ecfd7a : PS4, Line 24: # Workaround for EC/KBC. > remove the empty line and this comment Done https://review.coreboot.org/c/coreboot/+/75992/comment/a18f6a2c_e40aaa95 : PS4, Line 27: # Realtek 8168 > remove the empty line and this comment Done https://review.coreboot.org/c/coreboot/+/75992/comment/12109366_4612134b : PS4, Line 55: int > no need to redefine the type, please remove Done https://review.coreboot.org/c/coreboot/+/75992/comment/d4202f80_dc94c304 : PS4, Line 59: int > no need to redefine the type, please remove Acknowledged https://review.coreboot.org/c/coreboot/+/75992/comment/25cc4573_d293a3e1 : PS4, Line 63: string > no need to redefine the type, please remove Acknowledged https://review.coreboot.org/c/coreboot/+/75992/comment/050a33b6_a0b5123f : PS4, Line 75: config WARNINGS_ARE_ERRORS : default n : : config PAYLOAD_CONFIGFILE : default > These shouldn't be in the mainboard Kconfig, please remove. WARNINGS_ARE_ERRORS is needed while using a non-coreboot toolchain (for now I'm using the native toolchain on my x86 Linux). Anyway, I can remove it (but this option is not available by default). File src/mainboard/lenovo/l420/board_info.txt: https://review.coreboot.org/c/coreboot/+/75992/comment/e61b34f9_776b0692 : PS4, Line 5: Flashrom support: n > probably y? Flashrom on internal (chipset) programmer will not work unless the rom is already unlocked (ME). But an external programmer works using flashrom.. File src/mainboard/lenovo/l420/devicetree.cb: https://review.coreboot.org/c/coreboot/+/75992/comment/e525b193_f84cff81 : PS4, Line 29: # IGD Displays (spread spectrum on) : register "gfx" = "GMA_STATIC_DISPLAYS(1)" : : # Enable DisplayPort Hotplug with 6ms pulse : register "gpu_dp_d_hotplug" = "0x06" : : # Enable Panel as LVDS and configure power delays : register "gpu_panel_port_select" = "PANEL_PORT_LVDS" : register "gpu_panel_power_cycle_delay" = "6" : register "gpu_panel_power_up_delay" = "300" # T1+T2: 30ms : register "gpu_panel_power_down_delay" = "300" # T5+T6: 30ms : register "gpu_panel_power_backlight_on_delay" = "2500" # T3: 200ms : register "gpu_panel_power_backlight_off_delay" = "2500" # T4: 200ms : register "gpu_cpu_backlight" = "0x1155" : r > Move these under the IGD controller Done https://review.coreboot.org/c/coreboot/+/75992/comment/91eea0df_4815f47b : PS4, Line 45: device domain 0 on > Sandybridge has a chipset device tree (at src/northbridge/intel/sandybridge/chipset. […] Done File src/mainboard/lenovo/l420/dsdt.asl: https://review.coreboot.org/c/coreboot/+/75992/comment/88ace753_62de4233 : PS4, Line 24: // global NVS and variables > seems superfluous, remove Done https://review.coreboot.org/c/coreboot/+/75992/comment/74d13f5e_63608915 : PS4, Line 28: Scope (\_SB) { : Device (PCI0) : { : #include <northbridge/intel/sandybridge/acpi/sandybridge.asl> : #include <southbridge/intel/bd82x6x/acpi/pch.asl> : #include <drivers/intel/gma/acpi/default_brightness_levels.asl> : } : } > ``` […] Done File src/mainboard/lenovo/l420/mainboard.c: https://review.coreboot.org/c/coreboot/+/75992/comment/5271a1a6_4fff5345 : PS4, Line 9: // mainboard_enable is executed as first thing after : // enumerate_buses(). > seems superfluous, remove Done File src/mainboard/lenovo/l420/smihandler.c: https://review.coreboot.org/c/coreboot/+/75992/comment/5333a61e_2bba41e0 : PS4, Line 13: /* FIXME: check this */ > checked? Checking this, I remembered the ec on the L420 is not an H8 (as on my old Lenovo x220) but an IT8518. So more work to do.. -- To view, visit https://review.coreboot.org/c/coreboot/+/75992?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0e46810b80af72c608679235585ec8d5a98d48ac Gerrit-Change-Number: 75992 Gerrit-PatchSet: 7 Gerrit-Owner: Nicolas Provost Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 22 Jun 2023 17:21:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: new port for Lenovo L420 laptop
by Nicolas Provost (Code Review) 22 Jun '23

22 Jun '23

Attention is currently required from: Alexander Couzens, Nicolas Provost. Hello Alexander Couzens, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75992?usp=email to look at the new patch set (#7). Change subject: new port for Lenovo L420 laptop ...................................................................... new port for Lenovo L420 laptop Change-Id: I0e46810b80af72c608679235585ec8d5a98d48ac Signed-off-by: Nicolas Provost <dev(a)npsoft.fr> --- A src/mainboard/lenovo/l420/Kconfig A src/mainboard/lenovo/l420/Kconfig.name A src/mainboard/lenovo/l420/Makefile.inc A src/mainboard/lenovo/l420/acpi/ec.asl A src/mainboard/lenovo/l420/acpi/mainboard.asl A src/mainboard/lenovo/l420/acpi/platform.asl A src/mainboard/lenovo/l420/acpi/superio.asl A src/mainboard/lenovo/l420/acpi/thermal.asl A src/mainboard/lenovo/l420/acpi_tables.c A src/mainboard/lenovo/l420/board_info.txt A src/mainboard/lenovo/l420/cmos.default A src/mainboard/lenovo/l420/cmos.layout A src/mainboard/lenovo/l420/data.vbt A src/mainboard/lenovo/l420/devicetree.cb A src/mainboard/lenovo/l420/dsdt.asl A src/mainboard/lenovo/l420/early_init.c A src/mainboard/lenovo/l420/gma-mainboard.ads A src/mainboard/lenovo/l420/gpio.c A src/mainboard/lenovo/l420/hda_verb.c A src/mainboard/lenovo/l420/mainboard.c A src/mainboard/lenovo/l420/smihandler.c A src/mainboard/lenovo/l420/status.txt 22 files changed, 977 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/75992/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/75992?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0e46810b80af72c608679235585ec8d5a98d48ac Gerrit-Change-Number: 75992 Gerrit-PatchSet: 7 Gerrit-Owner: Nicolas Provost Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Nicolas Provost Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: new port for Lenovo L420 laptop
by Nicolas Provost (Code Review) 22 Jun '23

22 Jun '23

Attention is currently required from: Alexander Couzens, Nicolas Provost. Hello Alexander Couzens, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75992?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: new port for Lenovo L420 laptop ...................................................................... new port for Lenovo L420 laptop Change-Id: I0e46810b80af72c608679235585ec8d5a98d48ac Signed-off-by: Nicolas Provost <dev(a)npsoft.fr> --- A src/mainboard/lenovo/l420/Kconfig A src/mainboard/lenovo/l420/Kconfig.name A src/mainboard/lenovo/l420/Makefile.inc A src/mainboard/lenovo/l420/acpi/ec.asl A src/mainboard/lenovo/l420/acpi/mainboard.asl A src/mainboard/lenovo/l420/acpi/platform.asl A src/mainboard/lenovo/l420/acpi/superio.asl A src/mainboard/lenovo/l420/acpi/thermal.asl A src/mainboard/lenovo/l420/acpi_tables.c A src/mainboard/lenovo/l420/board_info.txt A src/mainboard/lenovo/l420/cmos.default A src/mainboard/lenovo/l420/cmos.layout A src/mainboard/lenovo/l420/data.vbt A src/mainboard/lenovo/l420/devicetree.cb A src/mainboard/lenovo/l420/dsdt.asl A src/mainboard/lenovo/l420/early_init.c A src/mainboard/lenovo/l420/gma-mainboard.ads A src/mainboard/lenovo/l420/gpio.c A src/mainboard/lenovo/l420/hda_verb.c A src/mainboard/lenovo/l420/mainboard.c A src/mainboard/lenovo/l420/smihandler.c A src/mainboard/lenovo/l420/status.txt 22 files changed, 977 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/75992/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/75992?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0e46810b80af72c608679235585ec8d5a98d48ac Gerrit-Change-Number: 75992 Gerrit-PatchSet: 6 Gerrit-Owner: Nicolas Provost Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Nicolas Provost Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: new port for Lenovo L420 laptop
by Nicolas Provost (Code Review) 22 Jun '23

22 Jun '23

Attention is currently required from: Alexander Couzens, Nicolas Provost. Hello Alexander Couzens, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75992?usp=email to look at the new patch set (#5). Change subject: new port for Lenovo L420 laptop ...................................................................... new port for Lenovo L420 laptop Change-Id: I0e46810b80af72c608679235585ec8d5a98d48ac Signed-off-by: Nicolas Provost <dev(a)npsoft.fr> --- A src/mainboard/lenovo/l420/Kconfig A src/mainboard/lenovo/l420/Kconfig.name A src/mainboard/lenovo/l420/Makefile.inc A src/mainboard/lenovo/l420/acpi/ec.asl A src/mainboard/lenovo/l420/acpi/mainboard.asl A src/mainboard/lenovo/l420/acpi/platform.asl A src/mainboard/lenovo/l420/acpi/superio.asl A src/mainboard/lenovo/l420/acpi/thermal.asl A src/mainboard/lenovo/l420/acpi_tables.c A src/mainboard/lenovo/l420/board_info.txt A src/mainboard/lenovo/l420/cmos.default A src/mainboard/lenovo/l420/cmos.layout A src/mainboard/lenovo/l420/data.vbt A src/mainboard/lenovo/l420/devicetree.cb A src/mainboard/lenovo/l420/dsdt.asl A src/mainboard/lenovo/l420/early_init.c A src/mainboard/lenovo/l420/gma-mainboard.ads A src/mainboard/lenovo/l420/gpio.c A src/mainboard/lenovo/l420/hda_verb.c A src/mainboard/lenovo/l420/mainboard.c A src/mainboard/lenovo/l420/smihandler.c A src/mainboard/lenovo/l420/status.txt 22 files changed, 978 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/75992/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/75992?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0e46810b80af72c608679235585ec8d5a98d48ac Gerrit-Change-Number: 75992 Gerrit-PatchSet: 5 Gerrit-Owner: Nicolas Provost Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Nicolas Provost Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023