Attention is currently required from: Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun Tuli.
Uday Bhat has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76003?usp=email )
Change subject: mb/google/rex: Enable GPIO for BT I2S offload for soundwire config
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
> > i understood that comment as go ahead and split, hence did that 😊 […]
Do you suggest now to merge and abandon this cl?
--
To view, visit https://review.coreboot.org/c/coreboot/+/76003?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I65eae8839d72b266f5239a694c7e57cec856eedf
Gerrit-Change-Number: 76003
Gerrit-PatchSet: 3
Gerrit-Owner: Uday Bhat <uday.m.bhat(a)intel.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Comment-Date: Thu, 22 Jun 2023 16:59:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Uday Bhat <uday.m.bhat(a)intel.com>
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, Kapil Porwal, Tarun Tuli, Uday Bhat.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76003?usp=email )
Change subject: mb/google/rex: Enable GPIO for BT I2S offload for soundwire config
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
> i understood that comment as go ahead and split, hence did that 😊
its the other way around (like don't split but just use another cl to update the printk inside I2s block)
--
To view, visit https://review.coreboot.org/c/coreboot/+/76003?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I65eae8839d72b266f5239a694c7e57cec856eedf
Gerrit-Change-Number: 76003
Gerrit-PatchSet: 3
Gerrit-Owner: Uday Bhat <uday.m.bhat(a)intel.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Uday Bhat <uday.m.bhat(a)intel.com>
Gerrit-Comment-Date: Thu, 22 Jun 2023 16:56:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Uday Bhat <uday.m.bhat(a)intel.com>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Christian Walter, David Hendricks, Elyes Haouas, Felix Singer, Jonathan Zhang, Lean Sheng Tan, Nico Huber, Nill Ge, Patrick Rudolph, Paul Menzel, TangYiwei, niehaitao(a)bytedance.com.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75722?usp=email )
Change subject: mb/bytedance: Add 2 SPR sockets server board bd_egs
......................................................................
Patch Set 12:
(1 comment)
File src/mainboard/bytedance/bd_egs/Kconfig:
https://review.coreboot.org/c/coreboot/+/75722/comment/91fb1abd_1159813d :
PS10, Line 32: default "\\_SB.C%03d"
> Let me confirm this part with other people and get back here, on what is the best value to put it in […]
is there any acpi bytecode that gets emitted by the fsp that references the cpu object or are all references to these cpu object only in the corbeoot source? if there are only references to those cpu object from the coreboot side, there's no need to change the defaults from the soc code; also since this is sort-of soc dependent, it probably shouldn't be overridden on the mainboard level. if the fsp generates some acpi bytecode that references those, i'd also guess that the same fsp is used for all mainboards, so i also doubt that this should be overridden on the mainboard level in this case.
the cpu object names just need to be unique for each cpu and the acpi interpreter doesn't care if decimal or hex digits are used in the cpu object names; the main advantage of using hex digits is that that that allows more unique cpu acpi objects
--
To view, visit https://review.coreboot.org/c/coreboot/+/75722?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I091bc78e39cd76b3c6b9a10a1fcf58e9d671ef5d
Gerrit-Change-Number: 75722
Gerrit-PatchSet: 12
Gerrit-Owner: TangYiwei
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Nill Ge <geshijian(a)bytedance.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: niehaitao(a)bytedance.com
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: laykong <lay.kong(a)intel.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Nill Ge <geshijian(a)bytedance.com>
Gerrit-Attention: TangYiwei
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: niehaitao(a)bytedance.com
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Thu, 22 Jun 2023 16:54:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com>
Comment-In-Reply-To: TangYiwei
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun Tuli.
Uday Bhat has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76003?usp=email )
Change subject: mb/google/rex: Enable GPIO for BT I2S offload for soundwire config
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
> wondering why did you split the CL 😊 […]
i understood that comment as go ahead and split, hence did that 😊
--
To view, visit https://review.coreboot.org/c/coreboot/+/76003?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I65eae8839d72b266f5239a694c7e57cec856eedf
Gerrit-Change-Number: 76003
Gerrit-PatchSet: 3
Gerrit-Owner: Uday Bhat <uday.m.bhat(a)intel.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Comment-Date: Thu, 22 Jun 2023 16:53:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun Tuli.
Uday Bhat has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75924?usp=email )
Change subject: mb/google/rex: Enable audio BT offload with soundwire audio
......................................................................
Patch Set 6:
(2 comments)
File src/mainboard/google/rex/variants/rex0/fw_config.c:
https://review.coreboot.org/c/coreboot/+/75924/comment/3328aa96_17541307 :
PS4, Line 94: printk(BIOS_INFO, "Configure GPIOs for BT offload mode with soundwire audio.\n");
: GPIO_PADBASED_OVERRIDE(padbased_table, bt_i2s_enable_pads);
> > As both the changes are related to BT offload - cant this be done in this? […]
Created separate patch for https://review.coreboot.org/c/coreboot/+/76003https://review.coreboot.org/c/coreboot/+/75924/comment/9b8f94fb_6aa2fff8 :
PS4, Line 99: Configure GPIOs for BT offload mode.
> may be a seperate CL ? […]
Updated to Configure GPIOs for BT I2S offload mode in https://review.coreboot.org/c/coreboot/+/76003
--
To view, visit https://review.coreboot.org/c/coreboot/+/75924?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I99df78787d9f54c91bcedf6f70352890a715cdb3
Gerrit-Change-Number: 75924
Gerrit-PatchSet: 6
Gerrit-Owner: Uday Bhat <uday.m.bhat(a)intel.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Comment-Date: Thu, 22 Jun 2023 16:52:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Uday Bhat <uday.m.bhat(a)intel.com>
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, Kapil Porwal, Tarun Tuli, Uday Bhat.
Hello Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun Tuli,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/76003?usp=email
to look at the new patch set (#3).
Change subject: mb/google/rex: Enable GPIO for BT I2S offload for soundwire config
......................................................................
mb/google/rex: Enable GPIO for BT I2S offload for soundwire config
GPIO configured for I2S offload on rex soundwire config
Change-Id: I65eae8839d72b266f5239a694c7e57cec856eedf
Signed-off-by: Uday M Bhat <uday.m.bhat(a)intel.com>
---
M src/mainboard/google/rex/variants/rex0/fw_config.c
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/76003/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/76003?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I65eae8839d72b266f5239a694c7e57cec856eedf
Gerrit-Change-Number: 76003
Gerrit-PatchSet: 3
Gerrit-Owner: Uday Bhat <uday.m.bhat(a)intel.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Uday Bhat <uday.m.bhat(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jakub Czapiga, Kapil Porwal, Tarun Tuli, Uday Bhat.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76003?usp=email )
Change subject: mb/google/rex: Enable GPIO for BT I2S offload for soundwire config
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
wondering why did you split the CL 😊
I have told to keep both in a same CL as you have justified here: https://review.coreboot.org/c/coreboot/+/75924/comment/518e0626_6cc8aff7/
--
To view, visit https://review.coreboot.org/c/coreboot/+/76003?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I65eae8839d72b266f5239a694c7e57cec856eedf
Gerrit-Change-Number: 76003
Gerrit-PatchSet: 2
Gerrit-Owner: Uday Bhat <uday.m.bhat(a)intel.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Uday Bhat <uday.m.bhat(a)intel.com>
Gerrit-Comment-Date: Thu, 22 Jun 2023 16:51:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun Tuli.
Hello Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun Tuli,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/76003?usp=email
to look at the new patch set (#2).
Change subject: mb/google/rex: Enable GPIO for BT I2S offload for soundwire config
......................................................................
mb/google/rex: Enable GPIO for BT I2S offload for soundwire config
GPIO configured for I2S offload on rex soundwire config
Change-Id: I65eae8839d72b266f5239a694c7e57cec856eedf
Signed-off-by: Uday M Bhat <uday.m.bhat(a)intel.com>
---
M src/mainboard/google/rex/variants/rex0/fw_config.c
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/76003/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/76003?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I65eae8839d72b266f5239a694c7e57cec856eedf
Gerrit-Change-Number: 76003
Gerrit-PatchSet: 2
Gerrit-Owner: Uday Bhat <uday.m.bhat(a)intel.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-MessageType: newpatchset