Attention is currently required from: Hung-Te Lin, jason-ch chen.
Hello Hung-Te Lin, build bot (Jenkins), Rex-BC Chen, Yidi Lin, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74064
to look at the new patch set (#6).
Change subject: soc/mediatek/mt8188: Set pin drive strength to 8mA for NOR
......................................................................
soc/mediatek/mt8188: Set pin drive strength to 8mA for NOR
Set NOR pin drive to 8mA to comply with HW requirement.
This implementation is according to chapter 5.8 and 5.19 in MT8188
Functional Specification.
BUG=b:270911452
TEST=build pass
Change-Id: If8344449f5b34cefcaaee6936e94f7f669c7148b
Signed-off-by: jason-ch chen <Jason-ch.Chen(a)mediatek.com>
---
M src/soc/mediatek/mt8188/spi.c
1 file changed, 27 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/74064/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/74064
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If8344449f5b34cefcaaee6936e94f7f669c7148b
Gerrit-Change-Number: 74064
Gerrit-PatchSet: 6
Gerrit-Owner: jason-ch chen <Jason-ch.Chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: jason-ch chen <Jason-ch.Chen(a)mediatek.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jon Murphy, Karthik Ramasubramanian, Mark Hasemeyer.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74109 )
Change subject: mb/google/myst: Add initial fch irq routing
......................................................................
Patch Set 23: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/74109
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic81c3cbfbb30a0beb3c4083624cf19abe6d1e694
Gerrit-Change-Number: 74109
Gerrit-PatchSet: 23
Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com>
Gerrit-Comment-Date: Thu, 06 Apr 2023 02:04:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Raul Rangel, Jon Murphy, Karthik Ramasubramanian, Mark Hasemeyer.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74108 )
Change subject: mb/google/myst: Add initial I2C configuration
......................................................................
Patch Set 23:
(1 comment)
File src/mainboard/google/myst/variants/myst/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/74108/comment/9664c820_5f0c2425
PS23, Line 32: device domain 0 on end # domain
if you want change this better in https://review.coreboot.org/c/coreboot/+/74098
--
To view, visit https://review.coreboot.org/c/coreboot/+/74108
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44668295fb6ed03992df9d9fc075792e181d1a8a
Gerrit-Change-Number: 74108
Gerrit-PatchSet: 23
Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com>
Gerrit-Comment-Date: Thu, 06 Apr 2023 02:03:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Raul Rangel, Jon Murphy, Paul Menzel, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74106 )
Change subject: mb/google/myst: Add ACPI configuration for USB ports
......................................................................
Patch Set 21:
(1 comment)
Patchset:
PS21:
Wondering AMD project need custom_pld or not?
--
To view, visit https://review.coreboot.org/c/coreboot/+/74106
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iecb256cad7b2daea1fddfc8323e88ff5c38d1e51
Gerrit-Change-Number: 74106
Gerrit-PatchSet: 21
Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Van Patten <timvp(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com>
Gerrit-Comment-Date: Thu, 06 Apr 2023 02:01:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Raul Rangel, Jon Murphy, Karthik Ramasubramanian, Mark Hasemeyer.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74105 )
Change subject: mb/google/myst: Enable USB controllers
......................................................................
Patch Set 22: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/74105
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I05dc5bb157f0ef955e4b37e34d7b32678e42ebc8
Gerrit-Change-Number: 74105
Gerrit-PatchSet: 22
Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com>
Gerrit-Comment-Date: Thu, 06 Apr 2023 01:56:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, cong yang, Yidi Lin, Yu-Ping Wu.
Jianeng Ceng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74115 )
Change subject: mb/google/geralt: Power on samsung-atna33xc20 eDP panel
......................................................................
Patch Set 10:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74115/comment/5506006c_c55586a8
PS9, Line 2: cengjianeng
> Please update your user name to not be the username. […]
Done
https://review.coreboot.org/c/coreboot/+/74115/comment/ed40ec83_b5497677
PS9, Line 29: cengjianeng
> Please update the spelling.
Done
File src/mainboard/google/geralt/panel_geralt.c:
https://review.coreboot.org/c/coreboot/+/74115/comment/4475e52f_41f82511
PS9, Line 65: .name = "MUTTO_B152731E1",
> Thank you for the quick reply. Please mention that in the commit message.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/74115
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd2d05c7eef1360ca954316f2e76b21ed1f85be8
Gerrit-Change-Number: 74115
Gerrit-PatchSet: 10
Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: jason-ch chen <Jason-ch.Chen(a)mediatek.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Thu, 06 Apr 2023 01:51:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: comment