coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[M] Change in coreboot[master]: soc/intel/cmd/block: Implement an API to get firmware partition details
by Dinesh Gehlot (Code Review) 11 Apr '23

11 Apr '23

Attention is currently required from: Haribalaraman Ramasubramanian, Dinesh Gehlot, Rizwan Qureshi, Reka Norman. Hello build bot (Jenkins), SRIDHAR SIRICILLA, Subrata Banik, Kangheui Won, Haribalaraman Ramasubramanian, Kapil Porwal, Rizwan Qureshi, Reka Norman, Sridhar Siricilla, Meera Ravindranath, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74005 to look at the new patch set (#28). Change subject: soc/intel/cmd/block: Implement an API to get firmware partition details ...................................................................... soc/intel/cmd/block: Implement an API to get firmware partition details This patch retrieves details of a specified firmware partition table. The information retrieved includes the current firmware version and other information about the firmware partition. The patch communicates with the ME using the HECI command to acquire this information. BUG=b:273661726 Test=Verified the changes for ISH partition on nissa board. Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> Change-Id: I0582010bbb836bd4734f843a8c74dee49d203fd8 --- M src/soc/intel/common/block/cse/cse.c M src/soc/intel/common/block/include/intelblocks/cse.h 2 files changed, 109 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/74005/28 -- To view, visit https://review.coreboot.org/c/coreboot/+/74005 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0582010bbb836bd4734f843a8c74dee49d203fd8 Gerrit-Change-Number: 74005 Gerrit-PatchSet: 28 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: SRIDHAR SIRICILLA Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/amd/birman/port_descriptors_*: use DDI_DP_W_TYPEC type for DDI 2..4
by Fred Reitberger (Code Review) 11 Apr '23

11 Apr '23

Attention is currently required from: Jason Glenesk, Felix Held. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74299 ) Change subject: mb/amd/birman/port_descriptors_*: use DDI_DP_W_TYPEC type for DDI 2..4 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74299 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I659d62bfb426e3e47214203490c34e9c200beee2 Gerrit-Change-Number: 74299 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 11 Apr 2023 15:33:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/amd/birman/port_descriptors_*: use DDI_DP_W_TYPEC type for DDI 2..4
by Felix Held (Code Review) 11 Apr '23

11 Apr '23

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74299 ) Change subject: mb/amd/birman/port_descriptors_*: use DDI_DP_W_TYPEC type for DDI 2..4 ...................................................................... mb/amd/birman/port_descriptors_*: use DDI_DP_W_TYPEC type for DDI 2..4 DDI 2..4 are the display outputs multiplexed onto the 3 USB type C ports as DisplayPort alternate function, so use the DDI_DP_W_TYPEC connector type for those. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I659d62bfb426e3e47214203490c34e9c200beee2 --- M src/mainboard/amd/birman/port_descriptors_glinda.c M src/mainboard/amd/birman/port_descriptors_phoenix.c 2 files changed, 22 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/74299/1 diff --git a/src/mainboard/amd/birman/port_descriptors_glinda.c b/src/mainboard/amd/birman/port_descriptors_glinda.c index a2c4557..df961bf 100644 --- a/src/mainboard/amd/birman/port_descriptors_glinda.c +++ b/src/mainboard/amd/birman/port_descriptors_glinda.c @@ -63,17 +63,17 @@ .hdp_index = DDI_HDP2 }, { /* DDI2 - DP (type C) */ - .connector_type = DDI_DP, + .connector_type = DDI_DP_W_TYPEC, .aux_index = DDI_AUX3, .hdp_index = DDI_HDP3, }, { /* DDI3 - DP (type C) */ - .connector_type = DDI_DP, + .connector_type = DDI_DP_W_TYPEC, .aux_index = DDI_AUX4, .hdp_index = DDI_HDP4, }, - { /* DDI4 - unused */ - .connector_type = DDI_UNUSED_TYPE, + { /* DDI4 - DP (type C) */ + .connector_type = DDI_DP_W_TYPEC, .aux_index = DDI_AUX5, .hdp_index = DDI_HDP5, } diff --git a/src/mainboard/amd/birman/port_descriptors_phoenix.c b/src/mainboard/amd/birman/port_descriptors_phoenix.c index a2c4557..df961bf 100644 --- a/src/mainboard/amd/birman/port_descriptors_phoenix.c +++ b/src/mainboard/amd/birman/port_descriptors_phoenix.c @@ -63,17 +63,17 @@ .hdp_index = DDI_HDP2 }, { /* DDI2 - DP (type C) */ - .connector_type = DDI_DP, + .connector_type = DDI_DP_W_TYPEC, .aux_index = DDI_AUX3, .hdp_index = DDI_HDP3, }, { /* DDI3 - DP (type C) */ - .connector_type = DDI_DP, + .connector_type = DDI_DP_W_TYPEC, .aux_index = DDI_AUX4, .hdp_index = DDI_HDP4, }, - { /* DDI4 - unused */ - .connector_type = DDI_UNUSED_TYPE, + { /* DDI4 - DP (type C) */ + .connector_type = DDI_DP_W_TYPEC, .aux_index = DDI_AUX5, .hdp_index = DDI_HDP5, } -- To view, visit https://review.coreboot.org/c/coreboot/+/74299 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I659d62bfb426e3e47214203490c34e9c200beee2 Gerrit-Change-Number: 74299 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mainboard/google/skyrim: Fix MP2 FW naming
by Martin Roth (Code Review) 11 Apr '23

11 Apr '23

Attention is currently required from: Marshall Dawson, Jason Nien. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74327 ) Change subject: mainboard/google/skyrim: Fix MP2 FW naming ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74327 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5418b1ed59e1916b971d2eece9f6a2fd0e51b1b3 Gerrit-Change-Number: 74327 Gerrit-PatchSet: 2 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Tue, 11 Apr 2023 15:14:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: arch/x86/smbios: Avoid buffer overflows
by Nico Huber (Code Review) 11 Apr '23

11 Apr '23

Attention is currently required from: Felix Singer, Paul Menzel, Angel Pons, Utkarsh Verma. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74128 ) Change subject: arch/x86/smbios: Avoid buffer overflows ...................................................................... Patch Set 7: Code-Review+1 (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74128/comment/9d020c95_f675744d PS7, Line 7: arch/x86/smbios: Avoid buffer overflows "buffer overflow" usually refers to writing beyond the bounds of a buffer. This is not possible with `snprintf(buf, sizeof(buf), )`. We could maybe say "string overflow"? In any case, it's hard to explain why we do this if there is nothing to fix, so how about "arch/x86/smbios: Refactor snprintf() uses" for the commit summary and then explain what and why in the commit message body. https://review.coreboot.org/c/coreboot/+/74128/comment/4b3281bc_dd4c3e45 PS7, Line 11: static analysers. This commit also alters buffer sizes, please mention that as well. https://review.coreboot.org/c/coreboot/+/74128/comment/c531c12c_fe69611c PS7, Line 14: https://scan6.scan.coverity.com/reports.htm#v55284/p10744 If you happen to have a link to the coreboot mailing list archive (Coverity is supposed to report all issues on the ML), that would be better. Links that require a login are discouraged and there's also no guarantee that this link will be still valid after 1, 2, 3 months. The commit message, OTOH, is forever. Patchset: PS7: Commit message needs more work, looks good to me otherwise. The commit message is quite important already during review. If you cover everything in the commit message, you can avoid bikeshedding (some at least) and confusion. File src/arch/x86/smbios.c: https://review.coreboot.org/c/coreboot/+/74128/comment/c6b5a7ab_48a16f66 PS4, Line 148: char string_buffer[15]; > Wait, I just checked it again. Shouldn't 15 buffer size be enough? […] Yes, you are right :) I must have missed that it's hex. -- To view, visit https://review.coreboot.org/c/coreboot/+/74128 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibbf93fd113791b6faa1e5128da8e692f7f00ac73 Gerrit-Change-Number: 74128 Gerrit-PatchSet: 7 Gerrit-Owner: Utkarsh Verma <utkarsh(a)bitbanged.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Utkarsh Verma <utkarsh(a)bitbanged.com> Gerrit-Comment-Date: Tue, 11 Apr 2023 15:13:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Utkarsh Verma <utkarsh(a)bitbanged.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: amdfwtool: Add --fsp-version option
by Matt DeVillier (Code Review) 11 Apr '23

11 Apr '23

Attention is currently required from: Jason Glenesk, Raul Rangel, Paul Menzel, Arthur Heymans, Grzegorz Bernacki, Fred Reitberger, Karthik Ramasubramanian, Felix Held. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74266 ) Change subject: amdfwtool: Add --fsp-version option ...................................................................... Patch Set 1: (1 comment) File util/amdfwtool/amdfwtool.c: https://review.coreboot.org/c/coreboot/+/74266/comment/a89572fc_8e00faee PS1, Line 214: FSP blobs > Grzegorz, FSP might be ambiguous as it came originally from Intel for Intel platforms. it's not ambiguous, Intel came up with the FSP spec, AMD has implemented it (this will be the 3rd AMD platform doing so). There's nothing platform specific about FSP. -- To view, visit https://review.coreboot.org/c/coreboot/+/74266 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idaa3a02ace524f44cfa656e34308bd896016dff6 Gerrit-Change-Number: 74266 Gerrit-PatchSet: 1 Gerrit-Owner: Grzegorz Bernacki Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Grzegorz Bernacki Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 11 Apr 2023 15:12:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Grzegorz Bernacki Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: device: Change NO_S0IX_SUPPORT default to def_bool
by Kapil Porwal (Code Review) 11 Apr '23

11 Apr '23

Attention is currently required from: Sean Rhodes. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74331 ) Change subject: device: Change NO_S0IX_SUPPORT default to def_bool ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74331 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc824c3e06019c8922616c1cb83df95c10e285fc Gerrit-Change-Number: 74331 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Tue, 11 Apr 2023 15:01:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/alderlake: Remove the tcss_d3_cold_disable devicetree option
by Kapil Porwal (Code Review) 11 Apr '23

11 Apr '23

Attention is currently required from: Sean Rhodes, Tarun Tuli, Subrata Banik. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74330 ) Change subject: soc/intel/alderlake: Remove the tcss_d3_cold_disable devicetree option ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74330 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib84814bd608742680cea7c8012011b56b8fb3271 Gerrit-Change-Number: 74330 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Tue, 11 Apr 2023 15:00:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Move TCSS D3 Cold to Kconfig
by Kapil Porwal (Code Review) 11 Apr '23

11 Apr '23

Attention is currently required from: Sean Rhodes, Tarun Tuli. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74329 ) Change subject: soc/intel/meteorlake: Move TCSS D3 Cold to Kconfig ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74329 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0fb22188ac5089e2ecf00850b2da8500ab73d6c2 Gerrit-Change-Number: 74329 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Comment-Date: Tue, 11 Apr 2023 15:00:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: device: Correct D3Cold Kconfig option
by Kapil Porwal (Code Review) 11 Apr '23

11 Apr '23

Attention is currently required from: Sean Rhodes. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74328 ) Change subject: device: Correct D3Cold Kconfig option ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74328 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9bdb6589e98ac81d0ce25df52fb916b5c2fd0157 Gerrit-Change-Number: 74328 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Tue, 11 Apr 2023 14:59:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023