coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[M] Change in coreboot[master]: mb/amd/mayan: Update DXIO descriptors per schematics
by Fred Reitberger (Code Review) 17 Apr '23

17 Apr '23

Attention is currently required from: Jason Glenesk, ritul guru, Paul Menzel, Anand Vaikar, Felix Held. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74191 ) Change subject: mb/amd/mayan: Update DXIO descriptors per schematics ...................................................................... Patch Set 3: (5 comments) File src/mainboard/amd/mayan/port_descriptors.c: https://review.coreboot.org/c/coreboot/+/74191/comment/e1fb9c0b_bc59700c PS3, Line 42: .link_aspm = 2, Prefer using the enums in vc/amd/fsp/phoenix/platform_descriptors.h - `ASPM_L1` here This also applies to the other entries https://review.coreboot.org/c/coreboot/+/74191/comment/13661fe5_def3ee2c PS3, Line 43: .link_aspm_L1_1 = 1, : .link_aspm_L1_2 = 1, Prefer using `true` here over `1` https://review.coreboot.org/c/coreboot/+/74191/comment/d8be3362_40c511e5 PS3, Line 47: .clk_pm_support = 1, Does the FSP support this? https://review.coreboot.org/c/coreboot/+/74191/comment/90fc1683_d54bd3d8 PS3, Line 66: //.gpio_group_id = 30, Is this just a placeholder for now? If so, please add "TODO". If not, please remove https://review.coreboot.org/c/coreboot/+/74191/comment/97998a2c_70b65ddf PS3, Line 90: }, GBE? SD card? WLAN? -- To view, visit https://review.coreboot.org/c/coreboot/+/74191 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b536f8a1ff4eab06f37aec0f25704525dc1b64e Gerrit-Change-Number: 74191 Gerrit-PatchSet: 3 Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 17 Apr 2023 13:13:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: ACPI: Obsolete FADT p_lvl2_lat and p_lvl3_lat fields
by Kyösti Mälkki (Code Review) 17 Apr '23

17 Apr '23

Attention is currently required from: Lance Zhao, Jason Glenesk, Raul Rangel, Jonathan Zhang, Matt DeVillier, Johnny Lin, Tim Wawrzynczak, Christian Walter, Arthur Heymans, Fred Reitberger, Tim Chu. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74430 ) Change subject: ACPI: Obsolete FADT p_lvl2_lat and p_lvl3_lat fields ...................................................................... Patch Set 3: (1 comment) File src/soc/amd/stoneyridge/acpi.c: https://review.coreboot.org/c/coreboot/+/74430/comment/061d9504_649c0744 PS2, Line 78: fadt->duty_width = 3; /* CLK_VAL bits 3:1 */ > Felix, do you think this would require a CPU _PTC to work? After Processor() was dropped P_BLK/P_CNT […] CB:74473 in case you need it. -- To view, visit https://review.coreboot.org/c/coreboot/+/74430 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3230be719659fe9cdf9ed6ae73bc91b05093ab97 Gerrit-Change-Number: 74430 Gerrit-PatchSet: 3 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Mon, 17 Apr 2023 12:58:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/google/rex: Initial setup for gpio config
by Kun Liu (Code Review) 17 Apr '23

17 Apr '23

1 0

[L] Change in coreboot[master]: mb/google/rex: Initial setup for gpio config
by Kun Liu (Code Review) 17 Apr '23

17 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. Kun Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74475 ) Change subject: mb/google/rex: Initial setup for gpio config ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74475/comment/13f24e5a_3dba23e4 PS2, Line 8: > Possible unwrapped commit description (prefer a maximum 72 chars per line) Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/74475 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib96e03f47bc1d6e5628ae459c3e1eb4dc18849c7 Gerrit-Change-Number: 74475 Gerrit-PatchSet: 2 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Mon, 17 Apr 2023 12:32:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/google/rex: Initial setup for gpio config
by Kun Liu (Code Review) 17 Apr '23

17 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. Hello build bot (Jenkins), Tarun Tuli, Subrata Banik, Kapil Porwal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74475 to look at the new patch set (#3). Change subject: mb/google/rex: Initial setup for gpio config ...................................................................... mb/google/rex: Initial setup for gpio config add the initial gpio configuration for the screebo BUG=b:276814951 TEST=emerge-rex coreboot Signed-off-by: liukun11 <liukun11(a)huaqin.corp-partner.google.com> Change-Id: Ib96e03f47bc1d6e5628ae459c3e1eb4dc18849c7 --- M src/mainboard/google/rex/variants/screebo/gpio.c 1 file changed, 422 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/74475/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/74475 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib96e03f47bc1d6e5628ae459c3e1eb4dc18849c7 Gerrit-Change-Number: 74475 Gerrit-PatchSet: 3 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: mb/google/rex: Initial setup for ramstage/early gpio config
by Kun Liu (Code Review) 17 Apr '23

17 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. Kun Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74475 ) Change subject: mb/google/rex: Initial setup for ramstage/early gpio config ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74475/comment/5894a75b_545e0ac2 PS1, Line 9: This adds the initial gpio configuration for the screebo initial variant. > Possible unwrapped commit description (prefer a maximum 72 chars per line) Please fix. File src/mainboard/google/rex/variants/screebo/gpio.c: https://review.coreboot.org/c/coreboot/+/74475/comment/77f18806_b19c164d PS1, Line 39: PAD_CFG_NF(GPP_A21, NONE, DEEP, NF1), > please, no spaces at the start of a line Please fix. https://review.coreboot.org/c/coreboot/+/74475/comment/4f1ed431_1ab4315b PS1, Line 65: PAD_CFG_NF_LOCK(GPP_B11, NONE, NF1, LOCK_CONFIG), > trailing whitespace Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/74475 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib96e03f47bc1d6e5628ae459c3e1eb4dc18849c7 Gerrit-Change-Number: 74475 Gerrit-PatchSet: 2 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Mon, 17 Apr 2023 12:26:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/google/rex: Initial setup for ramstage/early gpio config
by build bot (Jenkins) (Code Review) 17 Apr '23

17 Apr '23

1 0

[L] Change in coreboot[master]: mb/google/rex: Initial setup for ramstage/early gpio config
by Kun Liu (Code Review) 17 Apr '23

17 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. Hello build bot (Jenkins), Tarun Tuli, Subrata Banik, Kapil Porwal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74475 to look at the new patch set (#2). Change subject: mb/google/rex: Initial setup for ramstage/early gpio config ...................................................................... mb/google/rex: Initial setup for ramstage/early gpio config This adds the initial gpio configuration for the screebo initial variant. BUG=b:276814951 TEST=emerge-rex coreboot Signed-off-by: liukun11 <liukun11(a)huaqin.corp-partner.google.com> Change-Id: Ib96e03f47bc1d6e5628ae459c3e1eb4dc18849c7 --- M src/mainboard/google/rex/variants/screebo/gpio.c 1 file changed, 422 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/74475/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74475 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib96e03f47bc1d6e5628ae459c3e1eb4dc18849c7 Gerrit-Change-Number: 74475 Gerrit-PatchSet: 2 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: mb/google/rex: Initial setup for ramstage/early/romstage gpio config ...
by Kun Liu (Code Review) 17 Apr '23

17 Apr '23

1 0

[L] Change in coreboot[master]: mb/google/rex: Initial setup for ramstage/early/romstage gpio config ...
by build bot (Jenkins) (Code Review) 17 Apr '23

17 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74475 ) Change subject: mb/google/rex: Initial setup for ramstage/early/romstage gpio config for screebo ...................................................................... Patch Set 1: (4 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174275): https://review.coreboot.org/c/coreboot/+/74475/comment/cf538bce_670b1f7f PS1, Line 9: This adds the initial gpio configuration for the screebo initial variant. Possible unwrapped commit description (prefer a maximum 72 chars per line) File src/mainboard/google/rex/variants/screebo/gpio.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174275): https://review.coreboot.org/c/coreboot/+/74475/comment/0601f156_cdbc1965 PS1, Line 39: PAD_CFG_NF(GPP_A21, NONE, DEEP, NF1), please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174275): https://review.coreboot.org/c/coreboot/+/74475/comment/49e1b8af_2ac8bf7e PS1, Line 65: PAD_CFG_NF_LOCK(GPP_B11, NONE, NF1, LOCK_CONFIG), trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174275): https://review.coreboot.org/c/coreboot/+/74475/comment/d9d0c733_3253256a PS1, Line 89: PAD_NC(GPP_B23, NONE), please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/74475 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib96e03f47bc1d6e5628ae459c3e1eb4dc18849c7 Gerrit-Change-Number: 74475 Gerrit-PatchSet: 1 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Mon, 17 Apr 2023 12:08:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023