Attention is currently required from: Tarun Tuli, Subrata Banik, Paul Menzel, Kapil Porwal, Eric Lai.
Hello build bot (Jenkins), YH Lin, Tarun Tuli, Subrata Banik, Kapil Porwal,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74475
to look at the new patch set (#6).
Change subject: mb/google/rex: Add initial setup for gpio config
......................................................................
mb/google/rex: Add initial setup for gpio config
add the initial gpio configuration for screebo initial variant
BUG=b:276814951
TEST=emerge-rex coreboot
Signed-off-by: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Change-Id: Ib96e03f47bc1d6e5628ae459c3e1eb4dc18849c7
---
M src/mainboard/google/rex/variants/screebo/gpio.c
1 file changed, 421 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/74475/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/74475
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib96e03f47bc1d6e5628ae459c3e1eb4dc18849c7
Gerrit-Change-Number: 74475
Gerrit-PatchSet: 6
Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tarun Tuli, Subrata Banik, Paul Menzel, Kapil Porwal, Eric Lai.
Kun Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74475 )
Change subject: mb/google/rex: Add initial setup for gpio config
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74475/comment/73899686_106dfb82
PS5, Line 9: add the initial gpio configuration for screebo project
> /var/screebo:
Screebo is a project based on Rex board
--
To view, visit https://review.coreboot.org/c/coreboot/+/74475
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib96e03f47bc1d6e5628ae459c3e1eb4dc18849c7
Gerrit-Change-Number: 74475
Gerrit-PatchSet: 5
Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 18 Apr 2023 03:43:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Subrata Banik, Paul Menzel, Kapil Porwal, Kun Liu.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74475 )
Change subject: mb/google/rex: Add initial setup for gpio config
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74475/comment/288cb5c4_2542014b
PS5, Line 9: add the initial gpio configuration for screebo project
/var/screebo:
--
To view, visit https://review.coreboot.org/c/coreboot/+/74475
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib96e03f47bc1d6e5628ae459c3e1eb4dc18849c7
Gerrit-Change-Number: 74475
Gerrit-PatchSet: 5
Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 18 Apr 2023 03:28:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Subrata Banik, Paul Menzel, Kapil Porwal, Kun Liu.
YH Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74475 )
Change subject: mb/google/rex: Add initial setup for gpio config
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/74475
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib96e03f47bc1d6e5628ae459c3e1eb4dc18849c7
Gerrit-Change-Number: 74475
Gerrit-PatchSet: 5
Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 18 Apr 2023 02:32:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: YH Lin, Tarun Tuli, Subrata Banik, Paul Menzel, Kapil Porwal.
Kun Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74475 )
Change subject: mb/google/rex: Add initial setup for gpio config
......................................................................
Patch Set 5:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74475/comment/00a6c71f_9668380c
PS3, Line 2: liukun11
> Please configure your user name. […]
Done
https://review.coreboot.org/c/coreboot/+/74475/comment/53ddd6cd_d8f23cef
PS3, Line 7: mb/google/rex: Initial setup for gpio config
> Please make it a statement, by adding a verb (in imperative mood); cf `git log --oneline`.
Done
https://review.coreboot.org/c/coreboot/+/74475/comment/b777afd6_fdf6d508
PS3, Line 9: add the initial gpio configuration for the screebo
> What is the source for this?
Configure gpio based on the schematic diagram of screenbo project
https://review.coreboot.org/c/coreboot/+/74475/comment/3b50e951_c7d6627d
PS3, Line 14: liukun11
> Ditto.
Done
File src/mainboard/google/rex/variants/screebo/gpio.c:
https://review.coreboot.org/c/coreboot/+/74475/comment/c9365714_b4a56308
PS3, Line 153:
> nit: tab
Done
https://review.coreboot.org/c/coreboot/+/74475/comment/6c3de14f_b080e846
PS3, Line 205:
> ditto
Done
https://review.coreboot.org/c/coreboot/+/74475/comment/4943f05b_a5a6cf6f
PS3, Line 247:
> ditto
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/74475
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib96e03f47bc1d6e5628ae459c3e1eb4dc18849c7
Gerrit-Change-Number: 74475
Gerrit-PatchSet: 5
Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Comment-Date: Tue, 18 Apr 2023 02:12:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: YH Lin <yueherngl(a)google.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Kun Liu.
Hello build bot (Jenkins), YH Lin, Tarun Tuli, Subrata Banik, Kapil Porwal,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74475
to look at the new patch set (#5).
Change subject: mb/google/rex: Add initial setup for gpio config
......................................................................
mb/google/rex: Add initial setup for gpio config
add the initial gpio configuration for screebo project
BUG=b:276814951
TEST=emerge-rex coreboot
Signed-off-by: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Change-Id: Ib96e03f47bc1d6e5628ae459c3e1eb4dc18849c7
---
M src/mainboard/google/rex/variants/screebo/gpio.c
1 file changed, 421 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/74475/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/74475
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib96e03f47bc1d6e5628ae459c3e1eb4dc18849c7
Gerrit-Change-Number: 74475
Gerrit-PatchSet: 5
Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jason Glenesk, Martin L Roth, Paul Menzel, Angel Pons, Elyes Haouas.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73792 )
Change subject: crossgcc: Upgrade LLVM version 15.0.7 to 16.0.1
......................................................................
Patch Set 11:
(1 comment)
File util/crossgcc/buildgcc:
https://review.coreboot.org/c/coreboot/+/73792/comment/5dba22e9_d01eb2d2
PS11, Line 887: cd "$DESTDIR$TARGETDIR/lib/clang/${CLANG_VERSION}/lib" || exit 1
> I investigated the build failure and this is the reason. CLANG_VERSION is 16.0. […]
Not sure if that's a LLVM versioning issue. On our side, we could change the line to this but also not sure if that's more a hack.
`cd "$DESTDIR$TARGETDIR/lib/clang/*/lib" || exit 1`
This makes cd using whatever is there. Since the XGCC folder is always specific to one toolchain version, thus it shouldn't contain multiple versions of Clang, there should always be just one folder.
Opinions?
--
To view, visit https://review.coreboot.org/c/coreboot/+/73792
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I753bbcf3f03907b0cf966454c3dd6c9b61869599
Gerrit-Change-Number: 73792
Gerrit-PatchSet: 11
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Tue, 18 Apr 2023 01:32:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Martin L Roth, Paul Menzel, Angel Pons, Elyes Haouas.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73792 )
Change subject: crossgcc: Upgrade LLVM version 15.0.7 to 16.0.1
......................................................................
Patch Set 11:
(1 comment)
File util/crossgcc/buildgcc:
https://review.coreboot.org/c/coreboot/+/73792/comment/a4b4fdb7_2589b766
PS11, Line 887: cd "$DESTDIR$TARGETDIR/lib/clang/${CLANG_VERSION}/lib" || exit 1
I investigated the build failure and this is the reason. CLANG_VERSION is 16.0.1 but this directory doesn't exist. The directory is just named 16 and thus buildgcc can't cd into it, which makes it failing.
How do we deal with that issue? It seems it worked this way all the before.
--
To view, visit https://review.coreboot.org/c/coreboot/+/73792
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I753bbcf3f03907b0cf966454c3dd6c9b61869599
Gerrit-Change-Number: 73792
Gerrit-PatchSet: 11
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Tue, 18 Apr 2023 01:20:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment