coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: mb/google/skyrim: Fix eMMC reset GPIO
by Jon Murphy (Code Review) 18 Apr '23

18 Apr '23

Attention is currently required from: Jason Nien, Martin Roth, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer. Hello Jason Nien, Martin Roth, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74512 to look at the new patch set (#3). Change subject: mb/google/skyrim: Fix eMMC reset GPIO ...................................................................... mb/google/skyrim: Fix eMMC reset GPIO On Skyrim variants, the eMMC reset GPIO should be SSD_AUX_RST_L (GPIO6). Update the port_descriptors to link the correct reset GPIO. Data is from the skyrim variant schematics and go/skyrim-gpios. BUG=b:278759559 TEST=None Signed-off-by: Jon Murphy <jpmurphy(a)google.com> Change-Id: I4713b3af23bb7684c9e2e81cf9c8d8a560b41a79 --- M src/mainboard/google/skyrim/variants/markarth/port_descriptors.c M src/mainboard/google/skyrim/variants/winterhold/port_descriptors.c 2 files changed, 19 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/74512/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/74512 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4713b3af23bb7684c9e2e81cf9c8d8a560b41a79 Gerrit-Change-Number: 74512 Gerrit-PatchSet: 3 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/skyrim: Fix eMMC reset GPIO
by Jon Murphy (Code Review) 18 Apr '23

18 Apr '23

Attention is currently required from: Jason Nien, Martin Roth, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer. Hello Jason Nien, Martin Roth, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74512 to look at the new patch set (#2). Change subject: mb/google/skyrim: Fix eMMC reset GPIO ...................................................................... mb/google/skyrim: Fix eMMC reset GPIO On Whiterun, the eMMC reset GPIO should be SSD_AUX_RST_L (GPIO6). Update the port_descriptor to link the correct reset GPIO. Data is from the Whiterun schematic and go/skyrim-gpios. BUG=b:278759559 TEST=None Signed-off-by: Jon Murphy <jpmurphy(a)google.com> Change-Id: I4713b3af23bb7684c9e2e81cf9c8d8a560b41a79 --- M src/mainboard/google/skyrim/variants/markarth/port_descriptors.c M src/mainboard/google/skyrim/variants/winterhold/port_descriptors.c 2 files changed, 19 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/74512/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74512 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4713b3af23bb7684c9e2e81cf9c8d8a560b41a79 Gerrit-Change-Number: 74512 Gerrit-PatchSet: 2 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/skyrim: Fix eMMC reset GPIO
by Jon Murphy (Code Review) 18 Apr '23

18 Apr '23

Attention is currently required from: Jason Nien, Martin Roth, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74512 ) Change subject: mb/google/skyrim: Fix eMMC reset GPIO ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74512/comment/71a209d0_341a9710 PS1, Line 9: On Whiterun, the eMMC reset GPIO should be SSD_AUX_RST_L(GPIO6). > Skyrim, frostflow and crystaldrift use the right GPIO. Markarth needs to be updated. Done https://review.coreboot.org/c/coreboot/+/74512/comment/307660fe_68563cd8 PS1, Line 9: SSD_AUX_RST_L(GPIO6) > nit: add a space: `SSD_AUX_RST_L (GPIO6)` Done -- To view, visit https://review.coreboot.org/c/coreboot/+/74512 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4713b3af23bb7684c9e2e81cf9c8d8a560b41a79 Gerrit-Change-Number: 74512 Gerrit-PatchSet: 1 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Tue, 18 Apr 2023 21:50:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim: Fix eMMC reset GPIO
by Karthik Ramasubramanian (Code Review) 18 Apr '23

18 Apr '23

Attention is currently required from: Jason Nien, Jon Murphy, Martin Roth, Tim Van Patten, Mark Hasemeyer. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74512 ) Change subject: mb/google/skyrim: Fix eMMC reset GPIO ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74512/comment/7ef731f8_cf8103a8 PS1, Line 9: On Whiterun, the eMMC reset GPIO should be SSD_AUX_RST_L(GPIO6). > It looks like everything should be updated to GPIO6. […] Skyrim, frostflow and crystaldrift use the right GPIO. Markarth needs to be updated. -- To view, visit https://review.coreboot.org/c/coreboot/+/74512 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4713b3af23bb7684c9e2e81cf9c8d8a560b41a79 Gerrit-Change-Number: 74512 Gerrit-PatchSet: 1 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Tue, 18 Apr 2023 21:44:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/amd/birman/ec.c: Update EC configuration
by Felix Held (Code Review) 18 Apr '23

18 Apr '23

Attention is currently required from: Jason Glenesk, Paul Menzel, Martin Roth, Fred Reitberger. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73971 ) Change subject: mb/amd/birman/ec.c: Update EC configuration ...................................................................... Patch Set 10: (1 comment) File src/mainboard/amd/birman/Kconfig: https://review.coreboot.org/c/coreboot/+/73971/comment/6e948ada_b06f5122 PS10, Line 120: WWAN wlan -- To view, visit https://review.coreboot.org/c/coreboot/+/73971 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icd9df120f555eb06f920f6263a8d2ab45c05baec Gerrit-Change-Number: 73971 Gerrit-PatchSet: 10 Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Tue, 18 Apr 2023 21:42:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim: Fix eMMC reset GPIO
by Tim Van Patten (Code Review) 18 Apr '23

18 Apr '23

Attention is currently required from: Jason Nien, Jon Murphy, Martin Roth, Karthik Ramasubramanian, Mark Hasemeyer. Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74512 ) Change subject: mb/google/skyrim: Fix eMMC reset GPIO ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74512/comment/492cb62e_c6a2ea22 PS1, Line 9: On Whiterun, the eMMC reset GPIO should be SSD_AUX_RST_L(GPIO6). It looks like everything should be updated to GPIO6. Will there be other CLs for the other boards? https://review.coreboot.org/c/coreboot/+/74512/comment/a021caa5_92cd1dd7 PS1, Line 9: SSD_AUX_RST_L(GPIO6) nit: add a space: `SSD_AUX_RST_L (GPIO6)` -- To view, visit https://review.coreboot.org/c/coreboot/+/74512 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4713b3af23bb7684c9e2e81cf9c8d8a560b41a79 Gerrit-Change-Number: 74512 Gerrit-PatchSet: 1 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Tue, 18 Apr 2023 21:36:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim: Fix eMMC reset GPIO
by Jon Murphy (Code Review) 18 Apr '23

18 Apr '23

Jon Murphy has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74512 ) Change subject: mb/google/skyrim: Fix eMMC reset GPIO ...................................................................... mb/google/skyrim: Fix eMMC reset GPIO On Whiterun, the eMMC reset GPIO should be SSD_AUX_RST_L(GPIO6). Update the port_descriptor to link the correct reset GPIO. Data is from the Whiterun schematic and go/skyrim-gpios. BUG=b:278759559 TEST=None Signed-off-by: Jon Murphy <jpmurphy(a)google.com> Change-Id: I4713b3af23bb7684c9e2e81cf9c8d8a560b41a79 --- M src/mainboard/google/skyrim/variants/winterhold/port_descriptors.c 1 file changed, 18 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/74512/1 diff --git a/src/mainboard/google/skyrim/variants/winterhold/port_descriptors.c b/src/mainboard/google/skyrim/variants/winterhold/port_descriptors.c index 37edb02..330fc46 100644 --- a/src/mainboard/google/skyrim/variants/winterhold/port_descriptors.c +++ b/src/mainboard/google/skyrim/variants/winterhold/port_descriptors.c @@ -35,7 +35,7 @@ .link_aspm = ASPM_L1, .link_aspm_L1_1 = true, .link_aspm_L1_2 = true, - .gpio_group_id = GPIO_27, + .gpio_group_id = GPIO_6, .clk_req = CLK_REQ1, }, }; -- To view, visit https://review.coreboot.org/c/coreboot/+/74512 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4713b3af23bb7684c9e2e81cf9c8d8a560b41a79 Gerrit-Change-Number: 74512 Gerrit-PatchSet: 1 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/starlabs/starbook: Add ramtop_cmos_offset
by Sean Rhodes (Code Review) 18 Apr '23

18 Apr '23

Attention is currently required from: Subrata Banik, Nico Huber, Arthur Heymans. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74432 ) Change subject: mb/starlabs/starbook: Add ramtop_cmos_offset ...................................................................... Patch Set 4: (1 comment) File src/mainboard/starlabs/starbook/cmos.layout: https://review.coreboot.org/c/coreboot/+/74432/comment/5feb6a32_2bc403fe PS2, Line 42: 800 > Seems good now, at least according to my theory. […] Your theory seemed accurate, cmos was corrupt if not reset. After this, no problems (so far!) -- To view, visit https://review.coreboot.org/c/coreboot/+/74432 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88128d2c62bdc3246a3f30e768c353f0fe3faeb7 Gerrit-Change-Number: 74432 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subi.banik(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subi.banik(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 18 Apr 2023 21:05:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/starlabs/starbook: Add ramtop_cmos_offset
by Nico Huber (Code Review) 18 Apr '23

18 Apr '23

Attention is currently required from: Subrata Banik, Sean Rhodes, Arthur Heymans. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74432 ) Change subject: mb/starlabs/starbook: Add ramtop_cmos_offset ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File src/mainboard/starlabs/starbook/cmos.layout: https://review.coreboot.org/c/coreboot/+/74432/comment/9b06e640_80be1494 PS2, Line 42: 800 > The ramstop feature doesn't seem to use the option table API and I don't see […] Seems good now, at least according to my theory. But please share your test results :) -- To view, visit https://review.coreboot.org/c/coreboot/+/74432 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88128d2c62bdc3246a3f30e768c353f0fe3faeb7 Gerrit-Change-Number: 74432 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subi.banik(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subi.banik(a)gmail.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 18 Apr 2023 21:00:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/common: Make ramtop offset configurable
by Nico Huber (Code Review) 18 Apr '23

18 Apr '23

Attention is currently required from: Sean Rhodes, Subrata Banik, Lean Sheng Tan. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74511 ) Change subject: soc/intel/common: Make ramtop offset configurable ...................................................................... Patch Set 3: (1 comment) File src/soc/intel/common/basecode/ramtop/ramtop.c: https://review.coreboot.org/c/coreboot/+/74511/comment/197cecb6_1bd9ecb8 PS2, Line 23: CMOS_VSTART_ramtop_cmos_offset If there is no other code to sync with, I think we can just use CMOS_VSTART_ramtop_cmos_offset w/o comparing it to anything redundant, and fall back to the default value if no option table is used. Something like #if CONFIG(USE_OPTION_TABLE) #include "option_table.h" #if CMOS_VSTART_ramtop_cmos_offset % 8 == 0 #define RAMTOP_CMOS_OFFSET (CMOS_VSTART_ramtop_cmos_offset / 8) #else #error ... #endif ... #else #define RAMTOP_CMOS_OFFSET 100 #endif -- To view, visit https://review.coreboot.org/c/coreboot/+/74511 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5327b5d4e78b715a85072e5d9a62cf8fd2ae92c0 Gerrit-Change-Number: 74511 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Tue, 18 Apr 2023 20:54:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023