coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: mb/google/brya/var/taeko: remove rtd3 for emmc
by Joey Peng (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Cliff Huang, Tarun Tuli, Nick Vaccaro. Joey Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74029 ) Change subject: mb/google/brya/var/taeko: remove rtd3 for emmc ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Friendly ping. Since https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/… has merged, we would need this CL to be merged as well for eMMC SKUs to boot to OS. -- To view, visit https://review.coreboot.org/c/coreboot/+/74029 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I21191c9762a00ba137892e680d533f7dc3b53e86 Gerrit-Change-Number: 74029 Gerrit-PatchSet: 1 Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Tue, 25 Apr 2023 09:44:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: src/mb/facebook/fbg1701/board_mboot.h: Remove config from list
by Frans Hendriks (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Erik van den Bogaert. Hello Erik van den Bogaert, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74750 to look at the new patch set (#3). Change subject: src/mb/facebook/fbg1701/board_mboot.h: Remove config from list ...................................................................... src/mb/facebook/fbg1701/board_mboot.h: Remove config from list Error message ´Cannot map compressed file config without cbfs_cache' is reported. Compressed parts of CBFS can not be used during bootblock stage. Remove config from mb_log_list and add it to verified items. BUG=NA TEST=booting and verify log on facebook FBG1701 Change-Id: Iacf023bc8b9c2ebc66137c4ea683589751a30d2f Signed-off-by: Frans Hendriks <fhendriks(a)eltan.com> --- M src/mainboard/facebook/fbg1701/board_mboot.h 1 file changed, 18 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/74750/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/74750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iacf023bc8b9c2ebc66137c4ea683589751a30d2f Gerrit-Change-Number: 74750 Gerrit-PatchSet: 3 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/skyrim/var/winterhold:Generate RAM IDs for new memory parts
by Rex Chou (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Jason Nien, Martin Roth. Hello build bot (Jenkins), Jason Nien, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74740 to look at the new patch set (#4). Change subject: mb/google/skyrim/var/winterhold:Generate RAM IDs for new memory parts ...................................................................... mb/google/skyrim/var/winterhold:Generate RAM IDs for new memory parts Update K3KL6L60GM-MGCT support BRANCH=None BUG=b:243337816 TEST=emerge-skyrim coreboot Change-Id: I89b9798c16635a32dff12f1c0b65737d3c16cd59 Signed-off-by: Rex Chou <rex_chou(a)compal.corp-partner.google.com> --- M src/mainboard/google/skyrim/variants/winterhold/memory/Makefile.inc M src/mainboard/google/skyrim/variants/winterhold/memory/dram_id.generated.txt M src/mainboard/google/skyrim/variants/winterhold/memory/mem_parts_used.txt 3 files changed, 19 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/74740/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/74740 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I89b9798c16635a32dff12f1c0b65737d3c16cd59 Gerrit-Change-Number: 74740 Gerrit-PatchSet: 4 Gerrit-Owner: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: src/mb/facebook/fbg1701/board_mboot.h: Remove config from list
by Frans Hendriks (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Erik van den Bogaert. Hello Erik van den Bogaert, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74750 to look at the new patch set (#2). Change subject: src/mb/facebook/fbg1701/board_mboot.h: Remove config from list ...................................................................... src/mb/facebook/fbg1701/board_mboot.h: Remove config from list Error message ´Cannot map compressed file config without cbfs_cache' is reported. Compressed parts of CBFS can not be used during bootblock stage. Remove config from mb_log_list and add it to verified items. BUG=NA TEST=Boot and verify logging on facebook FBG1701 Change-Id: Iacf023bc8b9c2ebc66137c4ea683589751a30d2f Signed-off-by: Frans Hendriks <fhendriks(a)eltan.com> --- M src/mainboard/facebook/fbg1701/board_mboot.h 1 file changed, 18 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/74750/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iacf023bc8b9c2ebc66137c4ea683589751a30d2f Gerrit-Change-Number: 74750 Gerrit-PatchSet: 2 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/nissa/var/craask: avoid camera LED blinking during boot
by Jimmy Su (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Tarun Tuli, Reka Norman, Jimmy Su, Tyler Wang. Jimmy Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74728 ) Change subject: mb/google/nissa/var/craask: avoid camera LED blinking during boot ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74728 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I78ed5efe1e2c071d817c1e0455271886e89e63c7 Gerrit-Change-Number: 74728 Gerrit-PatchSet: 1 Gerrit-Owner: Jimmy Su <jimmy.su(a)intel.com> Gerrit-Reviewer: Jimmy Su <jimmy.su(a)intel.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Andy Yeh <andy.yeh(a)intel.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Tian Shu Qiu <tian.shu.qiu(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Jimmy Su <jimmy.su(a)intel.com> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Tue, 25 Apr 2023 09:33:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: src/mb/facebook/fbg1701/board mboot.h: Remove config from list´
by build bot (Jenkins) (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Erik van den Bogaert. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74750 ) Change subject: src/mb/facebook/fbg1701/board_mboot.h: Remove config from list´ ...................................................................... Patch Set 1: (2 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174908): https://review.coreboot.org/c/coreboot/+/74750/comment/3c112f56_c4587c03 PS1, Line 6: Possible long commit subject (prefer a maximum 65 characters) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174908): https://review.coreboot.org/c/coreboot/+/74750/comment/6be09192_fbcfd9c3 PS1, Line 15: TEST=Boot and verify logging on facebook FBG1701 Possible repeated word: 'and' -- To view, visit https://review.coreboot.org/c/coreboot/+/74750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iacf023bc8b9c2ebc66137c4ea683589751a30d2f Gerrit-Change-Number: 74750 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Comment-Date: Tue, 25 Apr 2023 09:31:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: src/mb/facebook/fbg1701/board mboot.h: Remove config from list´
by Frans Hendriks (Code Review) 25 Apr '23

25 Apr '23

Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74750 ) Change subject: src/mb/facebook/fbg1701/board_mboot.h: Remove config from list´ ...................................................................... src/mb/facebook/fbg1701/board_mboot.h: Remove config from list´ Error message ´Cannot map compressed file config without cbfs_cache Compressed parts of CBFS can not used during bootblock stage. Remove config from mb_log_list and and it to verified items. BUG=NA TEST=Boot and verify logging on facebook FBG1701 Change-Id: Iacf023bc8b9c2ebc66137c4ea683589751a30d2f Signed-off-by: Frans Hendriks <fhendriks(a)eltan.com> --- M src/mainboard/facebook/fbg1701/board_mboot.h 1 file changed, 18 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/74750/1 diff --git a/src/mainboard/facebook/fbg1701/board_mboot.h b/src/mainboard/facebook/fbg1701/board_mboot.h index 2865824..87dcb77 100644 --- a/src/mainboard/facebook/fbg1701/board_mboot.h +++ b/src/mainboard/facebook/fbg1701/board_mboot.h @@ -4,7 +4,6 @@ #include "board_verified_boot.h" const mboot_measure_item_t mb_log_list[] = { - { "config", CBFS_TYPE_RAW, MBOOT_PCR_INDEX_0, EV_NO_ACTION, NULL }, { "revision", CBFS_TYPE_RAW, MBOOT_PCR_INDEX_0, EV_NO_ACTION, NULL }, { "cmos_layout.bin", CBFS_TYPE_CMOS_LAYOUT, MBOOT_PCR_INDEX_0, EV_NO_ACTION, NULL }, -- To view, visit https://review.coreboot.org/c/coreboot/+/74750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iacf023bc8b9c2ebc66137c4ea683589751a30d2f Gerrit-Change-Number: 74750 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-MessageType: newchange

1 0

[XL] Change in coreboot[master]: vendorcode/intel/fsp/fsp2_0/alderlake: Remove unused headers
by Arthur Heymans (Code Review) 25 Apr '23

25 Apr '23

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74729 ) Change subject: vendorcode/intel/fsp/fsp2_0/alderlake: Remove unused headers ...................................................................... vendorcode/intel/fsp/fsp2_0/alderlake: Remove unused headers The headers from the FSP repo are used directly. Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: I58eda4b2f48386c39c9258a4ceacf0d84280397c --- D src/vendorcode/intel/fsp/fsp2_0/alderlake/FirmwareVersionInfoHob.h D src/vendorcode/intel/fsp/fsp2_0/alderlake/FspUpd.h D src/vendorcode/intel/fsp/fsp2_0/alderlake/FspmUpd.h D src/vendorcode/intel/fsp/fsp2_0/alderlake/FspsUpd.h D src/vendorcode/intel/fsp/fsp2_0/alderlake/MemInfoHob.h 5 files changed, 12 insertions(+), 7,576 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/74729/1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74729 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I58eda4b2f48386c39c9258a4ceacf0d84280397c Gerrit-Change-Number: 74729 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/google/brya/var/taeko:Disable C1E for RPL CPU
by build bot (Jenkins) (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Tarun Tuli, YH Lin, Subrata Banik, Nick Vaccaro, Eric Lai. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74727 ) Change subject: mb/google/brya/var/taeko:Disable C1E for RPL CPU ...................................................................... Patch Set 6: (1 comment) File src/mainboard/google/brya/variants/taeko/variant.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174906): https://review.coreboot.org/c/coreboot/+/74727/comment/1cda934f_33daac62 PS6, Line 23: else if (cpu_id == CPUID_ALDERLAKE_R0) { else should follow close brace '}' -- To view, visit https://review.coreboot.org/c/coreboot/+/74727 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic2d2d5d6075de25141c1d08ec18838731c63a342 Gerrit-Change-Number: 74727 Gerrit-PatchSet: 6 Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin3 Yang <kevin3.yang(a)lcfc.corp-partner.google.com> Gerrit-CC: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Tue, 25 Apr 2023 09:23:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/taeko:Disable C1E for RPL CPU
by Joey Peng (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Tarun Tuli, YH Lin, Subrata Banik, Nick Vaccaro, Eric Lai. Hello YH Lin, Tarun Tuli, Subrata Banik, Nick Vaccaro, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74727 to look at the new patch set (#6). Change subject: mb/google/brya/var/taeko:Disable C1E for RPL CPU ...................................................................... mb/google/brya/var/taeko:Disable C1E for RPL CPU Disable C1E on RPL CPU for improving acoustic noise tests BUG=b:278654939 TEST:emerge-brya coreboot and check that C1E can be disabled on RPL CPU Signed-off-by: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Change-Id: Ic2d2d5d6075de25141c1d08ec18838731c63a342 --- M src/mainboard/google/brya/variants/taeko/variant.c M src/soc/intel/alderlake/chip.h M src/soc/intel/alderlake/fsp_params.c 3 files changed, 41 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/74727/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/74727 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic2d2d5d6075de25141c1d08ec18838731c63a342 Gerrit-Change-Number: 74727 Gerrit-PatchSet: 6 Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin3 Yang <kevin3.yang(a)lcfc.corp-partner.google.com> Gerrit-CC: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023