coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: src/mb/facebook/fbg1701/board_mboot.h: Remove config from list
by Paul Menzel (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Erik van den Bogaert, Frans Hendriks. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74750 ) Change subject: src/mb/facebook/fbg1701/board_mboot.h: Remove config from list ...................................................................... Patch Set 3: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74750/comment/d21a2a2f_b67e9a52 PS3, Line 7: list log list? https://review.coreboot.org/c/coreboot/+/74750/comment/e2bea19a_a521d9a8 PS3, Line 7: src/ Please remove. https://review.coreboot.org/c/coreboot/+/74750/comment/6cb0059c_71e55370 PS3, Line 12: and add it to verified items Where is it added? -- To view, visit https://review.coreboot.org/c/coreboot/+/74750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iacf023bc8b9c2ebc66137c4ea683589751a30d2f Gerrit-Change-Number: 74750 Gerrit-PatchSet: 3 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Comment-Date: Tue, 25 Apr 2023 10:21:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim/var/winterhold:Generate RAM IDs for new memory parts
by Paul Menzel (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Jason Nien, Rex Chou, Martin Roth. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74740 ) Change subject: mb/google/skyrim/var/winterhold:Generate RAM IDs for new memory parts ...................................................................... Patch Set 4: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74740/comment/e17e4cb1_d9c6f964 PS4, Line 7: winterhold:Generate Add a space after the colon (:). https://review.coreboot.org/c/coreboot/+/74740/comment/b4138d28_196aaf7f PS4, Line 7: Generate RAM IDs for new memory parts I suggest: > Add support for K3KL6L60GM-MGCT https://review.coreboot.org/c/coreboot/+/74740/comment/b65770d4_53ffb9b4 PS4, Line 9: Update K3KL6L60GM-MGCT support 1. What kind of DIMM is it? 2. Please document the vendor. -- To view, visit https://review.coreboot.org/c/coreboot/+/74740 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I89b9798c16635a32dff12f1c0b65737d3c16cd59 Gerrit-Change-Number: 74740 Gerrit-PatchSet: 4 Gerrit-Owner: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Tue, 25 Apr 2023 10:18:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: spd/lp5: Add SPD for Samsung K3KL6L60GM-MGCT
by Paul Menzel (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Subrata Banik. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73343 ) Change subject: spd/lp5: Add SPD for Samsung K3KL6L60GM-MGCT ...................................................................... Patch Set 2: (1 comment) File spd/lp5/set-0/spd-9.hex: PS2: Sorry, I just noticed this now, but the commit message does not say, how an existing SPD, added in commit afd2f6ed6256 (spd/lp5: Add new memory configuration of H9JCNNNFA5MLYR-N6E) [1], was changed. Won’t that cause issues for the H9JCNNNFA5MLYR-N6E? [1]: https://review.coreboot.org/c/coreboot/+/68154 -- To view, visit https://review.coreboot.org/c/coreboot/+/73343 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I64b2623bc8da94c1fd3a935ec5368cdc6e76505b Gerrit-Change-Number: 73343 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Tue, 25 Apr 2023 10:17:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: WIP mb/prodrive/atlas: Enable/disable sleep states based on EC
by Arthur Heymans (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Lance Zhao, Tim Wawrzynczak, Christian Walter, Angel Pons, Arthur Heymans, Lean Sheng Tan. Hello Lance Zhao, build bot (Jenkins), Tim Wawrzynczak, Christian Walter, Angel Pons, Lean Sheng Tan, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74421 to look at the new patch set (#2). Change subject: WIP mb/prodrive/atlas: Enable/disable sleep states based on EC ...................................................................... WIP mb/prodrive/atlas: Enable/disable sleep states based on EC With the profile ATLAS_PROF_REALTIME_PERFORMANCE it is desired to not have the option to be able to sleep, the reason being that windows goes to sleep after 30min of inactivity. Change-Id: I424db7e712a705c628aa3a10a486d3313404987a Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/acpi/Kconfig M src/mainboard/prodrive/atlas/Kconfig M src/mainboard/prodrive/atlas/mainboard.c M src/southbridge/intel/common/acpi/sleepstates.asl 4 files changed, 68 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/74421/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74421 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I424db7e712a705c628aa3a10a486d3313404987a Gerrit-Change-Number: 74421 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: src/mb/facebook/fbg1701: Add config to additional list
by Frans Hendriks (Code Review) 25 Apr '23

25 Apr '23

Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74752 ) Change subject: src/mb/facebook/fbg1701: Add config to additional list ...................................................................... src/mb/facebook/fbg1701: Add config to additional list ´config´ is removed from measure list (CB:74750) Add 'config' to ram_stage_additional_list[] to have it measured and verified. BUG=NA TEST=booting and verify log on facebook FBG1701 Change-Id: Id4119bc3a01e11f14a091facf81964d1a71092c1 Signed-off-by: Frans Hendriks <fhendriks(a)eltan.com> --- M src/mainboard/facebook/fbg1701/board_verified_boot.c M src/mainboard/facebook/fbg1701/manifest.h M src/vendorcode/eltan/security/verified_boot/Kconfig 3 files changed, 25 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/74752/1 diff --git a/src/mainboard/facebook/fbg1701/board_verified_boot.c b/src/mainboard/facebook/fbg1701/board_verified_boot.c index 8b644cb..4932964 100644 --- a/src/mainboard/facebook/fbg1701/board_verified_boot.c +++ b/src/mainboard/facebook/fbg1701/board_verified_boot.c @@ -60,6 +60,10 @@ * romstage verify list */ static const verify_item_t ram_stage_additional_list[] = { +#if CONFIG(INCLUDE_CONFIG_FILE) + { VERIFY_FILE, "config", { { NULL, CBFS_TYPE_RAW } }, + HASH_IDX_CONFIG, MBOOT_PCR_INDEX_0 }, +#endif { VERIFY_FILE, OP_ROM_VBT, { { NULL, CBFS_TYPE_RAW } }, HASH_IDX_OPROM, MBOOT_PCR_INDEX_2 }, #if CONFIG(BMP_LOGO) diff --git a/src/mainboard/facebook/fbg1701/manifest.h b/src/mainboard/facebook/fbg1701/manifest.h index b104354..141b83e 100644 --- a/src/mainboard/facebook/fbg1701/manifest.h +++ b/src/mainboard/facebook/fbg1701/manifest.h @@ -18,5 +18,6 @@ #define HASH_IDX_DSDT 8 #define HASH_IDX_POSTCAR_STAGE 9 #define HASH_IDX_PUBLICKEY 10 -#define HASH_IDX_BOOTBLOCK 11 /* Should always be the last one */ +#define HASH_IDX_CONFIG 11 +#define HASH_IDX_BOOTBLOCK 12 /* Should always be the last one */ #endif diff --git a/src/vendorcode/eltan/security/verified_boot/Kconfig b/src/vendorcode/eltan/security/verified_boot/Kconfig index 7741782..50638db 100644 --- a/src/vendorcode/eltan/security/verified_boot/Kconfig +++ b/src/vendorcode/eltan/security/verified_boot/Kconfig @@ -33,6 +33,7 @@ config VENDORCODE_ELTAN_OEM_MANIFEST_ITEMS int "Manifest Items" + default 13 if INCLUDE_CONFIG_FILE default 12 config VENDORCODE_ELTAN_OEM_MANIFEST_ITEM_SIZE -- To view, visit https://review.coreboot.org/c/coreboot/+/74752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id4119bc3a01e11f14a091facf81964d1a71092c1 Gerrit-Change-Number: 74752 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/starlabs/starbook/adl: Correct port for Hot Plug
by Sean Rhodes (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Paul Menzel. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74738 ) Change subject: mb/starlabs/starbook/adl: Correct port for Hot Plug ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74738/comment/c7c4c3ce_199e4689 PS2, Line 9: ' > No quoting needed? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/74738 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I884f4997d73e31bd422477952466f168afad66a1 Gerrit-Change-Number: 74738 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 25 Apr 2023 09:46:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/starlabs/starbook/adl: Correct port for Hot Plug
by Sean Rhodes (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Sean Rhodes. Hello build bot (Jenkins), Paul Menzel, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74738 to look at the new patch set (#3). Change subject: mb/starlabs/starbook/adl: Correct port for Hot Plug ...................................................................... mb/starlabs/starbook/adl: Correct port for Hot Plug Commit 5103b87a4d7b ("mb/starlabs/starbook/adl: Add an option to enable Hot Plug") introduced an option to enable Hot Plug for the SSD. The port was set to 4 (RP5) which is the wireless card. Change this to 8 (RP9) which is the SSD. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I884f4997d73e31bd422477952466f168afad66a1 --- M src/mainboard/starlabs/starbook/variants/adl/ramstage.c 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/74738/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/74738 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I884f4997d73e31bd422477952466f168afad66a1 Gerrit-Change-Number: 74738 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/starlabs/starbook/adl: Correct port for Hot Plug
by Paul Menzel (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Sean Rhodes. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74738 ) Change subject: mb/starlabs/starbook/adl: Correct port for Hot Plug ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74738/comment/6dd4d28f_d1c233fd PS2, Line 9: ' No quoting needed? -- To view, visit https://review.coreboot.org/c/coreboot/+/74738 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I884f4997d73e31bd422477952466f168afad66a1 Gerrit-Change-Number: 74738 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Tue, 25 Apr 2023 09:46:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: vendorcode/intel/fsp/fsp2_0/alderlake: Remove unused headers
by Frans Hendriks (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Arthur Heymans. Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74729 ) Change subject: vendorcode/intel/fsp/fsp2_0/alderlake: Remove unused headers ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74729 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I58eda4b2f48386c39c9258a4ceacf0d84280397c Gerrit-Change-Number: 74729 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 25 Apr 2023 09:44:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/taniks: remove rtd3 for emmc
by Joey Peng (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Cliff Huang, Tarun Tuli, Nick Vaccaro. Joey Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74030 ) Change subject: mb/google/brya/var/taniks: remove rtd3 for emmc ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Friendly ping. Since https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/… has merged, we would need this CL to be merged as well for eMMC SKUs to boot to OS. -- To view, visit https://review.coreboot.org/c/coreboot/+/74030 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I03168ecbf4611f05acd8c6c722b6a5037a8cc31d Gerrit-Change-Number: 74030 Gerrit-PatchSet: 1 Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Tue, 25 Apr 2023 09:44:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023