coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: acpi/acpi.c: Reduce scope of some functions
by Arthur Heymans (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Lance Zhao, Martin L Roth, Subrata Banik, Lean Sheng Tan, Werner Zeh. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74756 ) Change subject: acpi/acpi.c: Reduce scope of some functions ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > can you elaborate more on the commit message? it is too vague. I'm not sure what you want. Reducing the scope of both functions and variables is an ubiquitous pattern in most programming language. -- To view, visit https://review.coreboot.org/c/coreboot/+/74756 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6f8282f308506a68b14ce3101f11078cb13709f2 Gerrit-Change-Number: 74756 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Tue, 25 Apr 2023 19:13:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: crossgcc: Upgrade LLVM version 15.0.7 to 16.0.2
by Elyes Haouas (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Jason Glenesk, Martin L Roth, Paul Menzel, Angel Pons. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73792 ) Change subject: crossgcc: Upgrade LLVM version 15.0.7 to 16.0.2 ...................................................................... Patch Set 15: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/73792/comment/d14a7d83_d0d3e3d6 PS4, Line 8: > Sorry, I only have this using llvm-16.0. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/73792 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I753bbcf3f03907b0cf966454c3dd6c9b61869599 Gerrit-Change-Number: 73792 Gerrit-PatchSet: 15 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 25 Apr 2023 19:10:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: crossgcc: Upgrade LLVM version 15.0.7 to 16.0.2
by build bot (Jenkins) (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Jason Glenesk, Martin L Roth, Paul Menzel, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73792 ) Change subject: crossgcc: Upgrade LLVM version 15.0.7 to 16.0.2 ...................................................................... Patch Set 15: (4 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174949): https://review.coreboot.org/c/coreboot/+/73792/comment/fbee1984_65b40dc7 PS15, Line 14: fallback/romstage 0x80 stage 17608 none Possible unwrapped commit description (prefer a maximum 72 chars per line) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174949): https://review.coreboot.org/c/coreboot/+/73792/comment/3b5c4f6b_ea26c797 PS15, Line 15: fallback/ramstage 0x4600 stage 64285 LZMA (137100 decompressed) Possible unwrapped commit description (prefer a maximum 72 chars per line) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174949): https://review.coreboot.org/c/coreboot/+/73792/comment/8138a7a2_1415f697 PS15, Line 29: fallback/romstage 0x80 stage 17608 none Possible unwrapped commit description (prefer a maximum 72 chars per line) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174949): https://review.coreboot.org/c/coreboot/+/73792/comment/b8fcd58d_59908acd PS15, Line 30: fallback/ramstage 0x4600 stage 64228 LZMA (137012 decompressed) Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/73792 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I753bbcf3f03907b0cf966454c3dd6c9b61869599 Gerrit-Change-Number: 73792 Gerrit-PatchSet: 15 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 25 Apr 2023 19:09:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: crossgcc: Upgrade LLVM version 15.0.7 to 16.0.2
by Elyes Haouas (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Jason Glenesk, Martin L Roth, Paul Menzel, Angel Pons. Hello Felix Singer, build bot (Jenkins), Jason Glenesk, Martin L Roth, Paul Menzel, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/73792 to look at the new patch set (#14). Change subject: crossgcc: Upgrade LLVM version 15.0.7 to 16.0.2 ...................................................................... crossgcc: Upgrade LLVM version 15.0.7 to 16.0.2 Built emulation/qemu-i440fx (QEMU x86 i440fx/piix4): LLVM version 15.0.7 FMAP REGION: COREBOOT Name Offset Type Size Comp cbfs_master_header 0x0 cbfs header 32 none fallback/romstage 0x80 stage 17608 none fallback/ramstage 0x4600 stage 64285 LZMA (137100 decompressed) config 0x14180 raw 1884 LZMA (5489 decompressed) revision 0x14940 raw 717 none build_info 0x14c40 raw 113 none fallback/dsdt.aml 0x14d00 raw 4044 none cmos_layout.bin 0x15d00 cmos_layout 640 none fallback/postcar 0x15fc0 stage 18832 none (empty) 0x1a9c0 null 4073892 none bootblock 0x3fd380 bootblock 10816 none LLVM version 16.0.2 FMAP REGION: COREBOOT Name Offset Type Size Comp cbfs_master_header 0x0 cbfs header 32 none fallback/romstage 0x80 stage 17608 none fallback/ramstage 0x4600 stage 64228 LZMA (137012 decompressed) config 0x14140 raw 1889 LZMA (5495 decompressed) revision 0x14900 raw 723 none build_info 0x14c00 raw 119 none fallback/dsdt.aml 0x14cc0 raw 4044 none cmos_layout.bin 0x15cc0 cmos_layout 640 none fallback/postcar 0x15f80 stage 18832 none (empty) 0x1a980 null 4073956 none bootblock 0x3fd380 bootblock 10816 none Change-Id: I753bbcf3f03907b0cf966454c3dd6c9b61869599 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/crossgcc/buildgcc D util/crossgcc/sum/clang-15.0.7.src.tar.xz.cksum A util/crossgcc/sum/clang-16.0.2.src.tar.xz.cksum D util/crossgcc/sum/clang-tools-extra-15.0.7.src.tar.xz.cksum A util/crossgcc/sum/clang-tools-extra-16.0.2.src.tar.xz.cksum D util/crossgcc/sum/cmake-15.0.7.src.tar.xz.cksum A util/crossgcc/sum/cmake-16.0.2.src.tar.xz.cksum D util/crossgcc/sum/compiler-rt-15.0.7.src.tar.xz.cksum A util/crossgcc/sum/compiler-rt-16.0.2.src.tar.xz.cksum D util/crossgcc/sum/llvm-15.0.7.src.tar.xz.cksum A util/crossgcc/sum/llvm-16.0.2.src.tar.xz.cksum 11 files changed, 47 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/73792/14 -- To view, visit https://review.coreboot.org/c/coreboot/+/73792 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I753bbcf3f03907b0cf966454c3dd6c9b61869599 Gerrit-Change-Number: 73792 Gerrit-PatchSet: 14 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: RFC: util/sconfig: Add include keyword
by Arthur Heymans (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Raul Rangel, Martin L Roth, Jon Murphy, Angel Pons, Tim Van Patten, Karthik Ramasubramanian, Felix Held. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74736 ) Change subject: RFC: util/sconfig: Add include keyword ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74736/comment/1bc152ab_6458b6c3 PS1, Line 9: Include > Instead of adding a new keyword, how about we just make sconfig check for a `chip.h` (or some fixed name) in the `mainboard` directory? Why not simply add it via CPPFLAGS of the static.o target in the makefile? It would look something like this: $(call src-to-obj,ramstage,$(obj)/mainboard/$(CONFIG_MAINBOARD_DIR)/static.c): CPPFLAGS_ramstage += -include file.h -- To view, visit https://review.coreboot.org/c/coreboot/+/74736 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I34893a703cc4f588dda3736e858429bf765059e6 Gerrit-Change-Number: 74736 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 19:05:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: crossgcc: Upgrade LLVM version 15.0.7 to 16.0.2
by Elyes Haouas (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Jason Glenesk, Martin L Roth, Paul Menzel, Angel Pons. Hello Felix Singer, build bot (Jenkins), Jason Glenesk, Martin L Roth, Paul Menzel, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/73792 to look at the new patch set (#13). Change subject: crossgcc: Upgrade LLVM version 15.0.7 to 16.0.2 ...................................................................... crossgcc: Upgrade LLVM version 15.0.7 to 16.0.2 LLVM version 15.0.7 FMAP REGION: COREBOOT Name Offset Type Size Comp cbfs_master_header 0x0 cbfs header 32 none fallback/romstage 0x80 stage 17608 none fallback/ramstage 0x4600 stage 64285 LZMA (137100 decompressed) config 0x14180 raw 1884 LZMA (5489 decompressed) revision 0x14940 raw 717 none build_info 0x14c40 raw 113 none fallback/dsdt.aml 0x14d00 raw 4044 none cmos_layout.bin 0x15d00 cmos_layout 640 none fallback/postcar 0x15fc0 stage 18832 none (empty) 0x1a9c0 null 4073892 none bootblock 0x3fd380 bootblock 10816 none LLVM version 16.0.2 FMAP REGION: COREBOOT Name Offset Type Size Comp cbfs_master_header 0x0 cbfs header 32 none fallback/romstage 0x80 stage 17608 none fallback/ramstage 0x4600 stage 64228 LZMA (137012 decompressed) config 0x14140 raw 1889 LZMA (5495 decompressed) revision 0x14900 raw 723 none build_info 0x14c00 raw 119 none fallback/dsdt.aml 0x14cc0 raw 4044 none cmos_layout.bin 0x15cc0 cmos_layout 640 none fallback/postcar 0x15f80 stage 18832 none (empty) 0x1a980 null 4073956 none bootblock 0x3fd380 bootblock 10816 none Change-Id: I753bbcf3f03907b0cf966454c3dd6c9b61869599 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/crossgcc/buildgcc D util/crossgcc/sum/clang-15.0.7.src.tar.xz.cksum A util/crossgcc/sum/clang-16.0.2.src.tar.xz.cksum D util/crossgcc/sum/clang-tools-extra-15.0.7.src.tar.xz.cksum A util/crossgcc/sum/clang-tools-extra-16.0.2.src.tar.xz.cksum D util/crossgcc/sum/cmake-15.0.7.src.tar.xz.cksum A util/crossgcc/sum/cmake-16.0.2.src.tar.xz.cksum D util/crossgcc/sum/compiler-rt-15.0.7.src.tar.xz.cksum A util/crossgcc/sum/compiler-rt-16.0.2.src.tar.xz.cksum D util/crossgcc/sum/llvm-15.0.7.src.tar.xz.cksum A util/crossgcc/sum/llvm-16.0.2.src.tar.xz.cksum 11 files changed, 46 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/73792/13 -- To view, visit https://review.coreboot.org/c/coreboot/+/73792 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I753bbcf3f03907b0cf966454c3dd6c9b61869599 Gerrit-Change-Number: 73792 Gerrit-PatchSet: 13 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: acpi/acpi.c: Reduce scope of some functions
by Tim Wawrzynczak (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Lance Zhao, Martin L Roth, Subrata Banik, Arthur Heymans, Werner Zeh. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74756 ) Change subject: acpi/acpi.c: Reduce scope of some functions ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74756 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6f8282f308506a68b14ce3101f11078cb13709f2 Gerrit-Change-Number: 74756 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Tue, 25 Apr 2023 19:04:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: crossgcc: Upgrade LLVM version 15.0.7 to 16.0.2
by Elyes Haouas (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Jason Glenesk, Martin L Roth, Paul Menzel, Angel Pons. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73792 ) Change subject: crossgcc: Upgrade LLVM version 15.0.7 to 16.0.2 ...................................................................... Patch Set 12: (1 comment) File util/crossgcc/buildgcc: https://review.coreboot.org/c/coreboot/+/73792/comment/5597b93c_c04c81a9 PS12, Line 885: --print-librt-file-name it gives this error: "clang: error: unsupported option '--print-librt-file-name'" -- To view, visit https://review.coreboot.org/c/coreboot/+/73792 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I753bbcf3f03907b0cf966454c3dd6c9b61869599 Gerrit-Change-Number: 73792 Gerrit-PatchSet: 12 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 25 Apr 2023 18:56:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: RFC: util/sconfig: Add include keyword
by Raul Rangel (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Martin L Roth, Jon Murphy, Arthur Heymans, Angel Pons, Tim Van Patten, Karthik Ramasubramanian, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74736 ) Change subject: RFC: util/sconfig: Add include keyword ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74736/comment/5da6d955_2ec1b856 PS1, Line 9: Include Instead of adding a new keyword, how about we just make sconfig check for a `chip.h` (or some fixed name) in the `mainboard` directory? -- To view, visit https://review.coreboot.org/c/coreboot/+/74736 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I34893a703cc4f588dda3736e858429bf765059e6 Gerrit-Change-Number: 74736 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 18:52:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/cbmem: Add REG_NEWLINE flag to fix matching pattern
by Raul Rangel (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Konrad Adamczyk, Jakub Czapiga, Grzegorz Bernacki. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74742 ) Change subject: util/cbmem: Add REG_NEWLINE flag to fix matching pattern ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74742/comment/f58449d0_9c248f72 PS1, Line 13: REG_NEWLINE How was this working before? Did we change the banner? -- To view, visit https://review.coreboot.org/c/coreboot/+/74742 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9e924349ead0fa7eea8b9ad5161138a4c4946ade Gerrit-Change-Number: 74742 Gerrit-PatchSet: 1 Gerrit-Owner: Konrad Adamczyk <konrada(a)google.com> Gerrit-Reviewer: Grzegorz Bernacki Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Konrad Adamczyk <konrada(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Grzegorz Bernacki Gerrit-Comment-Date: Tue, 25 Apr 2023 18:45:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023