coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[M] Change in coreboot[master]: soc/intel: Introduce ioapic_get_sci_pin()
by Arthur Heymans (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Lance Zhao, Tim Wawrzynczak, Kyösti Mälkki, Werner Zeh. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74326 ) Change subject: soc/intel: Introduce ioapic_get_sci_pin() ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74326 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I723c207f1dcbba5e6fc0452fe1dbd087fad290ee Gerrit-Change-Number: 74326 Gerrit-PatchSet: 5 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Tue, 25 Apr 2023 19:21:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: payloads/libpayload: Support sending EOP from payload
by build bot (Jenkins) (Code Review) 25 Apr '23

25 Apr '23

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74767 ) Change subject: payloads/libpayload: Support sending EOP from payload ...................................................................... Patch Set 1: (1 comment) File payloads/libpayload/libc/coreboot.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174952): https://review.coreboot.org/c/coreboot/+/74767/comment/f8410c4e_bcd9ac44 PS1, Line 282: info->cse_eop = (struct cb_cse_eop*)ptr; "(foo*)" should be "(foo *)" -- To view, visit https://review.coreboot.org/c/coreboot/+/74767 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e52434b178ba2963c756241e588cb075f71ffa4 Gerrit-Change-Number: 74767 Gerrit-PatchSet: 1 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 25 Apr 2023 19:17:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: vc/amd/fsp/mendocino/FspmUpd: Update Update UPD structure for MDN-FSP
by Matt DeVillier (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Jason Glenesk, Raul Rangel, Chris Wang, Fred Reitberger, Felix Held. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74757 ) Change subject: vc/amd/fsp/mendocino/FspmUpd: Update Update UPD structure for MDN-FSP ...................................................................... Patch Set 1: (1 comment) File src/vendorcode/amd/fsp/mendocino/FspmUpd.h: https://review.coreboot.org/c/coreboot/+/74757/comment/a1029286_db3d9998 PS1, Line 104: pwr_on_vary_bl_to_blon; : /** Offset 0x04EB**/ uint8_t pwr_down_bloff_to_varybloff; > The naming here is to align with the PCD which is in FSP. […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/74757 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id410c40a65c0fd4b9b73cf36dc1f08eba0a3e44c Gerrit-Change-Number: 74757 Gerrit-PatchSet: 1 Gerrit-Owner: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 19:16:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Comment-In-Reply-To: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: coreboot_table: Support sending EOP from payload
by build bot (Jenkins) (Code Review) 25 Apr '23

25 Apr '23

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74766 ) Change subject: coreboot_table: Support sending EOP from payload ...................................................................... Patch Set 1: (1 comment) File src/lib/coreboot_table.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174951): https://review.coreboot.org/c/coreboot/+/74766/comment/884ec66c_8c9c789e PS1, Line 470: printk(BIOS_INFO, "fill_cse_eop_info\n"); Prefer using '"%s...", __func__' to using 'fill_cse_eop_info', this function's name, in a string -- To view, visit https://review.coreboot.org/c/coreboot/+/74766 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c77c59006ff4721efecf5aa537216326c33166e Gerrit-Change-Number: 74766 Gerrit-PatchSet: 1 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 25 Apr 2023 19:16:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex: Enable sending EOP from payload
by Kapil Porwal (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik. Kapil Porwal has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74768 ) Change subject: mb/google/rex: Enable sending EOP from payload ...................................................................... mb/google/rex: Enable sending EOP from payload Enable sending EOP from payload BUG=b:279184514 TEST=Verify sending EOP from depthcharge Signed-off-by: Kapil Porwal <kapilporwal(a)google.com> Change-Id: I5eda0a5c6d4c34cfcc2de898adde0b005d6edc1e --- M src/mainboard/google/rex/Kconfig 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/74768/1 diff --git a/src/mainboard/google/rex/Kconfig b/src/mainboard/google/rex/Kconfig index 528a2dc..073b5b4 100644 --- a/src/mainboard/google/rex/Kconfig +++ b/src/mainboard/google/rex/Kconfig @@ -27,7 +27,7 @@ select PMC_IPC_ACPI_INTERFACE select SOC_INTEL_CSE_LITE_SKU select SOC_INTEL_CSE_PRE_CPU_RESET_TELEMETRY_V2 - select SOC_INTEL_CSE_SEND_EOP_ASYNC + select SOC_INTEL_CSE_SEND_EOP_BY_PAYLOAD config BOARD_GOOGLE_BASEBOARD_REX def_bool n -- To view, visit https://review.coreboot.org/c/coreboot/+/74768 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5eda0a5c6d4c34cfcc2de898adde0b005d6edc1e Gerrit-Change-Number: 74768 Gerrit-PatchSet: 1 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: payloads/libpayload: Support sending EOP from payload
by Kapil Porwal (Code Review) 25 Apr '23

25 Apr '23

Kapil Porwal has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74767 ) Change subject: payloads/libpayload: Support sending EOP from payload ...................................................................... payloads/libpayload: Support sending EOP from payload Add support for sending EOP from payload BUG=b:279184514 TEST=Verify sending EOP from depthcharge Signed-off-by: Kapil Porwal <kapilporwal(a)google.com> Change-Id: I6e52434b178ba2963c756241e588cb075f71ffa4 --- M payloads/libpayload/include/coreboot_tables.h M payloads/libpayload/include/sysinfo.h M payloads/libpayload/libc/coreboot.c 3 files changed, 31 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/74767/1 diff --git a/payloads/libpayload/include/coreboot_tables.h b/payloads/libpayload/include/coreboot_tables.h index 5f6a223..53637fe 100644 --- a/payloads/libpayload/include/coreboot_tables.h +++ b/payloads/libpayload/include/coreboot_tables.h @@ -80,6 +80,7 @@ CB_TAG_TCPA_LOG = 0x0036, CB_TAG_FMAP = 0x0037, CB_TAG_SMMSTOREV2 = 0x0039, + CB_TAG_CSE_EOP = 0x003b, CB_TAG_BOARD_CONFIG = 0x0040, CB_TAG_ACPI_CNVS = 0x0041, CB_TAG_TYPE_C_INFO = 0x0042, @@ -419,6 +420,12 @@ u32 type; }; +struct cb_cse_eop { + uint32_t tag; + uint32_t size; + void (*send)(void); +}; + /* * Handoff the ACPI RSDP */ diff --git a/payloads/libpayload/include/sysinfo.h b/payloads/libpayload/include/sysinfo.h index 12d8a13..1bb64fe 100644 --- a/payloads/libpayload/include/sysinfo.h +++ b/payloads/libpayload/include/sysinfo.h @@ -159,6 +159,7 @@ uint32_t cbfs_ro_mcache_size; uintptr_t cbfs_rw_mcache_offset; uint32_t cbfs_rw_mcache_size; + struct cb_cse_eop *cse_eop; }; extern struct sysinfo_t lib_sysinfo; diff --git a/payloads/libpayload/libc/coreboot.c b/payloads/libpayload/libc/coreboot.c index bcc9530..d48c7cf 100644 --- a/payloads/libpayload/libc/coreboot.c +++ b/payloads/libpayload/libc/coreboot.c @@ -277,6 +277,11 @@ info->acpi_rsdp = cb_acpi_rsdp->rsdp_pointer; } +static void cb_parse_cse_eop(unsigned char *ptr, struct sysinfo_t *info) +{ + info->cse_eop = (struct cb_cse_eop*)ptr; +} + int cb_parse_header(void *addr, int len, struct sysinfo_t *info) { struct cb_header *header; @@ -423,6 +428,9 @@ case CB_TAG_PCIE: cb_parse_pcie(ptr, info); break; + case CB_TAG_CSE_EOP: + cb_parse_cse_eop(ptr, info); + break; default: cb_parse_arch_specific(rec, info); break; -- To view, visit https://review.coreboot.org/c/coreboot/+/74767 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e52434b178ba2963c756241e588cb075f71ffa4 Gerrit-Change-Number: 74767 Gerrit-PatchSet: 1 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: coreboot_table: Support sending EOP from payload
by Kapil Porwal (Code Review) 25 Apr '23

25 Apr '23

Kapil Porwal has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74766 ) Change subject: coreboot_table: Support sending EOP from payload ...................................................................... coreboot_table: Support sending EOP from payload Add support for sending EOP from payload BUG=b:279184514 TEST=Verify sending EOP from depthcharge Signed-off-by: Kapil Porwal <kapilporwal(a)google.com> Change-Id: I7c77c59006ff4721efecf5aa537216326c33166e --- M src/commonlib/include/commonlib/coreboot_tables.h M src/lib/coreboot_table.c 2 files changed, 37 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/74766/1 diff --git a/src/commonlib/include/commonlib/coreboot_tables.h b/src/commonlib/include/commonlib/coreboot_tables.h index e646b8b..a665209 100644 --- a/src/commonlib/include/commonlib/coreboot_tables.h +++ b/src/commonlib/include/commonlib/coreboot_tables.h @@ -82,6 +82,7 @@ LB_TAG_PLATFORM_BLOB_VERSION = 0x0038, LB_TAG_SMMSTOREV2 = 0x0039, LB_TAG_TPM_PPI_HANDOFF = 0x003a, + LB_TAG_CSE_EOP = 0x003b, LB_TAG_BOARD_CONFIG = 0x0040, LB_TAG_ACPI_CNVS = 0x0041, LB_TAG_TYPE_C_INFO = 0x0042, @@ -572,4 +573,10 @@ lb_uint64_t rsdp_pointer; /* Address of the ACPI RSDP */ }; +struct lb_cse_eop { + uint32_t tag; + uint32_t size; + void (*send)(void); +}; + #endif diff --git a/src/lib/coreboot_table.c b/src/lib/coreboot_table.c index bee389d..292f4bb 100644 --- a/src/lib/coreboot_table.c +++ b/src/lib/coreboot_table.c @@ -464,6 +464,19 @@ return (uintptr_t)lb_table_fini(head) - entry; } +static void fill_cse_eop_info(struct lb_header *head) +{ + struct lb_cse_eop *lb_eop; + printk(BIOS_INFO, "fill_cse_eop_info\n"); + + lb_eop = (struct lb_cse_eop *)lb_new_record(head); + + lb_eop->tag = LB_TAG_CSE_EOP; + lb_eop->size = sizeof(*lb_eop); + + lb_eop->send = lb_cse_send_eop_and_finalize; +} + static uintptr_t write_coreboot_table(uintptr_t rom_table_end) { struct lb_header *head; @@ -560,6 +573,8 @@ if (CONFIG(HAVE_ACPI_TABLES)) lb_add_acpi_rsdp(head); + fill_cse_eop_info(head); + /* Remember where my valid memory ranges are */ return lb_table_fini(head); } -- To view, visit https://review.coreboot.org/c/coreboot/+/74766 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c77c59006ff4721efecf5aa537216326c33166e Gerrit-Change-Number: 74766 Gerrit-PatchSet: 1 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: soc/intel/cmn/block/cse: Support sending EOP from payload
by Kapil Porwal (Code Review) 25 Apr '23

25 Apr '23

Kapil Porwal has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74765 ) Change subject: soc/intel/cmn/block/cse: Support sending EOP from payload ...................................................................... soc/intel/cmn/block/cse: Support sending EOP from payload Add support for sending EOP from payload BUG=b:279184514 TEST=Verify sending EOP from depthcharge Signed-off-by: Kapil Porwal <kapilporwal(a)google.com> Change-Id: I0fbb9fd0f8522eefad39960ca3167c2ba764f523 --- M src/include/boot/coreboot_tables.h M src/soc/intel/common/block/cse/Kconfig M src/soc/intel/common/block/cse/cse.c M src/soc/intel/common/block/cse/cse_eop.c 4 files changed, 43 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/74765/1 diff --git a/src/include/boot/coreboot_tables.h b/src/include/boot/coreboot_tables.h index e209e4b..5d33cd7 100644 --- a/src/include/boot/coreboot_tables.h +++ b/src/include/boot/coreboot_tables.h @@ -47,4 +47,6 @@ /* Add VBOOT VBNV offsets. */ void lb_table_add_vbnv_cmos(struct lb_header *header); +void lb_cse_send_eop_and_finalize(void); + #endif /* COREBOOT_TABLES_H */ diff --git a/src/soc/intel/common/block/cse/Kconfig b/src/soc/intel/common/block/cse/Kconfig index 73cb51bc..80b8c25 100644 --- a/src/soc/intel/common/block/cse/Kconfig +++ b/src/soc/intel/common/block/cse/Kconfig @@ -107,6 +107,16 @@ request is posted (at CSE .final device operation) and the time coreboot check for its completion (BS_PAYLOAD_LOAD). +config SOC_INTEL_CSE_SEND_EOP_BY_PAYLOAD + bool + depends on SOC_INTEL_COMMON_BLOCK_CSE + depends on !SOC_INTEL_CSE_SEND_EOP_LATE + depends on !SOC_INTEL_CSE_SEND_EOP_EARLY + depends on !SOC_INTEL_CSE_SEND_EOP_ASYNC + help + Use this config to send End Of Post (EOP) using payload. Coreboot supplies a function + pointer to send EOP to payload via SYSINFO table. + config SOC_INTEL_CSE_LITE_SKU bool default n diff --git a/src/soc/intel/common/block/cse/cse.c b/src/soc/intel/common/block/cse/cse.c index 1aa3454..8deef01 100644 --- a/src/soc/intel/common/block/cse/cse.c +++ b/src/soc/intel/common/block/cse/cse.c @@ -1408,6 +1408,7 @@ void cse_late_finalize(void) { if (!CONFIG(SOC_INTEL_CSE_SEND_EOP_LATE) && + !CONFIG(SOC_INTEL_CSE_SEND_EOP_BY_PAYLOAD) && !CONFIG(SOC_INTEL_CSE_SEND_EOP_ASYNC)) return; @@ -1434,6 +1435,7 @@ * will be run once the EOP command has successfully been completed. */ if (CONFIG(SOC_INTEL_CSE_SEND_EOP_LATE) || + CONFIG(SOC_INTEL_CSE_SEND_EOP_BY_PAYLOAD) || CONFIG(SOC_INTEL_CSE_SEND_EOP_ASYNC)) return; diff --git a/src/soc/intel/common/block/cse/cse_eop.c b/src/soc/intel/common/block/cse/cse_eop.c index dd67e59..264f3c4 100644 --- a/src/soc/intel/common/block/cse/cse_eop.c +++ b/src/soc/intel/common/block/cse/cse_eop.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <acpi/acpi.h> +#include <boot/coreboot_tables.h> #include <bootstate.h> #include <console/console.h> #include <intelblocks/cse.h> @@ -301,10 +302,22 @@ do_send_end_of_post(true); if (CONFIG(SOC_INTEL_CSE_SEND_EOP_LATE) || + CONFIG(SOC_INTEL_CSE_SEND_EOP_BY_PAYLOAD) || CONFIG(SOC_INTEL_CSE_SEND_EOP_ASYNC)) cse_late_finalize(); } +void lb_cse_send_eop_and_finalize(void) +{ + if (!CONFIG(SOC_INTEL_CSE_SEND_EOP_BY_PAYLOAD)) + return; + + printk(BIOS_INFO, "Sending End-of-POST from the payload!\n"); + + send_cse_eop_with_late_finalize(NULL); +} + +#if !CONFIG(SOC_INTEL_CSE_SEND_EOP_BY_PAYLOAD) /* * Ideally, to give coreboot maximum flexibility, sending EOP would be done as * late possible. If HECI_DISABLE_USING_SMM is selected, then sending EOP must @@ -319,3 +332,4 @@ #else BOOT_STATE_INIT_ENTRY(BS_PAYLOAD_LOAD, BS_ON_ENTRY, send_cse_eop_with_late_finalize, NULL); #endif +#endif -- To view, visit https://review.coreboot.org/c/coreboot/+/74765 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0fbb9fd0f8522eefad39960ca3167c2ba764f523 Gerrit-Change-Number: 74765 Gerrit-PatchSet: 1 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: acpi/acpi.c: Reduce scope of some functions
by Lean Sheng Tan (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Lance Zhao, Martin L Roth, Subrata Banik, Arthur Heymans, Werner Zeh. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74756 ) Change subject: acpi/acpi.c: Reduce scope of some functions ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74756 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6f8282f308506a68b14ce3101f11078cb13709f2 Gerrit-Change-Number: 74756 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Tue, 25 Apr 2023 19:14:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: acpi/acpi.c: Reduce scope of some functions
by Elyes Haouas (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Lance Zhao, Martin L Roth, Subrata Banik, Arthur Heymans, Lean Sheng Tan, Werner Zeh. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74756 ) Change subject: acpi/acpi.c: Reduce scope of some functions ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74756 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6f8282f308506a68b14ce3101f11078cb13709f2 Gerrit-Change-Number: 74756 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Tue, 25 Apr 2023 19:14:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023