Attention is currently required from: johnson wang, Xixi Chen, Yidi Lin.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/73339 )
Change subject: soc/mediatek/mt8188: Add scramble switch and fix 1RK register bit
......................................................................
Patch Set 5: Verified+1 Code-Review+2
--
To view, visit https://review.coreboot.org/c/blobs/+/73339
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: master
Gerrit-Change-Id: I7bf751e19d6df32bbd40b9dacad16fb99253d2ae
Gerrit-Change-Number: 73339
Gerrit-PatchSet: 5
Gerrit-Owner: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: johnson wang <johnson.wang(a)mediatek.corp-partner.google.com>
Gerrit-Attention: johnson wang <johnson.wang(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Comment-Date: Thu, 02 Mar 2023 09:54:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Scott Chao, Zhuohao Lee.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73174 )
Change subject: mb/google/brask/var/moli: Allow USB2/3 wakeups to (un)plug events in dt
......................................................................
Patch Set 11: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/73174
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1c8daf62dabe674a39b1416d886f9e470ae23a5b
Gerrit-Change-Number: 73174
Gerrit-PatchSet: 11
Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Comment-Date: Thu, 02 Mar 2023 09:44:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Arthur Heymans, Keith Hui, Elyes Haouas.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61540 )
Change subject: mb/asus/p8x7x-series: Refactor mainboard_get_spd()
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS4:
> All, let's start that weakness discussion right now. […]
Can't recall, sorry. In this case, it's likely that no override will be needed in the future, so feel free to leave out the __weak for now. Even if there's a board with 2 DIMM slots, it would still work: it just tries reading two SPDs that are always not present. It would only be a problem if the board uses a non-standard DIMM slot mapping, e.g. Asus P8H61-M PRO CM6630 (in asus/h61m-series).
TL;DR: Option 3 seems reasonable.
--
To view, visit https://review.coreboot.org/c/coreboot/+/61540
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b9c616a6c722e1f0fc124ced225efdcadb46b25
Gerrit-Change-Number: 61540
Gerrit-PatchSet: 6
Gerrit-Owner: Keith Hui <buurin(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Keith Hui <buurin(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Thu, 02 Mar 2023 09:41:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Keith Hui <buurin(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: johnson wang, Yu-Ping Wu, Yidi Lin.
Xixi Chen has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/73339 )
Change subject: soc/mediatek/mt8188: Add scramble switch and fix 1RK register bit
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/blobs/+/73339/comment/d3d54bff_26cbd9fc
PS4, Line 12: /
> `, `
Done
--
To view, visit https://review.coreboot.org/c/blobs/+/73339
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: master
Gerrit-Change-Id: I7bf751e19d6df32bbd40b9dacad16fb99253d2ae
Gerrit-Change-Number: 73339
Gerrit-PatchSet: 5
Gerrit-Owner: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: johnson wang <johnson.wang(a)mediatek.corp-partner.google.com>
Gerrit-Attention: johnson wang <johnson.wang(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Comment-Date: Thu, 02 Mar 2023 09:36:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: johnson wang, Xixi Chen, Yidi Lin.
Hello johnson wang, Yu-Ping Wu, Yidi Lin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/blobs/+/73339
to look at the new patch set (#5).
Change subject: soc/mediatek/mt8188: Add scramble switch and fix 1RK register bit
......................................................................
soc/mediatek/mt8188: Add scramble switch and fix 1RK register bit
This version adds scramble switch to support both production build and
serial build, and also fixes fast-k single rank wrong register bit.
BUG=b:269049451,b:267590318
TEST=Single rank DRAM suspend/resume pass, enable/disable scramble pass
Signed-off-by: Xi Chen <xixi.chen(a)mediatek.corp-partner.google.com>
Change-Id: I7bf751e19d6df32bbd40b9dacad16fb99253d2ae
---
M soc/mediatek/mt8188/dram.elf
M soc/mediatek/mt8188/dram.elf.md5
M soc/mediatek/mt8188/dram_release_notes.txt
3 files changed, 29 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/blobs refs/changes/39/73339/5
--
To view, visit https://review.coreboot.org/c/blobs/+/73339
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: master
Gerrit-Change-Id: I7bf751e19d6df32bbd40b9dacad16fb99253d2ae
Gerrit-Change-Number: 73339
Gerrit-PatchSet: 5
Gerrit-Owner: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: johnson wang <johnson.wang(a)mediatek.corp-partner.google.com>
Gerrit-Attention: johnson wang <johnson.wang(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-MessageType: newpatchset