coreboot-gerrit March 2023

coreboot-gerrit@coreboot.org

1 participants
4871 discussions

[S] Change in coreboot[master]: mb/google/skyrim: Disable USE_SELECTIVE_GOP_INIT
by Martin L Roth (Code Review) 02 Mar '23

02 Mar '23

Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/73393 ) Change subject: mb/google/skyrim: Disable USE_SELECTIVE_GOP_INIT ...................................................................... mb/google/skyrim: Disable USE_SELECTIVE_GOP_INIT This is causing some issues, so disable it until those issues can be resolved. BUG=b:271437658, b:271199389, b:270077971 TEST=Screen always lights up on boot & after S0i3 Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Id4aa441e4b4f76168f8243b6abafa1cf1ea08dbd --- M src/mainboard/google/skyrim/Kconfig 1 file changed, 16 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/73393/1 diff --git a/src/mainboard/google/skyrim/Kconfig b/src/mainboard/google/skyrim/Kconfig index 22caf51..dfc8030 100644 --- a/src/mainboard/google/skyrim/Kconfig +++ b/src/mainboard/google/skyrim/Kconfig @@ -44,7 +44,6 @@ select SOC_AMD_MENDOCINO select SOC_AMD_COMMON_BLOCK_I2C3_TPM_SHARED_WITH_PSP select SOC_AMD_COMMON_BLOCK_USE_ESPI - select SOC_AMD_GFX_CACHE_VBIOS_IN_FMAP if CHROMEOS && RUN_FSP_GOP select SYSTEM_TYPE_LAPTOP select TPM_GOOGLE_TI50 select PCIEXP_ASPM @@ -118,9 +117,6 @@ default "crystaldrift" if BOARD_GOOGLE_CRYSTALDRIFT default "markarth" if BOARD_GOOGLE_MARKARTH -config USE_SELECTIVE_GOP_INIT - default y if CHROMEOS && RUN_FSP_GOP - config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES select VBOOT_LID_SWITCH -- To view, visit https://review.coreboot.org/c/coreboot/+/73393 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id4aa441e4b4f76168f8243b6abafa1cf1ea08dbd Gerrit-Change-Number: 73393 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newchange

1 0

[L] Change in coreboot[master]: mb/system76/adl-p: Add Oryx Pro 10 as a variant
by Jeremy Soller (Code Review) 02 Mar '23

02 Mar '23

Attention is currently required from: Tim Crawford. Jeremy Soller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69210 ) Change subject: mb/system76/adl-p: Add Oryx Pro 10 as a variant ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69210 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0cf46cb5d10098dd31f0dc3c620db0c7e20ffba4 Gerrit-Change-Number: 69210 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Comment-Date: Thu, 02 Mar 2023 18:49:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: mb/system76/adl: Add Oryx Pro 9 as a variant
by Jeremy Soller (Code Review) 02 Mar '23

02 Mar '23

Attention is currently required from: Tim Crawford. Jeremy Soller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65610 ) Change subject: mb/system76/adl: Add Oryx Pro 9 as a variant ...................................................................... Patch Set 13: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/65610 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8aac3e83f4423f444cb9ce8aa562ba465eb718c1 Gerrit-Change-Number: 65610 Gerrit-PatchSet: 13 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Comment-Date: Thu, 02 Mar 2023 18:49:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/system76/adl: Add Lemur Pro 11 as a variant
by Jeremy Soller (Code Review) 02 Mar '23

02 Mar '23

Attention is currently required from: Tim Crawford, Angel Pons. Jeremy Soller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65384 ) Change subject: mb/system76/adl: Add Lemur Pro 11 as a variant ...................................................................... Patch Set 24: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/65384 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic930df1ebacc8c7ef14dbb6c67a97eddb918b365 Gerrit-Change-Number: 65384 Gerrit-PatchSet: 24 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 02 Mar 2023 18:48:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/intel/mtlrvp: Enable RTD3 root port mutex for WWAN
by Cliff Huang (Code Review) 02 Mar '23

02 Mar '23

Cliff Huang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/73384 ) Change subject: mb/intel/mtlrvp: Enable RTD3 root port mutex for WWAN ...................................................................... mb/intel/mtlrvp: Enable RTD3 root port mutex for WWAN This adds RTD3 RPMX mutex to the root port. It is shared between RTD3 and WWAN. BRANCH=firmware-brya-14505.B TEST=boot to OS and check the generated SSDT table for the root port. The RPMX mutex should be generated under the root port. Signed-off-by: Cliff Huang <cliff.huang(a)intel.com> Change-Id: I5b53765453bac0fc96e9651ab347069c7c8bf058 --- M src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/73384/1 diff --git a/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb b/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb index 65da43c..5b38a5a 100644 --- a/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb +++ b/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb @@ -280,6 +280,7 @@ register "srcclk_pin" = "1" register "ext_pm_support" = "ACPI_PCIE_RP_EMIT_ALL" register "skip_on_off_support" = "true" + register "use_rp_mutex" = "true" device generic 0 alias rp7_rtd3 on end end chip drivers/wwan/fm -- To view, visit https://review.coreboot.org/c/coreboot/+/73384 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b53765453bac0fc96e9651ab347069c7c8bf058 Gerrit-Change-Number: 73384 Gerrit-PatchSet: 1 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/intel/adlrvp: Enable RTD3 root port mutex for WWAN
by Cliff Huang (Code Review) 02 Mar '23

02 Mar '23

Cliff Huang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/73383 ) Change subject: mb/intel/adlrvp: Enable RTD3 root port mutex for WWAN ...................................................................... mb/intel/adlrvp: Enable RTD3 root port mutex for WWAN This adds RTD3 RPMX mutex to the root port. It is shared between RTD3 and WWAN. BRANCH=firmware-brya-14505.B TEST=boot to OS and check the generated SSDT table for the root port. The RPMX mutex should be generated under the root port. Signed-off-by: Cliff Huang <cliff.huang(a)intel.com> Change-Id: I809eb84cb1a09deb168040e83041b65237a1b576 --- M src/mainboard/intel/adlrvp/variants/adlrvp_p_ext_ec/overridetree.cb M src/mainboard/intel/adlrvp/variants/adlrvp_rpl_ext_ec/overridetree.cb 2 files changed, 19 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/73383/1 diff --git a/src/mainboard/intel/adlrvp/variants/adlrvp_p_ext_ec/overridetree.cb b/src/mainboard/intel/adlrvp/variants/adlrvp_p_ext_ec/overridetree.cb index 544f9e2..fc4c11c 100644 --- a/src/mainboard/intel/adlrvp/variants/adlrvp_p_ext_ec/overridetree.cb +++ b/src/mainboard/intel/adlrvp/variants/adlrvp_p_ext_ec/overridetree.cb @@ -70,6 +70,7 @@ register "srcclk_pin" = "5" register "ext_pm_support" = "ACPI_PCIE_RP_EMIT_ALL" register "skip_on_off_support" = "true" + register "use_rp_mutex" = "true" device generic 0 alias rp6_rtd3 on end end diff --git a/src/mainboard/intel/adlrvp/variants/adlrvp_rpl_ext_ec/overridetree.cb b/src/mainboard/intel/adlrvp/variants/adlrvp_rpl_ext_ec/overridetree.cb index 544f9e2..fc4c11c 100644 --- a/src/mainboard/intel/adlrvp/variants/adlrvp_rpl_ext_ec/overridetree.cb +++ b/src/mainboard/intel/adlrvp/variants/adlrvp_rpl_ext_ec/overridetree.cb @@ -70,6 +70,7 @@ register "srcclk_pin" = "5" register "ext_pm_support" = "ACPI_PCIE_RP_EMIT_ALL" register "skip_on_off_support" = "true" + register "use_rp_mutex" = "true" device generic 0 alias rp6_rtd3 on end end -- To view, visit https://review.coreboot.org/c/coreboot/+/73383 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I809eb84cb1a09deb168040e83041b65237a1b576 Gerrit-Change-Number: 73383 Gerrit-PatchSet: 1 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/google/brya: Enable RTD3 root port mutex for WWAN
by Cliff Huang (Code Review) 02 Mar '23

02 Mar '23

Cliff Huang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/73382 ) Change subject: mb/google/brya: Enable RTD3 root port mutex for WWAN ...................................................................... mb/google/brya: Enable RTD3 root port mutex for WWAN This adds RTD3 RPMX mutex to the root port. It is shared between RTD3 and WWAN. BRANCH=firmware-brya-14505.B TEST=boot to OS and check the generated SSDT table for the root port. The RPMX mutex should be generated under the root port. Signed-off-by: Cliff Huang <cliff.huang(a)intel.com> Change-Id: Ia87b5f9d8300d6263c84a586256424799d3a45b1 --- M src/mainboard/google/brya/variants/brya0/overridetree.cb M src/mainboard/google/brya/variants/redrix/overridetree.cb M src/mainboard/google/brya/variants/redrix4es/overridetree.cb M src/mainboard/google/brya/variants/skolas/overridetree.cb M src/mainboard/google/brya/variants/skolas4es/overridetree.cb M src/mainboard/google/brya/variants/vell/overridetree.cb 6 files changed, 23 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/73382/1 diff --git a/src/mainboard/google/brya/variants/brya0/overridetree.cb b/src/mainboard/google/brya/variants/brya0/overridetree.cb index e07fc72..e8cde58 100644 --- a/src/mainboard/google/brya/variants/brya0/overridetree.cb +++ b/src/mainboard/google/brya/variants/brya0/overridetree.cb @@ -419,6 +419,7 @@ register "srcclk_pin" = "5" register "ext_pm_support" = "ACPI_PCIE_RP_EMIT_ALL" register "skip_on_off_support" = "true" + register "use_rp_mutex" = "true" device generic 0 alias rp6_rtd3 on probe DB_LTE LTE_PCIE end diff --git a/src/mainboard/google/brya/variants/redrix/overridetree.cb b/src/mainboard/google/brya/variants/redrix/overridetree.cb index e289fca..f8619c9 100644 --- a/src/mainboard/google/brya/variants/redrix/overridetree.cb +++ b/src/mainboard/google/brya/variants/redrix/overridetree.cb @@ -187,6 +187,7 @@ register "srcclk_pin" = "5" register "ext_pm_support" = "ACPI_PCIE_RP_EMIT_ALL" register "skip_on_off_support" = "true" + register "use_rp_mutex" = "true" device generic 0 alias rp6_rtd3 on probe DB_LTE LTE_PCIE end diff --git a/src/mainboard/google/brya/variants/redrix4es/overridetree.cb b/src/mainboard/google/brya/variants/redrix4es/overridetree.cb index c6cf489..81a808f 100644 --- a/src/mainboard/google/brya/variants/redrix4es/overridetree.cb +++ b/src/mainboard/google/brya/variants/redrix4es/overridetree.cb @@ -173,6 +173,7 @@ register "srcclk_pin" = "5" register "ext_pm_support" = "ACPI_PCIE_RP_EMIT_ALL" register "skip_on_off_support" = "true" + register "use_rp_mutex" = "true" device generic 0 alias rp6_rtd3 on probe DB_LTE LTE_PCIE end diff --git a/src/mainboard/google/brya/variants/skolas/overridetree.cb b/src/mainboard/google/brya/variants/skolas/overridetree.cb index d21b3e1..0677f82 100644 --- a/src/mainboard/google/brya/variants/skolas/overridetree.cb +++ b/src/mainboard/google/brya/variants/skolas/overridetree.cb @@ -419,6 +419,7 @@ register "srcclk_pin" = "5" register "ext_pm_support" = "ACPI_PCIE_RP_EMIT_ALL" register "skip_on_off_support" = "true" + register "use_rp_mutex" = "true" device generic 0 alias rp6_rtd3 on probe DB_LTE LTE_PCIE end diff --git a/src/mainboard/google/brya/variants/skolas4es/overridetree.cb b/src/mainboard/google/brya/variants/skolas4es/overridetree.cb index 5916fc7..6d1207f 100644 --- a/src/mainboard/google/brya/variants/skolas4es/overridetree.cb +++ b/src/mainboard/google/brya/variants/skolas4es/overridetree.cb @@ -262,6 +262,7 @@ register "srcclk_pin" = "5" register "ext_pm_support" = "ACPI_PCIE_RP_EMIT_ALL" register "skip_on_off_support" = "true" + register "use_rp_mutex" = "true" device generic 0 alias rp6_rtd3 on probe DB_LTE LTE_PCIE end diff --git a/src/mainboard/google/brya/variants/vell/overridetree.cb b/src/mainboard/google/brya/variants/vell/overridetree.cb index 8751350..1100628 100644 --- a/src/mainboard/google/brya/variants/vell/overridetree.cb +++ b/src/mainboard/google/brya/variants/vell/overridetree.cb @@ -200,6 +200,7 @@ register "srcclk_pin" = "5" register "ext_pm_support" = "ACPI_PCIE_RP_EMIT_ALL" register "skip_on_off_support" = "true" + register "use_rp_mutex" = "true" device generic 0 alias rp6_rtd3 on end end chip drivers/wwan/fm -- To view, visit https://review.coreboot.org/c/coreboot/+/73382 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia87b5f9d8300d6263c84a586256424799d3a45b1 Gerrit-Change-Number: 73382 Gerrit-PatchSet: 1 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: soc/intel/alderlake: Allow channel 0 for memory-down
by Jeremy Soller (Code Review) 02 Mar '23

02 Mar '23

Attention is currently required from: Tim Crawford, Tarun Tuli, Martin L Roth, Sridhar Siricilla. Jeremy Soller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65567 ) Change subject: soc/intel/alderlake: Allow channel 0 for memory-down ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/65567 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe56c0f2b81d660303429cd2e21a7bb6cd433da5 Gerrit-Change-Number: 65567 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Comment-Date: Thu, 02 Mar 2023 18:15:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: {ec,mb}/system76: Move smbios_system_wakeup_type
by Jeremy Soller (Code Review) 02 Mar '23

02 Mar '23

Attention is currently required from: Tim Crawford. Jeremy Soller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71802 ) Change subject: {ec,mb}/system76: Move smbios_system_wakeup_type ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71802 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaace234ca87e8a05eaa006a438d2c9eb13ce4d76 Gerrit-Change-Number: 71802 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Comment-Date: Thu, 02 Mar 2023 18:14:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/system76/tgl-u: Leave TBT LSX0 as FSP configured
by Jeremy Soller (Code Review) 02 Mar '23

02 Mar '23

Attention is currently required from: Tim Crawford. Jeremy Soller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71666 ) Change subject: mb/system76/tgl-u: Leave TBT LSX0 as FSP configured ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71666 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7ef4af2cde4f3260f2bc2efdbf85569b0eb147fb Gerrit-Change-Number: 71666 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Comment-Date: Thu, 02 Mar 2023 18:14:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2023