coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3037 discussions

[XS] Change in coreboot[main]: soc/mediatek/mt8188: Support loading OP-TEE via an SMC
by Kiwi Liu (Code Review) 24 Nov '23

24 Nov '23

Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu. Kiwi Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78801?usp=email ) Change subject: soc/mediatek/mt8188: Support loading OP-TEE via an SMC ...................................................................... Patch Set 16: Code-Review+1 (1 comment) File src/soc/mediatek/mt8188/Makefile.inc: https://review.coreboot.org/c/coreboot/+/78801/comment/534b28ba_b5d9b346 : PS15, Line 62: BL31_MAKEARGS > https://review.trustedfirmware. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/78801?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic38c8beb59c090ae56c5be6821dd8625435609e9 Gerrit-Change-Number: 78801 Gerrit-PatchSet: 16 Gerrit-Owner: Kiwi Liu <kiwi.liu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Kiwi Liu <kiwi.liu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: jason-ch chen <Jason-ch.Chen(a)mediatek.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 24 Nov 2023 00:16:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Kiwi Liu <kiwi.liu(a)mediatek.corp-partner.google.com> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: [WIP] treewide: indent conditioanls with whitespaces (Makefiles)
by Felix Singer (Code Review) 24 Nov '23

24 Nov '23

Attention is currently required from: Martin L Roth, Maximilian Brune. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79230?usp=email ) Change subject: [WIP] treewide: indent conditioanls with whitespaces (Makefiles) ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/79230/comment/94649edd_1d4764e2 : PS1, Line 7: conditioanls typo: conditionals Patchset: PS1: I like it! -- To view, visit https://review.coreboot.org/c/coreboot/+/79230?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iceaa0d7d9db3e3ede5b7cfba1a1e13388647f33e Gerrit-Change-Number: 79230 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Thu, 23 Nov 2023 23:52:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: vendorcode/amd: Hook up opensil
by Felix Held (Code Review) 24 Nov '23

24 Nov '23

Attention is currently required from: Arthur Heymans, Martin L Roth, Martin Roth, Varshit Pandya. Felix Held has uploaded a new patch set (#15) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/76511?usp=email ) The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: vendorcode/amd: Hook up opensil ...................................................................... vendorcode/amd: Hook up opensil OpenSIL has a native buildsystem using meson and configuration mechanism using kconfiglib. To be able to use the coreboot toolchain with opensil, meson crossfiles are used, which get generated by coreboot makefiles. Configuration of opensil is done in a similar fashion with a template defconfig after which kconfiglib is called to generate headers. Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Signed-off-by: Martin Roth <gaumless(a)gmail.com> Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Ide2d181914116119dfd37b1511d89ea965729141 --- M src/vendorcode/amd/Kconfig M src/vendorcode/amd/Makefile.inc A src/vendorcode/amd/opensil/Kconfig A src/vendorcode/amd/opensil/Kconfig.debug A src/vendorcode/amd/opensil/Makefile.inc A src/vendorcode/amd/opensil/genoa_poc/meson_cross.template A src/vendorcode/amd/opensil/genoa_poc/opensil_config.template 7 files changed, 228 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/76511/15 -- To view, visit https://review.coreboot.org/c/coreboot/+/76511?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ide2d181914116119dfd37b1511d89ea965729141 Gerrit-Change-Number: 76511 Gerrit-PatchSet: 15 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: acpi: Enable 64bit ECAM resource
by Maximilian Brune (Code Review) 24 Nov '23

24 Nov '23

Attention is currently required from: Angel Pons, Arthur Heymans, Cliff Huang, David Milosevic, Felix Singer, Lance Zhao, Lean Sheng Tan, Martin L Roth, Naresh Solanki, Nico Huber, Patrick Rudolph, Tim Wawrzynczak. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79096?usp=email ) Change subject: acpi: Enable 64bit ECAM resource ...................................................................... Patch Set 5: (1 comment) File src/acpi/dsdt_top.asl: https://review.coreboot.org/c/coreboot/+/79096/comment/445bfb90_8f6dbf98 : PS5, Line 66: 0x0000000000000000, // Granularity I am not sure but granularity seems to refer to the alignment. Does the ECAM base and limit have no alignment constraints? -- To view, visit https://review.coreboot.org/c/coreboot/+/79096?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idb049d848f2311e27df5279a10c33f9fab259c08 Gerrit-Change-Number: 79096 Gerrit-PatchSet: 5 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Comment-Date: Thu, 23 Nov 2023 23:41:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[4.22_branch]: nb/intel/sandybridge: Fix unitialized variable issue
by Martin L Roth (Code Review) 24 Nov '23

24 Nov '23

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79231?usp=email ) Change subject: nb/intel/sandybridge: Fix unitialized variable issue ...................................................................... nb/intel/sandybridge: Fix unitialized variable issue Cherry-picked from main branch using commit caa0c0e71a. Original commit message: commit 1e9601c5ef80 ("nb/intel/sandybridge: Standardize MRC vs. native SPD mapping API") introduced an uninitialized variable issue. Change-Id: I41b081dc4c961acc04423067e29e0eabe5f17539 Found-by: Coverity CID 1524317 Original-Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com> Original-Reviewed-on: https://review.coreboot.org/c/coreboot/+/79093 Original-Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> Original-Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Original-Reviewed-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79231 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin L Roth <gaumless(a)gmail.com> --- M src/northbridge/intel/sandybridge/raminit_mrc.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved diff --git a/src/northbridge/intel/sandybridge/raminit_mrc.c b/src/northbridge/intel/sandybridge/raminit_mrc.c index a1805a2..68b02b8 100644 --- a/src/northbridge/intel/sandybridge/raminit_mrc.c +++ b/src/northbridge/intel/sandybridge/raminit_mrc.c @@ -315,7 +315,7 @@ static void spd_fill_pei_data(struct pei_data *pei_data) { struct spd_info spdi = {0}; - unsigned int i, have_memory_down; + unsigned int i, have_memory_down = 0; mb_get_spd_map(&spdi); -- To view, visit https://review.coreboot.org/c/coreboot/+/79231?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: 4.22_branch Gerrit-Change-Id: I41b081dc4c961acc04423067e29e0eabe5f17539 Gerrit-Change-Number: 79231 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[4.22_branch]: nb/intel/sandybridge: Fix unitialized variable issue
by Martin L Roth (Code Review) 24 Nov '23

24 Nov '23

Attention is currently required from: Angel Pons, Felix Singer. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79231?usp=email ) Change subject: nb/intel/sandybridge: Fix unitialized variable issue ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79231?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: 4.22_branch Gerrit-Change-Id: I41b081dc4c961acc04423067e29e0eabe5f17539 Gerrit-Change-Number: 79231 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 23 Nov 2023 23:28:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[4.22_branch]: nb/intel/sandybridge: Fix unitialized variable issue
by Felix Singer (Code Review) 24 Nov '23

24 Nov '23

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79231?usp=email ) Change subject: nb/intel/sandybridge: Fix unitialized variable issue ...................................................................... nb/intel/sandybridge: Fix unitialized variable issue Cherry-picked from main branch using commit caa0c0e71a. Original commit message: commit 1e9601c5ef80 ("nb/intel/sandybridge: Standardize MRC vs. native SPD mapping API") introduced an uninitialized variable issue. Change-Id: I41b081dc4c961acc04423067e29e0eabe5f17539 Found-by: Coverity CID 1524317 Original-Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com> Original-Reviewed-on: https://review.coreboot.org/c/coreboot/+/79093 Original-Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> Original-Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Original-Reviewed-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/northbridge/intel/sandybridge/raminit_mrc.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/79231/1 diff --git a/src/northbridge/intel/sandybridge/raminit_mrc.c b/src/northbridge/intel/sandybridge/raminit_mrc.c index a1805a2..68b02b8 100644 --- a/src/northbridge/intel/sandybridge/raminit_mrc.c +++ b/src/northbridge/intel/sandybridge/raminit_mrc.c @@ -315,7 +315,7 @@ static void spd_fill_pei_data(struct pei_data *pei_data) { struct spd_info spdi = {0}; - unsigned int i, have_memory_down; + unsigned int i, have_memory_down = 0; mb_get_spd_map(&spdi); -- To view, visit https://review.coreboot.org/c/coreboot/+/79231?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: 4.22_branch Gerrit-Change-Id: I41b081dc4c961acc04423067e29e0eabe5f17539 Gerrit-Change-Number: 79231 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-MessageType: newchange

1 0

[L] Change in coreboot[main]: [WIP] treewide: indent conditioanls with whitespaces (Makefiles)
by Maximilian Brune (Code Review) 23 Nov '23

23 Nov '23

Maximilian Brune has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79230?usp=email ) Change subject: [WIP] treewide: indent conditioanls with whitespaces (Makefiles) ...................................................................... [WIP] treewide: indent conditioanls with whitespaces (Makefiles) I used the following awk script. The awk very likely does not cover everything, but this is currently only to show how it would look like ``` BEGIN { conditional_level = 0 } /^$/ { print; next } /^endif/ { conditional_level-- } /^(else)|(\t)/ { conditional_level-- } { for (i = 0; i < (conditional_level*4); i++) { printf " " } print $0 } /^(else)|(\t)/ { conditional_level++ } /^(ifn*eq)|(ifn*def)/ { conditional_level++ } ``` Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: Iceaa0d7d9db3e3ede5b7cfba1a1e13388647f33e --- M Makefile 1 file changed, 189 insertions(+), 189 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/79230/1 diff --git a/Makefile b/Makefile index 29597c8..e6cbfe4 100644 --- a/Makefile +++ b/Makefile @@ -1,7 +1,7 @@ ## SPDX-License-Identifier: BSD-3-Clause ifneq ($(words $(CURDIR)),1) - $(error Error: Path to the main directory cannot contain spaces) + $(error Error: Path to the main directory cannot contain spaces) endif top := $(CURDIR) src := src @@ -56,11 +56,11 @@ # Make is silent per default, but 'make V=1' will show all compiler calls. Q:=@ ifneq ($(V),1) -ifneq ($(Q),) -.SILENT: -MAKEFLAGS += -s -quiet_errors := 2>/dev/null -endif + ifneq ($(Q),) + .SILENT: + MAKEFLAGS += -s + quiet_errors := 2>/dev/null + endif endif # Disable implicit/built-in rules to make Makefile errors fail fast. @@ -104,34 +104,34 @@ # 4. when make distclean is run # Don't waste time on reading all Makefile.incs in these cases ifeq ($(strip $(HAVE_DOTCONFIG)),) -NOCOMPILE:=1 + NOCOMPILE:=1 endif ifeq ($(strip $(HAVE_KCONFIG_MAKEFILE_REAL)),) -ifneq ($(MAKECMDGOALS),tools) -NOCOMPILE:=1 -endif + ifneq ($(MAKECMDGOALS),tools) + NOCOMPILE:=1 + endif endif ifneq ($(MAKECMDGOALS),) -ifneq ($(filter %config %clean cross% clang iasl lint% help% what-jenkins-does,$(MAKECMDGOALS)),) -NOCOMPILE:=1 -endif -ifneq ($(filter %clean lint% help% what-jenkins-does,$(MAKECMDGOALS)),) -NOMKDIR:=1 -UNIT_TEST:=1 -endif + ifneq ($(filter %config %clean cross% clang iasl lint% help% what-jenkins-does,$(MAKECMDGOALS)),) + NOCOMPILE:=1 + endif + ifneq ($(filter %clean lint% help% what-jenkins-does,$(MAKECMDGOALS)),) + NOMKDIR:=1 + UNIT_TEST:=1 + endif endif ifneq ($(filter help%, $(MAKECMDGOALS)), ) -NOCOMPILE:=1 -UNIT_TEST:=1 + NOCOMPILE:=1 + UNIT_TEST:=1 else -ifneq ($(filter %-test %-tests %coverage-report, $(MAKECMDGOALS)),) -ifneq ($(filter-out %-test %-tests %coverage-report, $(MAKECMDGOALS)),) -$(error Cannot mix unit-tests targets with other targets) -endif -UNIT_TEST:=1 -NOCOMPILE:= -endif + ifneq ($(filter %-test %-tests %coverage-report, $(MAKECMDGOALS)),) + ifneq ($(filter-out %-test %-tests %coverage-report, $(MAKECMDGOALS)),) + $(error Cannot mix unit-tests targets with other targets) + endif + UNIT_TEST:=1 + NOCOMPILE:= + endif endif $(xcompile): util/xcompile/xcompile @@ -141,17 +141,17 @@ rm -f $@.tmp ifeq ($(NOCOMPILE),1) -# We also don't use .xcompile in the no-compile situations, so -# provide some reasonable defaults. -HOSTCC ?= $(if $(shell type gcc 2>/dev/null),gcc,cc) -HOSTCXX ?= g++ + # We also don't use .xcompile in the no-compile situations, so + # provide some reasonable defaults. + HOSTCC ?= $(if $(shell type gcc 2>/dev/null),gcc,cc) + HOSTCXX ?= g++ -include $(TOPLEVEL)/Makefile.inc -include $(TOPLEVEL)/payloads/Makefile.inc -include $(TOPLEVEL)/util/testing/Makefile.inc --include $(TOPLEVEL)/site-local/Makefile.inc -include $(TOPLEVEL)/tests/Makefile.inc -printall real-all: + include $(TOPLEVEL)/Makefile.inc + include $(TOPLEVEL)/payloads/Makefile.inc + include $(TOPLEVEL)/util/testing/Makefile.inc + -include $(TOPLEVEL)/site-local/Makefile.inc + include $(TOPLEVEL)/tests/Makefile.inc + printall real-all: @echo "Error: Trying to build, but NOCOMPILE is set." >&2 @echo " Please file a bug with the following information:" @echo "- MAKECMDGOALS: $(MAKECMDGOALS)" >&2 @@ -161,90 +161,90 @@ else -ifneq ($(UNIT_TEST),1) -include $(DOTCONFIG) -endif + ifneq ($(UNIT_TEST),1) + include $(DOTCONFIG) + endif -# The toolchain requires xcompile to determine the ARCH_SUPPORTED, so we can't -# wait for make to generate the file. -$(if $(wildcard $(xcompile)),, $(shell \ + # The toolchain requires xcompile to determine the ARCH_SUPPORTED, so we can't + # wait for make to generate the file. + $(if $(wildcard $(xcompile)),, $(shell \ mkdir -p $(dir $(xcompile)) && \ util/xcompile/xcompile $(XGCCPATH) > $(xcompile) || rm -f $(xcompile))) -include $(xcompile) + include $(xcompile) -ifneq ($(XCOMPILE_COMPLETE),1) -$(shell rm -f $(xcompile)) -$(error $(xcompile) deleted because it's invalid. \ - Restarting the build should fix that, or explain the problem) -endif + ifneq ($(XCOMPILE_COMPLETE),1) + $(shell rm -f $(xcompile)) + $(error $(xcompile) deleted because it's invalid. \ + Restarting the build should fix that, or explain the problem) + endif -# reproducible builds -LANG:=C -LC_ALL:=C -TZ:=UTC0 -ifneq ($(NOCOMPILE),1) -SOURCE_DATE_EPOCH := $(shell $(top)/util/genbuild_h/genbuild_h.sh . | sed -n 's/^.define COREBOOT_BUILD_EPOCH\>.*"$.*$".*/\1/p') -endif -# don't use COREBOOT_EXPORTS to ensure build steps outside the coreboot build system -# are reproducible -export LANG LC_ALL TZ SOURCE_DATE_EPOCH + # reproducible builds + LANG:=C + LC_ALL:=C + TZ:=UTC0 + ifneq ($(NOCOMPILE),1) + SOURCE_DATE_EPOCH := $(shell $(top)/util/genbuild_h/genbuild_h.sh . | sed -n 's/^.define COREBOOT_BUILD_EPOCH\>.*"$.*$".*/\1/p') + endif + # don't use COREBOOT_EXPORTS to ensure build steps outside the coreboot build system + # are reproducible + export LANG LC_ALL TZ SOURCE_DATE_EPOCH -ifneq ($(UNIT_TEST),1) -include toolchain.inc -endif + ifneq ($(UNIT_TEST),1) + include toolchain.inc + endif -strip_quotes = $(strip $(subst ",,$(subst \",,$(1)))) -# fix makefile syntax highlighting after strip macro \" ")) + strip_quotes = $(strip $(subst ",,$(subst \",,$(1)))) + # fix makefile syntax highlighting after strip macro \" ")) -ifneq ($(NOCOMPILE),1) -$(shell rm -f $(CCACHE_STATSLOG)) -endif + ifneq ($(NOCOMPILE),1) + $(shell rm -f $(CCACHE_STATSLOG)) + endif -# The primary target needs to be here before we include the -# other files + # The primary target needs to be here before we include the + # other files -real-all: real-target + real-all: real-target -# must come rather early -.SECONDARY: -.SECONDEXPANSION: -.DELETE_ON_ERROR: + # must come rather early + .SECONDARY: + .SECONDEXPANSION: + .DELETE_ON_ERROR: -$(KCONFIG_AUTOHEADER): $(KCONFIG_CONFIG) $(objutil)/kconfig/conf + $(KCONFIG_AUTOHEADER): $(KCONFIG_CONFIG) $(objutil)/kconfig/conf $(MAKE) olddefconfig $(MAKE) syncconfig -$(KCONFIG_AUTOCONFIG): $(KCONFIG_AUTOHEADER) + $(KCONFIG_AUTOCONFIG): $(KCONFIG_AUTOHEADER) true -$(KCONFIG_AUTOADS): $(KCONFIG_CONFIG) $(KCONFIG_AUTOHEADER) $(objutil)/kconfig/toada + $(KCONFIG_AUTOADS): $(KCONFIG_CONFIG) $(KCONFIG_AUTOHEADER) $(objutil)/kconfig/toada $(objutil)/kconfig/toada CB.Config <$< >$@ -$(obj)/%/$(notdir $(KCONFIG_AUTOADS)): $(KCONFIG_AUTOADS) + $(obj)/%/$(notdir $(KCONFIG_AUTOADS)): $(KCONFIG_AUTOADS) cp $< $@ -# Add a new class of source/object files to the build system -add-class= \ + # Add a new class of source/object files to the build system + add-class= \ $(eval $(1)-srcs:=) \ $(eval $(1)-objs:=) \ $(eval classes+=$(1)) -# Special classes are managed types with special behaviour -# On parse time, for each entry in variable $(1)-y -# a handler $(1)-handler is executed with the arguments: -# * $(1): directory the parser is in -# * $(2): current entry -add-special-class= \ + # Special classes are managed types with special behaviour + # On parse time, for each entry in variable $(1)-y + # a handler $(1)-handler is executed with the arguments: + # * $(1): directory the parser is in + # * $(2): current entry + add-special-class= \ $(eval $(1):=) \ $(eval special-classes+=$(1)) -# Converts one or more source file paths to their corresponding build/ paths. -# Only .ads, adb, .c and .S get converted to .o, other files (like .ld) keep -# their name. -# $1 stage name -# $2 file path (list) -src-to-obj=\ + # Converts one or more source file paths to their corresponding build/ paths. + # Only .ads, adb, .c and .S get converted to .o, other files (like .ld) keep + # their name. + # $1 stage name + # $2 file path (list) + src-to-obj=\ $(patsubst $(obj)/%,$(obj)/$(1)/%,\ $(patsubst $(obj)/$(1)/%,$(obj)/%,\ $(patsubst 3rdparty/%,$(obj)/%,\ @@ -255,11 +255,11 @@ $(patsubst %.S,%.o,\ $(subst .$(1),,$(2)))))))))) -# Converts one or more source file paths to the corresponding build/ paths -# of their Ada library information (.ali) files. -# $1 stage name -# $2 file path (list) -src-to-ali=\ + # Converts one or more source file paths to the corresponding build/ paths + # of their Ada library information (.ali) files. + # $1 stage name + # $2 file path (list) + src-to-ali=\ $(patsubst $(obj)/%,$(obj)/$(1)/%,\ $(patsubst $(obj)/$(1)/%,$(obj)/%,\ $(patsubst 3rdparty/%,$(obj)/%,\ @@ -269,10 +269,10 @@ $(subst .$(1),,\ $(filter %.ads %.adb,$(2))))))))) -# Clean -y variables, include Makefile.inc -# Add paths to files in X-y to X-srcs -# Add subdirs-y to subdirs -includemakefiles= \ + # Clean -y variables, include Makefile.inc + # Add paths to files in X-y to X-srcs + # Add subdirs-y to subdirs + includemakefiles= \ $(if $(wildcard $(1)), \ $(foreach class,classes subdirs $(classes) $(special-classes), $(eval $(class)-y:=)) \ $(eval -include $(1)) \ @@ -286,130 +286,130 @@ $$(abspath $$(subst $(dir $(1))/,/,$$(addprefix $(dir $(1)),$$($(class)-y)))))))) \ $(eval subdirs+=$$(subst $(CURDIR)/,,$$(wildcard $$(abspath $$(addprefix $(dir $(1)),$$(subdirs-y))))))) -# For each path in $(subdirs) call includemakefiles -# Repeat until subdirs is empty -evaluate_subdirs= \ + # For each path in $(subdirs) call includemakefiles + # Repeat until subdirs is empty + evaluate_subdirs= \ $(eval cursubdirs:=$(subdirs)) \ $(eval subdirs:=) \ $(foreach dir,$(cursubdirs), \ $(eval $(call includemakefiles,$(dir)/Makefile.inc))) \ $(if $(subdirs),$(eval $(call evaluate_subdirs))) -# collect all object files eligible for building -subdirs:=$(TOPLEVEL) -postinclude-hooks := + # collect all object files eligible for building + subdirs:=$(TOPLEVEL) + postinclude-hooks := -# Don't iterate through Makefile.incs under src/ when building tests -ifneq ($(UNIT_TEST),1) -$(eval $(call evaluate_subdirs)) -else -include $(TOPLEVEL)/tests/Makefile.inc -endif + # Don't iterate through Makefile.incs under src/ when building tests + ifneq ($(UNIT_TEST),1) + $(eval $(call evaluate_subdirs)) + else + include $(TOPLEVEL)/tests/Makefile.inc + endif -ifeq ($(FAILBUILD),1) -$(error cannot continue build) -endif + ifeq ($(FAILBUILD),1) + $(error cannot continue build) + endif -# Run hooks registered by subdirectories that need to be evaluated after all files have been parsed -$(eval $(postinclude-hooks)) + # Run hooks registered by subdirectories that need to be evaluated after all files have been parsed + $(eval $(postinclude-hooks)) -# Eliminate duplicate mentions of source files in a class -$(foreach class,$(classes),$(eval $(class)-srcs:=$(sort $($(class)-srcs)))) + # Eliminate duplicate mentions of source files in a class + $(foreach class,$(classes),$(eval $(class)-srcs:=$(sort $($(class)-srcs)))) -ifeq ($(CONFIG_IWYU),y) -MAKEFLAGS += -k -SAVE_IWYU_OUTPUT := 2>&1 | grep "should\|\#include\|---\|include-list\|^[[:blank:]]\?\'" | tee -a $$(obj)/iwyu.txt -endif + ifeq ($(CONFIG_IWYU),y) + MAKEFLAGS += -k + SAVE_IWYU_OUTPUT := 2>&1 | grep "should\|\#include\|---\|include-list\|^[[:blank:]]\?\'" | tee -a $$(obj)/iwyu.txt + endif -# Build Kconfig .ads if necessary -ifeq ($(CONFIG_ROMSTAGE_ADA),y) -romstage-srcs += $(obj)/romstage/$(notdir $(KCONFIG_AUTOADS)) -endif -ifeq ($(CONFIG_RAMSTAGE_ADA),y) -ramstage-srcs += $(obj)/ramstage/$(notdir $(KCONFIG_AUTOADS)) -endif + # Build Kconfig .ads if necessary + ifeq ($(CONFIG_ROMSTAGE_ADA),y) + romstage-srcs += $(obj)/romstage/$(notdir $(KCONFIG_AUTOADS)) + endif + ifeq ($(CONFIG_RAMSTAGE_ADA),y) + ramstage-srcs += $(obj)/ramstage/$(notdir $(KCONFIG_AUTOADS)) + endif -# To track dependencies, we need all Ada specification (.ads) files in -# *-srcs. Extract / filter all specification files that have a matching -# body (.adb) file here (specifications without a body are valid sources -# in Ada). -$(foreach class,$(classes),$(eval $(class)-extra-specs := \ + # To track dependencies, we need all Ada specification (.ads) files in + # *-srcs. Extract / filter all specification files that have a matching + # body (.adb) file here (specifications without a body are valid sources + # in Ada). + $(foreach class,$(classes),$(eval $(class)-extra-specs := \ $(filter \ $(addprefix %/,$(patsubst %.adb,%.ads,$(notdir $(filter %.adb,$($(class)-srcs))))), \ $(filter %.ads,$($(class)-srcs))))) -$(foreach class,$(classes),$(eval $(class)-srcs := \ + $(foreach class,$(classes),$(eval $(class)-srcs := \ $(filter-out $($(class)-extra-specs),$($(class)-srcs)))) -$(foreach class,$(classes),$(eval $(class)-objs:=$(call src-to-obj,$(class),$($(class)-srcs)))) -$(foreach class,$(classes),$(eval $(class)-alis:=$(call src-to-ali,$(class),$($(class)-srcs)))) + $(foreach class,$(classes),$(eval $(class)-objs:=$(call src-to-obj,$(class),$($(class)-srcs)))) + $(foreach class,$(classes),$(eval $(class)-alis:=$(call src-to-ali,$(class),$($(class)-srcs)))) -# For Ada includes -$(foreach class,$(classes),$(eval $(class)-ada-dirs:=$(sort $(dir $(filter %.ads %.adb,$($(class)-srcs)) $($(class)-extra-specs))))) + # For Ada includes + $(foreach class,$(classes),$(eval $(class)-ada-dirs:=$(sort $(dir $(filter %.ads %.adb,$($(class)-srcs)) $($(class)-extra-specs))))) -# Save all objs before processing them (for dependency inclusion) -originalobjs:=$(foreach var, $(addsuffix -objs,$(classes)), $($(var))) + # Save all objs before processing them (for dependency inclusion) + originalobjs:=$(foreach var, $(addsuffix -objs,$(classes)), $($(var))) -# Call post-processors if they're defined -$(foreach class,$(classes),\ + # Call post-processors if they're defined + $(foreach class,$(classes),\ $(if $(value $(class)-postprocess),$(eval $(call $(class)-postprocess,$($(class)-objs))))) -allsrcs:=$(foreach var, $(addsuffix -srcs,$(classes)), $($(var))) -allobjs:=$(foreach var, $(addsuffix -objs,$(classes)), $($(var))) -alldirs:=$(sort $(abspath $(dir $(allobjs)))) + allsrcs:=$(foreach var, $(addsuffix -srcs,$(classes)), $($(var))) + allobjs:=$(foreach var, $(addsuffix -objs,$(classes)), $($(var))) + alldirs:=$(sort $(abspath $(dir $(allobjs)))) -# Reads dependencies from an Ada library information (.ali) file -# Only basenames (with suffix) are preserved so we have to look the -# paths up in $($(stage)-srcs). -# $1 stage name -# $2 ali file -create_ada_deps=$$(if $(2),\ + # Reads dependencies from an Ada library information (.ali) file + # Only basenames (with suffix) are preserved so we have to look the + # paths up in $($(stage)-srcs). + # $1 stage name + # $2 ali file + create_ada_deps=$$(if $(2),\ gnat.adc \ $$(filter \ $$(addprefix %/,$$(shell sed -ne's/^D $[^\t]\+$.*$$$$/\1/p' $(2) 2>/dev/null)), \ $$($(1)-srcs) $$($(1)-extra-specs))) -# macro to define template macros that are used by use_template macro -define create_cc_template -# $1 obj class -# $2 source suffix (c, S, ld, ...) -# $3 additional compiler flags -# $4 additional dependencies -ifn$(EMPTY)def $(1)-objs_$(2)_template -de$(EMPTY)fine $(1)-objs_$(2)_template -ifn$(EMPTY)eq ($(filter ads adb,$(2)),) -$$(call src-to-obj,$1,$$(1).$2): $$(1).$2 $$(call create_ada_deps,$1,$$(call src-to-ali,$1,$$(1).$2)) $(4) + # macro to define template macros that are used by use_template macro + define create_cc_template + # $1 obj class + # $2 source suffix (c, S, ld, ...) + # $3 additional compiler flags + # $4 additional dependencies + ifn$(EMPTY)def $(1)-objs_$(2)_template + de$(EMPTY)fine $(1)-objs_$(2)_template + ifn$(EMPTY)eq ($(filter ads adb,$(2)),) + $$(call src-to-obj,$1,$$(1).$2): $$(1).$2 $$(call create_ada_deps,$1,$$(call src-to-ali,$1,$$(1).$2)) $(4) @printf " GCC $$$$(subst $$$$(obj)/,,$$$$(@))\n" $(GCC_$(1)) \ $$$$(ADAFLAGS_$(1)) $$$$(addprefix -I,$$$$($(1)-ada-dirs)) \ $(3) -c -o $$$$@ $$$$< -el$(EMPTY)se -$$(call src-to-obj,$1,$$(1).$2): $$(1).$2 $(KCONFIG_AUTOHEADER) $(4) + el$(EMPTY)se + $$(call src-to-obj,$1,$$(1).$2): $$(1).$2 $(KCONFIG_AUTOHEADER) $(4) @printf " CC $$$$(subst $$$$(obj)/,,$$$$(@))\n" $(CC_$(1)) \ -MMD $$$$(CPPFLAGS_$(1)) $$$$(CFLAGS_$(1)) -MT $$$$(@) \ $(3) -c -o $$$$@ $$$$< $(SAVE_IWYU_OUTPUT) -end$(EMPTY)if -en$(EMPTY)def -end$(EMPTY)if -endef + end$(EMPTY)if + en$(EMPTY)def + end$(EMPTY)if + endef -filetypes-of-class=$(subst .,,$(sort $(suffix $($(1)-srcs)))) -$(foreach class,$(classes), \ + filetypes-of-class=$(subst .,,$(sort $(suffix $($(1)-srcs)))) + $(foreach class,$(classes), \ $(foreach type,$(call filetypes-of-class,$(class)), \ $(eval $(class)-$(type)-ccopts += $(generic-$(type)-ccopts) $($(class)-generic-ccopts)) \ $(if $(generic-objs_$(type)_template_gen),$(eval $(call generic-objs_$(type)_template_gen,$(class))),\ $(eval $(call create_cc_template,$(class),$(type),$($(class)-$(type)-ccopts),$($(class)-$(type)-deps)))))) -foreach-src=$(foreach file,$($(1)-srcs),$(eval $(call $(1)-objs_$(subst .,,$(suffix $(file)))_template,$(basename $(file))))) -$(eval $(foreach class,$(classes),$(call foreach-src,$(class)))) + foreach-src=$(foreach file,$($(1)-srcs),$(eval $(call $(1)-objs_$(subst .,,$(suffix $(file)))_template,$(basename $(file))))) + $(eval $(foreach class,$(classes),$(call foreach-src,$(class)))) -# To supported complex package initializations, we need to call the -# emitted code explicitly. gnatbind gathers all the calls for us -# and exports them as a procedure $(stage)_adainit(). Every stage that -# uses Ada code has to call it! -define gnatbind_template -# $1 class -$$(obj)/$(1)/b__$(1).adb: $$$$(filter-out $$(obj)/$(1)/b__$(1).ali,$$$$($(1)-alis)) + # To supported complex package initializations, we need to call the + # emitted code explicitly. gnatbind gathers all the calls for us + # and exports them as a procedure $(stage)_adainit(). Every stage that + # uses Ada code has to call it! + define gnatbind_template + # $1 class + $$(obj)/$(1)/b__$(1).adb: $$$$(filter-out $$(obj)/$(1)/b__$(1).ali,$$$$($(1)-alis)) @printf " BIND $$(subst $$(obj)/,,$$@)\n" # We have to give gnatbind a simple filename (without leading # path components) so just cd there. @@ -418,20 +418,20 @@ --RTS=$$(absobj)/libgnat-$$(ARCH-$(1)-y)/ \ -L$(1)_ada -o $$(notdir $$@) \ $$(subst $$(dir $$@),,$$^) -$$(obj)/$(1)/b__$(1).o: $$(obj)/$(1)/b__$(1).adb + $$(obj)/$(1)/b__$(1).o: $$(obj)/$(1)/b__$(1).adb @printf " GCC $$(subst $$(obj)/,,$$@)\n" $(GCC_$(1)) $$(ADAFLAGS_$(1)) -c -o $$@ $$< -$(1)-objs += $$(obj)/$(1)/b__$(1).o -$($(1)-alis): %.ali: %.o ; -endef + $(1)-objs += $$(obj)/$(1)/b__$(1).o + $($(1)-alis): %.ali: %.o ; + endef -$(eval $(foreach class,$(filter-out libgnat-%,$(classes)), \ + $(eval $(foreach class,$(filter-out libgnat-%,$(classes)), \ $(if $($(class)-alis),$(call gnatbind_template,$(class))))) -DEPENDENCIES += $(addsuffix .d,$(basename $(allobjs))) --include $(DEPENDENCIES) + DEPENDENCIES += $(addsuffix .d,$(basename $(allobjs))) + -include $(DEPENDENCIES) -printall: + printall: @$(foreach class,$(classes), echo $(class)-objs: $($(class)-objs) | tr ' ' '\n'; echo; ) @echo alldirs: $(alldirs) | tr ' ' '\n'; echo @echo allsrcs: $(allsrcs) | tr ' ' '\n'; echo @@ -440,7 +440,7 @@ endif ifndef NOMKDIR -$(shell mkdir -p $(KCONFIG_SPLITCONFIG) $(objk)/lxdialog $(additional-dirs) $(alldirs)) + $(shell mkdir -p $(KCONFIG_SPLITCONFIG) $(objk)/lxdialog $(additional-dirs) $(alldirs)) endif $(obj)/project_filelist.txt: -- To view, visit https://review.coreboot.org/c/coreboot/+/79230?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iceaa0d7d9db3e3ede5b7cfba1a1e13388647f33e Gerrit-Change-Number: 79230 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[main]: arch/arm64: Add EL1/EL2/EL3 support for arm64
by ron minnich (Code Review) 23 Nov '23

23 Nov '23

Attention is currently required from: Angel Pons, Arthur Heymans, Christian Walter, David Milosevic, Felix Singer, Julius Werner, Martin L Roth, Maximilian Brune, Nico Huber. ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74798?usp=email ) Change subject: arch/arm64: Add EL1/EL2/EL3 support for arm64 ...................................................................... Patch Set 9: Code-Review+1 (1 comment) Patchset: PS9: The best is the enemy of the good, as the saying goes. We know what we want, we want 100% GPL firmware as it was in 2000, but I feel we should be careful not to close off a chance for a design win because it's not exactly that model. TBH, I worry a lot more about our growing UEFI inclusion in the payload than this change. I'm inclined to think this CL is a reasonable approach. Back in the linuxbios days, we did something very similar with a delivered intel HPC system, i.e. we gave over 64K of hardware startup to an intel blob and the rest was linuxbios. This would have been ca 2002, with company called Linux Labs. I can't find an article from that time. Sometimes, you have to give a little up to make progress. This CL certainly seems no worse than what we've had to do on x86. w.r.t the blob issue, there are proprietary DRAM controllers out there that make it impossible to release source code for early startup. None of us likes it, but that's the way it is. ARM, in theory open, is in practice very closed, esp in the server market. But many companies don't own core parts of the IP used in DRAM hardware, for example. on the RISC-V, on oreboot, we now run the ramstage at a lower privilege level than the ROM code. I like that; it follows a principle of least privilege, and this change has a certain similarity: drop privilege, at every step, as much as possible. Hence he use of the term "EL2" -- think of EL3 as a sort of SMM mode in x86 terms, and EL2 as kind of Ring 0, and it might make more sense. So, back to this CL; I think it shows how flexible coreboot can be, even as we necessarily accept a model we don't entirely like. But, as compared to what we have to accept in the x86 world? This does not seem as bad to me. I'm going +1 b/c the code may need further change, and I respect the concerns expressed by Julius, Nico, Felix, and others; but I'd also like to ask you all to step back and consider whether the gain here might be worth it. Thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/74798?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iae1c57f0846c8d0585384f7e54102a837e701e7e Gerrit-Change-Number: 74798 Gerrit-PatchSet: 9 Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Comment-Date: Thu, 23 Nov 2023 21:47:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: arch/arm64: Add EL1/EL2/EL3 support for arm64
by Lean Sheng Tan (Code Review) 23 Nov '23

23 Nov '23

Attention is currently required from: Angel Pons, Arthur Heymans, Christian Walter, David Milosevic, Felix Singer, Julius Werner, Martin L Roth, Maximilian Brune, Nico Huber. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74798?usp=email ) Change subject: arch/arm64: Add EL1/EL2/EL3 support for arm64 ...................................................................... Patch Set 9: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74798/comment/d8be863a_ce7eda31 : PS5, Line 11: one boots into TF-A first and drops into EL2 for coreboot afterwards. > > first, in my opinion , it’s very demeaning and over simplified to just called this “coreboot as a […] it’s not possible to publicly discuss it when it’s under NDA. we already did our best by upstreaming this since April 2023. too bad you were not with us during the Sat night discussion. I can’t change your mind, if you want to block it go ahead - I am losing hope to push coreboot adoption for more platforms. -- To view, visit https://review.coreboot.org/c/coreboot/+/74798?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iae1c57f0846c8d0585384f7e54102a837e701e7e Gerrit-Change-Number: 74798 Gerrit-PatchSet: 9 Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Comment-Date: Thu, 23 Nov 2023 21:26:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com> Comment-In-Reply-To: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023