coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3037 discussions

[XS] Change in coreboot[main]: mb/google/nissa/var/craask: Enable PIXA touchpad
by Tyler Wang (Code Review) 24 Nov '23

24 Nov '23

Attention is currently required from: Nick Vaccaro, Paul Menzel, Ren Kuo, Subrata Banik. Tyler Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79212?usp=email ) Change subject: mb/google/nissa/var/craask: Enable PIXA touchpad ...................................................................... Patch Set 7: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/79212/comment/d0e893e6_6875ca51 : PS6, Line 7: craaskvin/craaskana > Are these variants of the variant? Yes. https://review.coreboot.org/c/coreboot/+/79212/comment/97555602_3a9ccb53 : PS6, Line 8: > Please mention how it’s connected. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79212?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7e68a44eb3d639eaadb5b7b9cb5a6955fd059eeb Gerrit-Change-Number: 79212 Gerrit-PatchSet: 7 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Fri, 24 Nov 2023 06:18:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/craask: Enable PIXA touchpad
by Tyler Wang (Code Review) 24 Nov '23

24 Nov '23

Attention is currently required from: Nick Vaccaro, Ren Kuo, Subrata Banik, Tyler Wang. Hello David Wu, Eric Lai, Nick Vaccaro, Paul Menzel, Ren Kuo, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79212?usp=email to look at the new patch set (#7). Change subject: mb/google/nissa/var/craask: Enable PIXA touchpad ...................................................................... mb/google/nissa/var/craask: Enable PIXA touchpad Add PIXA touchpad for variants of craask. BUG=b:310489697 TEST=build craask firmware and test with PIXA touchpad Change-Id: I7e68a44eb3d639eaadb5b7b9cb5a6955fd059eeb Signed-off-by: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/variants/craask/overridetree.cb 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/79212/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/79212?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7e68a44eb3d639eaadb5b7b9cb5a6955fd059eeb Gerrit-Change-Number: 79212 Gerrit-PatchSet: 7 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: acpi: Enable 64bit ECAM resource
by Arthur Heymans (Code Review) 24 Nov '23

24 Nov '23

Attention is currently required from: Angel Pons, Cliff Huang, David Milosevic, Felix Singer, Lance Zhao, Lean Sheng Tan, Martin L Roth, Maximilian Brune, Naresh Solanki, Nico Huber, Patrick Rudolph, Tim Wawrzynczak. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79096?usp=email ) Change subject: acpi: Enable 64bit ECAM resource ...................................................................... Patch Set 5: (1 comment) File src/acpi/dsdt_top.asl: https://review.coreboot.org/c/coreboot/+/79096/comment/92b1e8e3_0845e0bc : PS5, Line 66: 0x0000000000000000, // Granularity > I am not sure but granularity seems to refer to the alignment. Does the ECAM base and limit have no alignment constraints? On Intel it needs to be aligned to it's size, but IDK on others. However here it's reported as a MinFixed & MaxFixed. You don't care about granularity as you tell the OS not to move it. -- To view, visit https://review.coreboot.org/c/coreboot/+/79096?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idb049d848f2311e27df5279a10c33f9fab259c08 Gerrit-Change-Number: 79096 Gerrit-PatchSet: 5 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Comment-Date: Fri, 24 Nov 2023 05:28:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: util/docker/archlinux: Extend the environment with packages and configs
by Felix Singer (Code Review) 24 Nov '23

24 Nov '23

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/77724?usp=email ) Change subject: util/docker/archlinux: Extend the environment with packages and configs ...................................................................... util/docker/archlinux: Extend the environment with packages and configs Add more packages which are useful for a coreboot development and build environment and also make neovim the default editor. Change-Id: Ied09a9b9500d85348fc9c3862247bd8b85e50b54 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/77724 Reviewed-by: Martin L Roth <gaumless(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M util/docker/archlinux/Dockerfile 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: Martin L Roth: Looks good to me, approved build bot (Jenkins): Verified diff --git a/util/docker/archlinux/Dockerfile b/util/docker/archlinux/Dockerfile index 9c80483..d3309d0 100644 --- a/util/docker/archlinux/Dockerfile +++ b/util/docker/archlinux/Dockerfile @@ -1,5 +1,9 @@ FROM archlinux:latest +RUN \ + echo "export EDITOR=nvim" > /etc/profile.d/cbsettings.sh && \ + chmod 755 /etc/profile.d/cbsettings.sh + RUN pacman-key --init && \ pacman -Sy --noconfirm archlinux-keyring && \ pacman-key --populate && \ @@ -9,11 +13,21 @@ RUN pacman -S --noconfirm \ base-devel \ bash-completion \ + bzip2 \ + ccache \ + cscope \ gcc-ada \ git \ go \ htop \ + lcov \ + less \ + msitools \ neovim \ + openssl \ python3 \ - tmux && \ + shellcheck \ + tmux \ + unzip \ + xz && \ rm -r /var/cache/pacman/pkg/* -- To view, visit https://review.coreboot.org/c/coreboot/+/77724?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ied09a9b9500d85348fc9c3862247bd8b85e50b54 Gerrit-Change-Number: 77724 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: util/docker/archlinux: Extend the environment with packages and configs
by Martin L Roth (Code Review) 24 Nov '23

24 Nov '23

Attention is currently required from: Felix Singer. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77724?usp=email ) Change subject: util/docker/archlinux: Extend the environment with packages and configs ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/77724?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ied09a9b9500d85348fc9c3862247bd8b85e50b54 Gerrit-Change-Number: 77724 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Comment-Date: Fri, 24 Nov 2023 04:05:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: [RFC] drivers/option: Add forms in cbtables
by Martin L Roth (Code Review) 24 Nov '23

24 Nov '23

Attention is currently required from: Angel Pons, Benjamin Doron, Lean Sheng Tan, Maximilian Brune, Nico Huber, Patrick Rudolph, Sean Rhodes. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74121?usp=email ) Change subject: [RFC] drivers/option: Add forms in cbtables ...................................................................... Patch Set 21: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74121/comment/dba64c92_07f45274 : PS18, Line 15: The system currently lacks a way : to describe where to find option values. > Technically, backends that store the name of an option as a string would […] Because storage areas could differ completely from one mainboard to another, so I think it would be best to allow for as much flexibility as we can, and for the storage locations to be specified completely separately from the option declarations. For most platforms, I'm thinking that we want a platform to say "Here's my default storage method, figure out where to put the options." ``` # Put everything in CMOS default_storage cmos flag cmos byte_aligned # Put any option a byte or larger on a byte boundary ``` For the hopefully small subset of platforms that would need to be more explicit, we'd probably want to be able to define a default, then override that default for individual settings. I'd prefer that each setup option already contained the information about how many bits or bytes it needed, so that the *only* piece we'd be setting with this is the location. If the size needed doesn't fit, it would throw an error. We'd generate a list of all of the setting locations after they're assigned, both for use in storing & retrieving the data and for debug. Those values would get added to rest of the options data. Maybe something like this: ``` # Most values get put into SMM_Store default_storage smmstore option option0 smmstore 0.0 # This needs to go in the smmstore before anything else option option1 smmstore -1.0 # Put this at the very end of the available storage #options2 - option99 get automatically assigned. # Put some stuff in cmos flag cmos packed # Specify that options are not byte aligned option binary_option1 cmos 5.0 # Byte 5, bit 0 (This is an index into the CMOS area, not a CMOS address) option binary_option3 cmos # Takes the next used bit option dword_option0 cmos # option cmos_checksum cmos # 2 bytes, but that doesn't need to be specified here. # We also have some read-only options from Google's CBI option wwan_present cbi #location is defined in coreboot devicetree option fp_present cbi ``` What I'm thinking is that all this file would specify about is the medium and the offset for the setting, plus flags that affect the layout. This shouldn't know or care about the particulars of any storage medium. I'd rather we defined the specifics of each storage medium somewhere else. So for CMOS, we'd have a map of the CMOS layout in a different file. Smmstore is defined in FMAP, CBI is defined in devicetree. NewMedium is defined wherever. Nico's thought about looking for options in the various storage mediums is interesting, but at least initially, I don't think I'm a fan. It seems like we'd really just want options to be stored in a single medium. A single source of truth and all that. There might be a reason to do it that I'm just not currently seeing though. -- To view, visit https://review.coreboot.org/c/coreboot/+/74121?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I304de7d26d79245a2e31a6d01f6c5643b31cb772 Gerrit-Change-Number: 74121 Gerrit-PatchSet: 21 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel Maslowski <info(a)orangecms.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Fri, 24 Nov 2023 04:03:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: util/docker/archlinux: Extend the environment with packages and configs
by Felix Singer (Code Review) 24 Nov '23

24 Nov '23

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77724?usp=email ) Change subject: util/docker/archlinux: Extend the environment with packages and configs ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/77724?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ied09a9b9500d85348fc9c3862247bd8b85e50b54 Gerrit-Change-Number: 77724 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Fri, 24 Nov 2023 03:59:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/nissa: make GPP_F17 edge triggered to avoid spamming EC
by Scott Chao (Code Review) 24 Nov '23

24 Nov '23

Attention is currently required from: Kapil Porwal, Nick Vaccaro, Paul Menzel. Scott Chao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79244?usp=email ) Change subject: mb/google/nissa: make GPP_F17 edge triggered to avoid spamming EC ...................................................................... Patch Set 4: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/79244/comment/4cef0752_f842813f : PS3, Line 11: cause > cause*s* Done https://review.coreboot.org/c/coreboot/+/79244/comment/b0750caf_a45b4ac8 : PS3, Line 11: triggered and it cause AP(Application Processor) to keep sending GET_NEXT_EVENT to EC during resume from suspend by connecting AC. > Please wrap the lines after 72 characters. Done https://review.coreboot.org/c/coreboot/+/79244/comment/e93cf40c_8fa57ca6 : PS3, Line 11: AP(Application Processor) > Please add a space before the (. Done https://review.coreboot.org/c/coreboot/+/79244/comment/958a024b_7c5c8c34 : PS3, Line 12: So we change GPP_F17 to edge triggered to avoid this condition. > Please add a blank line above to visually separate paragraphs. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79244?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3ceb1dfce46376a6a9a8c6cb6d691d818a0a42ff Gerrit-Change-Number: 79244 Gerrit-PatchSet: 4 Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Fri, 24 Nov 2023 00:28:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/nissa: make GPP_F17 edge triggered to avoid spamming EC
by Scott Chao (Code Review) 24 Nov '23

24 Nov '23

Attention is currently required from: Kapil Porwal, Nick Vaccaro, Scott Chao. Hello Eric Lai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Reka Norman, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79244?usp=email to look at the new patch set (#4). Change subject: mb/google/nissa: make GPP_F17 edge triggered to avoid spamming EC ...................................................................... mb/google/nissa: make GPP_F17 edge triggered to avoid spamming EC In nissa platform, we configured GPP_F17 as SCI+APIC to wake the system and also generate IRQ to the IOAPIC. Currently, we set GPP_F17 to level triggered and it causes AP (Application Processor) to keep sending GET_NEXT_EVENT to EC during resume from suspend by connecting AC. So we change GPP_F17 to edge triggered to avoid this condition. BUG=b:308716748 TEST=Original failure rate was 7 out of 10 times and it reduced to 0 out of 60 times on six joxer systems. Signed-off-by: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Change-Id: I3ceb1dfce46376a6a9a8c6cb6d691d818a0a42ff --- M src/mainboard/google/brya/variants/baseboard/nissa/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/79244/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/79244?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3ceb1dfce46376a6a9a8c6cb6d691d818a0a42ff Gerrit-Change-Number: 79244 Gerrit-PatchSet: 4 Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[main]: [WIP] treewide: indent conditioanls with whitespaces (Makefiles)
by Martin L Roth (Code Review) 24 Nov '23

24 Nov '23

Attention is currently required from: Maximilian Brune. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79230?usp=email ) Change subject: [WIP] treewide: indent conditioanls with whitespaces (Makefiles) ...................................................................... Patch Set 1: Code-Review-1 (3 comments) File Makefile: https://review.coreboot.org/c/coreboot/+/79230/comment/520e6dc0_90d4c089 : PS1, Line 4: $(error Error: Path to the main directory cannot contain spaces) this one was already indented... https://review.coreboot.org/c/coreboot/+/79230/comment/77c76a54_f9ed1566 : PS1, Line 154: printall real-all and this is the issue I was talking about with targets. Indenting the target here makes things ever so much more confusing. https://review.coreboot.org/c/coreboot/+/79230/comment/d44a1c45_212af37c : PS1, Line 162: else and indenting everything in this block just makes things awful. I think this would need to be rewritten before indenting, because this isn't okay. The targets names need to start all the way to the left. -- To view, visit https://review.coreboot.org/c/coreboot/+/79230?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iceaa0d7d9db3e3ede5b7cfba1a1e13388647f33e Gerrit-Change-Number: 79230 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Fri, 24 Nov 2023 00:25:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023