coreboot-gerrit October 2023

coreboot-gerrit@coreboot.org

1 participants
3354 discussions

[M] Change in coreboot[main]: mb/intel/mtlrvp: Add new MTL-P board variant for PD solution
by Jay Patel (Code Review) 09 Oct '23

09 Oct '23

Jay Patel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78282?usp=email ) Change subject: mb/intel/mtlrvp: Add new MTL-P board variant for PD solution ...................................................................... mb/intel/mtlrvp: Add new MTL-P board variant for PD solution This patch will add new board variant to enable PD chip based type-C solution for MTL-RVP BUG=b:303839908 BRANCH=none TEST=check if you can observe MTLRVP PD solutin option as part of make menuconfig. Able to boot to ChromeOS with PD solution. Change-Id: I8c98f08e143ac4ea620aca049e22f4e1e2f97e9e Signed-off-by: Jay Patel <jay2.patel(a)intel.com> --- M src/mainboard/intel/mtlrvp/Kconfig M src/mainboard/intel/mtlrvp/Kconfig.name M src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb M src/mainboard/intel/mtlrvp/variants/mtlrvp_p/overridetree.cb M src/mainboard/intel/mtlrvp/variants/mtlrvp_p_ext_ec/overridetree.cb A src/mainboard/intel/mtlrvp/variants/mtlrvp_pd/overridetree.cb 6 files changed, 76 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/78282/1 diff --git a/src/mainboard/intel/mtlrvp/Kconfig b/src/mainboard/intel/mtlrvp/Kconfig index f225aa5..29ad74b 100644 --- a/src/mainboard/intel/mtlrvp/Kconfig +++ b/src/mainboard/intel/mtlrvp/Kconfig @@ -33,6 +33,10 @@ select EC_GOOGLE_CHROMEEC_MEC select SOC_INTEL_METEORLAKE_PRE_PRODUCTION_SILICON +config BOARD_INTEL_MTLRVP_PD + select BOARD_EXT_EC_SPECIFIC_OPTIONS + select SOC_INTEL_METEORLAKE_PRE_PRODUCTION_SILICON + config BOARD_EXT_EC_SPECIFIC_OPTIONS def_bool n select BOARD_INTEL_MTLRVP_COMMON @@ -61,7 +65,7 @@ config BASEBOARD_DIR string - default "mtlrvp_p" if BOARD_INTEL_MTLRVP_P || BOARD_INTEL_MTLRVP_P_EXT_EC || BOARD_INTEL_MTLRVP_P_MCHP + default "mtlrvp_p" if BOARD_INTEL_MTLRVP_P || BOARD_INTEL_MTLRVP_P_EXT_EC || BOARD_INTEL_MTLRVP_P_MCHP || BOARD_INTEL_MTLRVP_PD config GBB_HWID string @@ -84,6 +88,7 @@ string default "mtlrvp_p" if BOARD_INTEL_MTLRVP_P default "mtlrvp_p_ext_ec" if BOARD_INTEL_MTLRVP_P_EXT_EC || BOARD_INTEL_MTLRVP_P_MCHP + default "mtlrvp_pd" if BOARD_INTEL_MTLRVP_PD config DEVICETREE string diff --git a/src/mainboard/intel/mtlrvp/Kconfig.name b/src/mainboard/intel/mtlrvp/Kconfig.name index 9f61aff..bff33da 100644 --- a/src/mainboard/intel/mtlrvp/Kconfig.name +++ b/src/mainboard/intel/mtlrvp/Kconfig.name @@ -6,3 +6,6 @@ config BOARD_INTEL_MTLRVP_P_MCHP bool "Meteorlake-P RVP with Microchip EC" + +config BOARD_INTEL_MTLRVP_PD + bool "Meteorlake-P RVP with PD chip" diff --git a/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb b/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb index 17a92a8..b9e3361 100644 --- a/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb +++ b/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb @@ -234,18 +234,6 @@ register "group" = "ACPI_PLD_GROUP(3, 2)" device ref tcss_usb3_port1 on end end - chip drivers/usb/acpi - register "desc" = ""USB3 Type-C Port C2"" - register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" - register "group" = "ACPI_PLD_GROUP(2, 2)" - device ref tcss_usb3_port2 on end - end - chip drivers/usb/acpi - register "desc" = ""USB3 Type-C Port C3"" - register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" - register "group" = "ACPI_PLD_GROUP(1, 2)" - device ref tcss_usb3_port3 on end - end end end end diff --git a/src/mainboard/intel/mtlrvp/variants/mtlrvp_p/overridetree.cb b/src/mainboard/intel/mtlrvp/variants/mtlrvp_p/overridetree.cb index 7ca0024..b13c74e 100644 --- a/src/mainboard/intel/mtlrvp/variants/mtlrvp_p/overridetree.cb +++ b/src/mainboard/intel/mtlrvp/variants/mtlrvp_p/overridetree.cb @@ -1,4 +1,24 @@ chip soc/intel/meteorlake - device domain 0 on end + device domain 0 on + device ref tcss_xhci on + chip drivers/usb/acpi + device ref tcss_root_hub on + chip drivers/usb/acpi + register "desc" = ""USB3 Type-C Port C2"" + register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" + register "group" = "ACPI_PLD_GROUP(2, 2)" + device ref tcss_usb3_port2 on end + end + chip drivers/usb/acpi + register "desc" = ""USB3 Type-C Port C3"" + register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" + register "group" = "ACPI_PLD_GROUP(1, 2)" + device ref tcss_usb3_port3 on end + end + end + end + end + end + end diff --git a/src/mainboard/intel/mtlrvp/variants/mtlrvp_p_ext_ec/overridetree.cb b/src/mainboard/intel/mtlrvp/variants/mtlrvp_p_ext_ec/overridetree.cb index 3f1579e..a2244aa 100644 --- a/src/mainboard/intel/mtlrvp/variants/mtlrvp_p_ext_ec/overridetree.cb +++ b/src/mainboard/intel/mtlrvp/variants/mtlrvp_p_ext_ec/overridetree.cb @@ -10,6 +10,24 @@ device pnp 0c09.0 on end end end + device ref tcss_xhci on + chip drivers/usb/acpi + device ref tcss_root_hub on + chip drivers/usb/acpi + register "desc" = ""USB3 Type-C Port C2"" + register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" + register "group" = "ACPI_PLD_GROUP(2, 2)" + device ref tcss_usb3_port2 on end + end + chip drivers/usb/acpi + register "desc" = ""USB3 Type-C Port C3"" + register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" + register "group" = "ACPI_PLD_GROUP(1, 2)" + device ref tcss_usb3_port3 on end + end + end + end + end device ref pmc hidden chip drivers/intel/pmc_mux device generic 0 on diff --git a/src/mainboard/intel/mtlrvp/variants/mtlrvp_pd/overridetree.cb b/src/mainboard/intel/mtlrvp/variants/mtlrvp_pd/overridetree.cb new file mode 100644 index 0000000..7cfbbcc --- /dev/null +++ b/src/mainboard/intel/mtlrvp/variants/mtlrvp_pd/overridetree.cb @@ -0,0 +1,28 @@ +chip soc/intel/meteorlake + + device domain 0 on + device ref soc_espi on + chip ec/google/chromeec + use conn0 as mux_conn[0] + use conn1 as mux_conn[1] + device pnp 0c09.0 on end + end + end + device ref pmc hidden + chip drivers/intel/pmc_mux + device generic 0 on + chip drivers/intel/pmc_mux/conn + use usb2_port1 as usb2_port + use tcss_usb3_port0 as usb3_port + device generic 0 alias conn0 on end + end + chip drivers/intel/pmc_mux/conn + use usb2_port2 as usb2_port + use tcss_usb3_port1 as usb3_port + device generic 1 alias conn1 on end + end + end + end + end + end +end -- To view, visit https://review.coreboot.org/c/coreboot/+/78282?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8c98f08e143ac4ea620aca049e22f4e1e2f97e9e Gerrit-Change-Number: 78282 Gerrit-PatchSet: 1 Gerrit-Owner: Jay Patel <jay2.patel(a)intel.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[main]: soc/amd/genoa: Enable eSPI early
by Felix Held (Code Review) 09 Oct '23

09 Oct '23

Attention is currently required from: Arthur Heymans, Varshit Pandya. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76508?usp=email ) Change subject: soc/amd/genoa: Enable eSPI early ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76508?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4965eac4ec3d600b1e840affce4e5b4fa2ea4360 Gerrit-Change-Number: 76508 Gerrit-PatchSet: 8 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 09 Oct 2023 20:23:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: soc/amd/genoa: Add aoac.c & enable AOAC devices early
by Felix Held (Code Review) 09 Oct '23

09 Oct '23

Attention is currently required from: Arthur Heymans, Martin L Roth, Martin Roth, Varshit Pandya. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76506?usp=email ) Change subject: soc/amd/genoa: Add aoac.c & enable AOAC devices early ...................................................................... Patch Set 12: Code-Review+2 (1 comment) File src/soc/amd/genoa/include/soc/aoac_defs.h: https://review.coreboot.org/c/coreboot/+/76506/comment/be61828f_b76234d7 : PS12, Line 18: #define FCH_AOAC_DEV_ESPI 27 looks like there are two espi devices; this one is espi0 -- To view, visit https://review.coreboot.org/c/coreboot/+/76506?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic9553e6016c92c9b1678c395cd6a9e6860bf8a76 Gerrit-Change-Number: 76506 Gerrit-PatchSet: 12 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Mon, 09 Oct 2023 20:21:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/rex0: Update NVM configuration for WFC
by Kiran2 Kumar (Code Review) 09 Oct '23

09 Oct '23

Attention is currently required from: Bora Guvendik, Cliff Huang, Eran Mitrani, Hannah Williams, Jamie Ryu, Kapil Porwal, Ravishankar Sarawadi, Tarun, kiran2.kumar(a)intel.com. Kiran2 Kumar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78211?usp=email ) Change subject: mb/google/rex/var/rex0: Update NVM configuration for WFC ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/78211?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I51bdf249549d3e03180e9d126a85e9dff91028db Gerrit-Change-Number: 78211 Gerrit-PatchSet: 2 Gerrit-Owner: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Kiran2 Kumar <kiran2.kumar(a)intel.corp-partner.google.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: kiran2.kumar(a)intel.com Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: kiran2.kumar(a)intel.com Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Mon, 09 Oct 2023 17:55:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/google/brya/var/dochi: update gpio settings
by David Wu (Code Review) 09 Oct '23

09 Oct '23

Attention is currently required from: Felix Held, Lucas Chen, Morris Hsu, Nick Vaccaro, Paul Menzel, Subrata Banik. David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78112?usp=email ) Change subject: mb/google/brya/var/dochi: update gpio settings ...................................................................... Patch Set 6: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78112/comment/3f68fcc9_ff8d99a2 : PS5, Line 9: schematics > might be good to add that info to the commit message too: […] Done. Thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/78112?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I10bd1b72c9b0299b8d29ab642fddb5f0c4727652 Gerrit-Change-Number: 78112 Gerrit-PatchSet: 6 Gerrit-Owner: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 09 Oct 2023 17:18:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: David Wu <david_wu(a)quanta.corp-partner.google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/google/brya/var/dochi: update gpio settings
by David Wu (Code Review) 09 Oct '23

09 Oct '23

Attention is currently required from: David Wu, Lucas Chen, Morris Hsu, Nick Vaccaro, Paul Menzel, Subrata Banik. David Wu has uploaded a new patch set (#6) to the change originally created by Morris Hsu. ( https://review.coreboot.org/c/coreboot/+/78112?usp=email ) Change subject: mb/google/brya/var/dochi: update gpio settings ...................................................................... mb/google/brya/var/dochi: update gpio settings Configure GPIOs according to schematics revision 20230923. TEST=emerge-brya coreboot Change-Id: I10bd1b72c9b0299b8d29ab642fddb5f0c4727652 Signed-off-by: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/variants/dochi/Makefile.inc A src/mainboard/google/brya/variants/dochi/gpio.c 2 files changed, 212 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/78112/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/78112?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I10bd1b72c9b0299b8d29ab642fddb5f0c4727652 Gerrit-Change-Number: 78112 Gerrit-PatchSet: 6 Gerrit-Owner: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[XL] Change in coreboot[main]: lib/jpeg: Replace decoder with Wuffs' implementation
by Patrick Georgi (Code Review) 09 Oct '23

09 Oct '23

Attention is currently required from: Martin L Roth, Tim Wawrzynczak. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78271?usp=email ) Change subject: lib/jpeg: Replace decoder with Wuffs' implementation ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Is there a link to to the Wuffs code that implements this? https://github.com/google/wuffs/tree/main/std/jpeg The wuffs code is on a 0.4.0 snapshot (more or less ToT), but once there's a suitable release, this can be further qualified by pointing at the tag. -- To view, visit https://review.coreboot.org/c/coreboot/+/78271?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If8fa7da69da1ad412f27c2c5e882393c7739bc82 Gerrit-Change-Number: 78271 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Comment-Date: Mon, 09 Oct 2023 17:13:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[main]: lib/jpeg: Replace decoder with Wuffs' implementation
by Tim Wawrzynczak (Code Review) 09 Oct '23

09 Oct '23

Attention is currently required from: Martin L Roth, Patrick Georgi. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78271?usp=email ) Change subject: lib/jpeg: Replace decoder with Wuffs' implementation ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Is there a link to to the Wuffs code that implements this? -- To view, visit https://review.coreboot.org/c/coreboot/+/78271?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If8fa7da69da1ad412f27c2c5e882393c7739bc82 Gerrit-Change-Number: 78271 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Mon, 09 Oct 2023 17:06:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/intel/mtlrvp: Disable package C-state auto demotion
by Kapil Porwal (Code Review) 09 Oct '23

09 Oct '23

Attention is currently required from: Sukumar Ghorai. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78278?usp=email ) Change subject: mb/intel/mtlrvp: Disable package C-state auto demotion ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78278?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6ff408280178a24686180f72f79522d2741607a1 Gerrit-Change-Number: 78278 Gerrit-PatchSet: 2 Gerrit-Owner: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Comment-Date: Mon, 09 Oct 2023 16:58:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel/mtl: Set slp-s0 counter frequency
by Kapil Porwal (Code Review) 09 Oct '23

09 Oct '23

Attention is currently required from: Eran Mitrani, Sukumar Ghorai, Tarun. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78277?usp=email ) Change subject: soc/intel/mtl: Set slp-s0 counter frequency ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78277?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1e95cd69e941d4d72d5c36a07660ca07ee2499ba Gerrit-Change-Number: 78277 Gerrit-PatchSet: 1 Gerrit-Owner: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Mon, 09 Oct 2023 16:58:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2023