Attention is currently required from: Eric Lai, Nick Vaccaro, Robert Chen, Shawn Ku, Subrata Banik.
Hello Derek Huang, Nick Vaccaro, Shawn Ku, Shawn Ku, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/78264?usp=email
to look at the new patch set (#3).
Change subject: mb/google/nissa/var/quandiso: Update touchscreen power sequence
......................................................................
mb/google/nissa/var/quandiso: Update touchscreen power sequence
Pull GPP_C1 to high in ramstage to meet touchscreen power sequence.
BUG=b:302236370
BRANCH=firmware-nissa-15217.B
TEST=emerge-nissa coreboot chromeos-bootimage
& test touchscreen function on quandiso DUT
Change-Id: Ia9f600ec0cc4be2d77ff08c0ae8951c90aec944f
Signed-off-by: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/brya/variants/quandiso/gpio.c
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/78264/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/78264?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia9f600ec0cc4be2d77ff08c0ae8951c90aec944f
Gerrit-Change-Number: 78264
Gerrit-PatchSet: 3
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Shawn Ku <shawnku(a)chromium.org>
Gerrit-Reviewer: Shawn Ku <shawnku(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Shawn Ku <shawnku(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Naresh Solanki, Paul Menzel.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77893?usp=email )
Change subject: mb/ibm/sbp1: Disable SATA controller
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/77893?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iab2d597e6a0f22b946e657a2851b68f752d1f7d4
Gerrit-Change-Number: 77893
Gerrit-PatchSet: 2
Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com>
Gerrit-Comment-Date: Thu, 12 Oct 2023 08:18:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Naresh Solanki, Paul Menzel.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77893?usp=email )
Change subject: mb/ibm/sbp1: Disable SATA controller
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/77893/comment/8cdf3a88_76a9ae2b :
PS1, Line 8:
> Why?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/77893?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iab2d597e6a0f22b946e657a2851b68f752d1f7d4
Gerrit-Change-Number: 77893
Gerrit-PatchSet: 2
Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com>
Gerrit-Comment-Date: Thu, 12 Oct 2023 08:18:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Naresh Solanki, Paul Menzel.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77893?usp=email )
Change subject: mb/ibm/sbp1: Disable SATA controller
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/ibm/sbp1/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/77893/comment/7e31c284_a92b152c :
PS1, Line 8: 1ba2
> In https://review.coreboot. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/77893?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iab2d597e6a0f22b946e657a2851b68f752d1f7d4
Gerrit-Change-Number: 77893
Gerrit-PatchSet: 2
Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com>
Gerrit-Comment-Date: Thu, 12 Oct 2023 08:18:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Christian Walter, David Hendricks, Naresh Solanki, Paul Menzel, Tim Chu.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77892?usp=email )
Change subject: soc/intel/xeon_sp/spr: Add SATA controllers 1 and 2 to devicetree
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/77892?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia654c4ef895b52338554d89c25f61b262fbbcbbb
Gerrit-Change-Number: 77892
Gerrit-PatchSet: 2
Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com>
Gerrit-Reviewer: Annie Chen <chen.annieet(a)inventec.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: David Hendricks
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: David Hendricks
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Thu, 12 Oct 2023 08:17:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai, Nick Vaccaro, Robert Chen, Shawn Ku, Subrata Banik.
Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78264?usp=email )
Change subject: mb/google/nissa/var/quandiso: Update gpio for touchscreen power sequencing
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78264/comment/423651bf_558d3c6f :
PS2, Line 7: Update gpio for touchscreen power sequencing
Please keep it in one line, probably "Update touchscreen power sequence"?
https://review.coreboot.org/c/coreboot/+/78264/comment/9ffc2293_0369358c :
PS2, Line 9: Pull ramstage GPP_C1 to high
Pull GPP_C1 to high in ramstage
--
To view, visit https://review.coreboot.org/c/coreboot/+/78264?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia9f600ec0cc4be2d77ff08c0ae8951c90aec944f
Gerrit-Change-Number: 78264
Gerrit-PatchSet: 2
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Shawn Ku <shawnku(a)chromium.org>
Gerrit-Reviewer: Shawn Ku <shawnku(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Shawn Ku <shawnku(a)chromium.org>
Gerrit-Comment-Date: Thu, 12 Oct 2023 08:11:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Nick Vaccaro, Subrata Banik.
Robert Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77588?usp=email )
Change subject: mb/google/brya/var/quandiso: Add VBT data file
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/77588?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia9f84b4f56171737a9e7a513b63549b3013775c4
Gerrit-Change-Number: 77588
Gerrit-PatchSet: 6
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Thu, 12 Oct 2023 08:11:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Bora Guvendik, Eran Mitrani, Jakub Czapiga, Jamie Ryu, Kane Chen, Kapil Porwal, Matt Chen, Subrata Banik, Tarun, Wonkyu Kim.
Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78122?usp=email )
Change subject: mb/google/rex: Turn off CNVi 3.3v power at romstage
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78122/comment/637f49d6_2c96e1d7 :
PS1, Line 14: TEST
> Could you please explain the issue fixed by this change?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/78122?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2f1bfc9f41bcb56c2a8af83ef75f3fab42e060f0
Gerrit-Change-Number: 78122
Gerrit-PatchSet: 2
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Matt Chen <matt.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Matt Chen <matt.chen(a)intel.corp-partner.google.com>
Gerrit-Attention: Kane Chen <kane.chen(a)intel.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-Comment-Date: Thu, 12 Oct 2023 07:57:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Bora Guvendik, Eran Mitrani, Jakub Czapiga, Jamie Ryu, Kane Chen, Kapil Porwal, Matt Chen, Subrata Banik, Tarun, Wonkyu Kim.
Hello Bora Guvendik, Eran Mitrani, Jakub Czapiga, Jamie Ryu, Kane Chen, Kapil Porwal, Matt Chen, Subrata Banik, Tarun, Wonkyu Kim, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/78122?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by Wonkyu Kim, Verified+1 by build bot (Jenkins)
Change subject: mb/google/rex: Turn off CNVi 3.3v power at romstage
......................................................................
mb/google/rex: Turn off CNVi 3.3v power at romstage
Turn CNVi 3.3v off at romstage so that it will be toggled during warm
boot. Cnvi 3.3v is already turned on at ramstage. This is necessary
to ensure the device starts in clean state.
BUG=286187821
BUG=297293441
TEST= Check the Cnvi is enumerated after warm reboot.
Signed-off-by: Cliff Huang <cliff.huang(a)intel.com>
Change-Id: I2f1bfc9f41bcb56c2a8af83ef75f3fab42e060f0
---
M src/mainboard/google/rex/variants/rex0/gpio.c
M src/mainboard/google/rex/variants/screebo/gpio.c
2 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/78122/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/78122?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2f1bfc9f41bcb56c2a8af83ef75f3fab42e060f0
Gerrit-Change-Number: 78122
Gerrit-PatchSet: 2
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Matt Chen <matt.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Matt Chen <matt.chen(a)intel.corp-partner.google.com>
Gerrit-Attention: Kane Chen <kane.chen(a)intel.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Bora Guvendik, Eran Mitrani, Jakub Czapiga, Jamie Ryu, Kane Chen, Kapil Porwal, Matt Chen, Subrata Banik, Tarun, Wonkyu Kim.
Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78122?usp=email )
Change subject: mb/google/rex: Turn off CNVi 3.3v power at romstage
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/78122?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2f1bfc9f41bcb56c2a8af83ef75f3fab42e060f0
Gerrit-Change-Number: 78122
Gerrit-PatchSet: 1
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Matt Chen <matt.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Matt Chen <matt.chen(a)intel.corp-partner.google.com>
Gerrit-Attention: Kane Chen <kane.chen(a)intel.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-Comment-Date: Thu, 12 Oct 2023 07:36:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment