coreboot-gerrit October 2023

coreboot-gerrit@coreboot.org

1 participants
3354 discussions

[S] Change in coreboot[main]: soc/amd/common: Add ACP device to common block graphics driver
by Matt DeVillier (Code Review) 17 Oct '23

17 Oct '23

Attention is currently required from: CoolStar, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78430?usp=email ) Change subject: soc/amd/common: Add ACP device to common block graphics driver ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/soc/amd/common/block/graphics/Kconfig: https://review.coreboot.org/c/coreboot/+/78430/comment/451d2a8a_9f897278 : PS3, Line 34: provide Audio CoProcessor device how about: "Select this option to provide an Audio CoProcessor ACPI device for pre-Ryzen APUs for use by custom Windows drivers" -- To view, visit https://review.coreboot.org/c/coreboot/+/78430?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0e31c3b31fa9fb99578c04b79fce2d8c1d695561 Gerrit-Change-Number: 78430 Gerrit-PatchSet: 3 Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 17 Oct 2023 18:59:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/kahlee: Fix backlight settings in Windows
by Matt DeVillier (Code Review) 17 Oct '23

17 Oct '23

Attention is currently required from: CoolStar, Jason Nien, Martin Roth. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78429?usp=email ) Change subject: mb/google/kahlee: Fix backlight settings in Windows ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78429/comment/84ab55e2_11501021 : PS5, Line 7: Fix backlight settings how about 'Enable display backlight control in Windows' -- To view, visit https://review.coreboot.org/c/coreboot/+/78429?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6792a91f26a5f6e4dc478cdde776ff749f08946f Gerrit-Change-Number: 78429 Gerrit-PatchSet: 5 Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Tue, 17 Oct 2023 18:58:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/amd/stoneyridge: Use common block graphics driver
by Matt DeVillier (Code Review) 17 Oct '23

17 Oct '23

Attention is currently required from: CoolStar, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Paul Menzel. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78428?usp=email ) Change subject: soc/amd/stoneyridge: Use common block graphics driver ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78428/comment/7a878c09_cc92cda4 : PS5, Line 1: Parent: 94f3866d (mb/google/brya: Create anraggar variant) add a note about using the common ssdt and dropping the ASL stub for the GPU -- To view, visit https://review.coreboot.org/c/coreboot/+/78428?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I260b964be59c1a208ff907c474243a9ace03f206 Gerrit-Change-Number: 78428 Gerrit-PatchSet: 5 Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 17 Oct 2023 18:57:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[main]: vc/intel/raptorlake: Use FSP v4301.01 headers for Google
by Nick Vaccaro (Code Review) 17 Oct '23

17 Oct '23

Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78444?usp=email ) Change subject: vc/intel/raptorlake: Use FSP v4301.01 headers for Google ...................................................................... vc/intel/raptorlake: Use FSP v4301.01 headers for Google Remove the existing FSP 4221.00 headers subdirectory called 4221.00_google, and have Google vendor devices use FSP 4301.01. Change-Id: Ic64b3aec62f0d6302278393bf06d090f43c0d592 Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com> --- M src/soc/intel/alderlake/Kconfig D src/vendorcode/intel/fsp/fsp2_0/raptorlake/4221.00_google/FirmwareVersionInfoHob.h D src/vendorcode/intel/fsp/fsp2_0/raptorlake/4221.00_google/FspUpd.h D src/vendorcode/intel/fsp/fsp2_0/raptorlake/4221.00_google/FspmUpd.h D src/vendorcode/intel/fsp/fsp2_0/raptorlake/4221.00_google/FspsUpd.h D src/vendorcode/intel/fsp/fsp2_0/raptorlake/4221.00_google/MemInfoHob.h 6 files changed, 0 insertions(+), 8,455 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/78444/1 -- To view, visit https://review.coreboot.org/c/coreboot/+/78444?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic64b3aec62f0d6302278393bf06d090f43c0d592 Gerrit-Change-Number: 78444 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: mb/google/brya/var/dochi: Enable EC keyboard backlight
by Bob Moragues (Code Review) 17 Oct '23

17 Oct '23

Attention is currently required from: Lucas Chen, Morris Hsu, Nick Vaccaro, Ren Kuo, Subrata Banik, YH Lin. Bob Moragues has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78395?usp=email ) Change subject: mb/google/brya/var/dochi: Enable EC keyboard backlight ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/78395?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1b640c576fcdd368110b88cba6f969f10dfc15f1 Gerrit-Change-Number: 78395 Gerrit-PatchSet: 1 Gerrit-Owner: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Bob Moragues <moragues(a)google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Tue, 17 Oct 2023 18:15:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: arch/arm: Build test all arm targets with clang
by Arthur Heymans (Code Review) 17 Oct '23

17 Oct '23

Attention is currently required from: Arthur Heymans, Julius Werner. Hello Julius Werner, Martin L Roth, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69747?usp=email to look at the new patch set (#13). Change subject: arch/arm: Build test all arm targets with clang ...................................................................... arch/arm: Build test all arm targets with clang Change-Id: I88cf8ce16fb6c61c19d615e396f5871179b06fc8 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/arch/arm/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/69747/13 -- To view, visit https://review.coreboot.org/c/coreboot/+/69747?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I88cf8ce16fb6c61c19d615e396f5871179b06fc8 Gerrit-Change-Number: 69747 Gerrit-PatchSet: 13 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: [WIP] Revert "soc/intel/meteorlake: Hook up UPD for C1 C-state auto-d...
by Sukumar Ghorai (Code Review) 17 Oct '23

17 Oct '23

Sukumar Ghorai has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/78303?usp=email ) Change subject: [WIP] Revert "soc/intel/meteorlake: Hook up UPD for C1 C-state auto-demotion" ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/78303?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I703f49b6d5751d6de5b319fa3a91bff2ee43a934 Gerrit-Change-Number: 78303 Gerrit-PatchSet: 1 Gerrit-Owner: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[main]: arch/arm64/armv8/Makefile.inc: Add clang -target for .ld CPP
by Arthur Heymans (Code Review) 17 Oct '23

17 Oct '23

Attention is currently required from: Julius Werner. Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78443?usp=email ) Change subject: arch/arm64/armv8/Makefile.inc: Add clang -target for .ld CPP ...................................................................... arch/arm64/armv8/Makefile.inc: Add clang -target for .ld CPP When preprocessing the linker script the target arch needs to be specified. Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: Id18af3da93d2d06a2ebb83eddd03377c9026c8fa --- M src/arch/arm64/armv8/Makefile.inc 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/78443/1 diff --git a/src/arch/arm64/armv8/Makefile.inc b/src/arch/arm64/armv8/Makefile.inc index 15d80e6..c47d40e 100644 --- a/src/arch/arm64/armv8/Makefile.inc +++ b/src/arch/arm64/armv8/Makefile.inc @@ -13,6 +13,10 @@ ################################################################################ ifeq ($(CONFIG_ARCH_BOOTBLOCK_ARMV8_64),y) +ifeq ($(CONFIG_COMPILER_LLVM_CLANG),y) +bootblock-ld-ccopts += -target arm64-elf +endif + ifneq ($(CONFIG_BOOTBLOCK_CUSTOM),y) decompressor-y += bootblock.S ifneq ($(CONFIG_COMPRESS_BOOTBLOCK),y) @@ -44,6 +48,10 @@ ################################################################################ ifeq ($(CONFIG_ARCH_VERSTAGE_ARMV8_64),y) +ifeq ($(CONFIG_COMPILER_LLVM_CLANG),y) +verstage-ld-ccopts += -target arm64-elf +endif + verstage-y += cache.c verstage-y += cpu.S verstage-y += exception.c @@ -57,6 +65,10 @@ ################################################################################ ifeq ($(CONFIG_ARCH_ROMSTAGE_ARMV8_64),y) +ifeq ($(CONFIG_COMPILER_LLVM_CLANG),y) +romstage-ld-ccopts += -target arm64-elf +endif + romstage-y += cache.c romstage-y += cpu.S romstage-y += exception.c @@ -73,6 +85,10 @@ ################################################################################ ifeq ($(CONFIG_ARCH_RAMSTAGE_ARMV8_64),y) +ifeq ($(CONFIG_COMPILER_LLVM_CLANG),y) +ramstage-ld-ccopts += -target arm64-elf +endif + ramstage-y += cache.c ramstage-y += cpu.S ramstage-y += exception.c -- To view, visit https://review.coreboot.org/c/coreboot/+/78443?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id18af3da93d2d06a2ebb83eddd03377c9026c8fa Gerrit-Change-Number: 78443 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[main]: arch/arm/armv7/Makefile.inc: Add more finegrained ld-ccopts
by Arthur Heymans (Code Review) 17 Oct '23

17 Oct '23

Attention is currently required from: Arthur Heymans, Martin L Roth. Hello Felix Singer, Julius Werner, Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75031?usp=email to look at the new patch set (#8). Change subject: arch/arm/armv7/Makefile.inc: Add more finegrained ld-ccopts ...................................................................... arch/arm/armv7/Makefile.inc: Add more finegrained ld-ccopts Add linker targets only to stages when ARCH_#stage_ARMV7 is set. Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: I4340681e30059d6f18a49a49937668cd3dd39ce1 --- M src/arch/arm/armv7/Makefile.inc 1 file changed, 15 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/75031/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/75031?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4340681e30059d6f18a49a49937668cd3dd39ce1 Gerrit-Change-Number: 75031 Gerrit-PatchSet: 8 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/intel/mtlrvp: Disable package C-state auto demotion
by Sukumar Ghorai (Code Review) 17 Oct '23

17 Oct '23

Hello Kapil Porwal, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78278?usp=email to look at the new patch set (#4). Change subject: mb/intel/mtlrvp: Disable package C-state auto demotion ...................................................................... mb/intel/mtlrvp: Disable package C-state auto demotion Package C-state auto demotion feature allows hardware to determine lower C-state as per platform policy. Since platform sets performance policy to balanced from hardware, auto demotion can be disabled without performance impact. Also, disabling this feature results soc to enter below PC8 state and additional power savings ~30mW in Local-Video-Playback scenario. Change-Id: I6ff408280178a24686180f72f79522d2741607a1 Signed-off-by: Sukumar Ghorai <sukumar.ghorai(a)intel.com> --- M src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/78278/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/78278?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6ff408280178a24686180f72f79522d2741607a1 Gerrit-Change-Number: 78278 Gerrit-PatchSet: 4 Gerrit-Owner: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2023