Attention is currently required from: CoolStar, Jason Nien, Martin Roth.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78429?usp=email )
Change subject: mb/google/kahlee: Enable display backlight control in Windows
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78429/comment/4a3fd157_46b8d2e2 :
PS6, Line 12: after 30
: minutes
Boot google/careena to Win10. Observe display brightness controls
functional after driver loads (immediately with patched driver,
30 minutes with unpatched).
--
To view, visit https://review.coreboot.org/c/coreboot/+/78429?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6792a91f26a5f6e4dc478cdde776ff749f08946f
Gerrit-Change-Number: 78429
Gerrit-PatchSet: 6
Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 17 Oct 2023 19:13:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jason Nien, Martin Roth, Martin Roth, Matt DeVillier, Nico Huber, Paul Menzel.
CoolStar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78406?usp=email )
Change subject: mb/google/kahlee: Select SOC_AMD_COMMON_BLOCK_GRAPHICS_ACP
......................................................................
Patch Set 9:
(1 comment)
Patchset:
PS5:
> let's see if we can get this to attach via a chip driver instead
attached by kconfig option from graphics.c instead
--
To view, visit https://review.coreboot.org/c/coreboot/+/78406?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I51527a1bfae3e12ce5cf1da8a3465bbc9ddfa76e
Gerrit-Change-Number: 78406
Gerrit-PatchSet: 9
Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 17 Oct 2023 19:09:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Matt DeVillier.
CoolStar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78430?usp=email )
Change subject: soc/amd/common: Add ACP device to common block graphics driver
......................................................................
Patch Set 4:
(1 comment)
File src/soc/amd/common/block/graphics/Kconfig:
https://review.coreboot.org/c/coreboot/+/78430/comment/d359f055_a03b157a :
PS3, Line 34: provide Audio CoProcessor device
> how about: […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/78430?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0e31c3b31fa9fb99578c04b79fce2d8c1d695561
Gerrit-Change-Number: 78430
Gerrit-PatchSet: 4
Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Tue, 17 Oct 2023 19:09:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Jason Nien, Martin Roth, Matt DeVillier.
CoolStar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78429?usp=email )
Change subject: mb/google/kahlee: Enable display backlight control in Windows
......................................................................
Patch Set 6:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78429/comment/3ad65ecf_97027411 :
PS5, Line 7: Fix backlight settings
> how about 'Enable display backlight control in Windows'
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/78429?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6792a91f26a5f6e4dc478cdde776ff749f08946f
Gerrit-Change-Number: 78429
Gerrit-PatchSet: 6
Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 17 Oct 2023 19:08:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Matt DeVillier, Paul Menzel.
CoolStar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78428?usp=email )
Change subject: soc/amd/stoneyridge: Use common block graphics driver
......................................................................
Patch Set 6:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78428/comment/3a7dda29_2641a662 :
PS5, Line 1: Parent: 94f3866d (mb/google/brya: Create anraggar variant)
> add a note about using the common ssdt and dropping the ASL stub for the GPU
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/78428?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I260b964be59c1a208ff907c474243a9ace03f206
Gerrit-Change-Number: 78428
Gerrit-PatchSet: 6
Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Tue, 17 Oct 2023 19:08:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: CoolStar, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Matt DeVillier.
Hello Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Matt DeVillier, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/78430?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Code-Review+1 by Matt DeVillier
Change subject: soc/amd/common: Add ACP device to common block graphics driver
......................................................................
soc/amd/common: Add ACP device to common block graphics driver
Supports a brand new ACP driver for STONEY / Grunt chromebooks.
AMD's Audio CoProcessor handles i2s/tdm audio, and is located on the
GPU.
On Windows the PCIe device for the GPU is owned by the AMD proprietary
driver, hence a separate device has to be added for the ACP driver.
Fortunately since IOMMU is disabled on STONEY, the driver itself can
pull BAR5 from the GPU and use that to initialize, so no special
configuration is required in ACPI other than the ID.
Change-Id: I0e31c3b31fa9fb99578c04b79fce2d8c1d695561
Signed-off-by: CoolStar <coolstarorganization(a)gmail.com>
---
M src/soc/amd/common/block/graphics/Kconfig
M src/soc/amd/common/block/graphics/graphics.c
2 files changed, 22 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/78430/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/78430?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0e31c3b31fa9fb99578c04b79fce2d8c1d695561
Gerrit-Change-Number: 78430
Gerrit-PatchSet: 4
Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: CoolStar, Jason Nien, Martin Roth.
Hello Jason Nien, Martin Roth, Matt DeVillier, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/78429?usp=email
to look at the new patch set (#6).
Change subject: mb/google/kahlee: Enable display backlight control in Windows
......................................................................
mb/google/kahlee: Enable display backlight control in Windows
Utilize the SOC_AMD_COMMON_BLOCK_GRAPHICS_ATIF to provide the Windows
driver with information on backlight settings.
TEST: Boot google/careena to Win10. Observe display turns on after 30
minutes with brightness controls functional.
Change-Id: I6792a91f26a5f6e4dc478cdde776ff749f08946f
Signed-off-by: CoolStar <coolstarorganization(a)gmail.com>
---
M src/mainboard/google/kahlee/Kconfig
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/78429/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/78429?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6792a91f26a5f6e4dc478cdde776ff749f08946f
Gerrit-Change-Number: 78429
Gerrit-PatchSet: 6
Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: CoolStar, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Paul Menzel.
Hello Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Matt DeVillier, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/78428?usp=email
to look at the new patch set (#6).
Change subject: soc/amd/stoneyridge: Use common block graphics driver
......................................................................
soc/amd/stoneyridge: Use common block graphics driver
Select the common block graphics driver for Stoney.
Decouple the common driver from FSP for Stoney.
Drop Stoney's ASL stub for the common ssdt
Change-Id: I260b964be59c1a208ff907c474243a9ace03f206
Signed-off-by: CoolStar <coolstarorganization(a)gmail.com>
---
M src/soc/amd/common/block/graphics/graphics.c
M src/soc/amd/stoneyridge/Kconfig
M src/soc/amd/stoneyridge/acpi/northbridge.asl
M src/soc/amd/stoneyridge/chipset_cz.cb
M src/soc/amd/stoneyridge/chipset_st.cb
5 files changed, 7 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/78428/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/78428?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I260b964be59c1a208ff907c474243a9ace03f206
Gerrit-Change-Number: 78428
Gerrit-PatchSet: 6
Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jason Nien, Martin Roth, Martin Roth, Matt DeVillier, Nico Huber, Paul Menzel.
CoolStar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78406?usp=email )
Change subject: mb/google/kahlee: Select SOC_AMD_COMMON_BLOCK_GRAPHICS_ACP
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS8:
> is this a function of the board or the SoC? If the latter, we can move this selection there
board. Devices with HDA don't need this
--
To view, visit https://review.coreboot.org/c/coreboot/+/78406?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I51527a1bfae3e12ce5cf1da8a3465bbc9ddfa76e
Gerrit-Change-Number: 78406
Gerrit-PatchSet: 8
Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 17 Oct 2023 19:05:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: CoolStar, Jason Nien, Martin Roth, Martin Roth, Nico Huber, Paul Menzel.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78406?usp=email )
Change subject: mb/google/kahlee: Select SOC_AMD_COMMON_BLOCK_GRAPHICS_ACP
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS8:
is this a function of the board or the SoC? If the latter, we can move this selection there
--
To view, visit https://review.coreboot.org/c/coreboot/+/78406?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I51527a1bfae3e12ce5cf1da8a3465bbc9ddfa76e
Gerrit-Change-Number: 78406
Gerrit-PatchSet: 8
Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 17 Oct 2023 19:01:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment