coreboot-gerrit April 2022

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

Change in coreboot[master]: payloads/external/LinuxBoot: Update Linuxboot Kconfig u-root
by Name of user not set (Code Review) 03 Apr '22

03 Apr '22

Name of user not set #1004172 has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/63342 ) Change subject: payloads/external/LinuxBoot: Update Linuxboot Kconfig u-root ...................................................................... Abandoned i have make a mistakes sorry -- To view, visit https://review.coreboot.org/c/coreboot/+/63342 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iabc345cf7d233a94b49650cfec386978e70b655a Gerrit-Change-Number: 63342 Gerrit-PatchSet: 1 Gerrit-Owner: Name of user not set #1004172 Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: payloads/external/LinuxBoot: Update Linuxboot Kconfig u-root
by Name of user not set (Code Review) 03 Apr '22

03 Apr '22

Name of user not set #1004172 has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63342 ) Change subject: payloads/external/LinuxBoot: Update Linuxboot Kconfig u-root ...................................................................... payloads/external/LinuxBoot: Update Linuxboot Kconfig u-root the u-root have modified repo names, this patch modify the "master" for "main" name repo and remove olds versions of u-root and use new tags Change-Id: Iabc345cf7d233a94b49650cfec386978e70b655a Signed-off-by: RatatouilleDummie <ratatouillemorde(a)gmail.com> --- M payloads/external/LinuxBoot/Kconfig 1 file changed, 16 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/63342/1 diff --git a/payloads/external/LinuxBoot/Kconfig b/payloads/external/LinuxBoot/Kconfig index a1e4e1f..ad9f795 100644 --- a/payloads/external/LinuxBoot/Kconfig +++ b/payloads/external/LinuxBoot/Kconfig @@ -184,19 +184,22 @@ help choose a custom u-root branch -config LINUXBOOT_UROOT_MASTER - bool "master" +config LINUXBOOT_UROOT_MAIN + bool "main" help Latest u-root version -config LINUXBOOT_UROOT_V3_0_0 - bool "v3.0.0" +config LINUXBOOT_UROOT_V7_0_0 + bool "v7.0.0" -config LINUXBOOT_UROOT_V2_0_0 - bool "v2.0.0" +config LINUXBOOT_UROOT_V6_0_0 + bool "v6.0.0" -config LINUXBOOT_UROOT_V1_0_0 - bool "v1.0.0" +config LINUXBOOT_UROOT_V5_0_0 + bool "v5.0.0" + +config LINUXBOOT_UROOT_V4_0_0 + bool "v4.0.0" endchoice @@ -207,10 +210,11 @@ config LINUXBOOT_UROOT_VERSION string default LINUXBOOT_UROOT_CHECKOUT if LINUXBOOT_UROOT_CUSTOM - default "master" if LINUXBOOT_UROOT_MASTER - default "v3.0.0" if LINUXBOOT_UROOT_V3_0_0 - default "v2.0.0" if LINUXBOOT_UROOT_V2_0_0 - default "v1.0.0" if LINUXBOOT_UROOT_V1_0_0 + default "main" if LINUXBOOT_UROOT_MAIN + default "v7.0.0" if LINUXBOOT_UROOT_v7_0_0 + default "v6.0.0" if LINUXBOOT_UROOT_V6_0_0 + default "v5.0.0" if LINUXBOOT_UROOT_V5_0_0 + default "v4.0.0" if LINUXBOOT_UROOT_V4_0_0 choice prompt "Build format" -- To view, visit https://review.coreboot.org/c/coreboot/+/63342 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iabc345cf7d233a94b49650cfec386978e70b655a Gerrit-Change-Number: 63342 Gerrit-PatchSet: 1 Gerrit-Owner: Name of user not set #1004172 Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel/common: register generic LPC resources
by Angel Pons (Code Review) 03 Apr '22

03 Apr '22

Attention is currently required from: Felix Singer, Nico Huber, Michał Żygowski, Paul Menzel, Michał Kopeć, Tim Wawrzynczak, Michael Niewöhner, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63341 ) Change subject: soc/intel/common: register generic LPC resources ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Patchset: PS2: I haven't read the datasheets File src/soc/intel/common/block/lpc/lpc.c: https://review.coreboot.org/c/coreboot/+/63341/comment/351cea45_fd0c7bd6 PS2, Line 54: nit: drop blank line -- To view, visit https://review.coreboot.org/c/coreboot/+/63341 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9f45b38498390016f841ab1d70c8438496dc857e Gerrit-Change-Number: 63341 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 03 Apr 2022 21:59:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/acpi: Add SPC0 and GPC0 methods
by Sean Rhodes (Code Review) 03 Apr '22

03 Apr '22

Sean Rhodes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/63143 ) Change subject: soc/intel/common/acpi: Add SPC0 and GPC0 methods ...................................................................... Abandoned Not needed -- To view, visit https://review.coreboot.org/c/coreboot/+/63143 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I435f1e5e1be716a6e8a3c330aa67510c18a458d8 Gerrit-Change-Number: 63143 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: drivers/efi: Add EFI variable store option support
by Angel Pons (Code Review) 03 Apr '22

03 Apr '22

Attention is currently required from: Sean Rhodes, Martin Roth, Patrick Rudolph, Matt DeVillier, Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52564 ) Change subject: drivers/efi: Add EFI variable store option support ...................................................................... Patch Set 10: (2 comments) File src/drivers/efi/efivars.c: https://review.coreboot.org/c/coreboot/+/52564/comment/bbbabd12_f6714d7b PS10, Line 75: WA > W=WCHAR […] rdev_strcmp_wchar_ascii I guess? I've never seen `WA` in this context before. https://review.coreboot.org/c/coreboot/+/52564/comment/86aa5763_5345c48f PS10, Line 271: void * > The third argument of walk_variables has the function prototype: […] Ah, I see. This could be a pointer to something else, e.g. if the `find_and_copy()` function is used. -- To view, visit https://review.coreboot.org/c/coreboot/+/52564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8079f71d29da5dc2db956fc68bef1486fe3906bb Gerrit-Change-Number: 52564 Gerrit-PatchSet: 10 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: Patrick Rudolph Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 03 Apr 2022 21:29:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/efi: Add EFI variable store option support
by Angel Pons (Code Review) 03 Apr '22

03 Apr '22

Attention is currently required from: Sean Rhodes, Martin Roth, Patrick Rudolph, Matt DeVillier, Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52564 ) Change subject: drivers/efi: Add EFI variable store option support ...................................................................... Patch Set 10: (1 comment) File src/drivers/efi/Kconfig: https://review.coreboot.org/c/coreboot/+/52564/comment/054db11f_3443d85a PS10, Line 1: DRIVERS_EFI_VARIABLE_STORE > yes, it needs to bind against UDK as the Makefile.inc sets the header include directory. […] Including multiple UDK could result in conflicts. I meant including directly as in specifying the full path to the edk2 headers. However, if those edk2 headers chain-include more headers, they may not be found in the include path... -- To view, visit https://review.coreboot.org/c/coreboot/+/52564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8079f71d29da5dc2db956fc68bef1486fe3906bb Gerrit-Change-Number: 52564 Gerrit-PatchSet: 10 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: Patrick Rudolph Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 03 Apr 2022 21:25:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/acpi/acpigen_usb.c: Fix False Memory leak error
by Angel Pons (Code Review) 03 Apr '22

03 Apr '22

Attention is currently required from: Felix Singer, Nico Huber, Tim Wawrzynczak, Paul Menzel, vaibhav. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62968 ) Change subject: src/acpi/acpigen_usb.c: Fix False Memory leak error ...................................................................... Patch Set 2: (1 comment) File src/acpi/acpigen_usb.c: https://review.coreboot.org/c/coreboot/+/62968/comment/400603fb_a8dc1e19 PS2, Line 92: #ifdef __clang_analyzer__ : free(fresh); : #endif > Hmm, right now we do not have any instances of this in the code I can found, other than vendorcode, […] I think scan-build is just stupid. The `acpi_dp_add_reference()` function stores a copy of the pointer, so it does not leak *here*. Strictly speaking, the memory actually leaks if the pointer doesn't get freed once the acpi_dp_* stuff no longer needs it. I guess one way to handle this could be to move the `strdup()` call inside the acpi_dp_* functions, and free all the pointers after they're no longer needed. -- To view, visit https://review.coreboot.org/c/coreboot/+/62968 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifed611bd0b9c1da3678386bff33bca3eac0311b4 Gerrit-Change-Number: 62968 Gerrit-PatchSet: 2 Gerrit-Owner: vaibhav <vrockz747(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: vaibhav <vrockz747(a)gmail.com> Gerrit-Comment-Date: Sun, 03 Apr 2022 21:23:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/starlabs/lite: Add Lite Mk IV variant
by Sean Rhodes (Code Review) 03 Apr '22

03 Apr '22

Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62706 ) Change subject: mb/starlabs/lite: Add Lite Mk IV variant ...................................................................... Patch Set 19: (2 comments) File src/mainboard/starlabs/lite/variants/glkr/devicetree.cb: https://review.coreboot.org/c/coreboot/+/62706/comment/26d78b06_4e10320d PS18, Line 6: # Graphics : # TODO: : # register "panel_cfg" = "{ : # .up_delay_ms = 0, // T3 : # .backlight_on_delay_ms = 0, // T7 : # .backlight_off_delay_ms = 0, // T9 : # .down_delay_ms = 0, // T10 : # .cycle_delay_ms = 500, // T12 : # .backlight_pwm_hz = 200, // PWM : # }" > Ah, there's CB:31611 if you're interested in libgfxinit Thanks, will pick it up once APL is done - I think there's only a couple of bugs left. https://review.coreboot.org/c/coreboot/+/62706/comment/3d54ca30_7b770a74 PS18, Line 36: : register "pcie_rp_clkreq_pin[0]" = "CLKREQ_DISABLED" : register "pcie_rp_clkreq_pin[1]" = "CLKREQ_DISABLED" : register "pcie_rp_clkreq_pin[2]" = "CLKREQ_DISABLED" : register "pcie_rp_clkreq_pin[3]" = "CLKREQ_DISABLED" : register "pcie_rp_clkreq_pin[4]" = "CLKREQ_DISABLED" : register "pcie_rp_clkreq_pin[5]" = "CLKREQ_DISABLED" : : register "pcie_rp_deemphasis_enable[0]" = "1" : register "pcie_rp_deemphasis_enable[1]" = "1" : register "pcie_rp_deemphasis_enable[2]" = "1" : register "pcie_rp_deemphasis_enable[3]" = "1" : register "pcie_rp_deemphasis_enable[4]" = "1" : register "pcie_rp_deemphasis_enable[5]" = "1" > According to FSP debug, FSP is stupid. Ah that made me giggle :) -- To view, visit https://review.coreboot.org/c/coreboot/+/62706 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id1cf2846a139004e9bec7bb27e9afe07b7e6f64f Gerrit-Change-Number: 62706 Gerrit-PatchSet: 19 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sun, 03 Apr 2022 21:18:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/starlabs/lite: Add Lite Mk IV variant
by Angel Pons (Code Review) 03 Apr '22

03 Apr '22

Attention is currently required from: Sean Rhodes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62706 ) Change subject: mb/starlabs/lite: Add Lite Mk IV variant ...................................................................... Patch Set 19: Code-Review+2 (2 comments) File src/mainboard/starlabs/lite/variants/glkr/devicetree.cb: https://review.coreboot.org/c/coreboot/+/62706/comment/a68ff5ce_a1866309 PS18, Line 6: # Graphics : # TODO: : # register "panel_cfg" = "{ : # .up_delay_ms = 0, // T3 : # .backlight_on_delay_ms = 0, // T7 : # .backlight_off_delay_ms = 0, // T9 : # .down_delay_ms = 0, // T10 : # .cycle_delay_ms = 500, // T12 : # .backlight_pwm_hz = 200, // PWM : # }" > Make libgfxinit work with GLK(R). Seeing as they all use the Broxton vbt, should be easy. Ah, there's CB:31611 if you're interested in libgfxinit https://review.coreboot.org/c/coreboot/+/62706/comment/0d3242c4_6bd20849 PS18, Line 36: : register "pcie_rp_clkreq_pin[0]" = "CLKREQ_DISABLED" : register "pcie_rp_clkreq_pin[1]" = "CLKREQ_DISABLED" : register "pcie_rp_clkreq_pin[2]" = "CLKREQ_DISABLED" : register "pcie_rp_clkreq_pin[3]" = "CLKREQ_DISABLED" : register "pcie_rp_clkreq_pin[4]" = "CLKREQ_DISABLED" : register "pcie_rp_clkreq_pin[5]" = "CLKREQ_DISABLED" : : register "pcie_rp_deemphasis_enable[0]" = "1" : register "pcie_rp_deemphasis_enable[1]" = "1" : register "pcie_rp_deemphasis_enable[2]" = "1" : register "pcie_rp_deemphasis_enable[3]" = "1" : register "pcie_rp_deemphasis_enable[4]" = "1" : register "pcie_rp_deemphasis_enable[5]" = "1" > According to FSP debug, still needed. According to FSP debug, FSP is stupid. -- To view, visit https://review.coreboot.org/c/coreboot/+/62706 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id1cf2846a139004e9bec7bb27e9afe07b7e6f64f Gerrit-Change-Number: 62706 Gerrit-PatchSet: 19 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Sun, 03 Apr 2022 21:14:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/wifi/generic/acpi.c: NULL-check pointers before dereferencing
by Felix Singer (Code Review) 03 Apr '22

03 Apr '22

Attention is currently required from: Tim Wawrzynczak, Angel Pons, Felix Held. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63340 ) Change subject: drivers/wifi/generic/acpi.c: NULL-check pointers before dereferencing ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63340 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3fbc9565e7e9b4e1c14a68f6a5fd779577045236 Gerrit-Change-Number: 63340 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 03 Apr 2022 20:50:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2022