coreboot-gerrit April 2022

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

Change in coreboot[master]: amdfwtool: Add a flag to record the second gen instead of romsig
by build bot (Jenkins) (Code Review) 04 Apr '22

04 Apr '22

Attention is currently required from: Zheng Bao. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63344 ) Change subject: amdfwtool: Add a flag to record the second gen instead of romsig ...................................................................... Patch Set 1: (2 comments) File util/amdfwtool/amdfwtool.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145316): https://review.coreboot.org/c/coreboot/+/63344/comment/faae0b57_035d84b1 PS1, Line 1481: break; break is not useful after a goto or return Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145316): https://review.coreboot.org/c/coreboot/+/63344/comment/e5f22e7a_2f21f420 PS1, Line 1487: break; break is not useful after a goto or return -- To view, visit https://review.coreboot.org/c/coreboot/+/63344 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id50311034b46aa1791dcc10b107de4af6c86b927 Gerrit-Change-Number: 63344 Gerrit-PatchSet: 1 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Zheng Bao Gerrit-Comment-Date: Mon, 04 Apr 2022 03:14:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: amdfwtool: Add a flag to record the second gen instead of romsig
by Bao Zheng (Code Review) 04 Apr '22

04 Apr '22

Attention is currently required from: Zheng Bao. Hello Zheng Bao, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/63344 to review the following change. Change subject: amdfwtool: Add a flag to record the second gen instead of romsig ...................................................................... amdfwtool: Add a flag to record the second gen instead of romsig This is for future feature combo, which gets the soc id from fw.cfg in a loop instead of the command line, and the romsig is not set until fw.cfg is processed. Change-Id: Id50311034b46aa1791dcc10b107de4af6c86b927 Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- M util/amdfwtool/amdfwtool.c M util/amdfwtool/amdfwtool.h 2 files changed, 25 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/63344/1 diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c index 23273e6..4d23a75 100644 --- a/util/amdfwtool/amdfwtool.c +++ b/util/amdfwtool/amdfwtool.c @@ -1471,6 +1471,27 @@ return false; } +static bool is_second_gen(enum platform platform_type) +{ + switch (platform_type) { + case PLATFORM_STONEYRIDGE: + case PLATFORM_RAVEN: + case PLATFORM_PICASSO: + return false; + break; + case PLATFORM_RENOIR: + case PLATFORM_LUCIENNE: + case PLATFORM_CEZANNE: + case PLATFORM_SABRINA: + return true; + break; + case PLATFORM_UNKNOWN: + default: + fprintf(stderr, "Error: Invalid SOC name.\n\n"); + return false; + } +} + int main(int argc, char **argv) { int c; @@ -1702,6 +1723,8 @@ } } + cb_config.second_gen = is_second_gen(soc_id) ? EFS_SECOND_GEN : EFS_BEFORE_SECOND_GEN; + if (needs_ish(soc_id)) cb_config.need_ish = true; @@ -1822,7 +1845,7 @@ if (cb_config.need_ish) ctx.address_mode = ADDRESS_MODE_2_REL_TAB; - else if (amd_romsig->efs_gen.gen == EFS_SECOND_GEN) + else if (cb_config.second_gen == EFS_SECOND_GEN) ctx.address_mode = ADDRESS_MODE_1_REL_BIOS; else ctx.address_mode = ADDRESS_MODE_0_PHY; diff --git a/util/amdfwtool/amdfwtool.h b/util/amdfwtool/amdfwtool.h index 3af4e94..936ef14 100644 --- a/util/amdfwtool/amdfwtool.h +++ b/util/amdfwtool/amdfwtool.h @@ -276,6 +276,7 @@ bool load_mp2_fw; bool multi_level; bool s0i3; + uint8_t second_gen; bool have_mb_spl; bool recovery_ab; bool need_ish; -- To view, visit https://review.coreboot.org/c/coreboot/+/63344 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id50311034b46aa1791dcc10b107de4af6c86b927 Gerrit-Change-Number: 63344 Gerrit-PatchSet: 1 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Attention: Zheng Bao Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/intel/adlrvp: Disable PM Timer for ADL-N
by Reka Norman (Code Review) 04 Apr '22

04 Apr '22

Attention is currently required from: V Sowmya, Kangheui Won, Maulik V Vaghela, Rizwan Qureshi, Krishna P Bhat D, Usha P. Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62915 ) Change subject: mb/intel/adlrvp: Disable PM Timer for ADL-N ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62915/comment/8adb095b_89fbc39d PS3, Line 9: Keeping the PM timer enabled will disqualify an ADL system from entering > Is this a problem only for rvp or does it apply for all ADL-N platforms? We already have it disabled for all brya variants including nivviks and nereid. But what about the other adlrvp variants? -- To view, visit https://review.coreboot.org/c/coreboot/+/62915 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I44651bf55df8e71a0a5a9a33ecbb8322ecd18575 Gerrit-Change-Number: 62915 Gerrit-PatchSet: 3 Gerrit-Owner: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-Comment-Date: Mon, 04 Apr 2022 02:51:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kangheui Won <khwon(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: amdfwtool: Add a macro to set explicitly second gen for old SOCs
by Bao Zheng (Code Review) 04 Apr '22

04 Apr '22

Attention is currently required from: Zheng Bao, Felix Held. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63319 ) Change subject: amdfwtool: Add a macro to set explicitly second gen for old SOCs ...................................................................... Patch Set 2: (1 comment) File util/amdfwtool/amdfwtool.c: https://review.coreboot.org/c/coreboot/+/63319/comment/34cc58de_145bccf4 PS1, Line 1808: amd_romsig->efs_gen.reserved = 0; > i wonder if this should also be moved inside the set_efs_table function and if that should also be s […] done. -- To view, visit https://review.coreboot.org/c/coreboot/+/63319 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I65caa11e835d2ff52bec4b8904057bbced434891 Gerrit-Change-Number: 63319 Gerrit-PatchSet: 2 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Zheng Bao Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 04 Apr 2022 02:48:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: amdfwtool: Add a macro to set explicitly second gen for old SOCs
by Bao Zheng (Code Review) 04 Apr '22

04 Apr '22

Attention is currently required from: Bao Zheng, Zheng Bao. Hello build bot (Jenkins), Angel Pons, Zheng Bao, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63319 to look at the new patch set (#2). Change subject: amdfwtool: Add a macro to set explicitly second gen for old SOCs ...................................................................... amdfwtool: Add a macro to set explicitly second gen for old SOCs It is more reasonable than getting the value from memset. For the reserved bits, keep them as they were for old SOCs. Change-Id: I65caa11e835d2ff52bec4b8904057bbced434891 Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- M util/amdfwtool/amdfwtool.c M util/amdfwtool/amdfwtool.h 2 files changed, 6 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/63319/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63319 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I65caa11e835d2ff52bec4b8904057bbced434891 Gerrit-Change-Number: 63319 Gerrit-PatchSet: 2 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/common/tcss: Check conn device enabled in tcss_get_port_info
by Reka Norman (Code Review) 04 Apr '22

04 Apr '22

Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63237 ) Change subject: soc/intel/common/tcss: Check conn device enabled in tcss_get_port_info ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > That's it, thanks! 😊 http://b/227965720 -- To view, visit https://review.coreboot.org/c/coreboot/+/63237 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I487f3ca4be4ead0c5dfb46e9eb19de5ae9b9bda9 Gerrit-Change-Number: 63237 Gerrit-PatchSet: 3 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Reka Norman <rekanorman(a)google.com> Gerrit-Comment-Date: Mon, 04 Apr 2022 01:53:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Reka Norman <rekanorman(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlrvp: Disable PM Timer for ADL-N
by Kangheui Won (Code Review) 04 Apr '22

04 Apr '22

Attention is currently required from: V Sowmya, Maulik V Vaghela, Reka Norman, Rizwan Qureshi, Krishna P Bhat D, Usha P. Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62915 ) Change subject: mb/intel/adlrvp: Disable PM Timer for ADL-N ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62915/comment/d5ca4c07_67a6db86 PS3, Line 9: Keeping the PM timer enabled will disqualify an ADL system from entering Is this a problem only for rvp or does it apply for all ADL-N platforms? -- To view, visit https://review.coreboot.org/c/coreboot/+/62915 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I44651bf55df8e71a0a5a9a33ecbb8322ecd18575 Gerrit-Change-Number: 62915 Gerrit-PatchSet: 3 Gerrit-Owner: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-Comment-Date: Mon, 04 Apr 2022 00:10:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads/LinuxBoot: Fix u-root branch
by Felix Singer (Code Review) 04 Apr '22

04 Apr '22

Attention is currently required from: Arthur Heymans, Martin Roth, Stefan Reinauer, Christian Walter, Angel Pons. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62590 ) Change subject: payloads/LinuxBoot: Fix u-root branch ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File payloads/external/LinuxBoot/Kconfig: https://review.coreboot.org/c/coreboot/+/62590/comment/6368d4bd_8a9fd2d7 PS1, Line 188: master > Also rename this? ping -- To view, visit https://review.coreboot.org/c/coreboot/+/62590 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I384ba66289a49bf226b505615bd16bdf85612c1a Gerrit-Change-Number: 62590 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 04 Apr 2022 00:01:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads/external/LinuxBoot: Update U-Root configs
by Name of user not set (Code Review) 03 Apr '22

03 Apr '22

Attention is currently required from: Martin Roth, Christian Walter, Stefan Reinauer. Hello Martin Roth, Stefan Reinauer, Christian Walter, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63343 to look at the new patch set (#2). Change subject: payloads/external/LinuxBoot: Update U-Root configs ...................................................................... payloads/external/LinuxBoot: Update U-Root configs Update U-roots configs in Kconfig file Change-Id: I2c0910b1f4bd1b13b2c7bb550e722b58ffdba06f Signed-off-by: RatatouilleDummie <ratatouillemorde(a)gmail.com> --- M payloads/external/LinuxBoot/Kconfig 1 file changed, 9 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/63343/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63343 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2c0910b1f4bd1b13b2c7bb550e722b58ffdba06f Gerrit-Change-Number: 63343 Gerrit-PatchSet: 2 Gerrit-Owner: Name of user not set #1004172 Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: payloads/external/LinuxBoot: Update U-Root configs
by Name of user not set (Code Review) 03 Apr '22

03 Apr '22

Name of user not set #1004172 has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63343 ) Change subject: payloads/external/LinuxBoot: Update U-Root configs ...................................................................... payloads/external/LinuxBoot: Update U-Root configs Update U-roots configs in Kconfig file Change-Id: I2c0910b1f4bd1b13b2c7bb550e722b58ffdba06f Signed-off-by: RatatouilleDummie <ratatouillemorde(a)gmail.com> --- M payloads/external/LinuxBoot/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/63343/1 diff --git a/payloads/external/LinuxBoot/Kconfig b/payloads/external/LinuxBoot/Kconfig index ad9f795..58a78be 100644 --- a/payloads/external/LinuxBoot/Kconfig +++ b/payloads/external/LinuxBoot/Kconfig @@ -177,7 +177,7 @@ choice prompt "U-root version" - default LINUXBOOT_UROOT_MASTER + default LINUXBOOT_UROOT_MAIN config LINUXBOOT_UROOT_CUSTOM bool "custom" @@ -211,7 +211,7 @@ string default LINUXBOOT_UROOT_CHECKOUT if LINUXBOOT_UROOT_CUSTOM default "main" if LINUXBOOT_UROOT_MAIN - default "v7.0.0" if LINUXBOOT_UROOT_v7_0_0 + default "v7.0.0" if LINUXBOOT_UROOT_V7_0_0 default "v6.0.0" if LINUXBOOT_UROOT_V6_0_0 default "v5.0.0" if LINUXBOOT_UROOT_V5_0_0 default "v4.0.0" if LINUXBOOT_UROOT_V4_0_0 -- To view, visit https://review.coreboot.org/c/coreboot/+/63343 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2c0910b1f4bd1b13b2c7bb550e722b58ffdba06f Gerrit-Change-Number: 63343 Gerrit-PatchSet: 1 Gerrit-Owner: Name of user not set #1004172 Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2022