coreboot-gerrit April 2022

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

Change in coreboot[master]: mb/emulation/qemu-q35: Support PARALLEL_MP with SMM_ASEG
by Arthur Heymans (Code Review) 07 Apr '22

07 Apr '22

Attention is currently required from: Arthur Heymans, Kyösti Mälkki. Arthur Heymans has uploaded a new patch set (#5) to the change originally created by Kyösti Mälkki. ( https://review.coreboot.org/c/coreboot/+/61494 ) Change subject: mb/emulation/qemu-q35: Support PARALLEL_MP with SMM_ASEG ...................................................................... mb/emulation/qemu-q35: Support PARALLEL_MP with SMM_ASEG Tested with SMI_DEBUG: SMM prints things on the console. Change-Id: I7db55aaabd16a6ef585c4802218790bf04650b13 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/cpu/qemu-x86/Kconfig M src/mainboard/emulation/qemu-i440fx/northbridge.c M src/mainboard/emulation/qemu-q35/cpu.c 3 files changed, 34 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/61494/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/61494 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7db55aaabd16a6ef585c4802218790bf04650b13 Gerrit-Change-Number: 61494 Gerrit-PatchSet: 5 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: cpu/qemu-x86: Allow up to 255 cores
by Arthur Heymans (Code Review) 07 Apr '22

07 Apr '22

Arthur Heymans has uploaded a new patch set (#3). ( https://review.coreboot.org/c/coreboot/+/63483 ) Change subject: cpu/qemu-x86: Allow up to 255 cores ...................................................................... cpu/qemu-x86: Allow up to 255 cores Qemu does not support more than 255 cores. "qemu-system-x86_64: apic initialization failed. APIC ID 255 is invalid" is being logged when attempted. Change-Id: I9eea91fb09f47de8b06de9fa7eb2ad66ef4dc7e2 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/qemu-x86/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/63483/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/63483 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9eea91fb09f47de8b06de9fa7eb2ad66ef4dc7e2 Gerrit-Change-Number: 63483 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: arch/x86/smbios.c: Fix for CONFIG_MAX_CPUS > 255
by Arthur Heymans (Code Review) 07 Apr '22

07 Apr '22

Arthur Heymans has uploaded a new patch set (#3). ( https://review.coreboot.org/c/coreboot/+/63482 ) Change subject: arch/x86/smbios.c: Fix for CONFIG_MAX_CPUS > 255 ...................................................................... arch/x86/smbios.c: Fix for CONFIG_MAX_CPUS > 255 Change-Id: I079c99006fea95ba3dc2fb02c95a3747af55e218 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/arch/x86/smbios.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/63482/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/63482 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I079c99006fea95ba3dc2fb02c95a3747af55e218 Gerrit-Change-Number: 63482 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: cpu/x86/smm_module_loader: Update logging
by Arthur Heymans (Code Review) 07 Apr '22

07 Apr '22

Arthur Heymans has uploaded a new patch set (#3). ( https://review.coreboot.org/c/coreboot/+/63481 ) Change subject: cpu/x86/smm_module_loader: Update logging ...................................................................... cpu/x86/smm_module_loader: Update logging Some logging is superfluous and logging that code is being copied is 'SPEW' level. Change-Id: I84d49a394cc53d78f1e1d3936502ac16810daf9f Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/x86/smm/smm_module_loader.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/63481/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/63481 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I84d49a394cc53d78f1e1d3936502ac16810daf9f Gerrit-Change-Number: 63481 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: cpu/x86/smm_module_loader: Drop superfluous check
by Arthur Heymans (Code Review) 07 Apr '22

07 Apr '22

Arthur Heymans has uploaded a new patch set (#3). ( https://review.coreboot.org/c/coreboot/+/63480 ) Change subject: cpu/x86/smm_module_loader: Drop superfluous check ...................................................................... cpu/x86/smm_module_loader: Drop superfluous check Checking if the stack encroaches on the entry points is done in other parts of the code. Change-Id: I275d5dda9c69cc89608450ae27dd5dbd581e3595 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/x86/smm/smm_module_loader.c 1 file changed, 3 insertions(+), 21 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/63480/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/63480 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I275d5dda9c69cc89608450ae27dd5dbd581e3595 Gerrit-Change-Number: 63480 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: cpu/x86/mp_init.c: Drop 'real' vs 'used' save state
by Arthur Heymans (Code Review) 07 Apr '22

07 Apr '22

Arthur Heymans has uploaded a new patch set (#3). ( https://review.coreboot.org/c/coreboot/+/63479 ) Change subject: cpu/x86/mp_init.c: Drop 'real' vs 'used' save state ...................................................................... cpu/x86/mp_init.c: Drop 'real' vs 'used' save state Now that the save state size is handled properly inside the smm_loader there is no reason to make that distinction in the mp_init code anymore. Change-Id: Ia0002a33b6d0f792d8d78cf625fd7e830e3e50fc Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/x86/mp_init.c M src/cpu/x86/smm/smm_module_loader.c M src/include/cpu/x86/smm.h 3 files changed, 14 insertions(+), 40 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/63479/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/63479 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia0002a33b6d0f792d8d78cf625fd7e830e3e50fc Gerrit-Change-Number: 63479 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: cpu/x86/smm_module_load: Rewrite setup_stub
by Arthur Heymans (Code Review) 07 Apr '22

07 Apr '22

Arthur Heymans has uploaded a new patch set (#3). ( https://review.coreboot.org/c/coreboot/+/63478 ) Change subject: cpu/x86/smm_module_load: Rewrite setup_stub ...................................................................... cpu/x86/smm_module_load: Rewrite setup_stub This code was hard to read as it did too much and had a lot of state to keep track of. It also looks like the staggered entry points were first copied and only later the parameters of the first stub where filled it. This effectively fixes SMM on all but CPU0! Change-Id: I42ef9d6a30f3039f25e2cde975086a1365ca4182 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/x86/smm/smm_module_loader.c 1 file changed, 21 insertions(+), 71 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/63478/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/63478 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I42ef9d6a30f3039f25e2cde975086a1365ca4182 Gerrit-Change-Number: 63478 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/emulation/qemu-q35: Support PARALLEL_MP with SMM_ASEG
by Arthur Heymans (Code Review) 07 Apr '22

07 Apr '22

Attention is currently required from: Arthur Heymans, Kyösti Mälkki. Arthur Heymans has uploaded a new patch set (#4) to the change originally created by Kyösti Mälkki. ( https://review.coreboot.org/c/coreboot/+/61494 ) Change subject: mb/emulation/qemu-q35: Support PARALLEL_MP with SMM_ASEG ...................................................................... mb/emulation/qemu-q35: Support PARALLEL_MP with SMM_ASEG Tested with SMI_DEBUG: SMM prints things on the console. Change-Id: I7db55aaabd16a6ef585c4802218790bf04650b13 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/cpu/qemu-x86/Kconfig M src/mainboard/emulation/qemu-i440fx/northbridge.c M src/mainboard/emulation/qemu-q35/cpu.c 3 files changed, 34 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/61494/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/61494 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7db55aaabd16a6ef585c4802218790bf04650b13 Gerrit-Change-Number: 61494 Gerrit-PatchSet: 4 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: cpu/x86/smm_module_loader.c: Rewrite setup more purely function
by Arthur Heymans (Code Review) 07 Apr '22

07 Apr '22

Arthur Heymans has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/63475 ) Change subject: cpu/x86/smm_module_loader.c: Rewrite setup more purely function ...................................................................... cpu/x86/smm_module_loader.c: Rewrite setup more purely function It's much easier to read code if you don't need to keep track of the state of a function, so rewrite it in mostly pure functional code. Change-Id: I310a232ced2ab15064bff99a39a26f745239f6b9 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/x86/smm/smm_module_loader.c 1 file changed, 117 insertions(+), 164 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/63475/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63475 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I310a232ced2ab15064bff99a39a26f745239f6b9 Gerrit-Change-Number: 63475 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: cpu/x86/smm_module_loader.c: Rewrite setup more purely function
by build bot (Jenkins) (Code Review) 07 Apr '22

07 Apr '22

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63475 ) Change subject: cpu/x86/smm_module_loader.c: Rewrite setup more purely function ...................................................................... Patch Set 1: (8 comments) File src/cpu/x86/smm/smm_module_loader.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145792): https://review.coreboot.org/c/coreboot/+/63475/comment/a0ef45a6_5e002d05 PS1, Line 468: const uintptr_t handler_base = ALIGN_DOWN(fx_save_area_base - handler_size, handler_alignment); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145792): https://review.coreboot.org/c/coreboot/+/63475/comment/bc3917e0_aadf2b1d PS1, Line 469: printk(BIOS_DEBUG, "smihandler [0x%lx-0x%lx[\n", handler_base, handler_base + handler_size); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145792): https://review.coreboot.org/c/coreboot/+/63475/comment/dbf338b0_ac8ba0d7 PS1, Line 515: return smm_module_setup_stub(stub_segment_base, smram_size, params, (void *)fx_save_area_base); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145792): https://review.coreboot.org/c/coreboot/+/63475/comment/1933f0ed_ad94f267 PS1, Line 561: const uintptr_t save_state_bottom = cpus[params->num_concurrent_save_states - 1].ss_start; line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145792): https://review.coreboot.org/c/coreboot/+/63475/comment/c7c970f4_d155776a PS1, Line 569: printk(BIOS_ERR, "fxsave wont fit in smram\n"); 'wont' may be misspelled - perhaps 'won't'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145792): https://review.coreboot.org/c/coreboot/+/63475/comment/2fef056b_8a1e8dbc PS1, Line 574: const size_t bottom_space = cpus[params->num_concurrent_save_states - 1].code_start - smm_stack_top; line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145792): https://review.coreboot.org/c/coreboot/+/63475/comment/4642e83d_39389172 PS1, Line 583: printk(BIOS_ERR, "handler wont fit in top of smram\n"); 'wont' may be misspelled - perhaps 'won't'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145792): https://review.coreboot.org/c/coreboot/+/63475/comment/4ca6a36c_1f43fc96 PS1, Line 590: printk(BIOS_ERR, "handler wont fit in bottom of smram\n"); 'wont' may be misspelled - perhaps 'won't'? -- To view, visit https://review.coreboot.org/c/coreboot/+/63475 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I310a232ced2ab15064bff99a39a26f745239f6b9 Gerrit-Change-Number: 63475 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 07 Apr 2022 20:18:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2022