coreboot-gerrit April 2022

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

Change in coreboot[master]: lib: Treat dimm addr_map 0 as not exist
by Frank Wu (Code Review) 14 Apr '22

14 Apr '22

Attention is currently required from: Jakub Czapiga, Tim Wawrzynczak, Ivy Jian, Eric Lai, Lean Sheng Tan. Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63628 ) Change subject: lib: Treat dimm addr_map 0 as not exist ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Patchset: PS5: Here is the positive result: https://partnerissuetracker.corp.google.com/issues/213964936#comment47 -- To view, visit https://review.coreboot.org/c/coreboot/+/63628 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2ada0109eb0805174cb85d4ce373e2a3ab7dbcac Gerrit-Change-Number: 63628 Gerrit-PatchSet: 5 Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Thu, 14 Apr 2022 08:42:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/cmn/fast_spi: Use tab instead space
by Lean Sheng Tan (Code Review) 14 Apr '22

14 Apr '22

Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Angel Pons, Arthur Heymans, Felix Held. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63623 ) Change subject: soc/intel/cmn/fast_spi: Use tab instead space ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I56bcd263c6a5c0036e459926a25538e3448fbce6 Gerrit-Change-Number: 63623 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 14 Apr 2022 08:36:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brask/variants/moli: use specific VBT files
by Raihow Shi (Code Review) 14 Apr '22

14 Apr '22

Attention is currently required from: YH Lin, Paul Menzel, Felix Held. Hello build bot (Jenkins), YH Lin, Tim Wawrzynczak, Zhuohao Lee, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63604 to look at the new patch set (#10). Change subject: mb/google/brask/variants/moli: use specific VBT files ...................................................................... mb/google/brask/variants/moli: use specific VBT files Use specific VBTs for HDMI,DP,and ABSENT according to FW_CONFIG. TEST=emerge-brask coreboot. Signed-off-by: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Change-Id: Icc8fbef1467605505459fce264697f670591c81e --- M src/mainboard/google/brya/variants/moli/ramstage.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/63604/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/63604 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icc8fbef1467605505459fce264697f670591c81e Gerrit-Change-Number: 63604 Gerrit-PatchSet: 10 Gerrit-Owner: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/common/{sa, adl}: Add `finalize` operation for systemagent
by Lean Sheng Tan (Code Review) 14 Apr '22

14 Apr '22

Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Nick Vaccaro, Angel Pons, Arthur Heymans, Eric Lai. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63518 ) Change subject: soc/intel/common/{sa, adl}: Add `finalize` operation for systemagent ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/63518 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd464d2507393ed0c746eb1fbd10e36092ed5599 Gerrit-Change-Number: 63518 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Thu, 14 Apr 2022 08:35:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lib: Treat dimm addr_map 0 as not exist
by Eric Lai (Code Review) 14 Apr '22

14 Apr '22

Attention is currently required from: Jakub Czapiga, Tim Wawrzynczak, Ivy Jian. Hello Frank Wu, build bot (Jenkins), Jakub Czapiga, Subrata Banik, Tim Wawrzynczak, Ivy Jian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63628 to look at the new patch set (#3). Change subject: lib: Treat dimm addr_map 0 as not exist ...................................................................... lib: Treat dimm addr_map 0 as not exist Treat dimm addr_map 0 as not exist. addr_map default is 0, we don't set it if there no HW exist. Also change the test case default to avoid 0. SODIMM SMbus address 0x50 to 0x53 is common used. BUG=b:213964936 BRANCH=firmware-brya-14505.B TEST=emerge-brya coreboot chromeos-bootimage The MRC training does not be performed again after rebooting. Signed-off-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Change-Id: I2ada0109eb0805174cb85d4ce373e2a3ab7dbcac --- M src/lib/spd_cache.c M tests/lib/spd_cache-test.c 2 files changed, 9 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/63628/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/63628 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2ada0109eb0805174cb85d4ce373e2a3ab7dbcac Gerrit-Change-Number: 63628 Gerrit-PatchSet: 3 Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in qc_blobs[master]: sc7280/qtiseclib: Update qtiseclib blobs binaries and release notes
by Shelley Chen (Code Review) 14 Apr '22

14 Apr '22

Shelley Chen has submitted this change. ( https://review.coreboot.org/c/qc_blobs/+/63614 ) Change subject: sc7280/qtiseclib: Update qtiseclib blobs binaries and release notes ...................................................................... sc7280/qtiseclib: Update qtiseclib blobs binaries and release notes Signed-off-by: Saurabh Gorecha <quic_sgorecha(a)quicinc.com> Change-Id: I6c60c3642b272fbc57c90ad857044bf69b01fef0 --- D sc7280/qtiseclib/ReleaseNotes.txt A sc7280/qtiseclib/Release_Notes.txt M sc7280/qtiseclib/libqtisec.a 3 files changed, 66 insertions(+), 23 deletions(-) Approvals: Julius Werner: Verified Shelley Chen: Looks good to me, approved diff --git a/sc7280/qtiseclib/ReleaseNotes.txt b/sc7280/qtiseclib/ReleaseNotes.txt deleted file mode 100644 index 4bf9a52..0000000 --- a/sc7280/qtiseclib/ReleaseNotes.txt +++ /dev/null @@ -1,23 +0,0 @@ -=================== Release 00044 ================================ -This Release Notes file covers these blobs: - * libqtisec.a - -Version : 00044 - -Release Date : Aug 11, 2021 - -Changes since last version : - * XPU and NOC related improvement - * Low Power Mode Enablement -=================== Release 00033 ================================ -Version : 00033 -Release Date : March 30, 2021 -Supported Silicon : SC7280 -Library will be used for TF-A compilation for SC7280. -binary is passed as QTISECLIB_PATH=<path with filename of qtisec lib> in TF-A compilation -Changes since last version : -* Perform SoC SC7280 -* PSCI Initialization -* Interrupt registrartion and handling -Errata : Nothing to report - diff --git a/sc7280/qtiseclib/Release_Notes.txt b/sc7280/qtiseclib/Release_Notes.txt new file mode 100644 index 0000000..7f49b18 --- /dev/null +++ b/sc7280/qtiseclib/Release_Notes.txt @@ -0,0 +1,66 @@ +=================== Release 00061 ================================ +This Release Notes file covers these blobs: + * libqtisec.a + +Version : 00061 + +Release Date : Apr 14, 2022 + +Changes since last version : + * Modem Sand box change + * Static analysis fixes +=================== Release 00056 ================================ +This Release Notes file covers these blobs: + * libqtisec.a + +Version : 00056 + +Release Date : Feb 28, 2022 + +Changes since last version : + * NOC MaxDIV DCD enablement + * ac update +=================== Release 00050 ================================ +This Release Notes file covers these blobs: + * libqtisec.a + +Version : 00050 + +Release Date : Nov 24, 2021 + +Changes since last version : + * disabling L3 voting register for perf + * sysini update +=================== Release 00047 ================================ +This Release Notes file covers these blobs: + * libqtisec.a + +Version : 00047 + +Release Date : Sep 28, 2021 + +Changes since last version : + * WLAN Sandboxing + * Noc debug Improvement +=================== Release 00044 ================================ +This Release Notes file covers these blobs: + * libqtisec.a + +Version : 00044 + +Release Date : Aug 11, 2021 + +Changes since last version : + * XPU and NOC related improvement + * Low Power Mode Enablement +=================== Release 00033 ================================ +Version : 00033 +Release Date : March 30, 2021 +Supported Silicon : SC7280 +Library will be used for TF-A compilation for SC7280. +binary is passed as QTISECLIB_PATH=<path with filename of qtisec lib> in TF-A compilation +Changes since last version : +* Perform SoC SC7280 +* PSCI Initialization +* Interrupt registrartion and handling +Errata : Nothing to report diff --git a/sc7280/qtiseclib/libqtisec.a b/sc7280/qtiseclib/libqtisec.a index 3ba99b8..71a3b91 100644 --- a/sc7280/qtiseclib/libqtisec.a +++ b/sc7280/qtiseclib/libqtisec.a Binary files differ -- To view, visit https://review.coreboot.org/c/qc_blobs/+/63614 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: qc_blobs Gerrit-Branch: master Gerrit-Change-Id: I6c60c3642b272fbc57c90ad857044bf69b01fef0 Gerrit-Change-Number: 63614 Gerrit-PatchSet: 3 Gerrit-Owner: Saurabh Gorecha <quic_sgorecha(a)quicinc.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Ravi Kumar Bokka <rbokka(a)codeaurora.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-MessageType: merged

1 0

Change in qc_blobs[master]: sc7280/qtiseclib: Update qtiseclib blobs binaries and release notes
by Shelley Chen (Code Review) 14 Apr '22

14 Apr '22

Attention is currently required from: Saurabh Gorecha, Ravi Kumar Bokka, mturney mturney. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/qc_blobs/+/63614 ) Change subject: sc7280/qtiseclib: Update qtiseclib blobs binaries and release notes ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/qc_blobs/+/63614 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: qc_blobs Gerrit-Branch: master Gerrit-Change-Id: I6c60c3642b272fbc57c90ad857044bf69b01fef0 Gerrit-Change-Number: 63614 Gerrit-PatchSet: 3 Gerrit-Owner: Saurabh Gorecha <quic_sgorecha(a)quicinc.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Ravi Kumar Bokka <rbokka(a)codeaurora.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-Attention: Saurabh Gorecha <quic_sgorecha(a)quicinc.com> Gerrit-Attention: Ravi Kumar Bokka <rbokka(a)codeaurora.org> Gerrit-Attention: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-Comment-Date: Thu, 14 Apr 2022 08:29:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Add RFC how to handle UEFI variables
by Patrick Rudolph (Code Review) 14 Apr '22

14 Apr '22

Attention is currently required from: Angel Pons. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62015 ) Change subject: Documentation: Add RFC how to handle UEFI variables ...................................................................... Patch Set 8: (3 comments) File Documentation/RFC/efivars.md: https://review.coreboot.org/c/coreboot/+/62015/comment/caa0c673_1e249ec3 PS5, Line 7: d > remove `d` […] Done https://review.coreboot.org/c/coreboot/+/62015/comment/ee45e593_5050bde3 PS5, Line 12: priviledged > remove spurious `d` Done https://review.coreboot.org/c/coreboot/+/62015/comment/daf92c2d_e3ea70d8 PS5, Line 24: priviledges > remove spurious `d` Done -- To view, visit https://review.coreboot.org/c/coreboot/+/62015 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iddf43a9ff6bf25232fbe2aa8aae2e466e5514492 Gerrit-Change-Number: 62015 Gerrit-PatchSet: 8 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 14 Apr 2022 08:28:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lib: Treat dimm addr_map 0 as not exist
by Eric Lai (Code Review) 14 Apr '22

14 Apr '22

Attention is currently required from: Tim Wawrzynczak, Ivy Jian, Eric Lai. Hello Frank Wu, build bot (Jenkins), Subrata Banik, Tim Wawrzynczak, Ivy Jian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63628 to look at the new patch set (#2). Change subject: lib: Treat dimm addr_map 0 as not exist ...................................................................... lib: Treat dimm addr_map 0 as not exist Treat dimm addr_map 0 as not exist. addr_map default is 0, we don't set it if there no HW exist. BUG=b:213964936 BRANCH=firmware-brya-14505.B TEST=emerge-brya coreboot chromeos-bootimage The MRC training does not be performed again after rebooting. Signed-off-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Change-Id: I2ada0109eb0805174cb85d4ce373e2a3ab7dbcac --- M src/lib/spd_cache.c M tests/lib/spd_cache-test.c 2 files changed, 9 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/63628/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63628 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2ada0109eb0805174cb85d4ce373e2a3ab7dbcac Gerrit-Change-Number: 63628 Gerrit-PatchSet: 2 Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/var/banshee: add the smbus addr for dimm1
by Frank Wu (Code Review) 14 Apr '22

14 Apr '22

Attention is currently required from: John Su, YH Lin, Dtrain Hsu, Ian Feng, Tim Wawrzynczak, Nick Vaccaro, Eric Lai, Amanda Hwang, Zhuohao Lee. Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63622 ) Change subject: mb/google/brya/var/banshee: add the smbus addr for dimm1 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I will address the issue for non-exist dimm problem. [INFO ] DIMM change, invalidate cache. […] Hi Tim and Eric, Should the CL be abandoned if the CL CB:63628 is fine? Would you give me suggestions? Thank you. -- To view, visit https://review.coreboot.org/c/coreboot/+/63622 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I708d6c3f7976891b1178e43449168090e215d122 Gerrit-Change-Number: 63622 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Comment-Date: Thu, 14 Apr 2022 07:47:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2022