coreboot-gerrit April 2022

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

Change in coreboot[master]: mb/google/guybrush: Remove EC_ENABLE_LID_SWITCH
by Jon Murphy (Code Review) 17 Apr '22

17 Apr '22

Attention is currently required from: Raul Rangel, Diana Zigterman, Rob Barnes, Karthik Ramasubramanian. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63658 ) Change subject: mb/google/guybrush: Remove EC_ENABLE_LID_SWITCH ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/63658 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c1cf7aeac8405bce7bfc77110eceaf3e5383fe7 Gerrit-Change-Number: 63658 Gerrit-PatchSet: 1 Gerrit-Owner: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Diana Zigterman <dzigterman(a)google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Diana Zigterman <dzigterman(a)google.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Sun, 17 Apr 2022 18:03:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush/var/nipperkin: turn off WLAN ASPM L1ss
by Rob Barnes (Code Review) 17 Apr '22

17 Apr '22

Attention is currently required from: Kevin Chiu, Bhanu Prakash Maiya, Eric Peers, Felix Held. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63537 ) Change subject: mb/google/guybrush/var/nipperkin: turn off WLAN ASPM L1ss ...................................................................... Patch Set 4: (1 comment) Patchset: PS2: > it's still under discussion if the DUT could be more stable while running suspend, thanks. Latest results show more stability with this turned off. I'd like to merge this change until we can root cause the issue. -- To view, visit https://review.coreboot.org/c/coreboot/+/63537 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9c61e1d0f3db8b9885040255d6de266616768b68 Gerrit-Change-Number: 63537 Gerrit-PatchSet: 4 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Eric Peers <epeers(a)google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Attention: Eric Peers <epeers(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 17 Apr 2022 17:16:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: asus/am1i-a: fix the IRQs and create the good MP tables
by Mike Banon (Code Review) 17 Apr '22

17 Apr '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58754 to look at the new patch set (#3). Change subject: asus/am1i-a: fix the IRQs and create the good MP tables ...................................................................... asus/am1i-a: fix the IRQs and create the good MP tables Although the IRQ programming of this board is much better than AMD Lenovo G505S or ASUS A88XM-E (both are AMD fam15h boards), still it's far from perfect and needs to be improved - to ensure that KolibriOS is working properly. Also, CB:38313 dropped the broken MP tables for many boards including am1i-a, so we can make the good ones. With this change applied: * AM1I-A boots fine to Linux - no angry IRQ-related messages at dmesg; * KolibriOS sees 15 IRQs in a table and could successfully attach a driver to Realtek RTL8168 onboard Ethernet controller with an IRQ 4. Signed-off-by: Mike Banon <mikebdp2(a)gmail.com> Change-Id: I23ab33ec6a43ac61fc37109ddeca920afb07498d --- M src/mainboard/asus/am1i-a/Kconfig M src/mainboard/asus/am1i-a/mainboard.c A src/mainboard/asus/am1i-a/mptable.c 3 files changed, 207 insertions(+), 47 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/58754/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/58754 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I23ab33ec6a43ac61fc37109ddeca920afb07498d Gerrit-Change-Number: 58754 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: lenovo/g505s: fix the IRQs and create the good MP tables
by Mike Banon (Code Review) 17 Apr '22

17 Apr '22

Attention is currently required from: Alexander Couzens, Patrick Rudolph, Elyes Haouas. Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58750 ) Change subject: lenovo/g505s: fix the IRQs and create the good MP tables ...................................................................... Patch Set 3: (1 comment) File src/mainboard/lenovo/g505s/mptable.c: https://review.coreboot.org/c/coreboot/+/58750/comment/ef503051_abdc8236 PS1, Line 132: smp_write_intsrc > I think we have smp_write_pci_intsrc() […] Thank you very much, done! -- To view, visit https://review.coreboot.org/c/coreboot/+/58750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifdfb619dabbea8296ae7c2eaa981df78267ccf82 Gerrit-Change-Number: 58750 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 17 Apr 2022 15:51:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lenovo/g505s: fix the IRQs and create the good MP tables
by Mike Banon (Code Review) 17 Apr '22

17 Apr '22

Attention is currently required from: Alexander Couzens, Patrick Rudolph. Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58750 to look at the new patch set (#3). Change subject: lenovo/g505s: fix the IRQs and create the good MP tables ...................................................................... lenovo/g505s: fix the IRQs and create the good MP tables IRQ programming should be outside the obsolete MP table generation, just like the proper way done for asus/am1i-a AMD fam16h - closest example for Lenovo G505S: all the fam15h boards have these "bad IRQs". OS like Linux still finds a way, but Kolibri can't see the IRQ table - so we need to fix the interrupts. Also, CB:38313 dropped the broken MP tables for many boards including g505s - so we can make the good ones. With this change applied: * G505S boots fine to Linux - no angry IRQ-related messages at dmesg; * KolibriOS sees 18 IRQs in a table and could successfully attach a driver to Atheros QCA8172 onboard Ethernet controller with an IRQ 3. Signed-off-by: Mike Banon <mikebdp2(a)gmail.com> Change-Id: Ifdfb619dabbea8296ae7c2eaa981df78267ccf82 --- M src/mainboard/lenovo/g505s/Kconfig M src/mainboard/lenovo/g505s/mainboard.c A src/mainboard/lenovo/g505s/mptable.c 3 files changed, 264 insertions(+), 23 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/58750/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/58750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifdfb619dabbea8296ae7c2eaa981df78267ccf82 Gerrit-Change-Number: 58750 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: lenovo/g505s: fix the IRQs and create the good MP tables
by Mike Banon (Code Review) 17 Apr '22

17 Apr '22

Attention is currently required from: Mike Banon, Alexander Couzens, Patrick Rudolph. Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58750 to look at the new patch set (#2). Change subject: lenovo/g505s: fix the IRQs and create the good MP tables ...................................................................... lenovo/g505s: fix the IRQs and create the good MP tables IRQ programming should be outside the obsolete MP table generation, just like the proper way done for asus/am1i-a AMD fam16h - closest example for Lenovo G505S: all the fam15h boards have these "bad IRQs". OS like Linux still finds a way, but Kolibri can't see the IRQ table - so we need to fix the interrupts. Also, CB:38313 dropped the broken MP tables for many boards including g505s - so we can make the good ones. With this change applied: * G505S boots fine to Linux - no angry IRQ-related messages at dmesg; * KolibriOS sees 18 IRQs in a table and could successfully attach a driver to Atheros QCA8172 onboard Ethernet controller with an IRQ 3. Signed-off-by: Mike Banon <mikebdp2(a)gmail.com> Change-Id: Ifdfb619dabbea8296ae7c2eaa981df78267ccf82 --- M src/mainboard/lenovo/g505s/Kconfig M src/mainboard/lenovo/g505s/mainboard.c A src/mainboard/lenovo/g505s/mptable.c 3 files changed, 264 insertions(+), 23 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/58750/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifdfb619dabbea8296ae7c2eaa981df78267ccf82 Gerrit-Change-Number: 58750 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: lenovo/g505s: enable the AMD_DGPU_WITHOUT_EEPROM discrete VGA adapter
by Mike Banon (Code Review) 17 Apr '22

17 Apr '22

Attention is currently required from: Angel Pons, Alexander Couzens, Patrick Rudolph. Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58653 ) Change subject: lenovo/g505s: enable the AMD_DGPU_WITHOUT_EEPROM discrete VGA adapter ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/58653/comment/ad0ca521_ac556ab7 PS2, Line 14: > Is this change tested? Of course this change is tested; moreover, it has been successfully tested so many times over the last ~4 years! 😜 Discrete GPU is working fine on G505S with these unofficial changes, but I can't get them merged to a coreboot master; to be honest I almost gave up on this and just maintaining them. -- To view, visit https://review.coreboot.org/c/coreboot/+/58653 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I53eeef073c15bdcc2a2c76195edb1fa80b00f1a7 Gerrit-Change-Number: 58653 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 17 Apr 2022 14:56:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: G505S dGPU support: scripts for applying the unofficial (not-merged-y...
by Mike Banon (Code Review) 17 Apr '22

17 Apr '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58745 to look at the new patch set (#3). Change subject: G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches ...................................................................... G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches These scripts will help you to securely and conveniently apply three changes CB:57319, CB:58652, CB:58653 - to enable the discrete GPU of AMD Lenovo G505S. Save to ./coreboot/ then run ./get_dgpu_patches.sh , ./check... and ./apply... Signed-off-by: Mike Banon <mikebdp2(a)gmail.com> Change-Id: I25e1ec5e8bd32cf32d606e5272a4d0383a57ba81 --- A apply_dgpu_patches.sh A check_dgpu_patches.sh A get_dgpu_patches.sh A sha256sums_dgpu_correct.txt 4 files changed, 60 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/58745/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/58745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25e1ec5e8bd32cf32d606e5272a4d0383a57ba81 Gerrit-Change-Number: 58745 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/lenovo/g505s/irq_tables.c: Use ALIGN_UP macro
by Mike Banon (Code Review) 17 Apr '22

17 Apr '22

Attention is currently required from: Mike Banon, Kyösti Mälkki, Alexander Couzens, Patrick Rudolph, Elyes Haouas, Felix Held. Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61919 ) Change subject: mb/lenovo/g505s/irq_tables.c: Use ALIGN_UP macro ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: This change is good. Although the updated code at not-merged-yet CB:58752 (from CB:48427 "AMD good IRQs" patches collection) doesn't have this alignment code, I still vote +1 (seems I no longer have +2, otherwise would have given) -- To view, visit https://review.coreboot.org/c/coreboot/+/61919 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2bd5e09f51918fe4c7e954edf54ab4d9bc629fd1 Gerrit-Change-Number: 61919 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 17 Apr 2022 12:27:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/x86/Kconfig: Guard with ARCH_X86
by Felix Singer (Code Review) 17 Apr '22

17 Apr '22

Attention is currently required from: Arthur Heymans. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63673 ) Change subject: cpu/x86/Kconfig: Guard with ARCH_X86 ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/cpu/x86/Kconfig: https://review.coreboot.org/c/coreboot/+/63673/comment/0f1fae2d_a4608a5f PS1, Line 1: if ARCH_X86 As far as I can see, src/cpu/x86/Kconfig.debug_cpu is not guarded either. Please guard these options too. -- To view, visit https://review.coreboot.org/c/coreboot/+/63673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie90ad24ff9013e38c42f10285cc3b546a3cc0571 Gerrit-Change-Number: 63673 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sun, 17 Apr 2022 11:52:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2022