coreboot-gerrit April 2022

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

Change in coreboot[master]: mb/google/brask/variants/moli: use specific VBT files
by Eric Lai (Code Review) 18 Apr '22

18 Apr '22

Attention is currently required from: YH Lin, Paul Menzel, Raihow Shi, Felix Held. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63604 ) Change subject: mb/google/brask/variants/moli: use specific VBT files ...................................................................... Patch Set 11: (1 comment) File src/mainboard/google/brya/variants/moli/ramstage.c: https://review.coreboot.org/c/coreboot/+/63604/comment/d8711c88_eba8ffef PS11, Line 11: #include <drivers/intel/gma/opregion.h> nit:in alphabet order? -- To view, visit https://review.coreboot.org/c/coreboot/+/63604 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icc8fbef1467605505459fce264697f670591c81e Gerrit-Change-Number: 63604 Gerrit-PatchSet: 11 Gerrit-Owner: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 18 Apr 2022 00:01:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Revert "crossgcc/buildgcc: Remove unused GCC_AUTOCONF_VERSION"
by Mike Banon (Code Review) 17 Apr '22

17 Apr '22

Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63679 ) Change subject: Revert "crossgcc/buildgcc: Remove unused GCC_AUTOCONF_VERSION" ...................................................................... Revert "crossgcc/buildgcc: Remove unused GCC_AUTOCONF_VERSION" This reverts commit ce134ababd6a444082962ccdfcd34415a647f41e. Need to do that to revert "util/crossgcc: Update gcc to 11.2". Change-Id: I0bc6772fc68ce8997c463e67ccfa8a911c076b94 Signed-off-by: Mike Banon <mikebdp2(a)gmail.com> --- M util/crossgcc/buildgcc 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/63679/1 diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index b25b260..6588a71 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -36,6 +36,7 @@ MPFR_VERSION=4.1.0 MPC_VERSION=1.2.1 GCC_VERSION=11.2.0 +GCC_AUTOCONF_VERSION=2.69 BINUTILS_VERSION=2.37 IASL_VERSION=20220331 # CLANG version number @@ -849,6 +850,7 @@ print_supported() { case "$PRINTSUPPORTED" in + AUTOCONF|autoconf) printf "%s\n" "$GCC_AUTOCONF_VERSION";; BINUTILS|binutils) printf "%s\n" "$BINUTILS_VERSION";; CLANG|clang) printf "%s\n" "$CLANG_VERSION";; GCC|gcc) printf "%s\n" "$GCC_VERSION";; -- To view, visit https://review.coreboot.org/c/coreboot/+/63679 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0bc6772fc68ce8997c463e67ccfa8a911c076b94 Gerrit-Change-Number: 63679 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: console/Kconfig: Reverse NO_POST and depend on ARCH_X86
by Arthur Heymans (Code Review) 17 Apr '22

17 Apr '22

Attention is currently required from: Arthur Heymans. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63678 to look at the new patch set (#2). Change subject: console/Kconfig: Reverse NO_POST and depend on ARCH_X86 ...................................................................... console/Kconfig: Reverse NO_POST and depend on ARCH_X86 Post codes are only used on x86. Change-Id: I184bd5574db9a8817dc235846cc6fddf519e7121 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/console/Kconfig M src/console/post.c M src/mainboard/51nb/x210/Kconfig M src/mainboard/purism/librem_bdw/Kconfig M src/mainboard/purism/librem_cnl/Kconfig M src/mainboard/purism/librem_skl/Kconfig M src/mainboard/razer/blade_stealth_kbl/Kconfig 7 files changed, 19 insertions(+), 18 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/63678/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I184bd5574db9a8817dc235846cc6fddf519e7121 Gerrit-Change-Number: 63678 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: console/Kconfig: Reverse NO_POST and depend on ARCH_X86
by Arthur Heymans (Code Review) 17 Apr '22

17 Apr '22

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63678 ) Change subject: console/Kconfig: Reverse NO_POST and depend on ARCH_X86 ...................................................................... console/Kconfig: Reverse NO_POST and depend on ARCH_X86 Post codes are only used on x86. Change-Id: I184bd5574db9a8817dc235846cc6fddf519e7121 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/console/Kconfig 1 file changed, 8 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/63678/1 diff --git a/src/console/Kconfig b/src/console/Kconfig index 6152592..19478f8 100644 --- a/src/console/Kconfig +++ b/src/console/Kconfig @@ -413,13 +413,14 @@ highlight lines based on their log level. Disable this if your terminal does not support ANSI escape sequences. -config NO_POST - bool "Don't show any POST codes" - default n +config POST + bool "Show POST codes" + depends on ARCH_X86 + default y config CMOS_POST bool "Store post codes in CMOS for debugging" - depends on !NO_POST && PC80_SYSTEM + depends on POST && PC80_SYSTEM default n help If enabled, coreboot will store post codes in CMOS and switch between @@ -437,7 +438,7 @@ config CONSOLE_POST bool "Show POST codes on the debug console" - depends on !NO_POST + depends on POST default n help If enabled, coreboot will additionally print POST codes (which are @@ -446,7 +447,7 @@ config POST_DEVICE bool "Send POST codes to an external device" - depends on !NO_POST + depends on POST default y choice @@ -471,7 +472,7 @@ config POST_IO bool "Send POST codes to an IO port" - depends on PC80_SYSTEM && !NO_POST + depends on PC80_SYSTEM && POST default y help If enabled, POST codes will be written to an IO port. -- To view, visit https://review.coreboot.org/c/coreboot/+/63678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I184bd5574db9a8817dc235846cc6fddf519e7121 Gerrit-Change-Number: 63678 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: Kconfig: Hide stage cache selection on !HAVE_ACPI_RESUME
by Arthur Heymans (Code Review) 17 Apr '22

17 Apr '22

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63677 ) Change subject: Kconfig: Hide stage cache selection on !HAVE_ACPI_RESUME ...................................................................... Kconfig: Hide stage cache selection on !HAVE_ACPI_RESUME Having a stage cache only makes sense with ACPI resume. Change-Id: I005ebde53d99b946dc54644e17b07ca12b32c0a6 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/63677/1 diff --git a/src/Kconfig b/src/Kconfig index dc81979..265e669 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -328,7 +328,7 @@ choice prompt "Stage Cache for ACPI S3 resume" - default NO_STAGE_CACHE if !HAVE_ACPI_RESUME + depends on HAVE_ACPI_RESUME default TSEG_STAGE_CACHE if SMM_TSEG config NO_STAGE_CACHE -- To view, visit https://review.coreboot.org/c/coreboot/+/63677 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I005ebde53d99b946dc54644e17b07ca12b32c0a6 Gerrit-Change-Number: 63677 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: Kconfig: Make HAVE_EM100_SUPPORT invisible
by Arthur Heymans (Code Review) 17 Apr '22

17 Apr '22

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63676 ) Change subject: Kconfig: Make HAVE_EM100_SUPPORT invisible ...................................................................... Kconfig: Make HAVE_EM100_SUPPORT invisible This is a property of a platform and should not be exposed to the user. Change-Id: I34f9097d40b2bf732cecf30bf13ba5a413dd53a5 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/63676/1 diff --git a/src/Kconfig b/src/Kconfig index d57ce90..dc81979 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -1210,7 +1210,7 @@ `pragma Debug`. config HAVE_EM100_SUPPORT - bool "Platform can support the Dediprog EM100 SPI emulator" + bool help This is enabled by platforms which can support using the EM100. -- To view, visit https://review.coreboot.org/c/coreboot/+/63676 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I34f9097d40b2bf732cecf30bf13ba5a413dd53a5 Gerrit-Change-Number: 63676 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: cpu/x86/Kconfig*: Guard with ARCH_X86
by Felix Singer (Code Review) 17 Apr '22

17 Apr '22

Attention is currently required from: Arthur Heymans. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63673 ) Change subject: cpu/x86/Kconfig*: Guard with ARCH_X86 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie90ad24ff9013e38c42f10285cc3b546a3cc0571 Gerrit-Change-Number: 63673 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sun, 17 Apr 2022 18:13:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/x86/Kconfig*: Guard with ARCH_X86
by Arthur Heymans (Code Review) 17 Apr '22

17 Apr '22

Attention is currently required from: Felix Singer. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63673 ) Change subject: cpu/x86/Kconfig*: Guard with ARCH_X86 ...................................................................... Patch Set 2: (1 comment) File src/cpu/x86/Kconfig: https://review.coreboot.org/c/coreboot/+/63673/comment/87b2a4e5_98c8eb88 PS1, Line 1: if ARCH_X86 > As far as I can see, src/cpu/x86/Kconfig.debug_cpu is not guarded either. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/63673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie90ad24ff9013e38c42f10285cc3b546a3cc0571 Gerrit-Change-Number: 63673 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Sun, 17 Apr 2022 18:08:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/x86/Kconfig*: Guard with ARCH_X86
by Arthur Heymans (Code Review) 17 Apr '22

17 Apr '22

Attention is currently required from: Arthur Heymans. Hello Felix Singer, build bot (Jenkins), Paul Menzel, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63673 to look at the new patch set (#2). Change subject: cpu/x86/Kconfig*: Guard with ARCH_X86 ...................................................................... cpu/x86/Kconfig*: Guard with ARCH_X86 None of these options make sense on different ARCH. Change-Id: Ie90ad24ff9013e38c42f10285cc3b546a3cc0571 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/x86/Kconfig M src/cpu/x86/Kconfig.debug_cpu 2 files changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/63673/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie90ad24ff9013e38c42f10285cc3b546a3cc0571 Gerrit-Change-Number: 63673 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/guybrush/var/nipperkin: turn off WLAN ASPM L1ss
by Jon Murphy (Code Review) 17 Apr '22

17 Apr '22

Attention is currently required from: Kevin Chiu, Bhanu Prakash Maiya, Eric Peers, Felix Held. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63537 ) Change subject: mb/google/guybrush/var/nipperkin: turn off WLAN ASPM L1ss ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/63537 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9c61e1d0f3db8b9885040255d6de266616768b68 Gerrit-Change-Number: 63537 Gerrit-PatchSet: 4 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Eric Peers <epeers(a)google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Attention: Eric Peers <epeers(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 17 Apr 2022 18:04:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2022