coreboot-gerrit April 2022

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

Change in coreboot[master]: tpm: Refactor TPM Kconfig dimensions
by Eric Lai (Code Review) 22 Apr '22

22 Apr '22

Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63424 ) Change subject: tpm: Refactor TPM Kconfig dimensions ...................................................................... Patch Set 21: (1 comment) Patchset: PS21: this broken buildbot now. #!!!!! Error: Undefined Symbol 'MAINBOARD_HAS_LPC_TPM' used at src/mainboard/prodrive/atlas/Kconfig:11. -- To view, visit https://review.coreboot.org/c/coreboot/+/63424 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4656b2b90363b8dfd008dc281ad591862fe2cc9e Gerrit-Change-Number: 63424 Gerrit-PatchSet: 21 Gerrit-Owner: Jes Klinke <jbk(a)chromium.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: siemens-bot Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 22 Apr 2022 03:09:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/google/chromeec: Add empty string check for OEM string
by Eric Lai (Code Review) 22 Apr '22

22 Apr '22

Eric Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63772 ) Change subject: ec/google/chromeec: Add empty string check for OEM string ...................................................................... ec/google/chromeec: Add empty string check for OEM string If set OEM string as "", it shows "Not Specified" with dmidecode. Use default string if it is empty. BUG=b:230039300 TEST=set OEM string "" and show google with dmidecode -t 2. Signed-off-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Change-Id: I097e1be696ae974aadc47feb8d0c1dae672a5c82 --- M src/ec/google/chromeec/ec_smbios.c 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/63772/1 diff --git a/src/ec/google/chromeec/ec_smbios.c b/src/ec/google/chromeec/ec_smbios.c index 0616c986..d804f64 100644 --- a/src/ec/google/chromeec/ec_smbios.c +++ b/src/ec/google/chromeec/ec_smbios.c @@ -27,13 +27,13 @@ if (manuf) return manuf; - if (google_chromeec_cbi_get_oem_name(&oem_name[0], - ARRAY_SIZE(oem_name)) < 0) { + manuf = CONFIG_MAINBOARD_SMBIOS_MANUFACTURER; + if (google_chromeec_cbi_get_oem_name(&oem_name[0], ARRAY_SIZE(oem_name)) < 0) printk(BIOS_INFO, "Couldn't obtain OEM name from CBI\n"); - manuf = CONFIG_MAINBOARD_SMBIOS_MANUFACTURER; - } else { + else if (strlen(oem_name) > 0) manuf = &oem_name[0]; - } + else + printk(BIOS_INFO, "OEM name from CBI is empty, use default\n"); return manuf; } -- To view, visit https://review.coreboot.org/c/coreboot/+/63772 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I097e1be696ae974aadc47feb8d0c1dae672a5c82 Gerrit-Change-Number: 63772 Gerrit-PatchSet: 1 Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/skyrim: Configure SD card reader power sequence
by Eric Lai (Code Review) 22 Apr '22

22 Apr '22

Attention is currently required from: Raul Rangel, Ian Feng, Karthik Ramasubramanian. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63739 ) Change subject: mb/google/skyrim: Configure SD card reader power sequence ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/63739 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I03d88d90acc03cdebcb1e83ed2e799dda8b5b735 Gerrit-Change-Number: 63739 Gerrit-PatchSet: 5 Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Fri, 22 Apr 2022 01:47:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/skyrim: Configure SD card reader power sequence
by Ian Feng (Code Review) 22 Apr '22

22 Apr '22

Attention is currently required from: Raul Rangel, Eric Lai, Karthik Ramasubramanian. Ian Feng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63739 ) Change subject: mb/google/skyrim: Configure SD card reader power sequence ...................................................................... Patch Set 5: (1 comment) File src/mainboard/google/skyrim/variants/baseboard/gpio.c: https://review.coreboot.org/c/coreboot/+/63739/comment/e2ce9e83_0652a64b PS5, Line 201: PAD_GPO(GPIO_27, HIGH), > ramstage set high is enough, do we need set high here? Yes,remove set HIGH SD card is not working. -- To view, visit https://review.coreboot.org/c/coreboot/+/63739 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I03d88d90acc03cdebcb1e83ed2e799dda8b5b735 Gerrit-Change-Number: 63739 Gerrit-PatchSet: 5 Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Fri, 22 Apr 2022 01:44:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/*/*/*.fmd: Start flash at 0
by Arthur Heymans (Code Review) 22 Apr '22

22 Apr '22

Attention is currently required from: Stefan Ott, Patrick Rudolph, Frans Hendriks, Julius Werner, Erik van den Bogaert, Jason Glenesk, Sean Rhodes, Marshall Dawson, Christian Walter, Tim Wawrzynczak, Alexander Couzens, Fred Reitberger, Felix Held. Hello Stefan Ott, Frans Hendriks, Patrick Rudolph, Julius Werner, Erik van den Bogaert, Jason Glenesk, Sean Rhodes, Marshall Dawson, Christian Walter, Tim Wawrzynczak, Alexander Couzens, Fred Reitberger, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63771 to look at the new patch set (#2). Change subject: mb/*/*/*.fmd: Start flash at 0 ...................................................................... mb/*/*/*.fmd: Start flash at 0 FMAP should not contain information about the memory map. Done with the following command: "find -name \*.fmd -exec sed -i 's/\(FLASH\).* \(.*\) /\1 \2 /' {} \;" Change-Id: Iac86ef9be6b14817a65bf3a7ccb624d205ca3f99 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/amd/bilby/board.fmd M src/mainboard/amd/chausie/board.fmd M src/mainboard/amd/chausie/chromeos.fmd M src/mainboard/amd/majolica/board.fmd M src/mainboard/amd/majolica/chromeos.fmd M src/mainboard/amd/mandolin/variants/cereme/board.fmd M src/mainboard/amd/mandolin/variants/mandolin/board.fmd M src/mainboard/cavium/cn8100_sff_evb/board.fmd M src/mainboard/emulation/qemu-i440fx/vboot-rwa-16M.fmd M src/mainboard/emulation/qemu-q35/vboot-rwa-16M.fmd M src/mainboard/emulation/qemu-q35/vboot-rwab-16M.fmd M src/mainboard/facebook/fbg1701/vboot-rw.fmd M src/mainboard/google/asurada/chromeos.fmd M src/mainboard/google/auron/chromeos.fmd M src/mainboard/google/beltino/chromeos.fmd M src/mainboard/google/butterfly/chromeos.fmd M src/mainboard/google/cherry/chromeos.fmd M src/mainboard/google/corsola/chromeos.fmd M src/mainboard/google/cyan/chromeos.fmd M src/mainboard/google/daisy/chromeos.fmd M src/mainboard/google/dedede/chromeos-dedede-16MiB.fmd M src/mainboard/google/dedede/chromeos-dedede-32MiB.fmd M src/mainboard/google/deltaur/chromeos-gbe.fmd M src/mainboard/google/deltaur/chromeos.fmd M src/mainboard/google/drallion/chromeos.fmd M src/mainboard/google/eve/chromeos.fmd M src/mainboard/google/fizz/chromeos.fmd M src/mainboard/google/foster/chromeos.fmd M src/mainboard/google/gale/chromeos.fmd M src/mainboard/google/glados/chromeos.fmd M src/mainboard/google/gru/chromeos.fmd M src/mainboard/google/guybrush/chromeos.fmd M src/mainboard/google/hatch/chromeos-hatch-16MiB.fmd M src/mainboard/google/hatch/chromeos-hatch-32MiB.fmd M src/mainboard/google/hatch/chromeos-puff-16MiB.fmd M src/mainboard/google/hatch/chromeos-puff-32MiB.fmd M src/mainboard/google/herobrine/chromeos.fmd M src/mainboard/google/jecht/chromeos.fmd M src/mainboard/google/kahlee/variants/baseboard/chromeos.fmd M src/mainboard/google/kukui/chromeos.fmd M src/mainboard/google/link/chromeos.fmd M src/mainboard/google/mistral/chromeos.fmd M src/mainboard/google/nyan/chromeos.fmd M src/mainboard/google/nyan_big/chromeos.fmd M src/mainboard/google/nyan_blaze/chromeos.fmd M src/mainboard/google/oak/chromeos.fmd M src/mainboard/google/parrot/chromeos.fmd M src/mainboard/google/peach_pit/chromeos.fmd M src/mainboard/google/poppy/chromeos.fmd M src/mainboard/google/rambi/chromeos.fmd M src/mainboard/google/sarien/chromeos.fmd M src/mainboard/google/skyrim/chromeos.fmd M src/mainboard/google/slippy/chromeos.fmd M src/mainboard/google/smaug/chromeos.fmd M src/mainboard/google/storm/chromeos.fmd M src/mainboard/google/stout/chromeos.fmd M src/mainboard/google/trogdor/chromeos.fmd M src/mainboard/google/veyron/chromeos.fmd M src/mainboard/google/veyron_mickey/chromeos.fmd M src/mainboard/google/veyron_rialto/chromeos.fmd M src/mainboard/google/zork/chromeos.fmd M src/mainboard/intel/baskingridge/chromeos.fmd M src/mainboard/intel/cedarisland_crb/board.fmd M src/mainboard/intel/coffeelake_rvp/chromeos.fmd M src/mainboard/intel/coffeelake_rvp/chromeos_32MB.fmd M src/mainboard/intel/galileo/vboot.fmd M src/mainboard/intel/icelake_rvp/chromeos.fmd M src/mainboard/intel/jasperlake_rvp/chromeos.fmd M src/mainboard/intel/kblrvp/chromeos.fmd M src/mainboard/intel/kunimitsu/chromeos.fmd M src/mainboard/intel/shadowmountain/chromeos.fmd M src/mainboard/intel/strago/chromeos.fmd M src/mainboard/intel/tglrvp/chromeos.fmd M src/mainboard/intel/wtm2/chromeos.fmd M src/mainboard/lenovo/t400/vboot-rwa.fmd M src/mainboard/lenovo/t410/vboot-rwa.fmd M src/mainboard/lenovo/t420/vboot-ro-me_clean.fmd M src/mainboard/lenovo/t420/vboot-ro.fmd M src/mainboard/lenovo/t420/vboot-rwa.fmd M src/mainboard/lenovo/t420s/vboot-ro-me_clean.fmd M src/mainboard/lenovo/t420s/vboot-ro.fmd M src/mainboard/lenovo/t420s/vboot-rwa.fmd M src/mainboard/lenovo/t430/vboot-ro-me_clean.fmd M src/mainboard/lenovo/t430/vboot-ro.fmd M src/mainboard/lenovo/t430/vboot-rwab.fmd M src/mainboard/lenovo/t430s/vboot-ro-me_clean.fmd M src/mainboard/lenovo/t430s/vboot-ro.fmd M src/mainboard/lenovo/t430s/vboot-rwab.fmd M src/mainboard/lenovo/t440p/vboot-ro-me_clean.fmd M src/mainboard/lenovo/t440p/vboot-ro.fmd M src/mainboard/lenovo/t440p/vboot-rwab.fmd M src/mainboard/lenovo/t520/vboot-ro-me_clean.fmd M src/mainboard/lenovo/t520/vboot-ro.fmd M src/mainboard/lenovo/t520/vboot-rwa.fmd M src/mainboard/lenovo/t530/vboot-ro-me_clean.fmd M src/mainboard/lenovo/t530/vboot-ro.fmd M src/mainboard/lenovo/t530/vboot-rwab.fmd M src/mainboard/lenovo/x131e/vboot-ro-me_clean.fmd M src/mainboard/lenovo/x131e/vboot-ro.fmd M src/mainboard/lenovo/x131e/vboot-rwab.fmd M src/mainboard/lenovo/x1_carbon_gen1/vboot-ro-me_clean.fmd M src/mainboard/lenovo/x1_carbon_gen1/vboot-ro.fmd M src/mainboard/lenovo/x1_carbon_gen1/vboot-rwab.fmd M src/mainboard/lenovo/x200/vboot-rwa.fmd M src/mainboard/lenovo/x201/vboot-rwa.fmd M src/mainboard/lenovo/x220/vboot-ro-me_clean.fmd M src/mainboard/lenovo/x220/vboot-ro.fmd M src/mainboard/lenovo/x220/vboot-rwa.fmd M src/mainboard/lenovo/x230/vboot-ro-me_clean.fmd M src/mainboard/lenovo/x230/vboot-ro.fmd M src/mainboard/lenovo/x230/vboot-rwab.fmd M src/mainboard/lenovo/x60/vboot-rwa.fmd M src/mainboard/opencellular/elgon/board.fmd M src/mainboard/opencellular/elgon/vboot.fmd M src/mainboard/samsung/lumpy/chromeos.fmd M src/mainboard/samsung/stumpy/chromeos.fmd M src/mainboard/siemens/mc_ehl/mc_ehl.fmd M src/mainboard/starlabs/labtop/variants/tgl/board.fmd M src/mainboard/ti/beaglebone/board.fmd M src/soc/amd/picasso/Makefile.inc 120 files changed, 125 insertions(+), 121 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/63771/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63771 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iac86ef9be6b14817a65bf3a7ccb624d205ca3f99 Gerrit-Change-Number: 63771 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Ott <coreboot(a)desire.ch> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: device/Kconfig: Change ON_DEVICE_ROM_LOAD default
by Arthur Heymans (Code Review) 22 Apr '22

22 Apr '22

Attention is currently required from: Paul Menzel. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63763 ) Change subject: device/Kconfig: Change ON_DEVICE_ROM_LOAD default ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/63763/comment/d5201314_72ff95f3 PS1, Line 9: is not a good : idea in an open source project > Why? I understand the security perspective, and would only mention that. Running non essential blobs should be opt-in not opt-out? -- To view, visit https://review.coreboot.org/c/coreboot/+/63763 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70b4ca6bf83f2d2fa591e30967e481d67e1b9f87 Gerrit-Change-Number: 63763 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 22 Apr 2022 00:16:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/*/*/*.fmd: Start flash at 0
by Arthur Heymans (Code Review) 22 Apr '22

22 Apr '22

Attention is currently required from: Stefan Ott, Erik van den Bogaert, Jason Glenesk, Sean Rhodes, Patrick Rudolph, Frans Hendriks, Marshall Dawson, Christian Walter, Tim Wawrzynczak, Alexander Couzens, Fred Reitberger, Felix Held. Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63771 ) Change subject: mb/*/*/*.fmd: Start flash at 0 ...................................................................... mb/*/*/*.fmd: Start flash at 0 FMAP should not contain information about the memory map. Done with the following command: "find -name \*.fmd -exec sed -i 's/\(FLASH\).* \(.*\) /\1 \2 /' {} \;" Change-Id: Iac86ef9be6b14817a65bf3a7ccb624d205ca3f99 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/amd/bilby/board.fmd M src/mainboard/amd/chausie/board.fmd M src/mainboard/amd/chausie/chromeos.fmd M src/mainboard/amd/majolica/board.fmd M src/mainboard/amd/majolica/chromeos.fmd M src/mainboard/amd/mandolin/variants/cereme/board.fmd M src/mainboard/amd/mandolin/variants/mandolin/board.fmd M src/mainboard/cavium/cn8100_sff_evb/board.fmd M src/mainboard/emulation/qemu-i440fx/vboot-rwa-16M.fmd M src/mainboard/emulation/qemu-q35/vboot-rwa-16M.fmd M src/mainboard/emulation/qemu-q35/vboot-rwab-16M.fmd M src/mainboard/facebook/fbg1701/vboot-rw.fmd M src/mainboard/google/asurada/chromeos.fmd M src/mainboard/google/auron/chromeos.fmd M src/mainboard/google/beltino/chromeos.fmd M src/mainboard/google/butterfly/chromeos.fmd M src/mainboard/google/cherry/chromeos.fmd M src/mainboard/google/corsola/chromeos.fmd M src/mainboard/google/cyan/chromeos.fmd M src/mainboard/google/daisy/chromeos.fmd M src/mainboard/google/dedede/chromeos-dedede-16MiB.fmd M src/mainboard/google/dedede/chromeos-dedede-32MiB.fmd M src/mainboard/google/deltaur/chromeos-gbe.fmd M src/mainboard/google/deltaur/chromeos.fmd M src/mainboard/google/drallion/chromeos.fmd M src/mainboard/google/eve/chromeos.fmd M src/mainboard/google/fizz/chromeos.fmd M src/mainboard/google/foster/chromeos.fmd M src/mainboard/google/gale/chromeos.fmd M src/mainboard/google/glados/chromeos.fmd M src/mainboard/google/gru/chromeos.fmd M src/mainboard/google/guybrush/chromeos.fmd M src/mainboard/google/hatch/chromeos-hatch-16MiB.fmd M src/mainboard/google/hatch/chromeos-hatch-32MiB.fmd M src/mainboard/google/hatch/chromeos-puff-16MiB.fmd M src/mainboard/google/hatch/chromeos-puff-32MiB.fmd M src/mainboard/google/herobrine/chromeos.fmd M src/mainboard/google/jecht/chromeos.fmd M src/mainboard/google/kahlee/variants/baseboard/chromeos.fmd M src/mainboard/google/kukui/chromeos.fmd M src/mainboard/google/link/chromeos.fmd M src/mainboard/google/mistral/chromeos.fmd M src/mainboard/google/nyan/chromeos.fmd M src/mainboard/google/nyan_big/chromeos.fmd M src/mainboard/google/nyan_blaze/chromeos.fmd M src/mainboard/google/oak/chromeos.fmd M src/mainboard/google/parrot/chromeos.fmd M src/mainboard/google/peach_pit/chromeos.fmd M src/mainboard/google/poppy/chromeos.fmd M src/mainboard/google/rambi/chromeos.fmd M src/mainboard/google/sarien/chromeos.fmd M src/mainboard/google/skyrim/chromeos.fmd M src/mainboard/google/slippy/chromeos.fmd M src/mainboard/google/smaug/chromeos.fmd M src/mainboard/google/storm/chromeos.fmd M src/mainboard/google/stout/chromeos.fmd M src/mainboard/google/trogdor/chromeos.fmd M src/mainboard/google/veyron/chromeos.fmd M src/mainboard/google/veyron_mickey/chromeos.fmd M src/mainboard/google/veyron_rialto/chromeos.fmd M src/mainboard/google/zork/chromeos.fmd M src/mainboard/intel/baskingridge/chromeos.fmd M src/mainboard/intel/cedarisland_crb/board.fmd M src/mainboard/intel/coffeelake_rvp/chromeos.fmd M src/mainboard/intel/coffeelake_rvp/chromeos_32MB.fmd M src/mainboard/intel/galileo/vboot.fmd M src/mainboard/intel/icelake_rvp/chromeos.fmd M src/mainboard/intel/jasperlake_rvp/chromeos.fmd M src/mainboard/intel/kblrvp/chromeos.fmd M src/mainboard/intel/kunimitsu/chromeos.fmd M src/mainboard/intel/shadowmountain/chromeos.fmd M src/mainboard/intel/strago/chromeos.fmd M src/mainboard/intel/tglrvp/chromeos.fmd M src/mainboard/intel/wtm2/chromeos.fmd M src/mainboard/lenovo/t400/vboot-rwa.fmd M src/mainboard/lenovo/t410/vboot-rwa.fmd M src/mainboard/lenovo/t420/vboot-ro-me_clean.fmd M src/mainboard/lenovo/t420/vboot-ro.fmd M src/mainboard/lenovo/t420/vboot-rwa.fmd M src/mainboard/lenovo/t420s/vboot-ro-me_clean.fmd M src/mainboard/lenovo/t420s/vboot-ro.fmd M src/mainboard/lenovo/t420s/vboot-rwa.fmd M src/mainboard/lenovo/t430/vboot-ro-me_clean.fmd M src/mainboard/lenovo/t430/vboot-ro.fmd M src/mainboard/lenovo/t430/vboot-rwab.fmd M src/mainboard/lenovo/t430s/vboot-ro-me_clean.fmd M src/mainboard/lenovo/t430s/vboot-ro.fmd M src/mainboard/lenovo/t430s/vboot-rwab.fmd M src/mainboard/lenovo/t440p/vboot-ro-me_clean.fmd M src/mainboard/lenovo/t440p/vboot-ro.fmd M src/mainboard/lenovo/t440p/vboot-rwab.fmd M src/mainboard/lenovo/t520/vboot-ro-me_clean.fmd M src/mainboard/lenovo/t520/vboot-ro.fmd M src/mainboard/lenovo/t520/vboot-rwa.fmd M src/mainboard/lenovo/t530/vboot-ro-me_clean.fmd M src/mainboard/lenovo/t530/vboot-ro.fmd M src/mainboard/lenovo/t530/vboot-rwab.fmd M src/mainboard/lenovo/x131e/vboot-ro-me_clean.fmd M src/mainboard/lenovo/x131e/vboot-ro.fmd M src/mainboard/lenovo/x131e/vboot-rwab.fmd M src/mainboard/lenovo/x1_carbon_gen1/vboot-ro-me_clean.fmd M src/mainboard/lenovo/x1_carbon_gen1/vboot-ro.fmd M src/mainboard/lenovo/x1_carbon_gen1/vboot-rwab.fmd M src/mainboard/lenovo/x200/vboot-rwa.fmd M src/mainboard/lenovo/x201/vboot-rwa.fmd M src/mainboard/lenovo/x220/vboot-ro-me_clean.fmd M src/mainboard/lenovo/x220/vboot-ro.fmd M src/mainboard/lenovo/x220/vboot-rwa.fmd M src/mainboard/lenovo/x230/vboot-ro-me_clean.fmd M src/mainboard/lenovo/x230/vboot-ro.fmd M src/mainboard/lenovo/x230/vboot-rwab.fmd M src/mainboard/lenovo/x60/vboot-rwa.fmd M src/mainboard/opencellular/elgon/board.fmd M src/mainboard/opencellular/elgon/vboot.fmd M src/mainboard/samsung/lumpy/chromeos.fmd M src/mainboard/samsung/stumpy/chromeos.fmd M src/mainboard/siemens/mc_ehl/mc_ehl.fmd M src/mainboard/starlabs/labtop/variants/tgl/board.fmd M src/mainboard/ti/beaglebone/board.fmd 119 files changed, 119 insertions(+), 119 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/63771/1 diff --git a/src/mainboard/amd/bilby/board.fmd b/src/mainboard/amd/bilby/board.fmd index c7ba3ee..00e31b9 100644 --- a/src/mainboard/amd/bilby/board.fmd +++ b/src/mainboard/amd/bilby/board.fmd @@ -1,4 +1,4 @@ -FLASH@0xFF000000 16M { +FLASH 16M { BIOS { RW_MRC_CACHE 64K FMAP 4K diff --git a/src/mainboard/amd/chausie/board.fmd b/src/mainboard/amd/chausie/board.fmd index ec87bba..da61e09 100644 --- a/src/mainboard/amd/chausie/board.fmd +++ b/src/mainboard/amd/chausie/board.fmd @@ -1,4 +1,4 @@ -FLASH@0xFF000000 16M { +FLASH 16M { BIOS { EC 4K RW_MRC_CACHE 96K diff --git a/src/mainboard/amd/chausie/chromeos.fmd b/src/mainboard/amd/chausie/chromeos.fmd index 959a05c..d998bf2 100644 --- a/src/mainboard/amd/chausie/chromeos.fmd +++ b/src/mainboard/amd/chausie/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xFF000000 16M { +FLASH 16M { SI_BIOS { EC 4K RW_MRC_CACHE(PRESERVE) 96K diff --git a/src/mainboard/amd/majolica/board.fmd b/src/mainboard/amd/majolica/board.fmd index 442d80f..fc7108b 100644 --- a/src/mainboard/amd/majolica/board.fmd +++ b/src/mainboard/amd/majolica/board.fmd @@ -1,4 +1,4 @@ -FLASH@0xFF000000 16M { +FLASH 16M { BIOS { EC 128K RW_MRC_CACHE 64K diff --git a/src/mainboard/amd/majolica/chromeos.fmd b/src/mainboard/amd/majolica/chromeos.fmd index bb21767..7baa20b 100644 --- a/src/mainboard/amd/majolica/chromeos.fmd +++ b/src/mainboard/amd/majolica/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xFF000000 16M { +FLASH 16M { SI_BIOS { EC 128K RW_MRC_CACHE(PRESERVE) 64K diff --git a/src/mainboard/amd/mandolin/variants/cereme/board.fmd b/src/mainboard/amd/mandolin/variants/cereme/board.fmd index 442d80f..fc7108b 100644 --- a/src/mainboard/amd/mandolin/variants/cereme/board.fmd +++ b/src/mainboard/amd/mandolin/variants/cereme/board.fmd @@ -1,4 +1,4 @@ -FLASH@0xFF000000 16M { +FLASH 16M { BIOS { EC 128K RW_MRC_CACHE 64K diff --git a/src/mainboard/amd/mandolin/variants/mandolin/board.fmd b/src/mainboard/amd/mandolin/variants/mandolin/board.fmd index 33b281d..522330c 100644 --- a/src/mainboard/amd/mandolin/variants/mandolin/board.fmd +++ b/src/mainboard/amd/mandolin/variants/mandolin/board.fmd @@ -1,4 +1,4 @@ -FLASH@0xFF800000 8M { +FLASH 8M { BIOS { EC 128K RW_MRC_CACHE 64K diff --git a/src/mainboard/cavium/cn8100_sff_evb/board.fmd b/src/mainboard/cavium/cn8100_sff_evb/board.fmd index 34f3161..6b1544a 100644 --- a/src/mainboard/cavium/cn8100_sff_evb/board.fmd +++ b/src/mainboard/cavium/cn8100_sff_evb/board.fmd @@ -1,4 +1,4 @@ -FLASH@0x0 8M { +FLASH 8M { WP_RO@0x0 0x800000 { RO_SECTION@0x0 0x7fc000 { # 0 - 0x10000 is free for firmware usage. diff --git a/src/mainboard/emulation/qemu-i440fx/vboot-rwa-16M.fmd b/src/mainboard/emulation/qemu-i440fx/vboot-rwa-16M.fmd index 0d2c9da..087a995 100644 --- a/src/mainboard/emulation/qemu-i440fx/vboot-rwa-16M.fmd +++ b/src/mainboard/emulation/qemu-i440fx/vboot-rwa-16M.fmd @@ -1,4 +1,4 @@ -FLASH@0xff000000 0x1000000 { +FLASH 0x1000000 { SI_BIOS 0x1000000 { RW_SECTION_A 0x7c0000 { VBLOCK_A 0x10000 diff --git a/src/mainboard/emulation/qemu-q35/vboot-rwa-16M.fmd b/src/mainboard/emulation/qemu-q35/vboot-rwa-16M.fmd index 0d2c9da..087a995 100644 --- a/src/mainboard/emulation/qemu-q35/vboot-rwa-16M.fmd +++ b/src/mainboard/emulation/qemu-q35/vboot-rwa-16M.fmd @@ -1,4 +1,4 @@ -FLASH@0xff000000 0x1000000 { +FLASH 0x1000000 { SI_BIOS 0x1000000 { RW_SECTION_A 0x7c0000 { VBLOCK_A 0x10000 diff --git a/src/mainboard/emulation/qemu-q35/vboot-rwab-16M.fmd b/src/mainboard/emulation/qemu-q35/vboot-rwab-16M.fmd index fcbfa95..b399b49 100644 --- a/src/mainboard/emulation/qemu-q35/vboot-rwab-16M.fmd +++ b/src/mainboard/emulation/qemu-q35/vboot-rwab-16M.fmd @@ -1,4 +1,4 @@ -FLASH@0xff000000 0x1000000 { +FLASH 0x1000000 { SI_BIOS 0x1000000 { RW_SECTION_A 0x1c0000 { VBLOCK_A 0x10000 diff --git a/src/mainboard/facebook/fbg1701/vboot-rw.fmd b/src/mainboard/facebook/fbg1701/vboot-rw.fmd index e3c370f..ae7312c 100644 --- a/src/mainboard/facebook/fbg1701/vboot-rw.fmd +++ b/src/mainboard/facebook/fbg1701/vboot-rw.fmd @@ -1,4 +1,4 @@ -FLASH@0xff800000 8M { +FLASH 8M { SI_BIOS@0x200000 0x600000 { MISC_RW@0x0 0x08000 { RW_MRC_CACHE@0 0x08000 diff --git a/src/mainboard/google/asurada/chromeos.fmd b/src/mainboard/google/asurada/chromeos.fmd index 7194632..4ecdaa5 100644 --- a/src/mainboard/google/asurada/chromeos.fmd +++ b/src/mainboard/google/asurada/chromeos.fmd @@ -10,7 +10,7 @@ # instead of a group section; otherwise the preserved data may be wrong if you # resize or reorder sections inside a group. -FLASH@0x0 8M { +FLASH 8M { WP_RO@0x0 4M { RO_SECTION { BOOTBLOCK 128K diff --git a/src/mainboard/google/auron/chromeos.fmd b/src/mainboard/google/auron/chromeos.fmd index 923c8ee..dae8796 100644 --- a/src/mainboard/google/auron/chromeos.fmd +++ b/src/mainboard/google/auron/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xff800000 0x800000 { +FLASH 0x800000 { SI_ALL@0x0 0x200000 { SI_DESC@0x0 0x1000 SI_ME@0x1000 0x1ff000 diff --git a/src/mainboard/google/beltino/chromeos.fmd b/src/mainboard/google/beltino/chromeos.fmd index 923c8ee..dae8796 100644 --- a/src/mainboard/google/beltino/chromeos.fmd +++ b/src/mainboard/google/beltino/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xff800000 0x800000 { +FLASH 0x800000 { SI_ALL@0x0 0x200000 { SI_DESC@0x0 0x1000 SI_ME@0x1000 0x1ff000 diff --git a/src/mainboard/google/butterfly/chromeos.fmd b/src/mainboard/google/butterfly/chromeos.fmd index 93048a3..ef8ca78 100644 --- a/src/mainboard/google/butterfly/chromeos.fmd +++ b/src/mainboard/google/butterfly/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xff800000 0x800000 { +FLASH 0x800000 { SI_ALL@0x0 0x200000 { SI_DESC@0x0 0x1000 SI_ME@0x1000 0x1ff000 diff --git a/src/mainboard/google/cherry/chromeos.fmd b/src/mainboard/google/cherry/chromeos.fmd index 7194632..4ecdaa5 100644 --- a/src/mainboard/google/cherry/chromeos.fmd +++ b/src/mainboard/google/cherry/chromeos.fmd @@ -10,7 +10,7 @@ # instead of a group section; otherwise the preserved data may be wrong if you # resize or reorder sections inside a group. -FLASH@0x0 8M { +FLASH 8M { WP_RO@0x0 4M { RO_SECTION { BOOTBLOCK 128K diff --git a/src/mainboard/google/corsola/chromeos.fmd b/src/mainboard/google/corsola/chromeos.fmd index 7194632..4ecdaa5 100644 --- a/src/mainboard/google/corsola/chromeos.fmd +++ b/src/mainboard/google/corsola/chromeos.fmd @@ -10,7 +10,7 @@ # instead of a group section; otherwise the preserved data may be wrong if you # resize or reorder sections inside a group. -FLASH@0x0 8M { +FLASH 8M { WP_RO@0x0 4M { RO_SECTION { BOOTBLOCK 128K diff --git a/src/mainboard/google/cyan/chromeos.fmd b/src/mainboard/google/cyan/chromeos.fmd index 923c8ee..dae8796 100644 --- a/src/mainboard/google/cyan/chromeos.fmd +++ b/src/mainboard/google/cyan/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xff800000 0x800000 { +FLASH 0x800000 { SI_ALL@0x0 0x200000 { SI_DESC@0x0 0x1000 SI_ME@0x1000 0x1ff000 diff --git a/src/mainboard/google/daisy/chromeos.fmd b/src/mainboard/google/daisy/chromeos.fmd index 63bde33..60794a8 100644 --- a/src/mainboard/google/daisy/chromeos.fmd +++ b/src/mainboard/google/daisy/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0x0 0x400000 { +FLASH 0x400000 { WP_RO@0x0 0x200000 { RO_SECTION@0x0 0x1f0000 { BOOTBLOCK@0 128K diff --git a/src/mainboard/google/dedede/chromeos-dedede-16MiB.fmd b/src/mainboard/google/dedede/chromeos-dedede-16MiB.fmd index ade4866..49eb83a 100644 --- a/src/mainboard/google/dedede/chromeos-dedede-16MiB.fmd +++ b/src/mainboard/google/dedede/chromeos-dedede-16MiB.fmd @@ -1,4 +1,4 @@ -FLASH@0xff000000 0x1000000 { +FLASH 0x1000000 { SI_ALL@0x0 0x381000 { SI_DESC@0x0 0x1000 SI_ME@0x1000 0x380000 diff --git a/src/mainboard/google/dedede/chromeos-dedede-32MiB.fmd b/src/mainboard/google/dedede/chromeos-dedede-32MiB.fmd index 4b31861..408ecdc 100644 --- a/src/mainboard/google/dedede/chromeos-dedede-32MiB.fmd +++ b/src/mainboard/google/dedede/chromeos-dedede-32MiB.fmd @@ -1,4 +1,4 @@ -FLASH@0xfe000000 0x2000000 { +FLASH 0x2000000 { SI_ALL@0x0 0x500000 { SI_DESC@0x0 0x1000 SI_ME@0x1000 0x4ff000 diff --git a/src/mainboard/google/deltaur/chromeos-gbe.fmd b/src/mainboard/google/deltaur/chromeos-gbe.fmd index 91918e8..3f1c441 100644 --- a/src/mainboard/google/deltaur/chromeos-gbe.fmd +++ b/src/mainboard/google/deltaur/chromeos-gbe.fmd @@ -1,4 +1,4 @@ -FLASH@0xfe000000 0x2000000 { +FLASH 0x2000000 { SI_ALL@0x0 0x606000 { SI_DESC@0x0 0x1000 SI_EC@0x1000 0x100000 diff --git a/src/mainboard/google/deltaur/chromeos.fmd b/src/mainboard/google/deltaur/chromeos.fmd index a84a448..ddc4520 100644 --- a/src/mainboard/google/deltaur/chromeos.fmd +++ b/src/mainboard/google/deltaur/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xfe000000 0x2000000 { +FLASH 0x2000000 { SI_ALL@0x0 0x606000 { SI_DESC@0x0 0x1000 SI_EC@0x1000 0x100000 diff --git a/src/mainboard/google/drallion/chromeos.fmd b/src/mainboard/google/drallion/chromeos.fmd index 6e9170e..6923886 100644 --- a/src/mainboard/google/drallion/chromeos.fmd +++ b/src/mainboard/google/drallion/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xfe000000 0x2000000 { +FLASH 0x2000000 { SI_ALL@0x0 0x438000 { SI_DESC@0x0 0x1000 SI_EC@0x1000 0x100000 diff --git a/src/mainboard/google/eve/chromeos.fmd b/src/mainboard/google/eve/chromeos.fmd index 1cc4a61..92bca1b 100644 --- a/src/mainboard/google/eve/chromeos.fmd +++ b/src/mainboard/google/eve/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xff000000 0x1000000 { +FLASH 0x1000000 { SI_ALL@0x0 0x200000 { SI_DESC@0x0 0x1000 SI_ME@0x1000 0x1ff000 diff --git a/src/mainboard/google/fizz/chromeos.fmd b/src/mainboard/google/fizz/chromeos.fmd index 1cc4a61..92bca1b 100644 --- a/src/mainboard/google/fizz/chromeos.fmd +++ b/src/mainboard/google/fizz/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xff000000 0x1000000 { +FLASH 0x1000000 { SI_ALL@0x0 0x200000 { SI_DESC@0x0 0x1000 SI_ME@0x1000 0x1ff000 diff --git a/src/mainboard/google/foster/chromeos.fmd b/src/mainboard/google/foster/chromeos.fmd index f9a531c..5a5f903 100644 --- a/src/mainboard/google/foster/chromeos.fmd +++ b/src/mainboard/google/foster/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0x0 0x400000 { +FLASH 0x400000 { WP_RO@0x0 0x300000 { RO_SECTION@0x0 0x2f0000 { BOOTBLOCK@0 128K diff --git a/src/mainboard/google/gale/chromeos.fmd b/src/mainboard/google/gale/chromeos.fmd index 3a55bdc..4d3c913 100644 --- a/src/mainboard/google/gale/chromeos.fmd +++ b/src/mainboard/google/gale/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0x0 0x800000 { +FLASH 0x800000 { WP_RO@0x0 0x400000 { RO_SECTION@0x0 0x3e0000 { BOOTBLOCK@0 128K diff --git a/src/mainboard/google/glados/chromeos.fmd b/src/mainboard/google/glados/chromeos.fmd index 9ba1bf7..8132712 100644 --- a/src/mainboard/google/glados/chromeos.fmd +++ b/src/mainboard/google/glados/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xff000000 0x1000000 { +FLASH 0x1000000 { SI_ALL@0x0 0x200000 { SI_DESC@0x0 0x1000 SI_ME@0x1000 0x1ff000 diff --git a/src/mainboard/google/gru/chromeos.fmd b/src/mainboard/google/gru/chromeos.fmd index 032f472..f569c30 100644 --- a/src/mainboard/google/gru/chromeos.fmd +++ b/src/mainboard/google/gru/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0x0 0x800000 { +FLASH 0x800000 { WP_RO@0x0 0x400000 { RO_SECTION@0x0 0x3e0000 { BOOTBLOCK@0 128K diff --git a/src/mainboard/google/guybrush/chromeos.fmd b/src/mainboard/google/guybrush/chromeos.fmd index a6dbc2c..c6d6351 100644 --- a/src/mainboard/google/guybrush/chromeos.fmd +++ b/src/mainboard/google/guybrush/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xFF000000 16M { +FLASH 16M { SI_BIOS { RW_MRC_CACHE(PRESERVE) 64K RW_SECTION_A 3M { diff --git a/src/mainboard/google/hatch/chromeos-hatch-16MiB.fmd b/src/mainboard/google/hatch/chromeos-hatch-16MiB.fmd index 8880a4f..83a828e 100644 --- a/src/mainboard/google/hatch/chromeos-hatch-16MiB.fmd +++ b/src/mainboard/google/hatch/chromeos-hatch-16MiB.fmd @@ -1,4 +1,4 @@ -FLASH@0xff000000 0x1000000 { +FLASH 0x1000000 { SI_ALL@0x0 0x400000 { SI_DESC@0x0 0x1000 SI_ME@0x1000 0x3ff000 diff --git a/src/mainboard/google/hatch/chromeos-hatch-32MiB.fmd b/src/mainboard/google/hatch/chromeos-hatch-32MiB.fmd index 8368b0a..2161ed5 100644 --- a/src/mainboard/google/hatch/chromeos-hatch-32MiB.fmd +++ b/src/mainboard/google/hatch/chromeos-hatch-32MiB.fmd @@ -1,4 +1,4 @@ -FLASH@0xfe000000 0x2000000 { +FLASH 0x2000000 { SI_ALL@0x0 0x400000 { SI_DESC@0x0 0x1000 SI_ME@0x1000 0x3ff000 diff --git a/src/mainboard/google/hatch/chromeos-puff-16MiB.fmd b/src/mainboard/google/hatch/chromeos-puff-16MiB.fmd index 61a0b0f..457c2c9 100644 --- a/src/mainboard/google/hatch/chromeos-puff-16MiB.fmd +++ b/src/mainboard/google/hatch/chromeos-puff-16MiB.fmd @@ -1,4 +1,4 @@ -FLASH@0xff000000 0x1000000 { +FLASH 0x1000000 { SI_ALL@0x0 0x300000 { SI_DESC@0x0 0x1000 SI_ME@0x1000 0x2ff000 diff --git a/src/mainboard/google/hatch/chromeos-puff-32MiB.fmd b/src/mainboard/google/hatch/chromeos-puff-32MiB.fmd index 81840b1..caa9636 100644 --- a/src/mainboard/google/hatch/chromeos-puff-32MiB.fmd +++ b/src/mainboard/google/hatch/chromeos-puff-32MiB.fmd @@ -1,4 +1,4 @@ -FLASH@0xfe000000 0x2000000 { +FLASH 0x2000000 { SI_ALL@0x0 0x300000 { SI_DESC@0x0 0x1000 SI_ME@0x1000 0x2ff000 diff --git a/src/mainboard/google/herobrine/chromeos.fmd b/src/mainboard/google/herobrine/chromeos.fmd index e85271c..acd59ae 100644 --- a/src/mainboard/google/herobrine/chromeos.fmd +++ b/src/mainboard/google/herobrine/chromeos.fmd @@ -1,7 +1,7 @@ ## SPDX-License-Identifier: GPL-2.0-only # TODO: update for Herobrine -FLASH@0x0 8M { +FLASH 8M { WP_RO 4M { RO_SECTION 0x3c4000 { BOOTBLOCK 96K diff --git a/src/mainboard/google/jecht/chromeos.fmd b/src/mainboard/google/jecht/chromeos.fmd index 923c8ee..dae8796 100644 --- a/src/mainboard/google/jecht/chromeos.fmd +++ b/src/mainboard/google/jecht/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xff800000 0x800000 { +FLASH 0x800000 { SI_ALL@0x0 0x200000 { SI_DESC@0x0 0x1000 SI_ME@0x1000 0x1ff000 diff --git a/src/mainboard/google/kahlee/variants/baseboard/chromeos.fmd b/src/mainboard/google/kahlee/variants/baseboard/chromeos.fmd index d7d0a88..faabc0b 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/chromeos.fmd +++ b/src/mainboard/google/kahlee/variants/baseboard/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xFF000000 0x1000000 { +FLASH 0x1000000 { SI_BIOS@0x0 0x1000000 { UNIFIED_MRC_CACHE@0x0 0x21000 { RW_MRC_CACHE@0x0 0x10000 diff --git a/src/mainboard/google/kukui/chromeos.fmd b/src/mainboard/google/kukui/chromeos.fmd index 2635854..b1385a1 100644 --- a/src/mainboard/google/kukui/chromeos.fmd +++ b/src/mainboard/google/kukui/chromeos.fmd @@ -10,7 +10,7 @@ # instead of a group section; otherwise the preserved data may be wrong if you # resize or reorder sections inside a group. -FLASH@0x0 8M { +FLASH 8M { WP_RO@0x0 4M { RO_SECTION { BOOTBLOCK 128K diff --git a/src/mainboard/google/link/chromeos.fmd b/src/mainboard/google/link/chromeos.fmd index 3841445..986e0a3 100644 --- a/src/mainboard/google/link/chromeos.fmd +++ b/src/mainboard/google/link/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xff800000 0x800000 { +FLASH 0x800000 { SI_ALL@0x0 0x200000 { SI_DESC@0x0 0x1000 SI_ME@0x1000 0x1ff000 diff --git a/src/mainboard/google/mistral/chromeos.fmd b/src/mainboard/google/mistral/chromeos.fmd index ccdfbde..e412c97 100644 --- a/src/mainboard/google/mistral/chromeos.fmd +++ b/src/mainboard/google/mistral/chromeos.fmd @@ -1,6 +1,6 @@ ## SPDX-License-Identifier: GPL-2.0-only -FLASH@0x0 8M { +FLASH 8M { WP_RO 4M { RO_SECTION 0x204000 { BOOTBLOCK 128K diff --git a/src/mainboard/google/nyan/chromeos.fmd b/src/mainboard/google/nyan/chromeos.fmd index ebc6eb1..0e08f10 100644 --- a/src/mainboard/google/nyan/chromeos.fmd +++ b/src/mainboard/google/nyan/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0x0 0x400000 { +FLASH 0x400000 { WP_RO@0x0 0x200000 { RO_SECTION@0x0 0x1f0000 { BOOTBLOCK@0 128K diff --git a/src/mainboard/google/nyan_big/chromeos.fmd b/src/mainboard/google/nyan_big/chromeos.fmd index ebc6eb1..0e08f10 100644 --- a/src/mainboard/google/nyan_big/chromeos.fmd +++ b/src/mainboard/google/nyan_big/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0x0 0x400000 { +FLASH 0x400000 { WP_RO@0x0 0x200000 { RO_SECTION@0x0 0x1f0000 { BOOTBLOCK@0 128K diff --git a/src/mainboard/google/nyan_blaze/chromeos.fmd b/src/mainboard/google/nyan_blaze/chromeos.fmd index ebc6eb1..0e08f10 100644 --- a/src/mainboard/google/nyan_blaze/chromeos.fmd +++ b/src/mainboard/google/nyan_blaze/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0x0 0x400000 { +FLASH 0x400000 { WP_RO@0x0 0x200000 { RO_SECTION@0x0 0x1f0000 { BOOTBLOCK@0 128K diff --git a/src/mainboard/google/oak/chromeos.fmd b/src/mainboard/google/oak/chromeos.fmd index df35976..9df6494 100644 --- a/src/mainboard/google/oak/chromeos.fmd +++ b/src/mainboard/google/oak/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0x0 0x400000 { +FLASH 0x400000 { WP_RO@0x0 0x200000 { RO_SECTION@0x0 0x1f0000 { BOOTBLOCK@0 128K diff --git a/src/mainboard/google/parrot/chromeos.fmd b/src/mainboard/google/parrot/chromeos.fmd index 6752888..90e59de 100644 --- a/src/mainboard/google/parrot/chromeos.fmd +++ b/src/mainboard/google/parrot/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xff800000 0x800000 { +FLASH 0x800000 { SI_ALL@0x0 0x200000 { SI_DESC@0x0 0x1000 SI_ME@0x1000 0x1ff000 diff --git a/src/mainboard/google/peach_pit/chromeos.fmd b/src/mainboard/google/peach_pit/chromeos.fmd index 63bde33..60794a8 100644 --- a/src/mainboard/google/peach_pit/chromeos.fmd +++ b/src/mainboard/google/peach_pit/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0x0 0x400000 { +FLASH 0x400000 { WP_RO@0x0 0x200000 { RO_SECTION@0x0 0x1f0000 { BOOTBLOCK@0 128K diff --git a/src/mainboard/google/poppy/chromeos.fmd b/src/mainboard/google/poppy/chromeos.fmd index 1cc4a61..92bca1b 100644 --- a/src/mainboard/google/poppy/chromeos.fmd +++ b/src/mainboard/google/poppy/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xff000000 0x1000000 { +FLASH 0x1000000 { SI_ALL@0x0 0x200000 { SI_DESC@0x0 0x1000 SI_ME@0x1000 0x1ff000 diff --git a/src/mainboard/google/rambi/chromeos.fmd b/src/mainboard/google/rambi/chromeos.fmd index 923c8ee..dae8796 100644 --- a/src/mainboard/google/rambi/chromeos.fmd +++ b/src/mainboard/google/rambi/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xff800000 0x800000 { +FLASH 0x800000 { SI_ALL@0x0 0x200000 { SI_DESC@0x0 0x1000 SI_ME@0x1000 0x1ff000 diff --git a/src/mainboard/google/sarien/chromeos.fmd b/src/mainboard/google/sarien/chromeos.fmd index 65a915a..18d3cf1 100644 --- a/src/mainboard/google/sarien/chromeos.fmd +++ b/src/mainboard/google/sarien/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xfe000000 0x2000000 { +FLASH 0x2000000 { SI_ALL@0x0 0x400000 { SI_DESC@0x0 0x1000 SI_EC@0x1000 0x100000 diff --git a/src/mainboard/google/skyrim/chromeos.fmd b/src/mainboard/google/skyrim/chromeos.fmd index c114c03..7dbc94c 100644 --- a/src/mainboard/google/skyrim/chromeos.fmd +++ b/src/mainboard/google/skyrim/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xFF000000 16M { +FLASH 16M { SI_BIOS { RW_MRC_CACHE(PRESERVE) 96K RW_SECTION_A 3M { diff --git a/src/mainboard/google/slippy/chromeos.fmd b/src/mainboard/google/slippy/chromeos.fmd index 923c8ee..dae8796 100644 --- a/src/mainboard/google/slippy/chromeos.fmd +++ b/src/mainboard/google/slippy/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xff800000 0x800000 { +FLASH 0x800000 { SI_ALL@0x0 0x200000 { SI_DESC@0x0 0x1000 SI_ME@0x1000 0x1ff000 diff --git a/src/mainboard/google/smaug/chromeos.fmd b/src/mainboard/google/smaug/chromeos.fmd index 4b1ba19..545949b 100644 --- a/src/mainboard/google/smaug/chromeos.fmd +++ b/src/mainboard/google/smaug/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0x0 0x1000000 { +FLASH 0x1000000 { WP_RO@0x0 0x500000 { RO_SECTION@0x0 0x4f0000 { BOOTBLOCK@0 128K diff --git a/src/mainboard/google/storm/chromeos.fmd b/src/mainboard/google/storm/chromeos.fmd index 3a55bdc..4d3c913 100644 --- a/src/mainboard/google/storm/chromeos.fmd +++ b/src/mainboard/google/storm/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0x0 0x800000 { +FLASH 0x800000 { WP_RO@0x0 0x400000 { RO_SECTION@0x0 0x3e0000 { BOOTBLOCK@0 128K diff --git a/src/mainboard/google/stout/chromeos.fmd b/src/mainboard/google/stout/chromeos.fmd index 93048a3..ef8ca78 100644 --- a/src/mainboard/google/stout/chromeos.fmd +++ b/src/mainboard/google/stout/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xff800000 0x800000 { +FLASH 0x800000 { SI_ALL@0x0 0x200000 { SI_DESC@0x0 0x1000 SI_ME@0x1000 0x1ff000 diff --git a/src/mainboard/google/trogdor/chromeos.fmd b/src/mainboard/google/trogdor/chromeos.fmd index f696076..aa311df 100644 --- a/src/mainboard/google/trogdor/chromeos.fmd +++ b/src/mainboard/google/trogdor/chromeos.fmd @@ -1,6 +1,6 @@ ## SPDX-License-Identifier: GPL-2.0-only -FLASH@0x0 8M { +FLASH 8M { WP_RO 4M { RO_SECTION 0x3e4000 { BOOTBLOCK 96K diff --git a/src/mainboard/google/veyron/chromeos.fmd b/src/mainboard/google/veyron/chromeos.fmd index ebc6eb1..0e08f10 100644 --- a/src/mainboard/google/veyron/chromeos.fmd +++ b/src/mainboard/google/veyron/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0x0 0x400000 { +FLASH 0x400000 { WP_RO@0x0 0x200000 { RO_SECTION@0x0 0x1f0000 { BOOTBLOCK@0 128K diff --git a/src/mainboard/google/veyron_mickey/chromeos.fmd b/src/mainboard/google/veyron_mickey/chromeos.fmd index 76ab2c3..882d098 100644 --- a/src/mainboard/google/veyron_mickey/chromeos.fmd +++ b/src/mainboard/google/veyron_mickey/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0x0 0x400000 { +FLASH 0x400000 { WP_RO@0x0 0x200000 { RO_SECTION@0x0 0x1f0000 { BOOTBLOCK@0 128K diff --git a/src/mainboard/google/veyron_rialto/chromeos.fmd b/src/mainboard/google/veyron_rialto/chromeos.fmd index df35976..9df6494 100644 --- a/src/mainboard/google/veyron_rialto/chromeos.fmd +++ b/src/mainboard/google/veyron_rialto/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0x0 0x400000 { +FLASH 0x400000 { WP_RO@0x0 0x200000 { RO_SECTION@0x0 0x1f0000 { BOOTBLOCK@0 128K diff --git a/src/mainboard/google/zork/chromeos.fmd b/src/mainboard/google/zork/chromeos.fmd index 4d2eda0..45db7c8 100644 --- a/src/mainboard/google/zork/chromeos.fmd +++ b/src/mainboard/google/zork/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xFF000000 16M { +FLASH 16M { SI_BIOS { RW_MRC_CACHE(PRESERVE) 64K RW_SECTION_A 3M { diff --git a/src/mainboard/intel/baskingridge/chromeos.fmd b/src/mainboard/intel/baskingridge/chromeos.fmd index 9852a22..32e2ab1 100644 --- a/src/mainboard/intel/baskingridge/chromeos.fmd +++ b/src/mainboard/intel/baskingridge/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xff800000 0x800000 { +FLASH 0x800000 { SI_ALL@0x0 0x180000 { SI_DESC@0x0 0x1000 SI_ME@0x1000 0x17f000 diff --git a/src/mainboard/intel/cedarisland_crb/board.fmd b/src/mainboard/intel/cedarisland_crb/board.fmd index 2002f6e..0b4c21a 100644 --- a/src/mainboard/intel/cedarisland_crb/board.fmd +++ b/src/mainboard/intel/cedarisland_crb/board.fmd @@ -1,4 +1,4 @@ -FLASH@0xfc000000 64M { +FLASH 64M { SI_ALL@0x0 0x2fe8000 { SI_DESC@0x0 0x1000 SI_GBE@0x1000 0x2000 diff --git a/src/mainboard/intel/coffeelake_rvp/chromeos.fmd b/src/mainboard/intel/coffeelake_rvp/chromeos.fmd index 39bd6c5..da4e70e 100644 --- a/src/mainboard/intel/coffeelake_rvp/chromeos.fmd +++ b/src/mainboard/intel/coffeelake_rvp/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xff000000 0x1000000 { +FLASH 0x1000000 { SI_ALL@0x0 0x380000 { SI_DESC@0x0 0x1000 SI_EC@0x01000 0x80000 diff --git a/src/mainboard/intel/coffeelake_rvp/chromeos_32MB.fmd b/src/mainboard/intel/coffeelake_rvp/chromeos_32MB.fmd index 62e0f5d..d6977c1 100644 --- a/src/mainboard/intel/coffeelake_rvp/chromeos_32MB.fmd +++ b/src/mainboard/intel/coffeelake_rvp/chromeos_32MB.fmd @@ -1,4 +1,4 @@ -FLASH@0xfe000000 0x2000000 { +FLASH 0x2000000 { SI_ALL@0x0 0x1081000 { SI_DESC@0x0 0x1000 SI_EC@0x1000 0x80000 diff --git a/src/mainboard/intel/galileo/vboot.fmd b/src/mainboard/intel/galileo/vboot.fmd index 3a64387..df7fc72 100644 --- a/src/mainboard/intel/galileo/vboot.fmd +++ b/src/mainboard/intel/galileo/vboot.fmd @@ -10,7 +10,7 @@ # GNU General Public License for more details. # -FLASH@0xff800000 0x800000 { +FLASH 0x800000 { SI_ALL@0x0 0x200000 { SI_DESC@0x0 0x1000 SI_ME@0x1000 0x1ff000 diff --git a/src/mainboard/intel/icelake_rvp/chromeos.fmd b/src/mainboard/intel/icelake_rvp/chromeos.fmd index f4db8b4..e7cf005 100644 --- a/src/mainboard/intel/icelake_rvp/chromeos.fmd +++ b/src/mainboard/intel/icelake_rvp/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xff000000 0x1000000 { +FLASH 0x1000000 { SI_ALL@0x0 0x3F0000 { SI_DESC@0x0 0x1000 SI_EC@0x1000 0x80000 diff --git a/src/mainboard/intel/jasperlake_rvp/chromeos.fmd b/src/mainboard/intel/jasperlake_rvp/chromeos.fmd index e4e0b24..5906778 100644 --- a/src/mainboard/intel/jasperlake_rvp/chromeos.fmd +++ b/src/mainboard/intel/jasperlake_rvp/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xff000000 0x1000000 { +FLASH 0x1000000 { SI_ALL@0x0 0x381000 { SI_DESC@0x0 0x1000 SI_EC@0x1000 0x80000 diff --git a/src/mainboard/intel/kblrvp/chromeos.fmd b/src/mainboard/intel/kblrvp/chromeos.fmd index 9ba1bf7..8132712 100644 --- a/src/mainboard/intel/kblrvp/chromeos.fmd +++ b/src/mainboard/intel/kblrvp/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xff000000 0x1000000 { +FLASH 0x1000000 { SI_ALL@0x0 0x200000 { SI_DESC@0x0 0x1000 SI_ME@0x1000 0x1ff000 diff --git a/src/mainboard/intel/kunimitsu/chromeos.fmd b/src/mainboard/intel/kunimitsu/chromeos.fmd index 9ba1bf7..8132712 100644 --- a/src/mainboard/intel/kunimitsu/chromeos.fmd +++ b/src/mainboard/intel/kunimitsu/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xff000000 0x1000000 { +FLASH 0x1000000 { SI_ALL@0x0 0x200000 { SI_DESC@0x0 0x1000 SI_ME@0x1000 0x1ff000 diff --git a/src/mainboard/intel/shadowmountain/chromeos.fmd b/src/mainboard/intel/shadowmountain/chromeos.fmd index a4b8643..6560d22 100644 --- a/src/mainboard/intel/shadowmountain/chromeos.fmd +++ b/src/mainboard/intel/shadowmountain/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xfe000000 0x2000000 { +FLASH 0x2000000 { SI_ALL@0x0 0x1000000 { SI_DESC@0x0 0x1000 SI_ME@0x1000 0xfff000 diff --git a/src/mainboard/intel/strago/chromeos.fmd b/src/mainboard/intel/strago/chromeos.fmd index 923c8ee..dae8796 100644 --- a/src/mainboard/intel/strago/chromeos.fmd +++ b/src/mainboard/intel/strago/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xff800000 0x800000 { +FLASH 0x800000 { SI_ALL@0x0 0x200000 { SI_DESC@0x0 0x1000 SI_ME@0x1000 0x1ff000 diff --git a/src/mainboard/intel/tglrvp/chromeos.fmd b/src/mainboard/intel/tglrvp/chromeos.fmd index 1e2e792..78a825e 100644 --- a/src/mainboard/intel/tglrvp/chromeos.fmd +++ b/src/mainboard/intel/tglrvp/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xfe000000 0x2000000 { +FLASH 0x2000000 { SI_ALL@0x0 0x1000000 { SI_DESC@0x0 0x1000 SI_EC@0x1000 0x80000 diff --git a/src/mainboard/intel/wtm2/chromeos.fmd b/src/mainboard/intel/wtm2/chromeos.fmd index 9852a22..32e2ab1 100644 --- a/src/mainboard/intel/wtm2/chromeos.fmd +++ b/src/mainboard/intel/wtm2/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xff800000 0x800000 { +FLASH 0x800000 { SI_ALL@0x0 0x180000 { SI_DESC@0x0 0x1000 SI_ME@0x1000 0x17f000 diff --git a/src/mainboard/lenovo/t400/vboot-rwa.fmd b/src/mainboard/lenovo/t400/vboot-rwa.fmd index 4af3fcd..4c0ee9e 100644 --- a/src/mainboard/lenovo/t400/vboot-rwa.fmd +++ b/src/mainboard/lenovo/t400/vboot-rwa.fmd @@ -1,4 +1,4 @@ -FLASH@0xff800000 0x800000 { +FLASH 0x800000 { SI_ALL@0x0 0x600000 { SI_DESC@0x0 0x1000 SI_ME@0x1000 0x5f5000 diff --git a/src/mainboard/lenovo/t410/vboot-rwa.fmd b/src/mainboard/lenovo/t410/vboot-rwa.fmd index 8f50d33..951077a 100644 --- a/src/mainboard/lenovo/t410/vboot-rwa.fmd +++ b/src/mainboard/lenovo/t410/vboot-rwa.fmd @@ -1,4 +1,4 @@ -FLASH@0xff800000 0x800000 { +FLASH 0x800000 { SI_ALL@0x0 0x500000 { SI_DESC@0x0 0x1000 SI_GBE@0x1000 0x2000 diff --git a/src/mainboard/lenovo/t420/vboot-ro-me_clean.fmd b/src/mainboard/lenovo/t420/vboot-ro-me_clean.fmd index d1cbff7..5f490f8 100644 --- a/src/mainboard/lenovo/t420/vboot-ro-me_clean.fmd +++ b/src/mainboard/lenovo/t420/vboot-ro-me_clean.fmd @@ -1,4 +1,4 @@ -FLASH@0xff800000 0x800000 { +FLASH 0x800000 { SI_ALL 0x20000 { SI_DESC 0x1000 SI_GBE 0x2000 diff --git a/src/mainboard/lenovo/t420/vboot-ro.fmd b/src/mainboard/lenovo/t420/vboot-ro.fmd index 51df8a5..bbcbba5 100644 --- a/src/mainboard/lenovo/t420/vboot-ro.fmd +++ b/src/mainboard/lenovo/t420/vboot-ro.fmd @@ -1,4 +1,4 @@ -FLASH@0xff800000 0x800000 { +FLASH 0x800000 { SI_ALL 0x500000 { SI_DESC 0x1000 SI_GBE 0x2000 diff --git a/src/mainboard/lenovo/t420/vboot-rwa.fmd b/src/mainboard/lenovo/t420/vboot-rwa.fmd index 8a4cd3b..6b7577c 100644 --- a/src/mainboard/lenovo/t420/vboot-rwa.fmd +++ b/src/mainboard/lenovo/t420/vboot-rwa.fmd @@ -1,4 +1,4 @@ -FLASH@0xff800000 0x800000 { +FLASH 0x800000 { SI_ALL@0x0 0x500000 { SI_DESC@0x0 0x1000 SI_GBE@0x1000 0x2000 diff --git a/src/mainboard/lenovo/t420s/vboot-ro-me_clean.fmd b/src/mainboard/lenovo/t420s/vboot-ro-me_clean.fmd index d1cbff7..5f490f8 100644 --- a/src/mainboard/lenovo/t420s/vboot-ro-me_clean.fmd +++ b/src/mainboard/lenovo/t420s/vboot-ro-me_clean.fmd @@ -1,4 +1,4 @@ -FLASH@0xff800000 0x800000 { +FLASH 0x800000 { SI_ALL 0x20000 { SI_DESC 0x1000 SI_GBE 0x2000 diff --git a/src/mainboard/lenovo/t420s/vboot-ro.fmd b/src/mainboard/lenovo/t420s/vboot-ro.fmd index 51df8a5..bbcbba5 100644 --- a/src/mainboard/lenovo/t420s/vboot-ro.fmd +++ b/src/mainboard/lenovo/t420s/vboot-ro.fmd @@ -1,4 +1,4 @@ -FLASH@0xff800000 0x800000 { +FLASH 0x800000 { SI_ALL 0x500000 { SI_DESC 0x1000 SI_GBE 0x2000 diff --git a/src/mainboard/lenovo/t420s/vboot-rwa.fmd b/src/mainboard/lenovo/t420s/vboot-rwa.fmd index 8a4cd3b..6b7577c 100644 --- a/src/mainboard/lenovo/t420s/vboot-rwa.fmd +++ b/src/mainboard/lenovo/t420s/vboot-rwa.fmd @@ -1,4 +1,4 @@ -FLASH@0xff800000 0x800000 { +FLASH 0x800000 { SI_ALL@0x0 0x500000 { SI_DESC@0x0 0x1000 SI_GBE@0x1000 0x2000 diff --git a/src/mainboard/lenovo/t430/vboot-ro-me_clean.fmd b/src/mainboard/lenovo/t430/vboot-ro-me_clean.fmd index 565cacd..5101caa 100644 --- a/src/mainboard/lenovo/t430/vboot-ro-me_clean.fmd +++ b/src/mainboard/lenovo/t430/vboot-ro-me_clean.fmd @@ -1,4 +1,4 @@ -FLASH@0xff400000 0xc00000 { +FLASH 0xc00000 { SI_ALL 0x20000 { SI_DESC 0x1000 SI_GBE 0x2000 diff --git a/src/mainboard/lenovo/t430/vboot-ro.fmd b/src/mainboard/lenovo/t430/vboot-ro.fmd index 6bdd4cc..027849b 100644 --- a/src/mainboard/lenovo/t430/vboot-ro.fmd +++ b/src/mainboard/lenovo/t430/vboot-ro.fmd @@ -1,4 +1,4 @@ -FLASH@0xff400000 0xc00000 { +FLASH 0xc00000 { SI_ALL 0x500000 { SI_DESC 0x1000 SI_GBE 0x2000 diff --git a/src/mainboard/lenovo/t430/vboot-rwab.fmd b/src/mainboard/lenovo/t430/vboot-rwab.fmd index 1747c0e..df47ff1 100644 --- a/src/mainboard/lenovo/t430/vboot-rwab.fmd +++ b/src/mainboard/lenovo/t430/vboot-rwab.fmd @@ -1,4 +1,4 @@ -FLASH@0xff400000 0xc00000 { +FLASH 0xc00000 { SI_ALL@0x0 0x500000 { SI_DESC@0x0 0x1000 SI_GBE@0x1000 0x2000 diff --git a/src/mainboard/lenovo/t430s/vboot-ro-me_clean.fmd b/src/mainboard/lenovo/t430s/vboot-ro-me_clean.fmd index 565cacd..5101caa 100644 --- a/src/mainboard/lenovo/t430s/vboot-ro-me_clean.fmd +++ b/src/mainboard/lenovo/t430s/vboot-ro-me_clean.fmd @@ -1,4 +1,4 @@ -FLASH@0xff400000 0xc00000 { +FLASH 0xc00000 { SI_ALL 0x20000 { SI_DESC 0x1000 SI_GBE 0x2000 diff --git a/src/mainboard/lenovo/t430s/vboot-ro.fmd b/src/mainboard/lenovo/t430s/vboot-ro.fmd index 6bdd4cc..027849b 100644 --- a/src/mainboard/lenovo/t430s/vboot-ro.fmd +++ b/src/mainboard/lenovo/t430s/vboot-ro.fmd @@ -1,4 +1,4 @@ -FLASH@0xff400000 0xc00000 { +FLASH 0xc00000 { SI_ALL 0x500000 { SI_DESC 0x1000 SI_GBE 0x2000 diff --git a/src/mainboard/lenovo/t430s/vboot-rwab.fmd b/src/mainboard/lenovo/t430s/vboot-rwab.fmd index 1747c0e..df47ff1 100644 --- a/src/mainboard/lenovo/t430s/vboot-rwab.fmd +++ b/src/mainboard/lenovo/t430s/vboot-rwab.fmd @@ -1,4 +1,4 @@ -FLASH@0xff400000 0xc00000 { +FLASH 0xc00000 { SI_ALL@0x0 0x500000 { SI_DESC@0x0 0x1000 SI_GBE@0x1000 0x2000 diff --git a/src/mainboard/lenovo/t440p/vboot-ro-me_clean.fmd b/src/mainboard/lenovo/t440p/vboot-ro-me_clean.fmd index 565cacd..5101caa 100644 --- a/src/mainboard/lenovo/t440p/vboot-ro-me_clean.fmd +++ b/src/mainboard/lenovo/t440p/vboot-ro-me_clean.fmd @@ -1,4 +1,4 @@ -FLASH@0xff400000 0xc00000 { +FLASH 0xc00000 { SI_ALL 0x20000 { SI_DESC 0x1000 SI_GBE 0x2000 diff --git a/src/mainboard/lenovo/t440p/vboot-ro.fmd b/src/mainboard/lenovo/t440p/vboot-ro.fmd index 6bdd4cc..027849b 100644 --- a/src/mainboard/lenovo/t440p/vboot-ro.fmd +++ b/src/mainboard/lenovo/t440p/vboot-ro.fmd @@ -1,4 +1,4 @@ -FLASH@0xff400000 0xc00000 { +FLASH 0xc00000 { SI_ALL 0x500000 { SI_DESC 0x1000 SI_GBE 0x2000 diff --git a/src/mainboard/lenovo/t440p/vboot-rwab.fmd b/src/mainboard/lenovo/t440p/vboot-rwab.fmd index 1747c0e..df47ff1 100644 --- a/src/mainboard/lenovo/t440p/vboot-rwab.fmd +++ b/src/mainboard/lenovo/t440p/vboot-rwab.fmd @@ -1,4 +1,4 @@ -FLASH@0xff400000 0xc00000 { +FLASH 0xc00000 { SI_ALL@0x0 0x500000 { SI_DESC@0x0 0x1000 SI_GBE@0x1000 0x2000 diff --git a/src/mainboard/lenovo/t520/vboot-ro-me_clean.fmd b/src/mainboard/lenovo/t520/vboot-ro-me_clean.fmd index d1cbff7..5f490f8 100644 --- a/src/mainboard/lenovo/t520/vboot-ro-me_clean.fmd +++ b/src/mainboard/lenovo/t520/vboot-ro-me_clean.fmd @@ -1,4 +1,4 @@ -FLASH@0xff800000 0x800000 { +FLASH 0x800000 { SI_ALL 0x20000 { SI_DESC 0x1000 SI_GBE 0x2000 diff --git a/src/mainboard/lenovo/t520/vboot-ro.fmd b/src/mainboard/lenovo/t520/vboot-ro.fmd index 51df8a5..bbcbba5 100644 --- a/src/mainboard/lenovo/t520/vboot-ro.fmd +++ b/src/mainboard/lenovo/t520/vboot-ro.fmd @@ -1,4 +1,4 @@ -FLASH@0xff800000 0x800000 { +FLASH 0x800000 { SI_ALL 0x500000 { SI_DESC 0x1000 SI_GBE 0x2000 diff --git a/src/mainboard/lenovo/t520/vboot-rwa.fmd b/src/mainboard/lenovo/t520/vboot-rwa.fmd index 8a4cd3b..6b7577c 100644 --- a/src/mainboard/lenovo/t520/vboot-rwa.fmd +++ b/src/mainboard/lenovo/t520/vboot-rwa.fmd @@ -1,4 +1,4 @@ -FLASH@0xff800000 0x800000 { +FLASH 0x800000 { SI_ALL@0x0 0x500000 { SI_DESC@0x0 0x1000 SI_GBE@0x1000 0x2000 diff --git a/src/mainboard/lenovo/t530/vboot-ro-me_clean.fmd b/src/mainboard/lenovo/t530/vboot-ro-me_clean.fmd index 565cacd..5101caa 100644 --- a/src/mainboard/lenovo/t530/vboot-ro-me_clean.fmd +++ b/src/mainboard/lenovo/t530/vboot-ro-me_clean.fmd @@ -1,4 +1,4 @@ -FLASH@0xff400000 0xc00000 { +FLASH 0xc00000 { SI_ALL 0x20000 { SI_DESC 0x1000 SI_GBE 0x2000 diff --git a/src/mainboard/lenovo/t530/vboot-ro.fmd b/src/mainboard/lenovo/t530/vboot-ro.fmd index 6bdd4cc..027849b 100644 --- a/src/mainboard/lenovo/t530/vboot-ro.fmd +++ b/src/mainboard/lenovo/t530/vboot-ro.fmd @@ -1,4 +1,4 @@ -FLASH@0xff400000 0xc00000 { +FLASH 0xc00000 { SI_ALL 0x500000 { SI_DESC 0x1000 SI_GBE 0x2000 diff --git a/src/mainboard/lenovo/t530/vboot-rwab.fmd b/src/mainboard/lenovo/t530/vboot-rwab.fmd index 1747c0e..df47ff1 100644 --- a/src/mainboard/lenovo/t530/vboot-rwab.fmd +++ b/src/mainboard/lenovo/t530/vboot-rwab.fmd @@ -1,4 +1,4 @@ -FLASH@0xff400000 0xc00000 { +FLASH 0xc00000 { SI_ALL@0x0 0x500000 { SI_DESC@0x0 0x1000 SI_GBE@0x1000 0x2000 diff --git a/src/mainboard/lenovo/x131e/vboot-ro-me_clean.fmd b/src/mainboard/lenovo/x131e/vboot-ro-me_clean.fmd index 565cacd..5101caa 100644 --- a/src/mainboard/lenovo/x131e/vboot-ro-me_clean.fmd +++ b/src/mainboard/lenovo/x131e/vboot-ro-me_clean.fmd @@ -1,4 +1,4 @@ -FLASH@0xff400000 0xc00000 { +FLASH 0xc00000 { SI_ALL 0x20000 { SI_DESC 0x1000 SI_GBE 0x2000 diff --git a/src/mainboard/lenovo/x131e/vboot-ro.fmd b/src/mainboard/lenovo/x131e/vboot-ro.fmd index 6bdd4cc..027849b 100644 --- a/src/mainboard/lenovo/x131e/vboot-ro.fmd +++ b/src/mainboard/lenovo/x131e/vboot-ro.fmd @@ -1,4 +1,4 @@ -FLASH@0xff400000 0xc00000 { +FLASH 0xc00000 { SI_ALL 0x500000 { SI_DESC 0x1000 SI_GBE 0x2000 diff --git a/src/mainboard/lenovo/x131e/vboot-rwab.fmd b/src/mainboard/lenovo/x131e/vboot-rwab.fmd index 1747c0e..df47ff1 100644 --- a/src/mainboard/lenovo/x131e/vboot-rwab.fmd +++ b/src/mainboard/lenovo/x131e/vboot-rwab.fmd @@ -1,4 +1,4 @@ -FLASH@0xff400000 0xc00000 { +FLASH 0xc00000 { SI_ALL@0x0 0x500000 { SI_DESC@0x0 0x1000 SI_GBE@0x1000 0x2000 diff --git a/src/mainboard/lenovo/x1_carbon_gen1/vboot-ro-me_clean.fmd b/src/mainboard/lenovo/x1_carbon_gen1/vboot-ro-me_clean.fmd index 565cacd..5101caa 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/vboot-ro-me_clean.fmd +++ b/src/mainboard/lenovo/x1_carbon_gen1/vboot-ro-me_clean.fmd @@ -1,4 +1,4 @@ -FLASH@0xff400000 0xc00000 { +FLASH 0xc00000 { SI_ALL 0x20000 { SI_DESC 0x1000 SI_GBE 0x2000 diff --git a/src/mainboard/lenovo/x1_carbon_gen1/vboot-ro.fmd b/src/mainboard/lenovo/x1_carbon_gen1/vboot-ro.fmd index 6bdd4cc..027849b 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/vboot-ro.fmd +++ b/src/mainboard/lenovo/x1_carbon_gen1/vboot-ro.fmd @@ -1,4 +1,4 @@ -FLASH@0xff400000 0xc00000 { +FLASH 0xc00000 { SI_ALL 0x500000 { SI_DESC 0x1000 SI_GBE 0x2000 diff --git a/src/mainboard/lenovo/x1_carbon_gen1/vboot-rwab.fmd b/src/mainboard/lenovo/x1_carbon_gen1/vboot-rwab.fmd index 1747c0e..df47ff1 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/vboot-rwab.fmd +++ b/src/mainboard/lenovo/x1_carbon_gen1/vboot-rwab.fmd @@ -1,4 +1,4 @@ -FLASH@0xff400000 0xc00000 { +FLASH 0xc00000 { SI_ALL@0x0 0x500000 { SI_DESC@0x0 0x1000 SI_GBE@0x1000 0x2000 diff --git a/src/mainboard/lenovo/x200/vboot-rwa.fmd b/src/mainboard/lenovo/x200/vboot-rwa.fmd index 4af3fcd..4c0ee9e 100644 --- a/src/mainboard/lenovo/x200/vboot-rwa.fmd +++ b/src/mainboard/lenovo/x200/vboot-rwa.fmd @@ -1,4 +1,4 @@ -FLASH@0xff800000 0x800000 { +FLASH 0x800000 { SI_ALL@0x0 0x600000 { SI_DESC@0x0 0x1000 SI_ME@0x1000 0x5f5000 diff --git a/src/mainboard/lenovo/x201/vboot-rwa.fmd b/src/mainboard/lenovo/x201/vboot-rwa.fmd index 0d1aa5d..3399416 100644 --- a/src/mainboard/lenovo/x201/vboot-rwa.fmd +++ b/src/mainboard/lenovo/x201/vboot-rwa.fmd @@ -1,4 +1,4 @@ -FLASH@0xff800000 0x800000 { +FLASH 0x800000 { SI_ALL@0x0 0x500000 { SI_DESC@0x0 0x1000 SI_GBE@0x1000 0x2000 diff --git a/src/mainboard/lenovo/x220/vboot-ro-me_clean.fmd b/src/mainboard/lenovo/x220/vboot-ro-me_clean.fmd index d1cbff7..5f490f8 100644 --- a/src/mainboard/lenovo/x220/vboot-ro-me_clean.fmd +++ b/src/mainboard/lenovo/x220/vboot-ro-me_clean.fmd @@ -1,4 +1,4 @@ -FLASH@0xff800000 0x800000 { +FLASH 0x800000 { SI_ALL 0x20000 { SI_DESC 0x1000 SI_GBE 0x2000 diff --git a/src/mainboard/lenovo/x220/vboot-ro.fmd b/src/mainboard/lenovo/x220/vboot-ro.fmd index 51df8a5..bbcbba5 100644 --- a/src/mainboard/lenovo/x220/vboot-ro.fmd +++ b/src/mainboard/lenovo/x220/vboot-ro.fmd @@ -1,4 +1,4 @@ -FLASH@0xff800000 0x800000 { +FLASH 0x800000 { SI_ALL 0x500000 { SI_DESC 0x1000 SI_GBE 0x2000 diff --git a/src/mainboard/lenovo/x220/vboot-rwa.fmd b/src/mainboard/lenovo/x220/vboot-rwa.fmd index 8a4cd3b..6b7577c 100644 --- a/src/mainboard/lenovo/x220/vboot-rwa.fmd +++ b/src/mainboard/lenovo/x220/vboot-rwa.fmd @@ -1,4 +1,4 @@ -FLASH@0xff800000 0x800000 { +FLASH 0x800000 { SI_ALL@0x0 0x500000 { SI_DESC@0x0 0x1000 SI_GBE@0x1000 0x2000 diff --git a/src/mainboard/lenovo/x230/vboot-ro-me_clean.fmd b/src/mainboard/lenovo/x230/vboot-ro-me_clean.fmd index 565cacd..5101caa 100644 --- a/src/mainboard/lenovo/x230/vboot-ro-me_clean.fmd +++ b/src/mainboard/lenovo/x230/vboot-ro-me_clean.fmd @@ -1,4 +1,4 @@ -FLASH@0xff400000 0xc00000 { +FLASH 0xc00000 { SI_ALL 0x20000 { SI_DESC 0x1000 SI_GBE 0x2000 diff --git a/src/mainboard/lenovo/x230/vboot-ro.fmd b/src/mainboard/lenovo/x230/vboot-ro.fmd index 6bdd4cc..027849b 100644 --- a/src/mainboard/lenovo/x230/vboot-ro.fmd +++ b/src/mainboard/lenovo/x230/vboot-ro.fmd @@ -1,4 +1,4 @@ -FLASH@0xff400000 0xc00000 { +FLASH 0xc00000 { SI_ALL 0x500000 { SI_DESC 0x1000 SI_GBE 0x2000 diff --git a/src/mainboard/lenovo/x230/vboot-rwab.fmd b/src/mainboard/lenovo/x230/vboot-rwab.fmd index 1747c0e..df47ff1 100644 --- a/src/mainboard/lenovo/x230/vboot-rwab.fmd +++ b/src/mainboard/lenovo/x230/vboot-rwab.fmd @@ -1,4 +1,4 @@ -FLASH@0xff400000 0xc00000 { +FLASH 0xc00000 { SI_ALL@0x0 0x500000 { SI_DESC@0x0 0x1000 SI_GBE@0x1000 0x2000 diff --git a/src/mainboard/lenovo/x60/vboot-rwa.fmd b/src/mainboard/lenovo/x60/vboot-rwa.fmd index b21cff3..2965a0e 100644 --- a/src/mainboard/lenovo/x60/vboot-rwa.fmd +++ b/src/mainboard/lenovo/x60/vboot-rwa.fmd @@ -1,4 +1,4 @@ -FLASH@0xffe00000 0x200000 { +FLASH 0x200000 { BIOS { RW_SECTION_A 0x100000 { VBLOCK_A 0x10000 diff --git a/src/mainboard/opencellular/elgon/board.fmd b/src/mainboard/opencellular/elgon/board.fmd index 784f3b0..d19c0a1 100644 --- a/src/mainboard/opencellular/elgon/board.fmd +++ b/src/mainboard/opencellular/elgon/board.fmd @@ -1,4 +1,4 @@ -FLASH@0x0 16M { +FLASH 16M { WP_RO@0x0 0x1000000 { RO_SECTION@0x0 0xffc000 { # 0 - 0x10000 is free for firmware usage. diff --git a/src/mainboard/opencellular/elgon/vboot.fmd b/src/mainboard/opencellular/elgon/vboot.fmd index 0d6af2d..7b27011 100644 --- a/src/mainboard/opencellular/elgon/vboot.fmd +++ b/src/mainboard/opencellular/elgon/vboot.fmd @@ -1,4 +1,4 @@ -FLASH@0x0 16M { +FLASH 16M { # must use a power of two in MiB for WP_RO WP_RO@0x0 0x400000 { RO_SECTION@0x0 0x3fc000 { diff --git a/src/mainboard/samsung/lumpy/chromeos.fmd b/src/mainboard/samsung/lumpy/chromeos.fmd index 9852a22..32e2ab1 100644 --- a/src/mainboard/samsung/lumpy/chromeos.fmd +++ b/src/mainboard/samsung/lumpy/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xff800000 0x800000 { +FLASH 0x800000 { SI_ALL@0x0 0x180000 { SI_DESC@0x0 0x1000 SI_ME@0x1000 0x17f000 diff --git a/src/mainboard/samsung/stumpy/chromeos.fmd b/src/mainboard/samsung/stumpy/chromeos.fmd index 9852a22..32e2ab1 100644 --- a/src/mainboard/samsung/stumpy/chromeos.fmd +++ b/src/mainboard/samsung/stumpy/chromeos.fmd @@ -1,4 +1,4 @@ -FLASH@0xff800000 0x800000 { +FLASH 0x800000 { SI_ALL@0x0 0x180000 { SI_DESC@0x0 0x1000 SI_ME@0x1000 0x17f000 diff --git a/src/mainboard/siemens/mc_ehl/mc_ehl.fmd b/src/mainboard/siemens/mc_ehl/mc_ehl.fmd index 78faf2b..8196ece 100644 --- a/src/mainboard/siemens/mc_ehl/mc_ehl.fmd +++ b/src/mainboard/siemens/mc_ehl/mc_ehl.fmd @@ -1,4 +1,4 @@ -FLASH @0xff000000 CONFIG_ROM_SIZE { +FLASH CONFIG_ROM_SIZE { SI_ALL 0x400000 { SI_DESC 0x1000 SI_ME 0x3ff000 diff --git a/src/mainboard/starlabs/labtop/variants/tgl/board.fmd b/src/mainboard/starlabs/labtop/variants/tgl/board.fmd index 932739e..971ed4f 100644 --- a/src/mainboard/starlabs/labtop/variants/tgl/board.fmd +++ b/src/mainboard/starlabs/labtop/variants/tgl/board.fmd @@ -2,7 +2,7 @@ # Manually defined FMD in order to ensure that space is reserved for the EC # at the top of the BIOS region. # -FLASH@0xff000000 0x1000000 { +FLASH 0x1000000 { SI_ALL@0x0 0x500000 { SI_DESC@0x0 0x1000 SI_ME@0x1000 diff --git a/src/mainboard/ti/beaglebone/board.fmd b/src/mainboard/ti/beaglebone/board.fmd index 0656b85..7579ac6 100644 --- a/src/mainboard/ti/beaglebone/board.fmd +++ b/src/mainboard/ti/beaglebone/board.fmd @@ -1,4 +1,4 @@ -FLASH@0x000 32M { +FLASH 32M { BIOS@0x0 109K { BOOTBLOCK@0x0 20K } -- To view, visit https://review.coreboot.org/c/coreboot/+/63771 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iac86ef9be6b14817a65bf3a7ccb624d205ca3f99 Gerrit-Change-Number: 63771 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Stefan Ott <coreboot(a)desire.ch> Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: Kconfig: Add an option to omit a cbfs master header
by Arthur Heymans (Code Review) 22 Apr '22

22 Apr '22

Attention is currently required from: Arthur Heymans, Angel Pons, Julius Werner. Hello build bot (Jenkins), Christian Walter, Angel Pons, Julius Werner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63378 to look at the new patch set (#5). Change subject: Kconfig: Add an option to omit a cbfs master header ...................................................................... Kconfig: Add an option to omit a cbfs master header The CBFS master header is legacy feature that has no internal use in coreboot. Some payloads do depend on it however. Change-Id: Ib3d5b32412db40df48c0ed4dd6216bdd9cb955e2 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/Kconfig M src/lib/Makefile.inc 2 files changed, 12 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/63378/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/63378 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib3d5b32412db40df48c0ed4dd6216bdd9cb955e2 Gerrit-Change-Number: 63378 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: tpm: Allow separate handling of Google Ti50 TPM
by Julius Werner (Code Review) 22 Apr '22

22 Apr '22

Attention is currently required from: Jes Klinke, Tim Wawrzynczak, Christian Walter, Angel Pons, Jett Rink. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63158 ) Change subject: tpm: Allow separate handling of Google Ti50 TPM ...................................................................... Patch Set 16: (6 comments) File src/drivers/i2c/tpm/cr50.c: https://review.coreboot.org/c/coreboot/+/63158/comment/d0019c38_ee0c0b24 PS6, Line 478: gsc > I have reverted the naming to cr50_ in this and other source files, even though many of the methods […] It would be great if you provide a general naming overhaul in a follow-up patch! File src/drivers/spi/tpm/tpm.c: https://review.coreboot.org/c/coreboot/+/63158/comment/f27a7cd7_325d5c76 PS6, Line 422: H1 based > I guess it is H1D3-based (updated now), I assumed that H1 could be taken to be any generation of the […] Oh okay, I didn't actually know the naming worked that way. File src/drivers/spi/tpm/tpm.c: https://review.coreboot.org/c/coreboot/+/63158/comment/902999ad_1209b57d PS16, Line 502: (tpm_info.vendor_id == 0x1ae0 FWIW I'm not sure why this check is here in the first place. We use CONFIG(TPM_GOOGLE) without extra runtime version checks in other critical parts of this driver already, it already wouldn't work if that option was set but the TPM wasn't actually a GSC. There's really no point in doing any of these checks here. File src/drivers/tpm/cr50.c: https://review.coreboot.org/c/coreboot/+/63158/comment/cb2297fd_75eec8fc PS16, Line 104: if (!CONFIG(TPM_GOOGLE_CR50)) So now you check the same Kconfig both in the caller and the callee... seems unnecessary? I think we should decide which of the two places make more sense and then only do it there (probably callee, I think). https://review.coreboot.org/c/coreboot/+/63158/comment/74a0bc86_d12e49c5 PS16, Line 158: return false; Does this line have any purpose? We don't have a TPM_GOOGLE that's neither cr50 nor ti50 right now, and if we ever had one in the future it would most likely have the long pulses by default as well. So maybe just take the explicit TI50 check out and just always return true for !CR50? File src/mainboard/google/brya/Kconfig: https://review.coreboot.org/c/coreboot/+/63158/comment/5fbb4eda_9b1e0962 PS14, Line 47: TI50 > Seems like that would be the case, yes. […] Considering that this is a one-off case that we'll never have again after Ti50 has rolled out, I'd prefer not to make things more complicated just for that. I'm sure we can sufficiently support the Ti50 team with the special devices by just providing custom AP images for them in a Drive directory or something like that. -- To view, visit https://review.coreboot.org/c/coreboot/+/63158 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e1f8eb9b94fc2d5689656335dc1135b47880986 Gerrit-Change-Number: 63158 Gerrit-PatchSet: 16 Gerrit-Owner: Jes Klinke <jbk(a)chromium.org> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jett Rink <jettrink(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Jes Klinke <jbk(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Jett Rink <jettrink(a)google.com> Gerrit-Comment-Date: Thu, 21 Apr 2022 23:59:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jes Klinke <jbk(a)chromium.org> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: device/Kconfig: Change ON_DEVICE_ROM_LOAD default
by Paul Menzel (Code Review) 22 Apr '22

22 Apr '22

Attention is currently required from: Arthur Heymans. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63763 ) Change subject: device/Kconfig: Change ON_DEVICE_ROM_LOAD default ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/63763/comment/584183fa_aa0fd022 PS1, Line 9: is not a good : idea in an open source project Why? I understand the security perspective, and would only mention that. File src/device/Kconfig: https://review.coreboot.org/c/coreboot/+/63763/comment/0b00e901_c8482fb7 PS1, Line 180: If you are concerned about security, you might want to : disable this option, but it might leave your system in a state of : degraded functionality. This would need to be updated. -- To view, visit https://review.coreboot.org/c/coreboot/+/63763 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70b4ca6bf83f2d2fa591e30967e481d67e1b9f87 Gerrit-Change-Number: 63763 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 21 Apr 2022 23:50:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2022