coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: Makefile.inc: assembly the Boot Guard manifests and add them to FIT
by Michał Żygowski (Code Review) 09 Jun '23

09 Jun '23

Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43404 ) Change subject: Makefile.inc: assembly the Boot Guard manifests and add them to FIT ...................................................................... Makefile.inc: assembly the Boot Guard manifests and add them to FIT Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: I4e38c66bbb47af7bb5d18ea4714ecfdfa4481946 --- M Makefile.inc 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/43404/1 diff --git a/Makefile.inc b/Makefile.inc index 0701ddc..21d48d8 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -1148,6 +1148,23 @@ $(IFITTOOL) -f $@.tmp -a -n cpu_microcode_blob.bin -t 1 -s $(CONFIG_CPU_INTEL_NUM_FIT_ENTRIES) \ -r COREBOOT endif +ifeq ($(CONFIG_INTEL_BOOTGUARD),y) +ifeq ($(CONFIG_KM_BUILD),y) + $(IBPMTOOL) -f $@.tmp -B $(CONFIG_BPM_PRIV_KEY) -b $(CONFIG_BPM_FILE) -k $(CONFIG_KM_FILE) \ + -K $(CONFIG_KM_PRIV_KEY) -i $(CONFIG_KM_KEY_ID) -S $(CONFIG_KM_SVN) -P $(CONFIG_KM_PM_VERSION) \ + -e $(CONFIG_CPU_INTEL_NUM_FIT_ENTRIES) -n $$(($(CONFIG_DCACHE_RAM_SIZE)/0x1000)) \ + -s $(CONFIG_BPM_SVN) -A $(CONFIG_ACM_SVN) -p $(CONFIG_BPM_PM_VERSION) -H -d +else + $(IBPMTOOL) -f $@.tmp -B $(CONFIG_BPM_PRIV_KEY) -b $(CONFIG_BPM_FILE) -k $(CONFIG_KM_FILE) \ + -e $(CONFIG_CPU_INTEL_NUM_FIT_ENTRIES) -n $$(($(CONFIG_DCACHE_RAM_SIZE)/0x1000)) \ + -s $(CONFIG_BPM_SVN) -A $(CONFIG_ACM_SVN) -p $(CONFIG_BPM_PM_VERSION) -H -d +endif + $(CBFSTOOL) $@.tmp add -n boot_policy_manifest.bin -f $(CONFIG_BPM_FILE) -t raw -a 16 + $(CBFSTOOL) $@.tmp add -n key_manifest.bin -f $(CONFIG_KM_FILE) -t raw -a 16 + $(IFITTOOL) -r COREBOOT -a -n key_manifest.bin -t 11 -s $(CONFIG_CPU_INTEL_NUM_FIT_ENTRIES) -f $@.tmp + $(IFITTOOL) -r COREBOOT -a -n boot_policy_manifest.bin -t 12 -s $(CONFIG_CPU_INTEL_NUM_FIT_ENTRIES) -f $@.tmp + $(IBPMTOOL) -D -b $(CONFIG_BPM_FILE) -k $(CONFIG_KM_FILE) +endif $(IFITTOOL) -f $@.tmp -D -r COREBOOT # Second FIT in TOP_SWAP bootblock -- To view, visit https://review.coreboot.org/c/coreboot/+/43404 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e38c66bbb47af7bb5d18ea4714ecfdfa4481946 Gerrit-Change-Number: 43404 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

3 2

Change in coreboot[master]: security/intel: add Boot Guard menu
by Michał Żygowski (Code Review) 09 Jun '23

09 Jun '23

Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43392 ) Change subject: security/intel: add Boot Guard menu ...................................................................... security/intel: add Boot Guard menu Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: I8630c28643e3cb098eb6e544eb4b64bb1527582c --- M src/security/intel/Kconfig A src/security/intel/bootguard/Kconfig 2 files changed, 104 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/43392/1 diff --git a/src/security/intel/Kconfig b/src/security/intel/Kconfig index 9cdd8a6..69aed6b 100644 --- a/src/security/intel/Kconfig +++ b/src/security/intel/Kconfig @@ -2,3 +2,5 @@ source "src/security/intel/txt/Kconfig" source "src/security/intel/stm/Kconfig" +source "src/security/intel/bootguard/Kconfig" + diff --git a/src/security/intel/bootguard/Kconfig b/src/security/intel/bootguard/Kconfig new file mode 100644 index 0000000..ebaf386 --- /dev/null +++ b/src/security/intel/bootguard/Kconfig @@ -0,0 +1,102 @@ +# SPDX-License-Identifier: GPL-2.0-only + +config INTEL_BOOTGUARD + bool "Intel Boot Guard" + depends on CPU_INTEL_FIRMWARE_INTERFACE_TABLE + default n + +if INTEL_BOOTGUARD + +menu "Boot Guard" + +choice + prompt "Key Manifest source" + default KM_EXISTING + +config KM_EXISTING + bool "Use existing Key Manifest" + +config KM_BUILD + bool "Build Key Manifest from OEM root key" + +endchoice + +config KM_PRIV_KEY + string "Path to private RSA key for Key Manifest" + depends on KM_BUILD + default "OEM_root_key_private.pem" + +config KM_PM_VERSION + int "Platform Manufacturer's Key Manifest Version" + depends on KM_BUILD + default 0 + help + OEM-defined version number, not used by Boot Guard. + + +config KM_KEY_ID + int "Key ID (1-15, must be the same as in ME)" + depends on KM_BUILD + default 15 + +config KM_SVN + int "Key Manifest Revocation Value (use with care)" + depends on KM_BUILD + default 0 + help + This value will be compared with value saved in FPF. If this value + is higher, the FPF will be updated. If it is lower, KM will be + revoked. Saturates at 15, no more revocations will be possible. + You have been warned. + +config KM_FILE + string + prompt "Path to pre-built Key Manifest" if KM_EXISTING + default "key_manifest.bin" + +config BPM_PRIV_KEY + string "Path to private RSA key for Boot Policy Manifest" + default "BPM_key_private.pem" + +config BPM_FILE + string + default "boot_policy_manifest.bin" + +config BPM_PM_VERSION + int "Platform Manufacturer's Boot Policy Version" + default 0 + help + OEM-defined version number, not used by Boot Guard. + +config BPM_SVN + int "Boot Policy Revocation Value (use with care)" + default 0 + help + This value will be compared with value saved in FPF. If this value + is higher, the FPF will be updated. If it is lower, BPM will be + revoked. Saturates at 15, no more revocations will be possible. + You have been warned. + +config ACM_SVN + int "ACM Revocation Value (use with care)" + default 2 + help + This value will be compared with value saved in FPF. If this value + is higher and the same as the one saved in ACM, the FPF will be + updated. If it is lower, ACM will be revoked. Values lower than 2 + are reserved for development versions of ACM. All ACMs with their + internal SVN higher than the one in FPF will be authorized, so this + value doesn't need to be bumped for newer ACMs. Saturates at 15, no + more revocations will be possible. + You have been warned. + +config BTG_ACM_FILE + string "Path and filename of the Boot Guard ACM" + default "" + help + Include the Boot Guard Authenticated Code Module necessary to boot + Boot Guard enabled platform + +endmenu + +endif -- To view, visit https://review.coreboot.org/c/coreboot/+/43392 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8630c28643e3cb098eb6e544eb4b64bb1527582c Gerrit-Change-Number: 43392 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: newchange

4 7

Change in coreboot[master]: soc/intel/skylake: Add necessary FSPT params when FSP CAR is used
by Michał Żygowski (Code Review) 09 Jun '23

09 Jun '23

Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43397 ) Change subject: soc/intel/skylake: Add necessary FSPT params when FSP CAR is used ...................................................................... soc/intel/skylake: Add necessary FSPT params when FSP CAR is used Without these parameters the build with FSP CAR enabled will fail, unless a board implement the parameters. Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: I7b3f770bd56ca072bebb485c02e1022ba95c6e4c --- M src/soc/intel/skylake/Makefile.inc A src/soc/intel/skylake/bootblock/fspcar.c 2 files changed, 30 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/43397/1 diff --git a/src/soc/intel/skylake/Makefile.inc b/src/soc/intel/skylake/Makefile.inc index 75121ab..842f582 100644 --- a/src/soc/intel/skylake/Makefile.inc +++ b/src/soc/intel/skylake/Makefile.inc @@ -10,6 +10,7 @@ subdirs-y += ../../../cpu/x86/smm subdirs-y += ../../../cpu/x86/tsc +bootblock-$(CONFIG_FSP_CAR) += bootblock/fspcar.c bootblock-y += bootblock/bootblock.c bootblock-y += bootblock/cpu.c bootblock-y += i2c.c diff --git a/src/soc/intel/skylake/bootblock/fspcar.c b/src/soc/intel/skylake/bootblock/fspcar.c new file mode 100644 index 0000000..b2580c4 --- /dev/null +++ b/src/soc/intel/skylake/bootblock/fspcar.c @@ -0,0 +1,29 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <stdint.h> +#include <FsptUpd.h> + +const FSPT_UPD temp_ram_init_params = { + .FspUpdHeader = { + .Signature = 0x545F4450554C424BULL, /* 'KBLUPD_T' */ + .Revision = 1, + .Reserved = {0}, + }, + .FsptCoreUpd = { + /* + * It is a requirement for firmware to have Firmware Interface Table + * (FIT), which contains pointers to each microcode update. + * The microcode update is loaded for all logical processors before + * cpu reset vector. + * + * All SoC since Gen-4 has above mechanism in place to load microcode + * even before hitting CPU reset vector. Hence skipping FSP-T loading + * microcode after CPU reset by passing '0' value to + * FSPT_UPD.MicrocodeRegionBase and FSPT_UPD.MicrocodeRegionSize. + */ + .MicrocodeRegionBase = 0, + .MicrocodeRegionSize = 0, + .CodeRegionBase = (uint32_t)(0x100000000ULL - CONFIG_ROM_SIZE), + .CodeRegionSize = (uint32_t)CONFIG_ROM_SIZE, + }, +}; -- To view, visit https://review.coreboot.org/c/coreboot/+/43397 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7b3f770bd56ca072bebb485c02e1022ba95c6e4c Gerrit-Change-Number: 43397 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

4 6

Change in coreboot[master]: Makefile.inc: Add Boot Guard IBB logic for CBFS files
by Michał Żygowski (Code Review) 09 Jun '23

09 Jun '23

Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43394 ) Change subject: Makefile.inc: Add Boot Guard IBB logic for CBFS files ...................................................................... Makefile.inc: Add Boot Guard IBB logic for CBFS files The Boot Guard implementation will leverage FIT entries to locate IBB files in CBFS to create the IBB hash. ifittool will create entries of type 7 which will be then parsd by another tool to calculate hash of whole IBB. These entries will be removed or left untouched based on the Boot Guard revison. This will open a path to support Converged Boot Guard and Trusted Execution Technology. Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: I73e23ddbd8c7f6eef2de3cd3baeb656c86917261 --- M Makefile.inc M src/drivers/intel/fsp2_0/Makefile.inc M src/security/vboot/Makefile.inc 3 files changed, 23 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/43394/1 diff --git a/Makefile.inc b/Makefile.inc index 89bb3e4..912dd42 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -712,6 +712,19 @@ endif +# For Intel BtG files in the CBFS needs to be marked as 'Initial Boot Block'. +# As CBFS attributes aren't cheap, only mark them if BtG is enabled. +ifeq ($(CONFIG_INTEL_BOOTGUARD),y) + +BTGIBB := --ibb + +else + +BTGIBB := + +endif + + ifeq ($(CONFIG_COMPRESS_BOOTBLOCK),y) $(objcbfs)/bootblock.lz4: $(objcbfs)/bootblock.elf $(objutil)/cbfstool/cbfs-compression-tool @@ -1051,7 +1064,7 @@ -f $(objcbfs)/bootblock.bin \ -n bootblock \ -t bootblock \ - $(TXTIBB) \ + $(TXTIBB) $(BTGIBB) \ -b -$(call file-size,$(objcbfs)/bootblock.bin) $(cbfs-autogen-attributes) \ $(TS_OPTIONS) else # ifeq ($(CONFIG_ARCH_X86),y) diff --git a/src/drivers/intel/fsp2_0/Makefile.inc b/src/drivers/intel/fsp2_0/Makefile.inc index e954a46..278036a 100644 --- a/src/drivers/intel/fsp2_0/Makefile.inc +++ b/src/drivers/intel/fsp2_0/Makefile.inc @@ -43,7 +43,7 @@ $(FSP_T_CBFS)-file := $(call strip_quotes,$(CONFIG_FSP_T_FILE)) $(FSP_T_CBFS)-type := fsp ifeq ($(CONFIG_FSP_T_XIP),y) -$(FSP_T_CBFS)-options := --xip $(TXTIBB) +$(FSP_T_CBFS)-options := --xip $(TXTIBB) $(BTGIBB) endif cbfs-files-$(CONFIG_ADD_FSP_BINARIES) += $(FSP_M_CBFS) diff --git a/src/security/vboot/Makefile.inc b/src/security/vboot/Makefile.inc index 90b2756..4097a53 100644 --- a/src/security/vboot/Makefile.inc +++ b/src/security/vboot/Makefile.inc @@ -141,7 +141,14 @@ endif endif -$(CONFIG_CBFS_PREFIX)/verstage-options += $(TXTIBB) +$(CONFIG_CBFS_PREFIX)/verstage-options += $(BTGIBB) $(TXTIBB) + +ifeq ($(CONFIG_INTEL_BOOTGUARD),y) +INTERMEDIATE+=add_verstage_ibb_fit + +add_verstage_ibb_fit: $(obj)/coreboot.pre $(IFITTOOL) + $(IFITTOOL) -r COREBOOT -a -n $(CONFIG_CBFS_PREFIX)/verstage -t 7 -s $(CONFIG_CPU_INTEL_NUM_FIT_ENTRIES) -f $< +endif else # CONFIG_VBOOT_SEPARATE_VERSTAGE ifeq ($(CONFIG_VBOOT_STARTS_IN_BOOTBLOCK),y) -- To view, visit https://review.coreboot.org/c/coreboot/+/43394 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I73e23ddbd8c7f6eef2de3cd3baeb656c86917261 Gerrit-Change-Number: 43394 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

4 4

Change in coreboot[master]: soc/intel/skylake/Kconfig: Select FSPT XIP in FSP CAR is used
by Michał Żygowski (Code Review) 09 Jun '23

09 Jun '23

Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43396 ) Change subject: soc/intel/skylake/Kconfig: Select FSPT XIP in FSP CAR is used ...................................................................... soc/intel/skylake/Kconfig: Select FSPT XIP in FSP CAR is used Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: Ic7c984c6e2c0f93cbb97a7aa8426c2f6ef889162 --- M src/soc/intel/skylake/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/43396/1 diff --git a/src/soc/intel/skylake/Kconfig b/src/soc/intel/skylake/Kconfig index a3e8d9f..1f36c27 100644 --- a/src/soc/intel/skylake/Kconfig +++ b/src/soc/intel/skylake/Kconfig @@ -30,6 +30,7 @@ select CPU_INTEL_FIRMWARE_INTERFACE_TABLE select CPU_INTEL_COMMON_HYPERTHREADING select FSP_M_XIP + select FSP_T_XIP if FSP_CAR select GENERIC_GPIO_LIB select HAVE_FSP_GOP select HAVE_FSP_LOGO_SUPPORT -- To view, visit https://review.coreboot.org/c/coreboot/+/43396 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7c984c6e2c0f93cbb97a7aa8426c2f6ef889162 Gerrit-Change-Number: 43396 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

4 4

Change in coreboot[master]: soc/intel/tgl: Enable Tracehub (not to be merged)
by Shreesh Chhabbi (Code Review) 09 Jun '23

09 Jun '23

Shreesh Chhabbi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42397 ) Change subject: soc/intel/tgl: Enable Tracehub (not to be merged) ...................................................................... soc/intel/tgl: Enable Tracehub (not to be merged) Change-Id: I288c17c0a3258cd506cac23014aac5e7520143b2 Signed-off-by: Shreesh Chhabbi <shreesh.chhabbi(a)intel.com> --- M src/soc/intel/tigerlake/fsp_params.c M src/soc/intel/tigerlake/romstage/fsp_params.c 2 files changed, 18 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/42397/1 diff --git a/src/soc/intel/tigerlake/fsp_params.c b/src/soc/intel/tigerlake/fsp_params.c index b9dbec8..7450c34 100644 --- a/src/soc/intel/tigerlake/fsp_params.c +++ b/src/soc/intel/tigerlake/fsp_params.c @@ -80,14 +80,19 @@ { int i; FSP_S_CONFIG *params = &supd->FspsConfig; + unsigned int *tracehub_mem; struct device *dev; struct soc_intel_tigerlake_config *config; config = config_of_soc(); + tracehub_mem = malloc(4*1024*sizeof(uint32_t)); + /* Parse device tree and enable/disable Serial I/O devices */ parse_devicetree(params); + params->TraceHubMemBase = (UINT32) tracehub_mem; + /* Load VBT before devicetree-specific config. */ params->GraphicsConfigPtr = (uintptr_t)vbt_get(); diff --git a/src/soc/intel/tigerlake/romstage/fsp_params.c b/src/soc/intel/tigerlake/romstage/fsp_params.c index f7956c8..b58952f 100644 --- a/src/soc/intel/tigerlake/romstage/fsp_params.c +++ b/src/soc/intel/tigerlake/romstage/fsp_params.c @@ -18,6 +18,9 @@ unsigned int i; uint32_t mask = 0; const struct device *dev; + //uint32_t *tracehub_mem; + + //tracehub_mem = malloc(4*1024*sizeof(uint32_t)); dev = pcidev_path_on_root(SA_DEVFN_IGD); if (!dev || !dev->enabled) { @@ -196,6 +199,16 @@ /* Change VmxEnable UPD value according to ENABLE_VMX Kconfig */ m_cfg->VmxEnable = CONFIG(ENABLE_VMX); + //m_cfg->TraceHubMemBase = tracehub_mem; + m_cfg->DciEn = 1; + m_cfg->DciDbcMode = 0; + m_cfg->CpuTraceHubMode = 2; + m_cfg->CpuTraceHubMemReg0Size = 2; + m_cfg->CpuTraceHubMemReg1Size = 2; + m_cfg->PchTraceHubMode = 2; + m_cfg->PchTraceHubMemReg0Size = 2; + m_cfg->PchTraceHubMemReg1Size = 2; + m_cfg->PlatformDebugConsent = 2; } void platform_fsp_memory_init_params_cb(FSPM_UPD *mupd, uint32_t version) -- To view, visit https://review.coreboot.org/c/coreboot/+/42397 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I288c17c0a3258cd506cac23014aac5e7520143b2 Gerrit-Change-Number: 42397 Gerrit-PatchSet: 1 Gerrit-Owner: Shreesh Chhabbi <shreesh.chhabbi(a)intel.com> Gerrit-MessageType: newchange

2 1

Change in coreboot[master]: arch/x86/exception: Add support for printing stack to x86_64
by Raul Rangel (Code Review) 09 Jun '23

09 Jun '23

Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43356 ) Change subject: arch/x86/exception: Add support for printing stack to x86_64 ...................................................................... arch/x86/exception: Add support for printing stack to x86_64 x86_64 uses rsp and rbp which are 8 bytes wide. BUG=b:159081993 TEST=none Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: Ie0571dd3a02acc4b70bdd00221e69cc2e20afec3 --- M src/arch/x86/exception.c 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/43356/1 diff --git a/src/arch/x86/exception.c b/src/arch/x86/exception.c index 958ebfc..48083ca 100644 --- a/src/arch/x86/exception.c +++ b/src/arch/x86/exception.c @@ -545,8 +545,19 @@ printk(BIOS_EMERG, "%.2x ", code[i]); } +#ifdef __x86_64__ + /* Align to 8-byte boundary and up the stack. */ + u64 *ptr = (u64 *)(ALIGN_DOWN(info->rsp, sizeof(u64)) + MDUMP_SIZE - sizeof(u64)); + for (i = 0; i < MDUMP_SIZE / sizeof(u64); ++i, --ptr) { + printk(BIOS_EMERG, "\n%p:\t0x%016llx", ptr, *ptr); + if ((uintptr_t)ptr == info->rbp) + printk(BIOS_EMERG, " <-rbp"); + else if ((uintptr_t)ptr == info->rsp) + printk(BIOS_EMERG, " <-rsp"); + } +#else /* Align to 4-byte boundary and up the stack. */ - u32 *ptr = (u32 *)(ALIGN_DOWN((uintptr_t)info->esp, sizeof(u32)) + MDUMP_SIZE - 4); + u32 *ptr = (u32 *)(ALIGN_DOWN(info->esp, sizeof(u32)) + MDUMP_SIZE - sizeof(u32)); for (i = 0; i < MDUMP_SIZE / sizeof(u32); ++i, --ptr) { printk(BIOS_EMERG, "\n%p:\t0x%08x", ptr, *ptr); if ((uintptr_t)ptr == info->ebp) @@ -554,6 +565,7 @@ else if ((uintptr_t)ptr == info->esp) printk(BIOS_EMERG, " <-esp"); } +#endif die("\n"); #endif -- To view, visit https://review.coreboot.org/c/coreboot/+/43356 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie0571dd3a02acc4b70bdd00221e69cc2e20afec3 Gerrit-Change-Number: 43356 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: newchange

4 6

Change in coreboot[master]: nb/intel/i945: Switch back from V4 to V3 resource allocator to fix hangs
by Paul Menzel (Code Review) 09 Jun '23

09 Jun '23

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43574 ) Change subject: nb/intel/i945: Switch back from V4 to V3 resource allocator to fix hangs ...................................................................... nb/intel/i945: Switch back from V4 to V3 resource allocator to fix hangs On the Lenovo T60 (TYPE 2007 with dedicated ATI/AMD graphics card) with the resource allocator v4 the system 99 percent of the time hangs decompressing the payload or a little later. coreboot runs the VGA Option ROM, as the GRUB payload is used. CBFS: Locating 'fallback/payload' CBFS: Found @ offset 4d580 size 60f2c Checking segment from ROM address 0xffe4d7b8 Checking segment from ROM address 0xffe4d7d4 Checking segment from ROM address 0xffe4d7f0 Loading segment from ROM address 0xffe4d7b8 code (compression=1) New segment dstaddr 0x00009000 memsize 0x17858 srcaddr 0xffe4d80c filesize 0x833b Loading Segment: addr: 0x00009000 memsz: 0x0000000000017858 filesz: 0x000000000000833b using LZMA Clearing Segment: addr: 0x0000000000018dc3 memsz: 0x0000000000007a95 Loading segment from ROM address 0xffe4d7d4 code (compression=1) New segment dstaddr 0x00100000 memsize 0x11a6c0 srcaddr 0xffe55b47 filesize 0x58b9d Loading Segment: addr: 0x00100000 memsz: 0x000000000011a6c0 filesz: 0x0000000000058b9d using LZMA Sometimes it halts also a little later. CBFS: Locating 'fallback/payload' CBFS: Found @ offset 4d580 size 60f2c Checking segment from ROM address 0xffe4d7b8 Checking segment from ROM address 0xffe4d7d4 Checking segment from ROM address 0xffe4d7f0 Loading segment from ROM address 0xffe4d7b8 code (compression=1) New segment dstaddr 0x00009000 memsize 0x17858 srcaddr 0xffe4d80c filesize 0x833b Loading Segment: addr: 0x00009000 memsz: 0x0000000000017858 filesz: 0x000000000000833b using LZMA Clearing Segment: addr: 0x0000000000018dc3 memsz: 0x0000000000007a95 Loading segment from ROM address 0xffe4d7d4 code (compression=1) New segment dstaddr 0x00100000 memsize 0x11a6c0 srcaddr 0xffe55b47 filesize 0x58b9d Loading Segment: addr: 0x00100000 memsz: 0x000000000011a6c0 filesz: 0x0000000000058b9d using LZMA Loading segment from ROM address 0xffe4d7f0 Entry Point 0x00009000 BS: BS_PAYLOAD_LOAD run times (exec / console): 365 / 81 ms ICH-NM10-PCH: watchdog disabled Jumping to boot code at 0x00009000(0xbfb7e000) A cursor in blinking on the top left corner. Fixes: 23b874a374 (device: Switch to resource allocator v4 by default treewide) Resolves: https://ticket.coreboot.org/issues/267 Change-Id: I1d8d60c26bfe036cbd769ef96b4873e1438adea8 Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de> --- M src/northbridge/intel/i945/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/43574/1 diff --git a/src/northbridge/intel/i945/Kconfig b/src/northbridge/intel/i945/Kconfig index d6498f1..ea74a8f 100644 --- a/src/northbridge/intel/i945/Kconfig +++ b/src/northbridge/intel/i945/Kconfig @@ -2,6 +2,7 @@ config NORTHBRIDGE_INTEL_I945 bool + select RESOURCE_ALLOCATOR_V3 if NORTHBRIDGE_INTEL_I945 -- To view, visit https://review.coreboot.org/c/coreboot/+/43574 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1d8d60c26bfe036cbd769ef96b4873e1438adea8 Gerrit-Change-Number: 43574 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newchange

2 2

Change in coreboot[master]: mb/google/hatch: Make Nightfury variant alphabettically sorted
by Edward O'Callaghan (Code Review) 09 Jun '23

09 Jun '23

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40400 ) Change subject: mb/google/hatch: Make Nightfury variant alphabettically sorted ...................................................................... mb/google/hatch: Make Nightfury variant alphabettically sorted Change-Id: I21a710ee0df45188f1f43aad61967069faf88fdb Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/Kconfig.name 2 files changed, 8 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/40400/1 diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 2419722..6eff9070 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -103,8 +103,8 @@ default "Kindred" if BOARD_GOOGLE_KINDRED default "Kohaku" if BOARD_GOOGLE_KOHAKU default "Mushu" if BOARD_GOOGLE_MUSHU - default "Palkia" if BOARD_GOOGLE_PALKIA default "Nightfury" if BOARD_GOOGLE_NIGHTFURY + default "Palkia" if BOARD_GOOGLE_PALKIA default "Puff" if BOARD_GOOGLE_PUFF default "Kaisa" if BOARD_GOOGLE_KAISA default "Stryke" if BOARD_GOOGLE_STRYKE @@ -131,8 +131,8 @@ default "kindred" if BOARD_GOOGLE_KINDRED default "kohaku" if BOARD_GOOGLE_KOHAKU default "mushu" if BOARD_GOOGLE_MUSHU - default "palkia" if BOARD_GOOGLE_PALKIA default "nightfury" if BOARD_GOOGLE_NIGHTFURY + default "palkia" if BOARD_GOOGLE_PALKIA default "puff" if BOARD_GOOGLE_PUFF default "kaisa" if BOARD_GOOGLE_KAISA default "stryke" if BOARD_GOOGLE_STRYKE diff --git a/src/mainboard/google/hatch/Kconfig.name b/src/mainboard/google/hatch/Kconfig.name index ce34211..f3f944f 100644 --- a/src/mainboard/google/hatch/Kconfig.name +++ b/src/mainboard/google/hatch/Kconfig.name @@ -60,6 +60,12 @@ select BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP select BOARD_ROMSIZE_KB_16384 +config BOARD_GOOGLE_NIGHTFURY + bool "-> Nightfury" + select BOARD_GOOGLE_BASEBOARD_HATCH + select BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP + select BOARD_ROMSIZE_KB_16384 + config BOARD_GOOGLE_PALKIA bool "-> Palkia" select BOARD_GOOGLE_BASEBOARD_HATCH @@ -68,12 +74,6 @@ select CHROMEOS_DSM_CALIB select DRIVERS_I2C_RT1011 -config BOARD_GOOGLE_NIGHTFURY - bool "-> Nightfury" - select BOARD_GOOGLE_BASEBOARD_HATCH - select BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP - select BOARD_ROMSIZE_KB_16384 - config BOARD_GOOGLE_PUFF bool "-> Puff" select BOARD_GOOGLE_BASEBOARD_HATCH -- To view, visit https://review.coreboot.org/c/coreboot/+/40400 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I21a710ee0df45188f1f43aad61967069faf88fdb Gerrit-Change-Number: 40400 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

5 8

Change in coreboot[master]: configs: Build test google/veyron_jaq with depthcharge payload
by Paul Menzel (Code Review) 09 Jun '23

09 Jun '23

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43469 ) Change subject: configs: Build test google/veyron_jaq with depthcharge payload ...................................................................... configs: Build test google/veyron_jaq with depthcharge payload Change-Id: Id59a2f98d928cc01a47ac3b64f9face811dc79e1 Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de> --- A configs/config.google_veyron_jaq_depthcharge_master 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/43469/1 diff --git a/configs/config.google_veyron_jaq_depthcharge_master b/configs/config.google_veyron_jaq_depthcharge_master new file mode 100644 index 0000000..032ff6d --- /dev/null +++ b/configs/config.google_veyron_jaq_depthcharge_master @@ -0,0 +1,5 @@ +CONFIG_VENDOR_GOOGLE=y +CONFIG_BOARD_GOOGLE_VEYRON_JAQ=y +CONFIG_CHROMEOS=y +CONFIG_PAYLOAD_DEPTHCHARGE=y +CONFIG_DEPTHCHARGE_MASTER=y -- To view, visit https://review.coreboot.org/c/coreboot/+/43469 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id59a2f98d928cc01a47ac3b64f9face811dc79e1 Gerrit-Change-Number: 43469 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newchange

2 3

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022