Attention is currently required from: Damien Zammit.
Hello build bot (Jenkins), Edward O'Callaghan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62809
to look at the new patch set (#2).
Change subject: mb/hp/z220_series: Add Z220 CMT Workstation variant
......................................................................
mb/hp/z220_series: Add Z220 CMT Workstation variant
This is based on previous work done by a good friend of mine.
This commit needs to be boot tested on a Z220 CMT Workstation,
(but I suspect it works).
Change-Id: I2b298921e6f509440ec7b049e086c0878f708bd3
Signed-off-by: Damien Zammit <damien(a)zamaudio.com>
---
M src/mainboard/hp/z220_series/Kconfig
M src/mainboard/hp/z220_series/Kconfig.name
A src/mainboard/hp/z220_series/variants/z220_cmt_workstation/gpio.c
A src/mainboard/hp/z220_series/variants/z220_cmt_workstation/overridetree.cb
4 files changed, 199 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/62809/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/62809
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b298921e6f509440ec7b049e086c0878f708bd3
Gerrit-Change-Number: 62809
Gerrit-PatchSet: 2
Gerrit-Owner: Damien Zammit
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Damien Zammit
Gerrit-MessageType: newpatchset
Attention is currently required from: Damien Zammit, Edward O'Callaghan.
Hello build bot (Jenkins), Edward O'Callaghan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62808
to look at the new patch set (#2).
Change subject: mb/hp/z220_series: Convert z220_sff_workstation into variant
......................................................................
mb/hp/z220_series: Convert z220_sff_workstation into variant
No functional change, just refactoring to make room for CMT variant.
Built with BUILD_TIMELESS=1 and no config included before and after.
$ diff master.rom build/coreboot.rom
$
Change-Id: I6aaac75216b2d7c8bb48801454ce616ace3b1422
Signed-off-by: Damien Zammit <damien(a)zamaudio.com>
---
R src/mainboard/hp/z220_series/Kconfig
R src/mainboard/hp/z220_series/Kconfig.name
A src/mainboard/hp/z220_series/Makefile.inc
R src/mainboard/hp/z220_series/acpi/ec.asl
R src/mainboard/hp/z220_series/acpi/platform.asl
R src/mainboard/hp/z220_series/acpi/superio.asl
R src/mainboard/hp/z220_series/board_info.txt
R src/mainboard/hp/z220_series/cmos.default
R src/mainboard/hp/z220_series/cmos.layout
R src/mainboard/hp/z220_series/data.vbt
R src/mainboard/hp/z220_series/devicetree.cb
R src/mainboard/hp/z220_series/dsdt.asl
R src/mainboard/hp/z220_series/early_init.c
R src/mainboard/hp/z220_series/gma-mainboard.ads
R src/mainboard/hp/z220_series/hda_verb.c
R src/mainboard/hp/z220_series/mainboard.c
R src/mainboard/hp/z220_series/variants/z220_sff_workstation/gpio.c
A src/mainboard/hp/z220_series/variants/z220_sff_workstation/overridetree.cb
D src/mainboard/hp/z220_sff_workstation/Makefile.inc
19 files changed, 38 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/62808/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/62808
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6aaac75216b2d7c8bb48801454ce616ace3b1422
Gerrit-Change-Number: 62808
Gerrit-PatchSet: 2
Gerrit-Owner: Damien Zammit
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Xi Chen, Paul Menzel, Xixi Chen.
Hello Xi Chen, Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61334
to look at the new patch set (#19).
Change subject: soc/mediatek: Pass dram info to cbmem
......................................................................
soc/mediatek: Pass dram info to cbmem
Pass dram_info struct from coreboot to depthcharge using payload.
BUG=b:206014043
TEST=Build pass on Kingler
Signed-off-by: Xi Chen <xixi.chen(a)mediatek.corp-partner.google.com>
Change-Id: I195187c0c757a43bb6d2c57c8f303249f2a7995a
---
M src/soc/mediatek/common/memory.c
M src/soc/mediatek/mt8192/Makefile.inc
M src/soc/mediatek/mt8195/Makefile.inc
3 files changed, 53 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/61334/19
--
To view, visit https://review.coreboot.org/c/coreboot/+/61334
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I195187c0c757a43bb6d2c57c8f303249f2a7995a
Gerrit-Change-Number: 61334
Gerrit-PatchSet: 19
Gerrit-Owner: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Sumeet R Pawnikar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62849 )
Change subject: [TEST]: mb/google/brya/variants/redrix: Enable CNVi DDR RFIM feature support
......................................................................
[TEST]: mb/google/brya/variants/redrix: Enable CNVi DDR RFIM feature support
This is test patch to enable CNVi DDR RFIM feature support and test it
on redrix system.
Change-Id: I58e90d48a69dbfd950d619c459244605a3ca69b5
Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar(a)intel.com>
---
M src/mainboard/google/brya/variants/redrix/overridetree.cb
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/62849/1
diff --git a/src/mainboard/google/brya/variants/redrix/overridetree.cb b/src/mainboard/google/brya/variants/redrix/overridetree.cb
index a44cb40..0f25319 100644
--- a/src/mainboard/google/brya/variants/redrix/overridetree.cb
+++ b/src/mainboard/google/brya/variants/redrix/overridetree.cb
@@ -170,6 +170,7 @@
device ref cnvi_wifi on
chip drivers/wifi/generic
register "wake" = "GPE0_PME_B0"
+ register "enable_cnvi_ddr_rfim" = "true"
device generic 0 on end
end
end
--
To view, visit https://review.coreboot.org/c/coreboot/+/62849
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I58e90d48a69dbfd950d619c459244605a3ca69b5
Gerrit-Change-Number: 62849
Gerrit-PatchSet: 1
Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-MessageType: newchange
Attention is currently required from: Henry Sun, Frank Chu, Paul Menzel, Karthik Ramasubramanian.
Ivan Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62704 )
Change subject: mb/google/dedede/var/galtic: update Wifi SAR for for galnat
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/62704
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I868a7416a002732736cabea48ce80548ea75e517
Gerrit-Change-Number: 62704
Gerrit-PatchSet: 5
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-CC: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Wed, 16 Mar 2022 06:31:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Henry Sun, Paul Menzel, Ivan Chen, Karthik Ramasubramanian.
Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62704 )
Change subject: mb/google/dedede/var/galtic: update Wifi SAR for for galnat
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
> Hi Frank, […]
coreboot ODM don't have verify permission,
our RF team verify power table ok
--
To view, visit https://review.coreboot.org/c/coreboot/+/62704
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I868a7416a002732736cabea48ce80548ea75e517
Gerrit-Change-Number: 62704
Gerrit-PatchSet: 5
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-CC: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Ivan Chen <yulunchen(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Wed, 16 Mar 2022 06:23:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Henry Sun <henrysun(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: John Su, YH Lin, Dtrain Hsu, Paul Menzel, Sumeet R Pawnikar, Ricky Chang.
Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62807 )
Change subject: mb/google/brya/var/banshee: Update DPTF parameters
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62807/comment/242f10e8_a9b32c01
PS1, Line 7: for Banshee
> Already in prefix.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/62807
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5da776e7ae3368ce00cd29ec0ccdb5b7a725ff88
Gerrit-Change-Number: 62807
Gerrit-PatchSet: 2
Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Ricky Chang <rickytlchang(a)google.com>
Gerrit-Comment-Date: Wed, 16 Mar 2022 06:19:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Frank Wu, John Su, YH Lin, Dtrain Hsu, Sumeet R Pawnikar, Ricky Chang.
Hello John Su, build bot (Jenkins), YH Lin, Dtrain Hsu, Tim Wawrzynczak, Sumeet R Pawnikar, Eric Lai, Ricky Chang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62807
to look at the new patch set (#2).
Change subject: mb/google/brya/var/banshee: Update DPTF parameters
......................................................................
mb/google/brya/var/banshee: Update DPTF parameters
Follow thermal team design to update thermal table.
BUG=b:223492897
BRANCH=firmware-brya-14505.B
TEST=emerge-brya coreboot chromeos-bootimage
Signed-off-by: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Change-Id: I5da776e7ae3368ce00cd29ec0ccdb5b7a725ff88
---
M src/mainboard/google/brya/variants/banshee/overridetree.cb
1 file changed, 28 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/62807/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/62807
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5da776e7ae3368ce00cd29ec0ccdb5b7a725ff88
Gerrit-Change-Number: 62807
Gerrit-PatchSet: 2
Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Ricky Chang <rickytlchang(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Gwendal Grignou.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62842 )
Change subject: driver/i2c/sx9360: Add pre-charge resistance setting
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/i2c/sx9360/chip.h:
https://review.coreboot.org/c/coreboot/+/62842/comment/1fdf9fec_7c538531
PS1, Line 40: input_precharge_resistor
… also include the unit to the variable name?
--
To view, visit https://review.coreboot.org/c/coreboot/+/62842
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I197b88d92784015b94c836dc128bacf3f1ef5b62
Gerrit-Change-Number: 62842
Gerrit-PatchSet: 1
Gerrit-Owner: Gwendal Grignou <gwendal(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Gwendal Grignou <gwendal(a)chromium.org>
Gerrit-Comment-Date: Wed, 16 Mar 2022 06:16:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment