coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: soc/intel/alderlake/retimer: Change loglevel prefix
by Wisley Chen (Code Review) 16 Mar '22

16 Mar '22

Attention is currently required from: Wisley Chen. Wisley Chen has uploaded a new patch set (#3) to the change originally created by Chen Wisley. ( https://review.coreboot.org/c/coreboot/+/62821 ) Change subject: soc/intel/alderlake/retimer: Change loglevel prefix ...................................................................... soc/intel/alderlake/retimer: Change loglevel prefix This message is not really an error message, so BIOS_ERR is inappropriate. Since the message is informational, switch to BIOS_INFO instead. BUG=b:222038287 BRANCH=firmware-brya-14505.B TEST=emerge-brya coreboot Change-Id: I9dc852a0cd30f95506c205f161a05e8a8c44fcd5 Signed-off-by: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> --- M src/soc/intel/alderlake/retimer.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/62821/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/62821 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9dc852a0cd30f95506c205f161a05e8a8c44fcd5 Gerrit-Change-Number: 62821 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/alderlake/retimer: Change loglevel prefix
by Wisley Chen (Code Review) 16 Mar '22

16 Mar '22

Attention is currently required from: Chen Wisley, Wisley Chen. Wisley Chen has uploaded a new patch set (#2) to the change originally created by Chen Wisley. ( https://review.coreboot.org/c/coreboot/+/62821 ) Change subject: soc/intel/alderlake/retimer: Change loglevel prefix ...................................................................... soc/intel/alderlake/retimer: Change loglevel prefix This message is not really an error message, so BIOS_ERR is inappropriate. Since the message is informational, switch to BIOS_INFO instead BUG=b:222038287 BRANCH=firmware-brya-14505.B TEST=emerge-brya coreboot Change-Id: I9dc852a0cd30f95506c205f161a05e8a8c44fcd5 Signed-off-by: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> --- M src/soc/intel/alderlake/retimer.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/62821/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62821 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9dc852a0cd30f95506c205f161a05e8a8c44fcd5 Gerrit-Change-Number: 62821 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: ec/google/chromeec: Change loglevel prefix
by Wisley Chen (Code Review) 16 Mar '22

16 Mar '22

Attention is currently required from: Chen Wisley. Wisley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62823 ) Change subject: ec/google/chromeec: Change loglevel prefix ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/62823/comment/f92d13c0_42180d24 PS1, Line 10: of smbios. > `in the SMBIOS table. […] Done https://review.coreboot.org/c/coreboot/+/62823/comment/5598e0e7_acaca6f9 PS1, Line 10: smbios. : It' better use the "BIOS_INFO" than "BIOS_ERR" : > remove line break between the two sentences? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/62823 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I52eb1e6926eaac30b1dbee13ab750ef15b466d89 Gerrit-Change-Number: 62823 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-CC: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Comment-Date: Wed, 16 Mar 2022 12:23:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/google/chromeec: Change loglevel prefix
by Wisley Chen (Code Review) 16 Mar '22

16 Mar '22

Attention is currently required from: Wisley Chen. Wisley Chen has uploaded a new patch set (#3) to the change originally created by Chen Wisley. ( https://review.coreboot.org/c/coreboot/+/62823 ) Change subject: ec/google/chromeec: Change loglevel prefix ...................................................................... ec/google/chromeec: Change loglevel prefix In most boards, it doesn't write OEM_NAME in CBI to override the manufacturer name in the SMBIOS table. It' better use the "BIOS_INFO" than "BIOS_ERR" BUG=b:222038287 BRANCH=firmware-brya-14505.B TEST=emerge-brya coreboot Change-Id: I52eb1e6926eaac30b1dbee13ab750ef15b466d89 Signed-off-by: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> --- M src/ec/google/chromeec/ec_smbios.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/62823/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/62823 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I52eb1e6926eaac30b1dbee13ab750ef15b466d89 Gerrit-Change-Number: 62823 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-CC: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: ec/google/chromeec: Change loglevel prefix
by Wisley Chen (Code Review) 16 Mar '22

16 Mar '22

Attention is currently required from: Chen Wisley, Wisley Chen. Wisley Chen has uploaded a new patch set (#2) to the change originally created by Chen Wisley. ( https://review.coreboot.org/c/coreboot/+/62823 ) Change subject: ec/google/chromeec: Change loglevel prefix ...................................................................... ec/google/chromeec: Change loglevel prefix In most boards, it doesn't write OEM_NAME in CBI to override the manufacturer name in the SMBIOS table.It' better use the "BIOS_INFO" than "BIOS_ERR" BUG=b:222038287 BRANCH=firmware-brya-14505.B TEST=emerge-brya coreboot Change-Id: I52eb1e6926eaac30b1dbee13ab750ef15b466d89 Signed-off-by: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> --- M src/ec/google/chromeec/ec_smbios.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/62823/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62823 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I52eb1e6926eaac30b1dbee13ab750ef15b466d89 Gerrit-Change-Number: 62823 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-CC: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/common/block/cse: Change logleve prefix to WARNING
by Wisley Chen (Code Review) 16 Mar '22

16 Mar '22

Attention is currently required from: Chen Wisley, Tim Wawrzynczak. Wisley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62820 ) Change subject: soc/intel/common/block/cse: Change logleve prefix to WARNING ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62820/comment/faf339a4_8ca4865e PS1, Line 8: : In do_send_end_of_post(), it checks whether send eop or not. : So, it's better to use "BIOS_WARNING" than "BIOS_ERR" > Suggestion: […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/62820 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I57a34334007a6a7443302c2f25de3d5c87c85573 Gerrit-Change-Number: 62820 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Wed, 16 Mar 2022 12:13:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/block/cse: Change logleve prefix to WARNING
by Wisley Chen (Code Review) 16 Mar '22

16 Mar '22

Attention is currently required from: Chen Wisley. Wisley Chen has uploaded a new patch set (#2) to the change originally created by Chen Wisley. ( https://review.coreboot.org/c/coreboot/+/62820 ) Change subject: soc/intel/common/block/cse: Change logleve prefix to WARNING ...................................................................... soc/intel/common/block/cse: Change logleve prefix to WARNING This message is not really an error message, so BIOS_ERR is inappropriate. The message does seem more like a warning though, that the developer could have multiple Kconfigs selected to send EOP, therefore switch to BIOS_WARN instead. BRANCH=firmware-brya-14505.B TEST=build Signed-off-by: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Change-Id: I57a34334007a6a7443302c2f25de3d5c87c85573 --- M src/soc/intel/common/block/cse/cse_eop.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/62820/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62820 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I57a34334007a6a7443302c2f25de3d5c87c85573 Gerrit-Change-Number: 62820 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/starlabs/lite: Add Lite Mk IV variant
by Sean Rhodes (Code Review) 16 Mar '22

16 Mar '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62706 to look at the new patch set (#18). Change subject: mb/starlabs/lite: Add Lite Mk IV variant ...................................................................... mb/starlabs/lite: Add Lite Mk IV variant Tested using upstream edk2: * Windows 10 * Ubuntu 20.04 * MX Linux 19.4 * Manjaro 21 No known issues. https://starlabs.systems/pages/starlite-specification Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Id1cf2846a139004e9bec7bb27e9afe07b7e6f64f --- M Documentation/mainboard/index.md A Documentation/mainboard/starlabs/lite_glkr.md M src/mainboard/starlabs/lite/Kconfig M src/mainboard/starlabs/lite/Kconfig.name M src/mainboard/starlabs/lite/variants/glk/gpio.c A src/mainboard/starlabs/lite/variants/glkr/Makefile.inc A src/mainboard/starlabs/lite/variants/glkr/data.vbt A src/mainboard/starlabs/lite/variants/glkr/devicetree.cb A src/mainboard/starlabs/lite/variants/glkr/gpio.c A src/mainboard/starlabs/lite/variants/glkr/hda_verb.c A src/mainboard/starlabs/lite/variants/glkr/romstage.c 11 files changed, 969 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/62706/18 -- To view, visit https://review.coreboot.org/c/coreboot/+/62706 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id1cf2846a139004e9bec7bb27e9afe07b7e6f64f Gerrit-Change-Number: 62706 Gerrit-PatchSet: 18 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: ec/starlabs/merlin: Make EC function names generic
by Sean Rhodes (Code Review) 16 Mar '22

16 Mar '22

Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62700 ) Change subject: ec/starlabs/merlin: Make EC function names generic ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/62700 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie61af233f731eb47772af1c82c6abdc515bc89cc Gerrit-Change-Number: 62700 Gerrit-PatchSet: 7 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 16 Mar 2022 12:02:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/starlabs/merlin: Add support for Nuvoton EC's
by Sean Rhodes (Code Review) 16 Mar '22

16 Mar '22

Attention is currently required from: Sean Rhodes. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62702 ) Change subject: ec/starlabs/merlin: Add support for Nuvoton EC's ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/62702 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib66baf1e88f5d548ce955dffa00c9b88255b2f95 Gerrit-Change-Number: 62702 Gerrit-PatchSet: 11 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Wed, 16 Mar 2022 12:02:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022