coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: soc/intel/common/block: Add Intel common UFS code support
by Daniil Lunev (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: Kangheui Won, Rizwan Qureshi, Meera Ravindranath. Daniil Lunev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62855 ) Change subject: soc/intel/common/block: Add Intel common UFS code support ...................................................................... Patch Set 1: (2 comments) File src/soc/intel/common/block/scs/ufs.c: https://review.coreboot.org/c/coreboot/+/62855/comment/54ff313b_718d4d48 PS1, Line 16: PCI_DEVICE_ID_INTEL_ADP_UFS When building from tot it compains this should be PCI_DID_INTEL_ADP_UFS https://review.coreboot.org/c/coreboot/+/62855/comment/73cece64_fd9f8d3a PS1, Line 22: PCI_VENDOR_ID_INTEL When building from tot it compains this should be PCI_VID_INTEL -- To view, visit https://review.coreboot.org/c/coreboot/+/62855 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I92f034ced64e2eaef41a7807133361d74b5009d3 Gerrit-Change-Number: 62855 Gerrit-PatchSet: 1 Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-CC: Daniil Lunev <dlunev(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Comment-Date: Wed, 16 Mar 2022 22:37:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/skyrim: Build APCB sources into amdfw when present
by Raul Rangel (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: Jon Murphy, Rob Barnes, Karthik Ramasubramanian, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62877 ) Change subject: mb/google/skyrim: Build APCB sources into amdfw when present ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS1: > We have asked AMD to refer to table of SPDs outside APCB. […] oh cool. I didn't know they were actually working on adding that feature. -- To view, visit https://review.coreboot.org/c/coreboot/+/62877 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I71b30a5716f2e0d60d07a0ec29f98609c1f2a8b7 Gerrit-Change-Number: 62877 Gerrit-PatchSet: 2 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 16 Mar 2022 22:30:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/skyrim: Build APCB sources into amdfw when present
by Karthik Ramasubramanian (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: Raul Rangel, Jon Murphy, Rob Barnes. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62877 ) Change subject: mb/google/skyrim: Build APCB sources into amdfw when present ...................................................................... Patch Set 2: (2 comments) Patchset: PS1: > Are we going to need to update APCB tool so we can generate these? We have asked AMD to refer to table of SPDs outside APCB. If that can be achieved, then I dont think we need to update APCB tool. Otherwise before fanning out to more variants, we need to update APCB tool to generate these. Thankfully we can leverage APCBv3 edit tool if needed. File src/mainboard/google/skyrim/Makefile.inc: https://review.coreboot.org/c/coreboot/+/62877/comment/f9bc0686_21d367c0 PS2, Line 17: SBR_D5 Renamed it to be more consistent with previous generation of mainboards eg. guybrush. -- To view, visit https://review.coreboot.org/c/coreboot/+/62877 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I71b30a5716f2e0d60d07a0ec29f98609c1f2a8b7 Gerrit-Change-Number: 62877 Gerrit-PatchSet: 2 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Comment-Date: Wed, 16 Mar 2022 22:22:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/skyrim: Build APCB sources into amdfw when present
by Karthik Ramasubramanian (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: Jon Murphy, Rob Barnes, Karthik Ramasubramanian. Hello build bot (Jenkins), Raul Rangel, Jon Murphy, Rob Barnes, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62877 to look at the new patch set (#2). Change subject: mb/google/skyrim: Build APCB sources into amdfw when present ...................................................................... mb/google/skyrim: Build APCB sources into amdfw when present BUG=b:224618411 TEST=util/abuild/abuild -t GOOGLE_SKYRIM with and without APCB Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com> Change-Id: I71b30a5716f2e0d60d07a0ec29f98609c1f2a8b7 --- M src/mainboard/google/skyrim/Makefile.inc 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/62877/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62877 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I71b30a5716f2e0d60d07a0ec29f98609c1f2a8b7 Gerrit-Change-Number: 62877 Gerrit-PatchSet: 2 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/skyrim: Build APCB sources into amdfw when present
by Raul Rangel (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: Jon Murphy, Rob Barnes, Karthik Ramasubramanian. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62877 ) Change subject: mb/google/skyrim: Build APCB sources into amdfw when present ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Are we going to need to update APCB tool so we can generate these? -- To view, visit https://review.coreboot.org/c/coreboot/+/62877 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I71b30a5716f2e0d60d07a0ec29f98609c1f2a8b7 Gerrit-Change-Number: 62877 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-CC: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 16 Mar 2022 22:10:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/skyrim: Build APCB sources into amdfw when present
by Karthik Ramasubramanian (Code Review) 17 Mar '22

17 Mar '22

Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62877 ) Change subject: mb/google/skyrim: Build APCB sources into amdfw when present ...................................................................... mb/google/skyrim: Build APCB sources into amdfw when present BUG=b:224618411 TEST=util/abuild/abuild -t GOOGLE_SKYRIM with and without APCB Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com> Change-Id: I71b30a5716f2e0d60d07a0ec29f98609c1f2a8b7 --- M src/mainboard/google/skyrim/Makefile.inc 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/62877/1 diff --git a/src/mainboard/google/skyrim/Makefile.inc b/src/mainboard/google/skyrim/Makefile.inc index 94708ac..f8a7dcd 100644 --- a/src/mainboard/google/skyrim/Makefile.inc +++ b/src/mainboard/google/skyrim/Makefile.inc @@ -13,3 +13,11 @@ CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/baseboard/include CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/include + +ifneq ($(wildcard $(MAINBOARD_BLOBS_DIR)/APCB_FT6_DefaultRecovery.bin),) +$(info APCB sources present.) +APCB_SOURCES = $(MAINBOARD_BLOBS_DIR)/APCB_FT6_DefaultRecovery.bin +APCB_SOURCES_RECOVERY = $(MAINBOARD_BLOBS_DIR)/APCB_FT6_DefaultRecovery.bin +else +$(info APCB sources not found. Skipping APCB.) +endif -- To view, visit https://review.coreboot.org/c/coreboot/+/62877 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I71b30a5716f2e0d60d07a0ec29f98609c1f2a8b7 Gerrit-Change-Number: 62877 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-CC: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: lib/cbfs: Compare addresses instead of arrays
by Julius Werner (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: Paul Menzel. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62827 ) Change subject: lib/cbfs: Compare addresses instead of arrays ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Can we just set -Wno-array-compare instead? There's nothing illegal about that expression and as we can see in this case, there are perfectly reasonable cases where you might want to do something like that. On the other hand, I don't really see a realistic scenario where this warning could prevent a real problem (anyone who doesn't know that `array1 == array2` doesn't compare the array elements in C shouldn't have any business submitting code to coreboot). -- To view, visit https://review.coreboot.org/c/coreboot/+/62827 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I69310b0bec166faa40f56a36c6d360065cf6b08a Gerrit-Change-Number: 62827 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 16 Mar 2022 22:00:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlrvp: Set EPP to 45% for all Adl RVP variants
by Bora Guvendik (Code Review) 16 Mar '22

16 Mar '22

Attention is currently required from: Kedar J. Karanje, Cliff Huang, Selma Bensaid. Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62744 ) Change subject: mb/intel/adlrvp: Set EPP to 45% for all Adl RVP variants ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62744 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If83a2148d596efccd2e50cc82f1afcbfb9ebb935 Gerrit-Change-Number: 62744 Gerrit-PatchSet: 2 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Deepika Punyamurtula <deepika.punyamurtula(a)intel.com> Gerrit-Reviewer: Kedar J. Karanje <kedar.j.karanje(a)intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Cliff Huang <cliff.huang(a)intel.corp-partner.google.com> Gerrit-Attention: Kedar J. Karanje <kedar.j.karanje(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Comment-Date: Wed, 16 Mar 2022 21:33:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/qualcomm/common: Add dram information to CBMEM table
by Shelley Chen (Code Review) 16 Mar '22

16 Mar '22

Attention is currently required from: Ravi kumar, Paul Menzel, mturney mturney, Sudheer Amrabadi, Julius Werner. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59195 ) Change subject: soc/qualcomm/common: Add dram information to CBMEM table ...................................................................... Patch Set 41: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59195 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f1dd05ee224bf8284661c0afaa01d0a9d71daa7 Gerrit-Change-Number: 59195 Gerrit-PatchSet: 41 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-CC: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-CC: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com> Gerrit-CC: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-Comment-Date: Wed, 16 Mar 2022 21:10:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Remove Pcie Generic driver for WWAN
by Tim Wawrzynczak (Code Review) 16 Mar '22

16 Mar '22

Attention is currently required from: Bora Guvendik, Cliff Huang, Selma Bensaid, Nick Vaccaro. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62330 ) Change subject: mb/google/brya: Remove Pcie Generic driver for WWAN ...................................................................... Patch Set 13: Code-Review+2 (1 comment) File src/mainboard/google/brya/variants/brya0/overridetree.cb: https://review.coreboot.org/c/coreboot/+/62330/comment/6fb587bd_332be418 PS10, Line 213: rp6_wwan > The last patchset removes PCIe generic driver and use recent _DSD support from the FM driver. […] I see, you're right I think this is buggy at the moment. -- To view, visit https://review.coreboot.org/c/coreboot/+/62330 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia343c7545cf30bdbcd1de19e5eb84049dbb2977f Gerrit-Change-Number: 62330 Gerrit-PatchSet: 13 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Cliff Huang <cliff.huang(a)intel.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Wed, 16 Mar 2022 20:41:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Cliff Huang <cliff.huang(a)intel.com> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022