Attention is currently required from: Arthur Heymans.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69119 )
Change subject: nb/amd/agesa: Remove leftover code
......................................................................
Patch Set 13: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/69119
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5464daa8cfb8231e2b19447c343fc80ab1d68ce8
Gerrit-Change-Number: 69119
Gerrit-PatchSet: 13
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Wed, 02 Nov 2022 10:03:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69120 )
Change subject: sb/amd: Remove dropped platforms
......................................................................
Patch Set 14: Code-Review+2
(1 comment)
Patchset:
PS14:
maybe out of topic:
now, 'config AZ_PIN' defined at "src/southbridge/amd/pi/hudson/Kconfig" is not used anymore
--
To view, visit https://review.coreboot.org/c/coreboot/+/69120
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60afbde6ead70f0c887866fc351b4a6a15a89287
Gerrit-Change-Number: 69120
Gerrit-PatchSet: 14
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Wed, 02 Nov 2022 10:03:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Christian Walter, Angel Pons, Lean Sheng Tan.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68783 )
Change subject: mb/prodrive/atlas: Add IBECC Kconfig option
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68783/comment/e337191e_10b9254b
PS1, Line 10: Code), which is currently needed for indurance testing
> Please add a dot/period at the end of sentences.
Done
https://review.coreboot.org/c/coreboot/+/68783/comment/ef01ae9f_a5f388f9
PS1, Line 10: indurance testing
> Is the test currently failing, or is the feature tested?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/68783
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I71ee2401136e2dc70b3164db6c99af03a3e1f346
Gerrit-Change-Number: 68783
Gerrit-PatchSet: 2
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Comment-Date: Wed, 02 Nov 2022 10:02:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Alexander Couzens.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69111 )
Change subject: mb/*/*: Remove AMD FAMILY15TN boards
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Aren’t there change-sets up for review [1]?
>
> [1]: https://review.coreboot.org/c/coreboot/+/64892/30
It's indeed up for review since quite some time... It does not implement the changes needed for resource allocator v4 and this series also removes v3.
--
To view, visit https://review.coreboot.org/c/coreboot/+/69111
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9efb5cb1149cc4cf6337c47af8a2f4c4b55f4368
Gerrit-Change-Number: 69111
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 02 Nov 2022 10:00:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Christian Walter, Maximilian Brune, Angel Pons, Lean Sheng Tan.
Hello build bot (Jenkins), Christian Walter, Angel Pons, Lean Sheng Tan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/68783
to look at the new patch set (#2).
Change subject: mb/prodrive/atlas: Add IBECC Kconfig option
......................................................................
mb/prodrive/atlas: Add IBECC Kconfig option
Add an option on Prodrive to enable IBECC (In Band Error Correction
Code), which is currently needed for indurance testing.
Test: start atlas mainboard with Linux. See in dmesg that IBECC (EDAC igen6) driver is loaded. Inject a fake error via debugfs and see in dmesg that Linux handles it.
Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com>
Change-Id: I71ee2401136e2dc70b3164db6c99af03a3e1f346
---
M src/mainboard/prodrive/atlas/Kconfig
M src/mainboard/prodrive/atlas/devicetree.cb
2 files changed, 25 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/68783/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/68783
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I71ee2401136e2dc70b3164db6c99af03a3e1f346
Gerrit-Change-Number: 68783
Gerrit-PatchSet: 2
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Hung-Te Lin, Liju-Clr Chen, Rex-BC Chen, Yu-Ping Wu, Yidi Lin.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69089 )
Change subject: soc/mediatek/mt8188: Disable input-gating for big-core SRAM
......................................................................
Patch Set 10: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69089/comment/f1c38ff6_75d979cb
PS1, Line 9: This patch fixes AP hanging issue caused by CPU input gating. The
: feature should be disabled by default, so we disable it.
> 1. CPU input gating (IG), please refer to https://ieeexplore.ieee.org/stamp/stamp. […]
Looks like this change is setting some chicken bits to disable a feature that doesn't work as intended: https://en.wiktionary.org/wiki/chicken_bit
--
To view, visit https://review.coreboot.org/c/coreboot/+/69089
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd68fe9362587955cdb8598c4cc5c2d0eefe53ca
Gerrit-Change-Number: 69089
Gerrit-PatchSet: 10
Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Comment-Date: Wed, 02 Nov 2022 09:55:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org>
Comment-In-Reply-To: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Alexander Couzens.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69111 )
Change subject: mb/*/*: Remove AMD FAMILY15TN boards
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Aren’t there change-sets up for review [1]?
[1]: https://review.coreboot.org/c/coreboot/+/64892/30
--
To view, visit https://review.coreboot.org/c/coreboot/+/69111
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9efb5cb1149cc4cf6337c47af8a2f4c4b55f4368
Gerrit-Change-Number: 69111
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 02 Nov 2022 09:54:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment