Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68790 )
Change subject: device/mmio: add clr/setbitsXp macros
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS2:
> Yeaaah, I stumbled upon that multiple times when using read*p tbh. […]
It was a side effect. The readXp/writeXp things were scattered around in native Intel code, and we decided to make them available everywhere.
--
To view, visit https://review.coreboot.org/c/coreboot/+/68790
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5b10ccab97c3a372051050b28ada854baec91d18
Gerrit-Change-Number: 68790
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 02 Nov 2022 18:46:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-MessageType: comment
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68788 )
(
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: soc/intel/common/acpi: provide PTS/WAK hooks for ECs
......................................................................
soc/intel/common/acpi: provide PTS/WAK hooks for ECs
Provide PTS/WAK hooks for ECs like we do for mainboards.
Change-Id: I687254362a896baa590959bd01ae49579ec12c94
Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/68788
Reviewed-by: Angel Pons <th3fanbus(a)gmail.com>
Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M src/soc/intel/common/acpi/platform.asl
1 file changed, 26 insertions(+), 0 deletions(-)
Approvals:
build bot (Jenkins): Verified
Angel Pons: Looks good to me, approved
Eric Lai: Looks good to me, approved
diff --git a/src/soc/intel/common/acpi/platform.asl b/src/soc/intel/common/acpi/platform.asl
index c988e0a..6a19792 100644
--- a/src/soc/intel/common/acpi/platform.asl
+++ b/src/soc/intel/common/acpi/platform.asl
@@ -6,6 +6,8 @@
External(\_SB.MWAK, MethodObj)
External(\_SB.PCI0.EGPM, MethodObj)
External(\_SB.PCI0.RGPM, MethodObj)
+External(\_SB.PCI0.LPCB.EC0.PTS, MethodObj)
+External(\_SB.PCI0.LPCB.EC0.WAK, MethodObj)
#include <arch/x86/acpi/post.asl>
@@ -18,6 +20,10 @@
{
DBG0 = POST_OS_ENTER_PTS
+ If (CondRefOf (\_SB.PCI0.LPCB.EC0.PTS))
+ {
+ \_SB.PCI0.LPCB.EC0.PTS (Arg0)
+ }
If (CondRefOf (\_SB.MPTS))
{
\_SB.MPTS (Arg0)
@@ -38,6 +44,10 @@
{
DBG0 = POST_OS_ENTER_WAKE
+ If (CondRefOf (\_SB.PCI0.LPCB.EC0.WAK))
+ {
+ \_SB.PCI0.LPCB.EC0.WAK (Arg0)
+ }
If (CondRefOf (\_SB.MWAK))
{
\_SB.MWAK (Arg0)
--
To view, visit https://review.coreboot.org/c/coreboot/+/68788
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I687254362a896baa590959bd01ae49579ec12c94
Gerrit-Change-Number: 68788
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Nicholas Chin, Kyösti Mälkki.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68264 )
Change subject: drivers/usb/gadget.c: Add support for EHCI debug using the WCH CH347
......................................................................
Patch Set 4:
(1 comment)
File src/drivers/usb/gadget.c:
https://review.coreboot.org/c/coreboot/+/68264/comment/d8e0784b_20fea5f5
PS4, Line 215: } __packed;
This might not be portable.
--
To view, visit https://review.coreboot.org/c/coreboot/+/68264
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd4ad17b7369948003fff7e825b46fe852bc7eb9
Gerrit-Change-Number: 68264
Gerrit-PatchSet: 4
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Comment-Date: Wed, 02 Nov 2022 18:43:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Nicholas Chin, Kyösti Mälkki.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68264 )
Change subject: drivers/usb/gadget.c: Add support for EHCI debug using the WCH CH347
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS3:
> Adding Kyösti as he has worked on EHCI debug in the past. […]
It's been a while.
--
To view, visit https://review.coreboot.org/c/coreboot/+/68264
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd4ad17b7369948003fff7e825b46fe852bc7eb9
Gerrit-Change-Number: 68264
Gerrit-PatchSet: 4
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Comment-Date: Wed, 02 Nov 2022 18:42:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Patrick Rudolph, Richard Hughes, Angel Pons, Nicholas Chin.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68995 )
Change subject: Documentation/sbom: Add SBOM Documentation
......................................................................
Patch Set 7:
(10 comments)
File Documentation/sbom/sbom.md:
https://review.coreboot.org/c/coreboot/+/68995/comment/43fd6e53_7cfb0799
PS6, Line 2: simply
> nit: omit "simply"
Done
https://review.coreboot.org/c/coreboot/+/68995/comment/953d403a_00c5cbea
PS6, Line 4: much
> "many", because "software parts" is countable […]
Done
https://review.coreboot.org/c/coreboot/+/68995/comment/5f0a84ff_a0623cb5
PS6, Line 12: Systems
> Why is "Systems" capitalized?
Done
https://review.coreboot.org/c/coreboot/+/68995/comment/74719ee0_4b8ee087
PS6, Line 18: Image
> Why is "Image" capitalized?
Done
https://review.coreboot.org/c/coreboot/+/68995/comment/23ded66d_1caedab8
PS6, Line 92: CONFIG_SBOM_[software-name]\_PATH
> You may want to wrap this in backticks ` so that Markdown doesn't try to do anything weird. […]
Done
https://review.coreboot.org/c/coreboot/+/68995/comment/665103ac_d22f1482
PS6, Line 103: CONFIG_SBOM_[software-name]\_PATH=/path/to/me.bin
> You may want to wrap this in backticks ` so that Markdown doesn't try to do anything weird. […]
Done
https://review.coreboot.org/c/coreboot/+/68995/comment/3c28c0a3_8ba65dd1
PS6, Line 116: The second solution should in general be preferred
> Why not place the preferred option first?
Done
https://review.coreboot.org/c/coreboot/+/68995/comment/8dd0fc13_e04ee2ef
PS6, Line 116: The second solution should in general be preferred
> Why not place the preferred option first?
Done
File Documentation/sbom/sbom_generation.plantuml:
PS6:
> It appears to be the source for the diagram, written for a tool called plantuml. […]
Yes plantuml is used to generate the SVG/PNG Image file. It was easier and faster to use plantuml and if the diagram should be changed in the future one can easily use the plantuml file as basis
File Documentation/sbom/sbom_generation.png:
PS3:
> @Max: Given that this is a diagram, can you please make it a SVG? […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/68995
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I39fbcba60a0fbdbed9f662119ed7692c0a0fd30e
Gerrit-Change-Number: 68995
Gerrit-PatchSet: 7
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Richard Hughes <richard(a)hughsie.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Richard Hughes <richard(a)hughsie.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Wed, 02 Nov 2022 18:40:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com>
Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Patrick Rudolph, Richard Hughes, Angel Pons, Maximilian Brune.
Hello build bot (Jenkins), Richard Hughes, Nicholas Chin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/68995
to look at the new patch set (#7).
Change subject: Documentation/sbom: Add SBOM Documentation
......................................................................
Documentation/sbom: Add SBOM Documentation
Change-Id: I39fbcba60a0fbdbed9f662119ed7692c0a0fd30e
Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com>
---
M Documentation/index.md
A Documentation/sbom/sbom.md
A Documentation/sbom/sbom_generation.plantuml
A Documentation/sbom/sbom_generation.svg
4 files changed, 280 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/68995/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/68995
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I39fbcba60a0fbdbed9f662119ed7692c0a0fd30e
Gerrit-Change-Number: 68995
Gerrit-PatchSet: 7
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Richard Hughes <richard(a)hughsie.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Richard Hughes <richard(a)hughsie.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Angel Pons, Werner Zeh.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69167 )
Change subject: soc/intel/**/fast_spi.c: Drop spurious whitespace
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/69167
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1972d173f99507dd167bd86c73d99434b04701ab
Gerrit-Change-Number: 69167
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Wed, 02 Nov 2022 18:38:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Werner Zeh.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69168 )
Change subject: soc/intel/**/fast_spi.c: Reorganize some statements
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/69168
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I42ce55c2978ad9c593c359c5decd5842fb3a97a1
Gerrit-Change-Number: 69168
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Wed, 02 Nov 2022 18:38:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment