coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[M] Change in coreboot[master]: device/dram: Add kconfig options for memory types
by Martin Roth (Code Review) 02 Nov '22

02 Nov '22

Attention is currently required from: Martin L Roth, Angel Pons. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68992 ) Change subject: device/dram: Add kconfig options for memory types ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Update to self: And how do you deal with the build problems? Don't bother for now. The mainboard can't unselect them currently, but we could fix that if it was really desirable. We could either change from selects to setting defaults, or move the selects into a separate Kconfig option that could be defaulted to off and overridden by a mainboard. If you think that's worthwhile, I can go ahead and add it. This was an initial implementation, and I don't mind updating it. -- To view, visit https://review.coreboot.org/c/coreboot/+/68992 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I07c98a702e0d67c5ad7bd9b8a4ff24c9288ab569 Gerrit-Change-Number: 68992 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 02 Nov 2022 18:51:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/clevo/l140cu: make use of the new clevo/it5570e ec driver
by Angel Pons (Code Review) 02 Nov '22

02 Nov '22

Attention is currently required from: Felix Singer, Michał Żygowski, Michał Kopeć, Michael Niewöhner. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68795 ) Change subject: mb/clevo/l140cu: make use of the new clevo/it5570e ec driver ...................................................................... Patch Set 10: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/68795/comment/f67ef922_8408e87e PS4, Line 11: Tested: > everything works fine, except the touchpad toggle on Linux when udev entries are missing (see CB:687 […] Could you mention that UCSI is not implemented? File src/mainboard/clevo/cml-u/smihandler.c: https://review.coreboot.org/c/coreboot/+/68795/comment/399af331_ff742a7d PS4, Line 19: return 0; > probably not and even mainboard_smi_apmc could be void just like the other smi functions (except mai […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/68795 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I28ac401ada2945bb58fe862895458b10fed505fe Gerrit-Change-Number: 68795 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Wed, 02 Nov 2022 18:51:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: cpu/mp_init.c: Only enable CPUs once they execute code
by Angel Pons (Code Review) 02 Nov '22

02 Nov '22

Attention is currently required from: Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68892 ) Change subject: cpu/mp_init.c: Only enable CPUs once they execute code ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/68892 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6c8042b4d6127239175924f996f735bf9c83c6e8 Gerrit-Change-Number: 68892 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 02 Nov 2022 18:49:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: device/mmio: add clr/setbitsXp macros
by Angel Pons (Code Review) 02 Nov '22

02 Nov '22

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68790 ) Change subject: device/mmio: add clr/setbitsXp macros ...................................................................... Patch Set 6: (1 comment) Patchset: PS2: > Yeaaah, I stumbled upon that multiple times when using read*p tbh. […] It was a side effect. The readXp/writeXp things were scattered around in native Intel code, and we decided to make them available everywhere. -- To view, visit https://review.coreboot.org/c/coreboot/+/68790 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b10ccab97c3a372051050b28ada854baec91d18 Gerrit-Change-Number: 68790 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 02 Nov 2022 18:46:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: device/mmio: add clr/setbitsXp macros
by Angel Pons (Code Review) 02 Nov '22

02 Nov '22

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68790 ) Change subject: device/mmio: add clr/setbitsXp macros ...................................................................... Patch Set 6: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/68790/comment/c5125e3e_1dfb4d73 PS2, Line 9: pendant > Done Interesting -- To view, visit https://review.coreboot.org/c/coreboot/+/68790 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b10ccab97c3a372051050b28ada854baec91d18 Gerrit-Change-Number: 68790 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 02 Nov 2022 18:45:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: device/mmio: add clr/setbitsXp macros
by Michael Niewöhner (Code Review) 02 Nov '22

02 Nov '22

Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68790 ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: device/mmio: add clr/setbitsXp macros ...................................................................... device/mmio: add clr/setbitsXp macros Add clr/setbits*p macros as pendant to read/write*p. Change-Id: I5b10ccab97c3a372051050b28ada854baec91d18 Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/68790 Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/include/device/mmio.h 1 file changed, 30 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/src/include/device/mmio.h b/src/include/device/mmio.h index 7c8e2bd..b5b79ee 100644 --- a/src/include/device/mmio.h +++ b/src/include/device/mmio.h @@ -26,6 +26,21 @@ #define clrbits32(addr, clear) clrsetbits32(addr, clear, 0) #define clrbits64(addr, clear) clrsetbits64(addr, clear, 0) +#define clrsetbits8p(addr, clear, set) clrsetbits8((void *)((uintptr_t)addr), clear, set) +#define clrsetbits16p(addr, clear, set) clrsetbits16((void *)((uintptr_t)addr), clear, set) +#define clrsetbits32p(addr, clear, set) clrsetbits32((void *)((uintptr_t)addr), clear, set) +#define clrsetbits64p(addr, clear, set) clrsetbits64((void *)((uintptr_t)addr), clear, set) + +#define setbits8p(addr, set) clrsetbits8((void *)((uintptr_t)addr), 0, set) +#define setbits16p(addr, set) clrsetbits16((void *)((uintptr_t)addr), 0, set) +#define setbits32p(addr, set) clrsetbits32((void *)((uintptr_t)addr), 0, set) +#define setbits64p(addr, set) clrsetbits64((void *)((uintptr_t)addr), 0, set) + +#define clrbits8p(addr, clear) clrsetbits8((void *)((uintptr_t)addr), clear, 0) +#define clrbits16p(addr, clear) clrsetbits16((void *)((uintptr_t)addr), clear, 0) +#define clrbits32p(addr, clear) clrsetbits32((void *)((uintptr_t)addr), clear, 0) +#define clrbits64p(addr, clear) clrsetbits64((void *)((uintptr_t)addr), clear, 0) + /* * Reads a transfer buffer from 32-bit FIFO registers. fifo_stride is the * distance in bytes between registers (e.g. pass 4 for a normal array of 32-bit -- To view, visit https://review.coreboot.org/c/coreboot/+/68790 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b10ccab97c3a372051050b28ada854baec91d18 Gerrit-Change-Number: 68790 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: soc/intel/common/acpi: provide PTS/WAK hooks for ECs
by Michael Niewöhner (Code Review) 02 Nov '22

02 Nov '22

Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68788 ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: soc/intel/common/acpi: provide PTS/WAK hooks for ECs ...................................................................... soc/intel/common/acpi: provide PTS/WAK hooks for ECs Provide PTS/WAK hooks for ECs like we do for mainboards. Change-Id: I687254362a896baa590959bd01ae49579ec12c94 Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/68788 Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/soc/intel/common/acpi/platform.asl 1 file changed, 26 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Eric Lai: Looks good to me, approved diff --git a/src/soc/intel/common/acpi/platform.asl b/src/soc/intel/common/acpi/platform.asl index c988e0a..6a19792 100644 --- a/src/soc/intel/common/acpi/platform.asl +++ b/src/soc/intel/common/acpi/platform.asl @@ -6,6 +6,8 @@ External(\_SB.MWAK, MethodObj) External(\_SB.PCI0.EGPM, MethodObj) External(\_SB.PCI0.RGPM, MethodObj) +External(\_SB.PCI0.LPCB.EC0.PTS, MethodObj) +External(\_SB.PCI0.LPCB.EC0.WAK, MethodObj) #include <arch/x86/acpi/post.asl> @@ -18,6 +20,10 @@ { DBG0 = POST_OS_ENTER_PTS + If (CondRefOf (\_SB.PCI0.LPCB.EC0.PTS)) + { + \_SB.PCI0.LPCB.EC0.PTS (Arg0) + } If (CondRefOf (\_SB.MPTS)) { \_SB.MPTS (Arg0) @@ -38,6 +44,10 @@ { DBG0 = POST_OS_ENTER_WAKE + If (CondRefOf (\_SB.PCI0.LPCB.EC0.WAK)) + { + \_SB.PCI0.LPCB.EC0.WAK (Arg0) + } If (CondRefOf (\_SB.MWAK)) { \_SB.MWAK (Arg0) -- To view, visit https://review.coreboot.org/c/coreboot/+/68788 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I687254362a896baa590959bd01ae49579ec12c94 Gerrit-Change-Number: 68788 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: drivers/usb/gadget.c: Add support for EHCI debug using the WCH CH347
by Angel Pons (Code Review) 02 Nov '22

02 Nov '22

Attention is currently required from: Nicholas Chin, Kyösti Mälkki. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68264 ) Change subject: drivers/usb/gadget.c: Add support for EHCI debug using the WCH CH347 ...................................................................... Patch Set 4: (1 comment) File src/drivers/usb/gadget.c: https://review.coreboot.org/c/coreboot/+/68264/comment/d8e0784b_20fea5f5 PS4, Line 215: } __packed; This might not be portable. -- To view, visit https://review.coreboot.org/c/coreboot/+/68264 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd4ad17b7369948003fff7e825b46fe852bc7eb9 Gerrit-Change-Number: 68264 Gerrit-PatchSet: 4 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Wed, 02 Nov 2022 18:43:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: drivers/usb/gadget.c: Add support for EHCI debug using the WCH CH347
by Angel Pons (Code Review) 02 Nov '22

02 Nov '22

Attention is currently required from: Nicholas Chin, Kyösti Mälkki. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68264 ) Change subject: drivers/usb/gadget.c: Add support for EHCI debug using the WCH CH347 ...................................................................... Patch Set 4: (1 comment) Patchset: PS3: > Adding Kyösti as he has worked on EHCI debug in the past. […] It's been a while. -- To view, visit https://review.coreboot.org/c/coreboot/+/68264 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd4ad17b7369948003fff7e825b46fe852bc7eb9 Gerrit-Change-Number: 68264 Gerrit-PatchSet: 4 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Wed, 02 Nov 2022 18:42:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: Documentation/sbom: Add SBOM Documentation
by Maximilian Brune (Code Review) 02 Nov '22

02 Nov '22

Attention is currently required from: Patrick Rudolph, Richard Hughes, Angel Pons, Nicholas Chin. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68995 ) Change subject: Documentation/sbom: Add SBOM Documentation ...................................................................... Patch Set 7: (10 comments) File Documentation/sbom/sbom.md: https://review.coreboot.org/c/coreboot/+/68995/comment/43fd6e53_7cfb0799 PS6, Line 2: simply > nit: omit "simply" Done https://review.coreboot.org/c/coreboot/+/68995/comment/953d403a_00c5cbea PS6, Line 4: much > "many", because "software parts" is countable […] Done https://review.coreboot.org/c/coreboot/+/68995/comment/5f0a84ff_a0623cb5 PS6, Line 12: Systems > Why is "Systems" capitalized? Done https://review.coreboot.org/c/coreboot/+/68995/comment/74719ee0_4b8ee087 PS6, Line 18: Image > Why is "Image" capitalized? Done https://review.coreboot.org/c/coreboot/+/68995/comment/23ded66d_1caedab8 PS6, Line 92: CONFIG_SBOM_[software-name]\_PATH > You may want to wrap this in backticks ` so that Markdown doesn't try to do anything weird. […] Done https://review.coreboot.org/c/coreboot/+/68995/comment/665103ac_d22f1482 PS6, Line 103: CONFIG_SBOM_[software-name]\_PATH=/path/to/me.bin > You may want to wrap this in backticks ` so that Markdown doesn't try to do anything weird. […] Done https://review.coreboot.org/c/coreboot/+/68995/comment/3c28c0a3_8ba65dd1 PS6, Line 116: The second solution should in general be preferred > Why not place the preferred option first? Done https://review.coreboot.org/c/coreboot/+/68995/comment/8dd0fc13_e04ee2ef PS6, Line 116: The second solution should in general be preferred > Why not place the preferred option first? Done File Documentation/sbom/sbom_generation.plantuml: PS6: > It appears to be the source for the diagram, written for a tool called plantuml. […] Yes plantuml is used to generate the SVG/PNG Image file. It was easier and faster to use plantuml and if the diagram should be changed in the future one can easily use the plantuml file as basis File Documentation/sbom/sbom_generation.png: PS3: > @Max: Given that this is a diagram, can you please make it a SVG? […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/68995 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39fbcba60a0fbdbed9f662119ed7692c0a0fd30e Gerrit-Change-Number: 68995 Gerrit-PatchSet: 7 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Wed, 02 Nov 2022 18:40:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022