Attention is currently required from: Martin L Roth, Arthur Heymans.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69213 )
Change subject: configs: Rename saved configs as config.vendor_board.description
......................................................................
Patch Set 2:
(1 comment)
File configs/config.emulation_qemu-i440fx:
PS2:
util/abuild picks up this one.
We don't need this anymore because CB:39382 made abuild always build-test the default config for a board. The config.h and coreboot.rom are identical:
```
./util/abuild/abuild -a --timeless -y -c $(nproc) -Z -t emulation/qemu-i440fx
diff -s -q coreboot-builds/EMULATION_QEMU_X86_I440FX/config.h coreboot-builds/EMULATION_QEMU_X86_I440FX_/config.h
diff -s -q coreboot-builds/EMULATION_QEMU_X86_I440FX/coreboot.rom coreboot-builds/EMULATION_QEMU_X86_I440FX_/coreboot.rom
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/69213
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I008610ff87b3dd6c4b6c6b04fbdbc30a18ba776b
Gerrit-Change-Number: 69213
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Sat, 05 Nov 2022 16:11:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth, Arthur Heymans.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69213 )
Change subject: configs: Rename saved configs as config.vendor_board.description
......................................................................
Patch Set 2: -Code-Review
(28 comments)
Patchset:
PS2:
There seem to be a lot of unnecessary renamings.
File configs/config.asus_p2b.ramdebug:
PS2:
util/abuild picks up this one, but we can rename it for consistency with other files.
File configs/config.asus_p8x7x-series.p8z77-v_lx2_debug_smmstore_hotplug_yabel_em100:
PS2:
Not picked up, neither before nor after. The problem is that the board name doesn't match the Kconfig symbol, because `-` is not `_`. `config.asus_p8z77_v_lx2.debug_smmstore_hotplug_yabel_em100` works.
File configs/config.dell_snb_ivb_workstations.optiplex_9010_sff:
PS2:
util/abuild picks up this one.
File configs/config.emulation_qemu-i440fx.asan:
PS2:
util/abuild picks up this one.
File configs/config.emulation_qemu-i440fx.noserial:
PS2:
util/abuild picks up this one.
File configs/config.emulation_qemu-i440fx.x86_64:
PS2:
util/abuild picks up this one.
File configs/config.emulation_qemu-q35.smm_tseg:
PS2:
util/abuild picks up this one.
File configs/config.emulation_qemu_x86_i440fx_debug:
PS2:
Deleted?
File configs/config.foxconn_g41s-k.g41m:
PS2:
util/abuild picks up this one.
File configs/config.google_beltino.panther.pch_serialio_uart:
PS2:
util/abuild picks up this one.
File configs/config.google_jecht.guado_pch_serialio_uart:
PS2:
util/abuild picks up this one.
File configs/config.google_octopus.meep_cros:
PS2:
util/abuild picks up this one.
File configs/config.google_octopus.spi_flash_console:
PS2:
util/abuild picks up this one, but we can rename it for consistency with other files.
File configs/config.google_reef.cros:
PS2:
util/abuild picks up this one, but we can rename it for consistency with other files.
File configs/config.hp_compaq_8200_elite_sff.pc.x86_64:
PS2:
util/abuild picks up this one, but we can rename it for consistency with other files.
File configs/config.intel_coffeelake_rvp.fsp_car:
PS2:
util/abuild picks up this one.
File configs/config.lenovo_t400.vboot_and_debug:
PS2:
util/abuild picks up this one, but we can rename it for consistency with other files.
File configs/config.lenovo_t420.static_option_table_no_mem_fuses:
PS2:
util/abuild picks up this one, but we can rename it for consistency with other files.
File configs/config.lenovo_t430.all_debug_and_option_table:
PS2:
util/abuild picks up this one, but we can rename it for consistency with other files.
File configs/config.lenovo_x201.all_debug_option_table_bt_on_wifi:
PS2:
util/abuild picks up this one, but we can rename it for consistency with other files.
File configs/config.lenovo_x220.mrc_bin:
PS2:
util/abuild picks up this one, but we can rename it for consistency with other files.
File configs/config.lenovo_x220.option_table_debug_tpm_extended_cbfs:
PS2:
util/abuild picks up this one, but we can rename it for consistency with other files.
File configs/config.pcengines_apu2.apu3:
PS2:
util/abuild picks up this one.
File configs/config.pcengines_apu2.apu4:
PS2:
util/abuild picks up this one.
File configs/config.pcengines_apu2.apu5:
PS2:
util/abuild picks up this one.
File configs/config.purism_librem_skl.librem15_v4.txt_build_test:
PS2:
util/abuild picks up this one.
File configs/config.purism_librem_skl.librem15_v4_stm:
PS2:
util/abuild picks up this one.
--
To view, visit https://review.coreboot.org/c/coreboot/+/69213
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I008610ff87b3dd6c4b6c6b04fbdbc30a18ba776b
Gerrit-Change-Number: 69213
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Sat, 05 Nov 2022 16:07:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth, Arthur Heymans.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69213 )
Change subject: configs: Rename saved configs as config.vendor_board.description
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Looks like there's a hardcoded path somewhere:
```
cp: cannot stat '/home/coreboot/node-root/workspace/coreboot-gerrit/configs/config.emulation_qemu_x86_i440fx': No such file or directory
make[1]: *** [/home/coreboot/node-root/workspace/coreboot-gerrit/tests/Makefile.common:154: build/coverage/.config] Error 1
make: *** [util/testing/Makefile.inc:100: what-jenkins-does] Error 2
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/69213
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I008610ff87b3dd6c4b6c6b04fbdbc30a18ba776b
Gerrit-Change-Number: 69213
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Sat, 05 Nov 2022 15:48:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Lean Sheng Tan, Andrey Petrov.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68592 )
Change subject: drivers/intel/fsp2_0/memory_init.c: clean code
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68592/comment/78385889_e07bad89
PS2, Line 8:
> commit message missing, can you be more specific?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/68592
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d57c45ede520160ef615725c023b7e92289a995
Gerrit-Change-Number: 68592
Gerrit-PatchSet: 3
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Comment-Date: Sat, 05 Nov 2022 15:38:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-MessageType: comment
Attention is currently required from: Maximilian Brune, Andrey Petrov.
Hello build bot (Jenkins), Lean Sheng Tan, Andrey Petrov,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/68592
to look at the new patch set (#3).
Change subject: drivers/intel/fsp2_0/memory_init.c: clean code
......................................................................
drivers/intel/fsp2_0/memory_init.c: clean code
No need to call a function that just instantly returns. It greatly enhances readability to just check before calling a funtion and it also removes an extra argument.
Change-Id: I4d57c45ede520160ef615725c023b7e92289a995
Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com>
---
M src/drivers/intel/fsp2_0/memory_init.c
1 file changed, 15 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/68592/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/68592
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d57c45ede520160ef615725c023b7e92289a995
Gerrit-Change-Number: 68592
Gerrit-PatchSet: 3
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Crawford, Tim Wawrzynczak, Angel Pons.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69214 )
Change subject: soc/intel/cannonlake: Fix GPIO reset mapping
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/69214
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib586c987f768ddff31b053f4c108a8526326a7dc
Gerrit-Change-Number: 69214
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Sat, 05 Nov 2022 15:35:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69208 )
Change subject: vboot: Introduce handy vboot reboot functions
......................................................................
Patch Set 3:
(2 comments)
File src/security/vboot/vboot_common.c:
https://review.coreboot.org/c/coreboot/+/69208/comment/5a95d4d0_a1b5305b
PS1, Line 14: if (!verification_should_run() && !(ENV_ROMSTAGE && CONFIG(VBOOT_EARLY_EC_SYNC))
> Is this block belong to the next patch?
Yes, it does. I did lazy split of patch and forgot about it. Thanks :)
File src/security/vboot/vboot_logic.c:
https://review.coreboot.org/c/coreboot/+/69208/comment/d33e80ff_8b14311d
PS2, Line 354: vboot_save_data(ctx);
> I think we can move this below the […]
It makes sense. vboot data will be saved in both cases only once. Thanks!
--
To view, visit https://review.coreboot.org/c/coreboot/+/69208
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie29410e8985e7cf19bd8d4cccc393b050ca1f1c5
Gerrit-Change-Number: 69208
Gerrit-PatchSet: 3
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Sat, 05 Nov 2022 15:30:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Jason Glenesk, Raul Rangel, Matt DeVillier, Eric Lai, Fred Reitberger, Yu-Ping Wu, Felix Held.
Hello Hung-Te Lin, build bot (Jenkins), Jason Glenesk, Raul Rangel, Matt DeVillier, Julius Werner, Eric Lai, Fred Reitberger, Yu-Ping Wu, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/66909
to look at the new patch set (#23).
Change subject: vboot: Add VBOOT_CBFS_INTEGRATION support
......................................................................
vboot: Add VBOOT_CBFS_INTEGRATION support
This patch introduces support signing and verification of firmware
slots using CBFS metadata hash verification method for faster initial
verification. To have complete verification, CBFS_VERIFICATION should
also be enabled, as metadata hash covers only files metadata, not their
contents.
This patch also adapts mainboards and SoCs to new vboot reset
requirements.
TEST=Google Volteer/Voxel boots with VBOOT_CBFS_INTEGRATION enabled
Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com>
Change-Id: I40ae01c477c4e4f7a1c90e4026a8a868ae64b5ca
---
M src/include/cbfs_glue.h
M src/lib/cbfs.c
M src/mainboard/google/asurada/Makefile.inc
M src/mainboard/google/cherry/Makefile.inc
M src/mainboard/google/corsola/Makefile.inc
M src/mainboard/google/geralt/Makefile.inc
M src/security/vboot/Kconfig
M src/security/vboot/Makefile.inc
M src/security/vboot/common.c
M src/security/vboot/vboot_common.c
M src/security/vboot/vboot_loader.c
M src/security/vboot/vboot_logic.c
M src/soc/mediatek/mt8173/Makefile.inc
13 files changed, 122 insertions(+), 33 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/66909/23
--
To view, visit https://review.coreboot.org/c/coreboot/+/66909
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40ae01c477c4e4f7a1c90e4026a8a868ae64b5ca
Gerrit-Change-Number: 66909
Gerrit-PatchSet: 23
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jakub Czapiga.
Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Matt DeVillier, Julius Werner, Eric Lai, Fred Reitberger, Yu-Ping Wu, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69208
to look at the new patch set (#3).
Change subject: vboot: Introduce handy vboot reboot functions
......................................................................
vboot: Introduce handy vboot reboot functions
This patch groups vboot context, recovery reason and subcode saving, and
reboot calls into two handy functions:
- vboot_save_and_reboot() - save context and reboot
- vboot_fail_and_reboot() - store recovery reason and call function
above
Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com>
Change-Id: Ie29410e8985e7cf19bd8d4cccc393b050ca1f1c5
---
M src/security/vboot/vboot_common.c
M src/security/vboot/vboot_common.h
M src/security/vboot/vboot_logic.c
M src/soc/amd/common/psp_verstage/psp_verstage.c
M src/soc/intel/common/block/cse/cse.c
5 files changed, 59 insertions(+), 44 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/69208/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/69208
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie29410e8985e7cf19bd8d4cccc393b050ca1f1c5
Gerrit-Change-Number: 69208
Gerrit-PatchSet: 3
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-MessageType: newpatchset