coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: cpu/x86/mp_init.c: Fix the logic to add AP cpus
by Angel Pons (Code Review) 05 Nov '22

05 Nov '22

Attention is currently required from: Bill XIE, Tim Wawrzynczak, Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69215 ) Change subject: cpu/x86/mp_init.c: Fix the logic to add AP cpus ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/69215 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1075bc52091e619ef79cbeab0a0f6b57cff1d708 Gerrit-Change-Number: 69215 Gerrit-PatchSet: 1 Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 05 Nov 2022 16:41:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: drivers/intel/fsp2_0/memory_init.c: clean code
by Angel Pons (Code Review) 05 Nov '22

05 Nov '22

Attention is currently required from: Maximilian Brune, Andrey Petrov. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68592 ) Change subject: drivers/intel/fsp2_0/memory_init.c: clean code ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/68592/comment/ccd64bee_605343d1 PS3, Line 9: No need to call a function that just instantly returns. It greatly enhances readability to just check before calling a funtion and it also removes an extra argument. Please wrap at 72 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/68592 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4d57c45ede520160ef615725c023b7e92289a995 Gerrit-Change-Number: 68592 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Sat, 05 Nov 2022 16:40:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: configs: Rename test config for Asus P8Z77-V LX2
by Angel Pons (Code Review) 05 Nov '22

05 Nov '22

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69216 ) Change subject: configs: Rename test config for Asus P8Z77-V LX2 ...................................................................... configs: Rename test config for Asus P8Z77-V LX2 Looks like abuild picks up filenames according to the mainboard's Kconfig symbol. For the Asus P8Z77-V LX2 mainboard, the symbol is `BOARD_ASUS_P8Z77_V_LX2`, but the (absurdly long) filename of the config file contains `asus_p8z77-v_lx2`, with a hyphen instead of an underscore. Thus, rename this file so that abuild picks it up. TEST: ./util/abuild/abuild -y -c $(nproc) -Z -t asus/p8x7x-series Change-Id: I1dbf6c7bf6ce3dafcabe6b9078331f1a4b22ffb4 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- R configs/config.asus_p8z77_v_lx2.debug_smmstore_hotplug_yabel_em100 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/69216/1 diff --git a/configs/config.asus_p8z77-v_lx2.debug_smmstore_hotplug_yabel_em100 b/configs/config.asus_p8z77_v_lx2.debug_smmstore_hotplug_yabel_em100 similarity index 100% rename from configs/config.asus_p8z77-v_lx2.debug_smmstore_hotplug_yabel_em100 rename to configs/config.asus_p8z77_v_lx2.debug_smmstore_hotplug_yabel_em100 -- To view, visit https://review.coreboot.org/c/coreboot/+/69216 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1dbf6c7bf6ce3dafcabe6b9078331f1a4b22ffb4 Gerrit-Change-Number: 69216 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: soc/amd/common/data_fabric: Make common device ops
by 9elements QA (Code Review) 05 Nov '22

05 Nov '22

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69173 ) Change subject: soc/amd/common/data_fabric: Make common device ops ...................................................................... Patch Set 2: Automatic boot test returned (PASS/FAIL/TOTAL): 13 / 1 / 14 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES_ and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/133911 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/133910 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/133909 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/133908 FAIL: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload TianoCore : https://lava.9esec.io/r/133907 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/133906 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload TianoCore : https://lava.9esec.io/r/133905 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/133904 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload TianoCore : https://lava.9esec.io/r/133903 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload TianoCore : https://lava.9esec.io/r/133901 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload SeaBIOS : https://lava.9esec.io/r/133900 PASS: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/133899 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/133897 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/133896 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/69173 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I12053389a12081ddd81912a647bb532b31062093 Gerrit-Change-Number: 69173 Gerrit-PatchSet: 2 Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Sat, 05 Nov 2022 16:35:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: cpu/x86/mp_init.c: Use linked list data structures
by Bill XIE (Code Review) 05 Nov '22

05 Nov '22

Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64340 ) Change subject: cpu/x86/mp_init.c: Use linked list data structures ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: This commit incorrectly assumed that (g_)cpu_bus->children->sibling can always represent the first AP cpu, introducing some regression that may be fixed in https://review.coreboot.org/c/coreboot/+/69215 . -- To view, visit https://review.coreboot.org/c/coreboot/+/64340 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie728110fc8c60fec94ae4bedf74e17740cf78f67 Gerrit-Change-Number: 64340 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Sat, 05 Nov 2022 16:32:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: acpi/acpi.c: Follow spec more closely for MADT
by Tim Wawrzynczak (Code Review) 05 Nov '22

05 Nov '22

Attention is currently required from: Lance Zhao, Arthur Heymans. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69225 ) Change subject: acpi/acpi.c: Follow spec more closely for MADT ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Patchset: PS5: This looks correct, have you tested it? -- To view, visit https://review.coreboot.org/c/coreboot/+/69225 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a98560760b662a7ba7efb46f5f7882fb0f7bb1f Gerrit-Change-Number: 69225 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 05 Nov 2022 16:29:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: cpu/x86/mp_init.c: Fix the logic to add AP cpus
by Bill XIE (Code Review) 05 Nov '22

05 Nov '22

Bill XIE has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69215 ) Change subject: cpu/x86/mp_init.c: Fix the logic to add AP cpus ...................................................................... cpu/x86/mp_init.c: Fix the logic to add AP cpus https://review.coreboot.org/c/coreboot/+/64340 assumes (g_)cpu_bus->children->sibling represents the first AP cpu, but this is not true when device tree (like mb/asus/p8x7x-series/devicetree.cb) contains additional static lapic nodes. In such case, Linux kernel can find one cpu unable to wake up, and an additional working cpu without corresponding ACPI firmware node: smpboot: Allowing 5 CPUs, 0 hotplug CPUs smpboot: CPU0: Intel(R) Xeon(R) CPU E3-1225 V2 @ 3.20GHz (family: 0x6, model: 0x3a, stepping: 0x9) smpboot: do_boot_cpu failed(-1) to wakeup CPU#2 Now, in the end of init_bsp(), the last apic node is held on g_last_apic, and all node representing an AP cpu should be inserted and set up after it. The consistency lost with CB:64340 should be restored now. Signed-off-by: Bill XIE <persmule(a)hardenedlinux.org> Change-Id: I1075bc52091e619ef79cbeab0a0f6b57cff1d708 --- M src/cpu/x86/mp_init.c 1 file changed, 38 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/69215/1 diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c index febc30b..1aed394 100644 --- a/src/cpu/x86/mp_init.c +++ b/src/cpu/x86/mp_init.c @@ -172,7 +172,7 @@ stop_this_cpu(); } -static struct bus *g_cpu_bus; +static struct device *g_last_apic; /* By the time APs call ap_init() caching has been setup, and microcode has * been loaded. */ @@ -184,7 +184,7 @@ enable_lapic(); setup_lapic_interrupts(); - struct device *dev = g_cpu_bus->children; + struct device *dev = g_last_apic; for (unsigned int i = info->index; i > 0; i--) dev = dev->sibling; @@ -534,6 +534,7 @@ { struct device_path cpu_path; struct cpu_info *info; + struct device *child; /* Print processor name */ fill_processor_name(processor_name); @@ -559,6 +560,14 @@ /* Track BSP in cpu_map structures. */ cpu_add_map_entry(info->index); + + /* Find the last apic node, which may not be identical to + * cpu_bus->children. + */ + for (child = info->cpu; child && child->sibling; /* */) + child = child->sibling; + + g_last_apic = child; return CB_SUCCESS; } @@ -584,8 +593,6 @@ int num_cpus; atomic_t *ap_count; - g_cpu_bus = cpu_bus; - if (init_bsp(cpu_bus) != CB_SUCCESS) { printk(BIOS_CRIT, "Setting up BSP failed\n"); return CB_ERR; -- To view, visit https://review.coreboot.org/c/coreboot/+/69215 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1075bc52091e619ef79cbeab0a0f6b57cff1d708 Gerrit-Change-Number: 69215 Gerrit-PatchSet: 1 Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: soc/intel/cannonlake: Fix GPIO reset mapping
by Tim Wawrzynczak (Code Review) 05 Nov '22

05 Nov '22

Attention is currently required from: Tim Crawford, Angel Pons. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69214 ) Change subject: soc/intel/cannonlake: Fix GPIO reset mapping ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69214 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib586c987f768ddff31b053f4c108a8526326a7dc Gerrit-Change-Number: 69214 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 05 Nov 2022 16:25:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: drivers/intel/fsp2_0/memory_init.c: clean code
by Lean Sheng Tan (Code Review) 05 Nov '22

05 Nov '22

Attention is currently required from: Angel Pons, Maximilian Brune, Andrey Petrov. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68592 ) Change subject: drivers/intel/fsp2_0/memory_init.c: clean code ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/68592 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4d57c45ede520160ef615725c023b7e92289a995 Gerrit-Change-Number: 68592 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Sat, 05 Nov 2022 16:22:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: configs: Rename saved configs as config.vendor_board.description
by Angel Pons (Code Review) 05 Nov '22

05 Nov '22

Attention is currently required from: Martin L Roth, Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69213 ) Change subject: configs: Rename saved configs as config.vendor_board.description ...................................................................... Patch Set 2: (10 comments) File configs/config.cavium_cn8100_sff_evb.bdk_verbose_fit_payload_support: PS2: util/abuild picks up this one. File configs/config.emulation_qemu-aarch64.fit_support_timestamps: PS2: util/abuild picks up this one. File configs/config.emulation_qemu-power9: PS2: util/abuild picks up this one. File configs/config.emulation_qemu-riscv.rv64: PS2: util/abuild picks up this one. File configs/config.google_gru.kevin_secdata_mock: PS2: util/abuild picks up this one. File configs/config.intel_galileo.gen2_debug: PS2: util/abuild picks up this one. File configs/config.intel_galileo.gen2_fsp2.0: PS2: util/abuild picks up this one. File configs/config.intel_galileo.gen2_sd: PS2: util/abuild picks up this one. File configs/config.intel_galileo.gen2_vboot: PS2: util/abuild picks up this one. File configs/config.ocp_deltalake.cbnt: PS2: util/abuild picks up this one, but we can rename it for consistency with other files. -- To view, visit https://review.coreboot.org/c/coreboot/+/69213 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I008610ff87b3dd6c4b6c6b04fbdbc30a18ba776b Gerrit-Change-Number: 69213 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 05 Nov 2022 16:19:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022