coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: soc/qualcomm/sc7280: Move AOP load and reset handle to Romstage
by Venkat Thogaru (Code Review) 07 Nov '22

07 Nov '22

Attention is currently required from: Venkat Thogaru, Julius Werner, Sudheer Amrabadi. Venkat Thogaru has uploaded a new patch set (#22) to the change originally created by Sudheer Amrabadi. ( https://review.coreboot.org/c/coreboot/+/67673 ) Change subject: soc/qualcomm/sc7280: Move AOP load and reset handle to Romstage ...................................................................... soc/qualcomm/sc7280: Move AOP load and reset handle to Romstage As AOP takes 500 msec delay to get up, moving aop load and reset to romstage improves the performance. BUG=b:218406702 TEST=reboot from AP console (on CRD3) prior to fix (from cbmem dump): 1000:depthcharge start 1,139,809 (152,679) after fix (from cbmem dump): 1000:depthcharge start 1,041,109 (46,353) Signed-off-by: Sudheer Kumar Amrabadi <samrabad(a)codeaurora.org> Change-Id: Iabc8ee8f6e7b14d237b0aeaae42da8077f9dafc4 --- M src/mainboard/google/herobrine/romstage.c M src/soc/qualcomm/sc7280/Makefile.inc M src/soc/qualcomm/sc7280/memlayout.ld M src/soc/qualcomm/sc7280/soc.c 4 files changed, 26 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/67673/22 -- To view, visit https://review.coreboot.org/c/coreboot/+/67673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iabc8ee8f6e7b14d237b0aeaae42da8077f9dafc4 Gerrit-Change-Number: 67673 Gerrit-PatchSet: 22 Gerrit-Owner: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: T.Michael Turney <tmiketurney(a)gmail.com> Gerrit-Attention: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/qualcomm/sc7280: Update Skuid to support pro/non-pro
by Venkat Thogaru (Code Review) 07 Nov '22

07 Nov '22

Attention is currently required from: Paul Menzel, Sudheer Amrabadi. Venkat Thogaru has uploaded a new patch set (#15) to the change originally created by Sudheer Amrabadi. ( https://review.coreboot.org/c/coreboot/+/68385 ) Change subject: soc/qualcomm/sc7280: Update Skuid to support pro/non-pro ...................................................................... soc/qualcomm/sc7280: Update Skuid to support pro/non-pro Tranferring a bit to DC through Skuid to update the regulator node in order to support pro and non-pro BUG=b:248187555 TEST=Validate boards are detected correctly on PRO and NON_PRO SKUs Signed-off-by: Sudheer Kumar Amrabadi <quic_samrabad(a)quicinc.com> Change-Id: Iec392c03c2e2c79d20b1fcb79236ca9e048bfd07 --- M src/mainboard/google/herobrine/boardid.c 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/68385/15 -- To view, visit https://review.coreboot.org/c/coreboot/+/68385 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iec392c03c2e2c79d20b1fcb79236ca9e048bfd07 Gerrit-Change-Number: 68385 Gerrit-PatchSet: 15 Gerrit-Owner: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: soc/qualcomm/sc7280: Add API to differentialize PRO and NON_PRO SKUs
by Venkat Thogaru (Code Review) 07 Nov '22

07 Nov '22

Attention is currently required from: Shelley Chen, Taniya Das, Paul Menzel, Julius Werner, Sudheer Amrabadi. Venkat Thogaru has uploaded a new patch set (#14) to the change originally created by Sudheer Amrabadi. ( https://review.coreboot.org/c/coreboot/+/68384 ) Change subject: soc/qualcomm/sc7280: Add API to differentialize PRO and NON_PRO SKUs ...................................................................... soc/qualcomm/sc7280: Add API to differentialize PRO and NON_PRO SKUs The API socinfo_pro_part() returns 1 for Pro and 0 for NON_PRO SKUs. To reduce the binary footprint for chipinfo structure, change its members range from uint32_t to uint16_t. Add helper functions for reading and matching jtagid. BUG=b:248187555 TEST=Validate boards are detected correctly on PRO and NON_PRO SKUs Signed-off-by: Taniya Das <quic_tdas(a)quicinc.com> Change-Id: Id9f23696384a6c1a89000292eafebd8a16c273ca --- M src/soc/qualcomm/sc7280/include/soc/socinfo.h M src/soc/qualcomm/sc7280/socinfo.c 2 files changed, 86 insertions(+), 57 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/68384/14 -- To view, visit https://review.coreboot.org/c/coreboot/+/68384 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id9f23696384a6c1a89000292eafebd8a16c273ca Gerrit-Change-Number: 68384 Gerrit-PatchSet: 14 Gerrit-Owner: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Taniya Das <quic_tdas(a)quicinc.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Taniya Das <tdas(a)qualcomm.corp-partner.google.com> Gerrit-CC: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Taniya Das <quic_tdas(a)quicinc.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Taniya Das <tdas(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/herobrine: Update comment of modem status info
by Venkat Thogaru (Code Review) 07 Nov '22

07 Nov '22

Venkat Thogaru has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/69296 ) Change subject: mb/google/herobrine: Update comment of modem status info ...................................................................... mb/google/herobrine: Update comment of modem status info Updated comment as per guidelines. BUG=b:232302324 TEST=none Signed-off-by: Venkat Thogaru <quic_thogaru(a)quicinc.com> Change-Id: I6a925477a926e7e9d54e42d662768536318ec8e0 --- M src/mainboard/google/herobrine/boardid.c 1 file changed, 17 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/69296/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69296 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6a925477a926e7e9d54e42d662768536318ec8e0 Gerrit-Change-Number: 69296 Gerrit-PatchSet: 2 Gerrit-Owner: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/qualcomm/sc7280: Update Skuid to support pro/non-pro
by Venkat Thogaru (Code Review) 07 Nov '22

07 Nov '22

Attention is currently required from: Paul Menzel, Sudheer Amrabadi. Venkat Thogaru has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68385 ) Change subject: soc/qualcomm/sc7280: Update Skuid to support pro/non-pro ...................................................................... Patch Set 14: (1 comment) File src/mainboard/google/herobrine/boardid.c: https://review.coreboot.org/c/coreboot/+/68385/comment/15cceb35_e7868b71 PS10, Line 47: /* Update modem status in 9th bit of sku id */ > Moved the changes to separate commit. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/68385 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iec392c03c2e2c79d20b1fcb79236ca9e048bfd07 Gerrit-Change-Number: 68385 Gerrit-PatchSet: 14 Gerrit-Owner: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Comment-Date: Mon, 07 Nov 2022 10:30:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/qualcomm/sc7280: Update Skuid to support pro/non-pro
by Venkat Thogaru (Code Review) 07 Nov '22

07 Nov '22

Attention is currently required from: Paul Menzel, Sudheer Amrabadi. Venkat Thogaru has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68385 ) Change subject: soc/qualcomm/sc7280: Update Skuid to support pro/non-pro ...................................................................... Patch Set 14: (1 comment) File src/mainboard/google/herobrine/boardid.c: https://review.coreboot.org/c/coreboot/+/68385/comment/e9de06db_eda8791b PS10, Line 47: /* Update modem status in 9th bit of sku id */ > Please factor this out into a separate commit. Moved the changes to separate commit. https://review.coreboot.org/c/coreboot/+/69296 -- To view, visit https://review.coreboot.org/c/coreboot/+/68385 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iec392c03c2e2c79d20b1fcb79236ca9e048bfd07 Gerrit-Change-Number: 68385 Gerrit-PatchSet: 14 Gerrit-Owner: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Comment-Date: Mon, 07 Nov 2022 10:28:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/herobrine: Update comment of modem status info
by build bot (Jenkins) (Code Review) 07 Nov '22

07 Nov '22

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69296 ) Change subject: mb/google/herobrine: Update comment of modem status info ...................................................................... Patch Set 1: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162651): https://review.coreboot.org/c/coreboot/+/69296/comment/50361f29_e35a9350 PS1, Line 8: 'guidlines' may be misspelled - perhaps 'guidelines'? -- To view, visit https://review.coreboot.org/c/coreboot/+/69296 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6a925477a926e7e9d54e42d662768536318ec8e0 Gerrit-Change-Number: 69296 Gerrit-PatchSet: 1 Gerrit-Owner: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 07 Nov 2022 10:28:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/herobrine: Update comment of modem status info
by Venkat Thogaru (Code Review) 07 Nov '22

07 Nov '22

Venkat Thogaru has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69296 ) Change subject: mb/google/herobrine: Update comment of modem status info ...................................................................... mb/google/herobrine: Update comment of modem status info Updated comment as per guidlines. BUG=b:232302324 TEST=none Signed-off-by: Venkat Thogaru <quic_thogaru(a)quicinc.com> Change-Id: I6a925477a926e7e9d54e42d662768536318ec8e0 --- M src/mainboard/google/herobrine/boardid.c 1 file changed, 17 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/69296/1 diff --git a/src/mainboard/google/herobrine/boardid.c b/src/mainboard/google/herobrine/boardid.c index 7bac5df..fc058e2 100644 --- a/src/mainboard/google/herobrine/boardid.c +++ b/src/mainboard/google/herobrine/boardid.c @@ -43,7 +43,8 @@ uint32_t sku_id(void) { static uint32_t id = UNDEFINED_STRAPPING_ID; - /*Update modem status in 9th bit of sku id*/ + + /* Update modem status in 9th bit of sku id */ uint32_t mask = 1 << 9; id = google_chromeec_get_board_sku(); id = ((id & ~mask) | (socinfo_modem_supported() << 9)); -- To view, visit https://review.coreboot.org/c/coreboot/+/69296 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6a925477a926e7e9d54e42d662768536318ec8e0 Gerrit-Change-Number: 69296 Gerrit-PatchSet: 1 Gerrit-Owner: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: soc/qualcomm/sc7280: Move AOP load and reset handle to Romstage
by Venkat Thogaru (Code Review) 07 Nov '22

07 Nov '22

Attention is currently required from: Venkat Thogaru, Julius Werner, Sudheer Amrabadi. Venkat Thogaru has uploaded a new patch set (#21) to the change originally created by Sudheer Amrabadi. ( https://review.coreboot.org/c/coreboot/+/67673 ) Change subject: soc/qualcomm/sc7280: Move AOP load and reset handle to Romstage ...................................................................... soc/qualcomm/sc7280: Move AOP load and reset handle to Romstage As AOP takes 500 msec delay to get up, moving aop load and reset to romstage improves the performance. BUG=b:218406702 TEST=reboot from AP console (on CRD3) prior to fix (from cbmem dump): 1000:depthcharge start 1,139,809 (152,679) after fix (from cbmem dump): 1000:depthcharge start 1,041,109 (46,353) Signed-off-by: Sudheer Kumar Amrabadi <samrabad(a)codeaurora.org> Change-Id: Iabc8ee8f6e7b14d237b0aeaae42da8077f9dafc4 --- M src/mainboard/google/herobrine/romstage.c M src/soc/qualcomm/sc7280/Makefile.inc M src/soc/qualcomm/sc7280/memlayout.ld M src/soc/qualcomm/sc7280/soc.c 4 files changed, 26 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/67673/21 -- To view, visit https://review.coreboot.org/c/coreboot/+/67673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iabc8ee8f6e7b14d237b0aeaae42da8077f9dafc4 Gerrit-Change-Number: 67673 Gerrit-PatchSet: 21 Gerrit-Owner: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: T.Michael Turney <tmiketurney(a)gmail.com> Gerrit-Attention: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: soc/amd/mendocino: Enhance DPTC_INPUT to support 13 DPTC thermal para...
by EricKY Cheng (Code Review) 07 Nov '22

07 Nov '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held. EricKY Cheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68649 ) Change subject: soc/amd/mendocino: Enhance DPTC_INPUT to support 13 DPTC thermal parameters ...................................................................... Patch Set 21: (1 comment) File src/soc/amd/mendocino/root_complex.c: https://review.coreboot.org/c/coreboot/+/68649/comment/102f63ea_1e484067 PS20, Line 269: /* Normal mode DPTC values. */ : struct dptc_input default_input = DPTC_INPUTS( : config->thermctl_limit_degreeC, : config->sustained_power_limit_mW, : config->slow_ppt_time_constant_s, : config->fast_ppt_limit_mW, : config->slow_ppt_limit_mW, : config->vrm_current_limit_mA, : config->vrm_maximum_current_limit_mA, : config->vrm_soc_current_limit_mA, : config->stt_min_limit, : config->stt_m1, : config->stt_m2, : config->stt_c_apu, : config->stt_skin_temp_apu); : acpigen_write_alib_dptc_default((uint8_t *)&default_input, sizeof(default_input)); : : /* Low/No Battery */ : struct dptc_input no_battery_input = DPTC_INPUTS( : config->thermctl_limit_degreeC, : config->sustained_power_limit_mW, : config->slow_ppt_time_constant_s, : config->fast_ppt_limit_mW, : config->slow_ppt_limit_mW, : config->vrm_current_limit_throttle_mA, : config->vrm_maximum_current_limit_throttle_mA, : config->vrm_soc_current_limit_throttle_mA, : config->stt_min_limit, : config->stt_m1, : config->stt_m2, : config->stt_c_apu, : config->stt_skin_temp_apu); : acpigen_write_alib_dptc_no_battery((uint8_t *)&no_battery_input, : sizeof(no_battery_input)); > Delete these and use the ones defined below instead. default_input on line 270 is different form default_input on line 395. no_battery_input on line 287 s different form default_input on line 405. Follow thermal team's proposal, default_input is used as table A on line 270 defined with DTTS requested parameters. If delete the default_input on line 270 and used the default_input on line 395, will conflict with thermal team's proposal. -- To view, visit https://review.coreboot.org/c/coreboot/+/68649 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6d6a00f0eca0b0941860b9bc75da41d7a10d60e8 Gerrit-Change-Number: 68649 Gerrit-PatchSet: 21 Gerrit-Owner: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 07 Nov 2022 10:26:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022