coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: drivers/intel/fsp2_0: Add support for locating specific HOB instance
by Felix Held (Code Review) 12 Nov '22

12 Nov '22

Attention is currently required from: Martin L Roth, Marshall Dawson, Nikolai Vyssotski, Andrey Petrov, Matt Papageorge, Patrick Rudolph. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51061 ) Change subject: drivers/intel/fsp2_0: Add support for locating specific HOB instance ...................................................................... Patch Set 4: (1 comment) Patchset: PS1: > this comment still applies. […] ended up reworking quite a bit of the fsp hob handling code in CB:69475 that more or less replaces this patch. since that's written from scratch and apart from my comments there wasn't any discussion here, i chose to not recycle this change id -- To view, visit https://review.coreboot.org/c/coreboot/+/51061 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I695f0d1574a59e65f01d12561a2c2f6142cac44d Gerrit-Change-Number: 51061 Gerrit-PatchSet: 4 Gerrit-Owner: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 12 Nov 2022 02:38:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: driver/intel/fsp2_0/hand_off_block: rework fsp_display_fvi_version_hob
by build bot (Jenkins) (Code Review) 12 Nov '22

12 Nov '22

Attention is currently required from: Andrey Petrov. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69499 ) Change subject: driver/intel/fsp2_0/hand_off_block: rework fsp_display_fvi_version_hob ...................................................................... Patch Set 1: (1 comment) File src/drivers/intel/fsp2_0/hand_off_block.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163368): https://review.coreboot.org/c/coreboot/+/69499/comment/dd24a8e7_bf609ba9 PS1, Line 327: if (hob_uuid != NULL) { braces {} are not necessary for single statement blocks -- To view, visit https://review.coreboot.org/c/coreboot/+/69499 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3398043dbdb3fc618277cefdd349b2c935bbfa52 Gerrit-Change-Number: 69499 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Sat, 12 Nov 2022 02:27:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: driver/intel/fsp2_0/hand_off_block: rework fsp_display_fvi_version_hob
by Felix Held (Code Review) 12 Nov '22

12 Nov '22

Attention is currently required from: Andrey Petrov. Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69499 ) Change subject: driver/intel/fsp2_0/hand_off_block: rework fsp_display_fvi_version_hob ...................................................................... driver/intel/fsp2_0/hand_off_block: rework fsp_display_fvi_version_hob Use the new fsp_hob_iterator_get_next_guid_extension function in fsp_display_fvi_version_hob instead of iterating through the HOB list in this function. TEST=Not tested on hardware, since no AMD SoC uses this functionality Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I3398043dbdb3fc618277cefdd349b2c935bbfa52 --- M src/drivers/intel/fsp2_0/hand_off_block.c 1 file changed, 21 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/69499/1 diff --git a/src/drivers/intel/fsp2_0/hand_off_block.c b/src/drivers/intel/fsp2_0/hand_off_block.c index 2ded33699..8f51159 100644 --- a/src/drivers/intel/fsp2_0/hand_off_block.c +++ b/src/drivers/intel/fsp2_0/hand_off_block.c @@ -317,22 +317,15 @@ void fsp_display_fvi_version_hob(void) { - const uint8_t *hob_uuid; - const struct hob_header *hob = fsp_get_hob_list(); + const void *hob_uuid; + size_t hob_size; - if (!hob) - return; + hob_uuid = fsp_find_extension_hob_by_guid(uuid_fv_info, &hob_size); printk(BIOS_DEBUG, "Display FSP Version Info HOB\n"); - for (; hob->type != HOB_TYPE_END_OF_HOB_LIST; hob = fsp_next_hob(hob)) { - if (hob->type != HOB_TYPE_GUID_EXTENSION) - continue; - hob_uuid = hob_header_to_struct(hob); - - if (fsp_guid_compare(hob_uuid, uuid_fv_info)) { - display_fsp_version_info_hob(hob); - } + if (hob_uuid != NULL) { + display_fsp_version_info_hob(hob_uuid); } } -- To view, visit https://review.coreboot.org/c/coreboot/+/69499 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3398043dbdb3fc618277cefdd349b2c935bbfa52 Gerrit-Change-Number: 69499 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: drv/intel/fsp2_0/hand_off_block: rework fsp_find_extension_hob_by_guid
by Felix Held (Code Review) 12 Nov '22

12 Nov '22

Attention is currently required from: Andrey Petrov. Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69478 ) Change subject: drv/intel/fsp2_0/hand_off_block: rework fsp_find_extension_hob_by_guid ...................................................................... drv/intel/fsp2_0/hand_off_block: rework fsp_find_extension_hob_by_guid Use the new fsp_hob_iterator_get_next_guid_extension function in fsp_find_extension_hob_by_guid instead of iterating through the HOB list in this function. TEST=AMD_FSP_DMI_HOB is still found and the same type 17 DMI info is printed on the console. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I4d4ce14c8a5494763de3f65ed049f98a768c40a5 --- M src/drivers/intel/fsp2_0/hand_off_block.c 1 file changed, 22 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/69478/1 diff --git a/src/drivers/intel/fsp2_0/hand_off_block.c b/src/drivers/intel/fsp2_0/hand_off_block.c index 2738c78..2ded33699 100644 --- a/src/drivers/intel/fsp2_0/hand_off_block.c +++ b/src/drivers/intel/fsp2_0/hand_off_block.c @@ -233,22 +233,14 @@ const void *fsp_find_extension_hob_by_guid(const uint8_t *guid, size_t *size) { - const uint8_t *hob_guid; - const struct hob_header *hob = fsp_get_hob_list(); + const struct hob_header *hob_iterator; + const void *hob_guid; - if (!hob) + if (fsp_hob_iterator_init(&hob_iterator) != CB_SUCCESS) return NULL; - for (; hob->type != HOB_TYPE_END_OF_HOB_LIST; hob = fsp_next_hob(hob)) { - if (hob->type != HOB_TYPE_GUID_EXTENSION) - continue; - - hob_guid = hob_header_to_struct(hob); - if (fsp_guid_compare(hob_guid, guid)) { - *size = hob->length - (HOB_HEADER_LEN + 16); - return hob_header_to_extension_hob(hob); - } - } + if (fsp_hob_iterator_get_next_guid_extension(&hob_iterator, guid, &hob_guid, size) == CB_SUCCESS) + return hob_guid; return NULL; } -- To view, visit https://review.coreboot.org/c/coreboot/+/69478 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4d4ce14c8a5494763de3f65ed049f98a768c40a5 Gerrit-Change-Number: 69478 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: drivers/intel/fsp2_0/hand_off_block: use iterator in fsp_find_range_hob
by Felix Held (Code Review) 12 Nov '22

12 Nov '22

Attention is currently required from: Andrey Petrov. Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69477 ) Change subject: drivers/intel/fsp2_0/hand_off_block: use iterator in fsp_find_range_hob ...................................................................... drivers/intel/fsp2_0/hand_off_block: use iterator in fsp_find_range_hob Drop the find_resource_hob_by_guid implementation and use the new fsp_hob_iterator_init and fsp_hob_iterator_get_next_guid_resource functions in fsp_find_range_hob. TEST=Mandolin still finds the TSEG range HOB and uses the correct TSEG location. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I00786cbeea203fba195ddc953c3242be544a7d70 --- M src/drivers/intel/fsp2_0/hand_off_block.c 1 file changed, 20 insertions(+), 22 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/69477/1 diff --git a/src/drivers/intel/fsp2_0/hand_off_block.c b/src/drivers/intel/fsp2_0/hand_off_block.c index 13fbb06..2738c78 100644 --- a/src/drivers/intel/fsp2_0/hand_off_block.c +++ b/src/drivers/intel/fsp2_0/hand_off_block.c @@ -190,23 +190,6 @@ return CB_ERR; } -static const -struct hob_resource *find_resource_hob_by_guid(const struct hob_header *hob, - const uint8_t guid[16]) -{ - const struct hob_resource *res; - - for (; hob->type != HOB_TYPE_END_OF_HOB_LIST; hob = fsp_next_hob(hob)) { - if (hob->type != HOB_TYPE_RESOURCE_DESCRIPTOR) - continue; - - res = fsp_hob_header_to_resource(hob); - if (fsp_guid_compare(res->owner_guid, guid)) - return res; - } - return NULL; -} - void fsp_print_guid(const void *base) { uint32_t big; @@ -224,17 +207,15 @@ int fsp_find_range_hob(struct range_entry *re, const uint8_t guid[16]) { + const struct hob_header *hob_iterator; const struct hob_resource *fsp_mem; - const void *hob_list = fsp_get_hob_list(); - if (!hob_list) + if (fsp_hob_iterator_init(&hob_iterator) != CB_SUCCESS) return -1; range_entry_init(re, 0, 0, 0); - fsp_mem = find_resource_hob_by_guid(hob_list, guid); - - if (!fsp_mem) { + if (fsp_hob_iterator_get_next_guid_resource(&hob_iterator, guid, &fsp_mem) != CB_SUCCESS) { fsp_print_guid(guid); printk(BIOS_SPEW, " not found!\n"); return -1; -- To view, visit https://review.coreboot.org/c/coreboot/+/69477 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00786cbeea203fba195ddc953c3242be544a7d70 Gerrit-Change-Number: 69477 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: soc/amd/*/root_complex: use FSP HOB iterator functions
by Felix Held (Code Review) 12 Nov '22

12 Nov '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger. Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69476 ) Change subject: soc/amd/*/root_complex: use FSP HOB iterator functions ...................................................................... soc/amd/*/root_complex: use FSP HOB iterator functions Use the newly added functions to iterate over the FSP HOBs to report the resources used by FSP to the resource allocator instead of open coding the iteration over the HOBs in the SoC code. TEST=Patch doesn't change reported resources on Mandolin Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I67ca346345c1fa08b008caa885d0a00d2d5afb12 --- M src/soc/amd/cezanne/root_complex.c M src/soc/amd/glinda/root_complex.c M src/soc/amd/mendocino/root_complex.c M src/soc/amd/morgana/root_complex.c M src/soc/amd/picasso/root_complex.c 5 files changed, 32 insertions(+), 47 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/69476/1 diff --git a/src/soc/amd/cezanne/root_complex.c b/src/soc/amd/cezanne/root_complex.c index 5f2024c..31c2e1a 100644 --- a/src/soc/amd/cezanne/root_complex.c +++ b/src/soc/amd/cezanne/root_complex.c @@ -103,7 +103,7 @@ { uint32_t mem_usable = (uintptr_t)cbmem_top(); unsigned int idx = 0; - const struct hob_header *hob = fsp_get_hob_list(); + const struct hob_header *hob_iterator; const struct hob_resource *res; struct resource *gnb_apic; @@ -148,19 +148,13 @@ gnb_apic->size = 0x00001000; gnb_apic->flags = IORESOURCE_MEM | IORESOURCE_ASSIGNED | IORESOURCE_FIXED; - if (!hob) { + if (fsp_hob_iterator_init(&hob_iterator) != CB_SUCCESS) { printk(BIOS_ERR, "%s incomplete because no HOB list was found\n", __func__); return; } - for (; hob->type != HOB_TYPE_END_OF_HOB_LIST; hob = fsp_next_hob(hob)) { - - if (hob->type != HOB_TYPE_RESOURCE_DESCRIPTOR) - continue; - - res = fsp_hob_header_to_resource(hob); - + while (fsp_hob_iterator_get_next_resource(&hob_iterator, &res) == CB_SUCCESS) { if (res->type == EFI_RESOURCE_SYSTEM_MEMORY && res->addr < mem_usable) continue; /* 0 through low usable was set above */ if (res->type == EFI_RESOURCE_MEMORY_MAPPED_IO) diff --git a/src/soc/amd/glinda/root_complex.c b/src/soc/amd/glinda/root_complex.c index 16f1bdd..04d0599 100644 --- a/src/soc/amd/glinda/root_complex.c +++ b/src/soc/amd/glinda/root_complex.c @@ -118,7 +118,7 @@ { uint32_t mem_usable = (uintptr_t)cbmem_top(); unsigned int idx = 0; - const struct hob_header *hob = fsp_get_hob_list(); + const struct hob_header *hob_iterator; const struct hob_resource *res; struct resource *gnb_apic; @@ -163,19 +163,13 @@ gnb_apic->size = 0x00001000; gnb_apic->flags = IORESOURCE_MEM | IORESOURCE_ASSIGNED | IORESOURCE_FIXED; - if (!hob) { + if (fsp_hob_iterator_init(&hob_iterator) != CB_SUCCESS) { printk(BIOS_ERR, "%s incomplete because no HOB list was found\n", __func__); return; } - for (; hob->type != HOB_TYPE_END_OF_HOB_LIST; hob = fsp_next_hob(hob)) { - - if (hob->type != HOB_TYPE_RESOURCE_DESCRIPTOR) - continue; - - res = fsp_hob_header_to_resource(hob); - + while (fsp_hob_iterator_get_next_resource(&hob_iterator, &res) == CB_SUCCESS) { if (res->type == EFI_RESOURCE_SYSTEM_MEMORY && res->addr < mem_usable) continue; /* 0 through low usable was set above */ if (res->type == EFI_RESOURCE_MEMORY_MAPPED_IO) diff --git a/src/soc/amd/mendocino/root_complex.c b/src/soc/amd/mendocino/root_complex.c index d728516..abc49cf 100644 --- a/src/soc/amd/mendocino/root_complex.c +++ b/src/soc/amd/mendocino/root_complex.c @@ -118,7 +118,7 @@ { uint32_t mem_usable = (uintptr_t)cbmem_top(); unsigned int idx = 0; - const struct hob_header *hob = fsp_get_hob_list(); + const struct hob_header *hob_iterator; const struct hob_resource *res; struct resource *gnb_apic; @@ -163,19 +163,13 @@ gnb_apic->size = 0x00001000; gnb_apic->flags = IORESOURCE_MEM | IORESOURCE_ASSIGNED | IORESOURCE_FIXED; - if (!hob) { + if (fsp_hob_iterator_init(&hob_iterator) != CB_SUCCESS) { printk(BIOS_ERR, "%s incomplete because no HOB list was found\n", __func__); return; } - for (; hob->type != HOB_TYPE_END_OF_HOB_LIST; hob = fsp_next_hob(hob)) { - - if (hob->type != HOB_TYPE_RESOURCE_DESCRIPTOR) - continue; - - res = fsp_hob_header_to_resource(hob); - + while (fsp_hob_iterator_get_next_resource(&hob_iterator, &res) == CB_SUCCESS) { if (res->type == EFI_RESOURCE_SYSTEM_MEMORY && res->addr < mem_usable) continue; /* 0 through low usable was set above */ if (res->type == EFI_RESOURCE_MEMORY_MAPPED_IO) diff --git a/src/soc/amd/morgana/root_complex.c b/src/soc/amd/morgana/root_complex.c index 0e6e730..10e5415 100644 --- a/src/soc/amd/morgana/root_complex.c +++ b/src/soc/amd/morgana/root_complex.c @@ -118,7 +118,7 @@ { uint32_t mem_usable = (uintptr_t)cbmem_top(); unsigned int idx = 0; - const struct hob_header *hob = fsp_get_hob_list(); + const struct hob_header *hob_iterator; const struct hob_resource *res; struct resource *gnb_apic; @@ -163,19 +163,13 @@ gnb_apic->size = 0x00001000; gnb_apic->flags = IORESOURCE_MEM | IORESOURCE_ASSIGNED | IORESOURCE_FIXED; - if (!hob) { + if (fsp_hob_iterator_init(&hob_iterator) != CB_SUCCESS) { printk(BIOS_ERR, "%s incomplete because no HOB list was found\n", __func__); return; } - for (; hob->type != HOB_TYPE_END_OF_HOB_LIST; hob = fsp_next_hob(hob)) { - - if (hob->type != HOB_TYPE_RESOURCE_DESCRIPTOR) - continue; - - res = fsp_hob_header_to_resource(hob); - + while (fsp_hob_iterator_get_next_resource(&hob_iterator, &res) == CB_SUCCESS) { if (res->type == EFI_RESOURCE_SYSTEM_MEMORY && res->addr < mem_usable) continue; /* 0 through low usable was set above */ if (res->type == EFI_RESOURCE_MEMORY_MAPPED_IO) diff --git a/src/soc/amd/picasso/root_complex.c b/src/soc/amd/picasso/root_complex.c index 4892023..c662320 100644 --- a/src/soc/amd/picasso/root_complex.c +++ b/src/soc/amd/picasso/root_complex.c @@ -103,7 +103,7 @@ { uint32_t mem_usable = (uintptr_t)cbmem_top(); unsigned int idx = 0; - const struct hob_header *hob = fsp_get_hob_list(); + const struct hob_header *hob_iterator; const struct hob_resource *res; struct resource *gnb_apic; @@ -146,19 +146,12 @@ gnb_apic->size = 0x00001000; gnb_apic->flags = IORESOURCE_MEM | IORESOURCE_ASSIGNED | IORESOURCE_FIXED; - if (!hob) { - printk(BIOS_ERR, "%s incomplete because no HOB list was found\n", - __func__); + if (fsp_hob_iterator_init(&hob_iterator) != CB_SUCCESS) { + printk(BIOS_ERR, "%s incomplete because no HOB list was found\n", __func__); return; } - for (; hob->type != HOB_TYPE_END_OF_HOB_LIST; hob = fsp_next_hob(hob)) { - - if (hob->type != HOB_TYPE_RESOURCE_DESCRIPTOR) - continue; - - res = fsp_hob_header_to_resource(hob); - + while (fsp_hob_iterator_get_next_resource(&hob_iterator, &res) == CB_SUCCESS) { if (res->type == EFI_RESOURCE_SYSTEM_MEMORY && res->addr < mem_usable) continue; /* 0 through low usable was set above */ if (res->type == EFI_RESOURCE_MEMORY_MAPPED_IO) -- To view, visit https://review.coreboot.org/c/coreboot/+/69476 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67ca346345c1fa08b008caa885d0a00d2d5afb12 Gerrit-Change-Number: 69476 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: drivers/intel/fsp2_0/hand_off_block: add functions to iterate over HOBs
by Felix Held (Code Review) 12 Nov '22

12 Nov '22

Attention is currently required from: Andrey Petrov. Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69475 ) Change subject: drivers/intel/fsp2_0/hand_off_block: add functions to iterate over HOBs ...................................................................... drivers/intel/fsp2_0/hand_off_block: add functions to iterate over HOBs Introduce iterator function to go through the HOBs that will be used in follow-up commits both from the rest of the common FSP HOB access code and from SoC-specific code that needs to access specific HOBs. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: If86dde2a9f41d0ca7941493a92f11b91a77e2ae0 --- M src/drivers/intel/fsp2_0/hand_off_block.c M src/drivers/intel/fsp2_0/include/fsp/util.h 2 files changed, 95 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/69475/1 diff --git a/src/drivers/intel/fsp2_0/hand_off_block.c b/src/drivers/intel/fsp2_0/hand_off_block.c index 21ce03e..13fbb06 100644 --- a/src/drivers/intel/fsp2_0/hand_off_block.c +++ b/src/drivers/intel/fsp2_0/hand_off_block.c @@ -126,6 +126,70 @@ return &fsp_hob_list_ptr; } +enum cb_err fsp_hob_iterator_init(const struct hob_header **hob_iterator) +{ + *hob_iterator = fsp_get_hob_list(); + return *hob_iterator ? CB_SUCCESS : CB_ERR; +} + +static enum cb_err fsp_hob_iterator_get_next(const struct hob_header **hob_iterator, + uint16_t hob_type, + const struct hob_header **hob) +{ + const struct hob_header *current_hob; + while ((*hob_iterator)->type != HOB_TYPE_END_OF_HOB_LIST) { + current_hob = *hob_iterator; + *hob_iterator = fsp_next_hob(*hob_iterator); + if (current_hob->type == hob_type) { + *hob = current_hob; + return CB_SUCCESS; + } + } + return CB_ERR; +} + +enum cb_err fsp_hob_iterator_get_next_resource(const struct hob_header **hob_iterator, + const struct hob_resource **res) +{ + const struct hob_header *hob; + while (fsp_hob_iterator_get_next(hob_iterator, HOB_TYPE_RESOURCE_DESCRIPTOR, &hob) == CB_SUCCESS) { + *res = fsp_hob_header_to_resource(hob); + return CB_SUCCESS; + } + return CB_ERR; +} + +enum cb_err fsp_hob_iterator_get_next_guid_resource(const struct hob_header **hob_iterator, + const uint8_t guid[16], + const struct hob_resource **res) +{ + const struct hob_resource *res_hob; + while (fsp_hob_iterator_get_next_resource(hob_iterator, &res_hob) == CB_SUCCESS) { + if (fsp_guid_compare(res_hob->owner_guid, guid)) { + *res = res_hob; + return CB_SUCCESS; + } + } + return CB_ERR; +} + +enum cb_err fsp_hob_iterator_get_next_guid_extension(const struct hob_header **hob_iterator, + const uint8_t guid[16], + const void **data, size_t *size) +{ + const struct hob_header *hob; + const uint8_t *guid_hob; + while (fsp_hob_iterator_get_next(hob_iterator, HOB_TYPE_GUID_EXTENSION, &hob) == CB_SUCCESS) { + guid_hob = hob_header_to_struct(hob); + if (fsp_guid_compare(guid_hob, guid)) { + *size = hob->length - (HOB_HEADER_LEN + 16); + *data = hob_header_to_extension_hob(hob); + return CB_SUCCESS; + } + } + return CB_ERR; +} + static const struct hob_resource *find_resource_hob_by_guid(const struct hob_header *hob, const uint8_t guid[16]) diff --git a/src/drivers/intel/fsp2_0/include/fsp/util.h b/src/drivers/intel/fsp2_0/include/fsp/util.h index 1cc422e..566fad9 100644 --- a/src/drivers/intel/fsp2_0/include/fsp/util.h +++ b/src/drivers/intel/fsp2_0/include/fsp/util.h @@ -106,6 +106,23 @@ extern const uint8_t fsp_nv_storage_guid[16]; extern const uint8_t fsp_reserved_memory_guid[16]; +/* + * Functions to iterate over the HOBs and get resource structs or extension HOB data. It's + * required to initialize the hob_iterator struct by a fsp_hob_iterator_init call before + * passing the fsp_hob_iterator_get_next_* functions. The fsp_hob_iterator_get_next_* functions + * will update the hob_iterator to point to the next HOB header, so the iterators can be called + * multiple times to get the data from multiple HOB instances. + */ +enum cb_err fsp_hob_iterator_init(const struct hob_header **hob_iterator); +enum cb_err fsp_hob_iterator_get_next_resource(const struct hob_header **hob_iterator, + const struct hob_resource **res); +enum cb_err fsp_hob_iterator_get_next_guid_resource(const struct hob_header **hob_iterator, + const uint8_t guid[16], + const struct hob_resource **res); +enum cb_err fsp_hob_iterator_get_next_guid_extension(const struct hob_header **hob_iterator, + const uint8_t guid[16], + const void **data, size_t *size); + /* Function to extract the FSP timestamp from FPDT Hob and display */ void fsp_display_timestamp(void); const void *fsp_get_hob_list(void); -- To view, visit https://review.coreboot.org/c/coreboot/+/69475 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If86dde2a9f41d0ca7941493a92f11b91a77e2ae0 Gerrit-Change-Number: 69475 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: mb/clevo/l140cu: make use of the new clevo/it5570e ec driver
by 9elements QA (Code Review) 12 Nov '22

12 Nov '22

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68795 ) Change subject: mb/clevo/l140cu: make use of the new clevo/it5570e ec driver ...................................................................... Patch Set 16: Automatic boot test returned (PASS/FAIL/TOTAL): 14 / 2 / 16 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES_ and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/136079 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/136078 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/136077 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/136076 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload TianoCore : https://lava.9esec.io/r/136075 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/136074 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload TianoCore : https://lava.9esec.io/r/136073 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/136072 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload TianoCore : https://lava.9esec.io/r/136071 FAIL: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload SeaBIOS : https://lava.9esec.io/r/136070 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload TianoCore : https://lava.9esec.io/r/136069 FAIL: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload SeaBIOS : https://lava.9esec.io/r/136068 PASS: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/136067 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/136066 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/136065 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/136064 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/68795 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I28ac401ada2945bb58fe862895458b10fed505fe Gerrit-Change-Number: 68795 Gerrit-PatchSet: 16 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Sat, 12 Nov 2022 00:24:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/starlabs/*: Bind UART debug to EDK2_DEBUG
by Angel Pons (Code Review) 12 Nov '22

12 Nov '22

Attention is currently required from: Sean Rhodes, Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69322 ) Change subject: mb/starlabs/*: Bind UART debug to EDK2_DEBUG ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: > Not that I know of, but the way you've written that suggests there is? You could keep the debug UART configured, but disable UART logging. -- To view, visit https://review.coreboot.org/c/coreboot/+/69322 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I54e1dc5768fd765254c7ede91eaa45842fed3bd6 Gerrit-Change-Number: 69322 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 12 Nov 2022 00:01:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/starlabs/starbook: Add Alder Lake StarBook Mk VI variant
by Angel Pons (Code Review) 12 Nov '22

12 Nov '22

Attention is currently required from: Sean Rhodes, Paul Menzel, Tim Wawrzynczak, Ben McMillen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65785 ) Change subject: mb/starlabs/starbook: Add Alder Lake StarBook Mk VI variant ...................................................................... Patch Set 26: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/65785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc0c265a88b19cf9e89cc8ab3e8db9abd8cf8409 Gerrit-Change-Number: 65785 Gerrit-PatchSet: 26 Gerrit-Owner: Ben McMillen <ben(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Ben McMillen <ben(a)starlabs.systems> Gerrit-Comment-Date: Fri, 11 Nov 2022 23:59:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022