Attention is currently required from: Jonathan Zhang, Johnny Lin, Christian Walter, Arthur Heymans, Tim Chu.
Hello Jonathan Zhang, Johnny Lin, Christian Walter, Arthur Heymans, Tim Chu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69500
to look at the new patch set (#3).
Change subject: src/soc/intel/xeon_sp/ras/hest.c: fix HEST table length
......................................................................
src/soc/intel/xeon_sp/ras/hest.c: fix HEST table length
`current' is the very beginning of table, so `next' - `current' is the
total length of the table. header->length is not zero but initialized
with the length of header.
Change-Id: I4780785bac782aa966def3f042f365a1ead9d9d8
Signed-off-by: Li Jinfeng <lijinfeng01(a)inspur.com>
---
M src/soc/intel/xeon_sp/ras/hest.c
1 file changed, 15 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/69500/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/69500
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4780785bac782aa966def3f042f365a1ead9d9d8
Gerrit-Change-Number: 69500
Gerrit-PatchSet: 3
Gerrit-Owner: Li Jinfeng <lijinfeng01(a)inspur.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jonathan Zhang, Johnny Lin, Christian Walter, Arthur Heymans, Tim Chu.
Hello Jonathan Zhang, Johnny Lin, Christian Walter, Arthur Heymans, Tim Chu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69500
to look at the new patch set (#2).
Change subject: src/soc/intel/xeon_sp/ras/hest.c: fix HEST table length
......................................................................
src/soc/intel/xeon_sp/ras/hest.c: fix HEST table length
`current' is the very begining of table, so `next' - `current' is the
total legnth of the table. header->length is not zero but initialized
with the length of header.
Change-Id: I4780785bac782aa966def3f042f365a1ead9d9d8
Signed-off-by: Li Jinfeng <lijinfeng01(a)inspur.com>
---
M src/soc/intel/xeon_sp/ras/hest.c
1 file changed, 15 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/69500/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/69500
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4780785bac782aa966def3f042f365a1ead9d9d8
Gerrit-Change-Number: 69500
Gerrit-PatchSet: 2
Gerrit-Owner: Li Jinfeng <lijinfeng01(a)inspur.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jonathan Zhang, Johnny Lin, Christian Walter, Arthur Heymans, Tim Chu.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69500 )
Change subject: src/soc/intel/xeon_sp/ras/hest.c: fix HEST table length
......................................................................
Patch Set 1:
(4 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163370):
https://review.coreboot.org/c/coreboot/+/69500/comment/106f9114_b3a90510
PS1, Line 8:
Possible unwrapped commit description (prefer a maximum 72 chars per line)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163370):
https://review.coreboot.org/c/coreboot/+/69500/comment/684d91d3_1254f1e8
PS1, Line 8:
'begining' may be misspelled - perhaps 'beginning'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163370):
https://review.coreboot.org/c/coreboot/+/69500/comment/54495d7a_356c296c
PS1, Line 9: `current' is the very begining of table, so `next' - `current' is the total
Possible unwrapped commit description (prefer a maximum 72 chars per line)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163370):
https://review.coreboot.org/c/coreboot/+/69500/comment/dea1d41c_5a102a39
PS1, Line 9: `current' is the very begining of table, so `next' - `current' is the total
'legnth' may be misspelled - perhaps 'length'?
--
To view, visit https://review.coreboot.org/c/coreboot/+/69500
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4780785bac782aa966def3f042f365a1ead9d9d8
Gerrit-Change-Number: 69500
Gerrit-PatchSet: 1
Gerrit-Owner: Li Jinfeng <lijinfeng01(a)inspur.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Sat, 12 Nov 2022 03:43:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Li Jinfeng has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69500 )
Change subject: src/soc/intel/xeon_sp/ras/hest.c: fix HEST table length
......................................................................
src/soc/intel/xeon_sp/ras/hest.c: fix HEST table length
`current' is the very begining of table, so `next' - `current' is the total
legnth of the table. header->length is not zero but initialized with the length
of header.
Change-Id: I4780785bac782aa966def3f042f365a1ead9d9d8
Signed-off-by: Li Jinfeng <lijinfeng01(a)inspur.com>
---
M src/soc/intel/xeon_sp/ras/hest.c
1 file changed, 15 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/69500/1
diff --git a/src/soc/intel/xeon_sp/ras/hest.c b/src/soc/intel/xeon_sp/ras/hest.c
index 9eb54d9..2da720a 100644
--- a/src/soc/intel/xeon_sp/ras/hest.c
+++ b/src/soc/intel/xeon_sp/ras/hest.c
@@ -65,7 +65,7 @@
next = hest + 1;
next += acpi_hest_add_ghes(next);
hest->error_source_count += 1;
- header->length += next - current;
+ header->length = next - current;
return header->length;
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/69500
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4780785bac782aa966def3f042f365a1ead9d9d8
Gerrit-Change-Number: 69500
Gerrit-PatchSet: 1
Gerrit-Owner: Li Jinfeng <lijinfeng01(a)inspur.com>
Gerrit-MessageType: newchange
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69425 )
(
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: mb/google/brya/var/gladios: Include GL9763E driver for eMMC support
......................................................................
mb/google/brya/var/gladios: Include GL9763E driver for eMMC support
Support GL9763E as a eMMC boot disk.
BUG=b:239513596
TEST=emerge-brask coreboot
Signed-off-by: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Change-Id: I2b29309615df381f1e24f29fc048c6f9bf216b7f
Reviewed-on: https://review.coreboot.org/c/coreboot/+/69425
Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M src/mainboard/google/brya/Kconfig.name
1 file changed, 19 insertions(+), 0 deletions(-)
Approvals:
build bot (Jenkins): Verified
Eric Lai: Looks good to me, approved
diff --git a/src/mainboard/google/brya/Kconfig.name b/src/mainboard/google/brya/Kconfig.name
index 2d11e10..8716211 100644
--- a/src/mainboard/google/brya/Kconfig.name
+++ b/src/mainboard/google/brya/Kconfig.name
@@ -299,6 +299,7 @@
bool "-> Gladios"
select BOARD_GOOGLE_BASEBOARD_BRASK
select SOC_INTEL_RAPTORLAKE
+ select DRIVERS_GENESYSLOGIC_GL9763E
config BOARD_GOOGLE_MARASOV
bool "-> Marasov"
--
To view, visit https://review.coreboot.org/c/coreboot/+/69425
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b29309615df381f1e24f29fc048c6f9bf216b7f
Gerrit-Change-Number: 69425
Gerrit-PatchSet: 4
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Elyes Haouas.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68376 )
Change subject: util/amdfwtool/amdfwtool: Don't rewrite macros
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/68376
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iea9dc65584c751e4d02524582b744ec9732e2c04
Gerrit-Change-Number: 68376
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sat, 12 Nov 2022 03:29:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Subrata Banik, Andrey Petrov.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69499 )
Change subject: driver/intel/fsp2_0/hand_off_block: rework fsp_display_fvi_version_hob
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
i don't expect any breakage from this, but might be good to verify that this on an intel soc that calls this function; the amd socs don't use it
--
To view, visit https://review.coreboot.org/c/coreboot/+/69499
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3398043dbdb3fc618277cefdd349b2c935bbfa52
Gerrit-Change-Number: 69499
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Comment-Date: Sat, 12 Nov 2022 03:05:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment