Attention is currently required from: Ravi Mistry.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69320 )
Change subject: mb/hp/memphis-s: Add HP Memphis-S (IPM87-MP)
......................................................................
Patch Set 7:
(1 comment)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163444):
https://review.coreboot.org/c/coreboot/+/69320/comment/6bf1888e_8e49bbde
PS7, Line 11: Specs:
Possible unwrapped commit description (prefer a maximum 72 chars per line)
--
To view, visit https://review.coreboot.org/c/coreboot/+/69320
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If3162fa4c60374877d9e67e9e1f6121743f03b21
Gerrit-Change-Number: 69320
Gerrit-PatchSet: 7
Gerrit-Owner: Ravi Mistry
Gerrit-Reviewer: Ravi Mistry
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Ravi Mistry
Gerrit-Comment-Date: Sat, 12 Nov 2022 21:02:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Ravi Mistry.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69320
to look at the new patch set (#7).
Change subject: mb/hp/memphis-s: Add HP Memphis-S (IPM87-MP)
......................................................................
mb/hp/memphis-s: Add HP Memphis-S (IPM87-MP)
This is a µATX mainboard with an LGA1150 socket and two DDR3 DIMM slots.
Specs:
- HP Memphis-S (IPM87-MP)
- Intel H87
- Macronix MX25L6473E (8MB)
- Fintek F71808A
- Realtek RTL8111 compatible Gigabit
Tested with EDK2 payload to boot Fedora Linux 36.
Working:
- PCIE slots (including MINI_CARD1)
- USB 2.0, 3.0
- Both DIMM slots
- SATA (except mSATA)
- Ethernet
- VGA, DVI (libgfxinit and VBT)
- S0/S3/S5
- Audio
- Hardware monitor
Untested:
- mSATA
- HOOD_SENSE
- MINI_LED header
- EHCI debug port, LPC debug
- CMOS
Change-Id: If3162fa4c60374877d9e67e9e1f6121743f03b21
Signed-off-by: Ravi Mistry <rvstry(a)protonmail.com>
---
A src/mainboard/hp/memphis-s/Kconfig
A src/mainboard/hp/memphis-s/Kconfig.name
A src/mainboard/hp/memphis-s/Makefile.inc
A src/mainboard/hp/memphis-s/acpi/ec.asl
A src/mainboard/hp/memphis-s/acpi/platform.asl
A src/mainboard/hp/memphis-s/acpi/superio.asl
A src/mainboard/hp/memphis-s/board_info.txt
A src/mainboard/hp/memphis-s/bootblock.c
A src/mainboard/hp/memphis-s/cmos.default
A src/mainboard/hp/memphis-s/cmos.layout
A src/mainboard/hp/memphis-s/data.vbt
A src/mainboard/hp/memphis-s/devicetree.cb
A src/mainboard/hp/memphis-s/dsdt.asl
A src/mainboard/hp/memphis-s/gma-mainboard.ads
A src/mainboard/hp/memphis-s/gpio.c
A src/mainboard/hp/memphis-s/hda_verb.c
A src/mainboard/hp/memphis-s/romstage.c
17 files changed, 649 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/69320/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/69320
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If3162fa4c60374877d9e67e9e1f6121743f03b21
Gerrit-Change-Number: 69320
Gerrit-PatchSet: 7
Gerrit-Owner: Ravi Mistry
Gerrit-Reviewer: Ravi Mistry
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Ravi Mistry
Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Ben McMillen, Elyes Haouas.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65785 )
Change subject: mb/starlabs/starbook: Add Alder Lake StarBook Mk VI variant
......................................................................
Patch Set 26:
(1 comment)
File src/mainboard/starlabs/starbook/variants/adl/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/65785/comment/c1cacfc2_753d2d81
PS26, Line 71: u32
> <stdint. […]
`uint32_t` preferred?
--
To view, visit https://review.coreboot.org/c/coreboot/+/65785
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc0c265a88b19cf9e89cc8ab3e8db9abd8cf8409
Gerrit-Change-Number: 65785
Gerrit-PatchSet: 26
Gerrit-Owner: Ben McMillen <ben(a)starlabs.systems>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-CC: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Ben McMillen <ben(a)starlabs.systems>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sat, 12 Nov 2022 20:29:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: comment
Attention is currently required from: Marc Jones, Jonathan Zhang, Johnny Lin, Paul Menzel, Angel Pons, Johnny Li, Shuming Chu (Shuming), Tim Chu.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68784 )
Change subject: drivers/ocp: add VPD processing framework
......................................................................
Patch Set 3:
(1 comment)
File src/drivers/ocp/vpd/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/68784/comment/49318354_01c5af65
PS2, Line 3: smm-$(C
> Arthur, didn't you have some patches to allow passing runtime-configurable settings to the SMI handler?
No but CB:49460 achieves just that.
--
To view, visit https://review.coreboot.org/c/coreboot/+/68784
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I705bea348b1611f25ccbd798b77cfee22ec30f0f
Gerrit-Change-Number: 68784
Gerrit-PatchSet: 3
Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com>
Gerrit-Reviewer: Johnny Li <johnny_li(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Johnny Li <johnny_li(a)wistron.corp-partner.google.com>
Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Sat, 12 Nov 2022 20:17:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang <jonzhang(a)fb.com>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Matt DeVillier, Fred Reitberger.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63727 )
Change subject: soc/amd/picasso: Add support for 64bit builds
......................................................................
Patch Set 8:
(1 comment)
File src/soc/amd/picasso/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/63727/comment/39d86c45_df6e8b0b
PS8, Line 146: ifeq ($(CONFIG_ARCH_BOOTBLOCK_X86_64),y)
: PSP_BIOSBIN_SIZE=$(shell $(READELF_bootblock) -l $(PSP_ELF_FILE) | grep -A1 LOAD | tr -d '\n' | awk '{print $$5}')
: else
: PSP_BIOSBIN_SIZE=$(shell $(READELF_bootblock) -l $(PSP_ELF_FILE) | grep LOAD | awk '{print $$5}')
: endif
> If you pass the wide option to readelf (-lW instead of -l), it will still be on a single line for the grep/awk commands. Should work for both 32-bit and 64-bit cases.
Thanks. Nice suggestion.
--
To view, visit https://review.coreboot.org/c/coreboot/+/63727
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icd72c4eef7805aacba6378632cbac7de9527673b
Gerrit-Change-Number: 63727
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Comment-Date: Sat, 12 Nov 2022 20:14:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Matt DeVillier, Arthur Heymans.
Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Marshall Dawson, Matt DeVillier, Fred Reitberger, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/63727
to look at the new patch set (#9).
Change subject: soc/amd/picasso: Add support for 64bit builds
......................................................................
soc/amd/picasso: Add support for 64bit builds
Tested on google/vilboz (running the PCI rom with yabel).
Change-Id: Icd72c4eef7805aacba6378632cbac7de9527673b
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/soc/amd/common/block/cpu/noncar/pre_c.S
M src/soc/amd/picasso/Kconfig
M src/soc/amd/picasso/Makefile.inc
3 files changed, 26 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/63727/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/63727
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icd72c4eef7805aacba6378632cbac7de9527673b
Gerrit-Change-Number: 63727
Gerrit-PatchSet: 9
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Kyösti Mälkki.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68893 )
Change subject: [WIP]cpu/mp_init: Detect the number of CPUs are runtime
......................................................................
Patch Set 14:
(2 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163441):
https://review.coreboot.org/c/coreboot/+/68893/comment/7beb3006_bd7ffb8c
PS14, Line 8:
Possible repeated word: 'are'
File src/cpu/x86/mp_init.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163441):
https://review.coreboot.org/c/coreboot/+/68893/comment/43e6cc4c_dd95414e
PS14, Line 494: if (!cpu->enabled) {
braces {} are not necessary for any arm of this statement
--
To view, visit https://review.coreboot.org/c/coreboot/+/68893
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iafe9d3d4838dad46cd0c7b6d30b905cbd258f17f
Gerrit-Change-Number: 68893
Gerrit-PatchSet: 14
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Comment-Date: Sat, 12 Nov 2022 20:03:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64802 )
Change subject: cpu/smm_module_loader.c: Fix up CPU index locally
......................................................................
Patch Set 16:
(1 comment)
File src/cpu/x86/smm/smm_module_loader.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163435):
https://review.coreboot.org/c/coreboot/+/64802/comment/23615e12_64944ed9
PS16, Line 275: printk(BIOS_ERR, "%s: Failed to find BSP struct device\n", __func__);
code indent should use tabs where possible
--
To view, visit https://review.coreboot.org/c/coreboot/+/64802
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I070bc00ae5e5bceb6c5b90ea833cc057dd41f6cc
Gerrit-Change-Number: 64802
Gerrit-PatchSet: 16
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Sat, 12 Nov 2022 20:01:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Kyösti Mälkki.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68893 )
Change subject: [WIP]cpu/mp_init: Detect the number of CPUs are runtime
......................................................................
Patch Set 13:
(2 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163430):
https://review.coreboot.org/c/coreboot/+/68893/comment/475b52bf_d5db1b4a
PS13, Line 8:
Possible repeated word: 'are'
File src/cpu/x86/mp_init.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163430):
https://review.coreboot.org/c/coreboot/+/68893/comment/e373cd5d_4ce5f9e0
PS13, Line 494: if (!cpu->enabled) {
braces {} are not necessary for any arm of this statement
--
To view, visit https://review.coreboot.org/c/coreboot/+/68893
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iafe9d3d4838dad46cd0c7b6d30b905cbd258f17f
Gerrit-Change-Number: 68893
Gerrit-PatchSet: 13
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Comment-Date: Sat, 12 Nov 2022 20:00:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment