Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37807 )
Change subject: util/lint: Provide some exemption to common parts of a vendor's MB
......................................................................
util/lint: Provide some exemption to common parts of a vendor's MB
Adding common definitions for a vendor's mainboard(eg. CB:37705) requires
creating dummy board_info.txt and Kconfig.name files due to lint checks.
Update the lint scripts to provide exemption to common definitions for a
vendor's mainboard.
BUG=None
TEST=Ensure that no lint errors are observed when common definitions are
added for a vendor's mainboard.
Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com>
Change-Id: I55c3474c17eacd008fee5f4089da33d4f7d6002a
---
M util/lint/lint-stable-005-board-status
M util/lint/lint-stable-006-board-name
2 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/37807/1
diff --git a/util/lint/lint-stable-005-board-status b/util/lint/lint-stable-005-board-status
index 952a9b5..e8313f2 100755
--- a/util/lint/lint-stable-005-board-status
+++ b/util/lint/lint-stable-005-board-status
@@ -17,6 +17,10 @@
LC_ALL=C export LC_ALL
for mobodir in $(git ls-files src/mainboard | sed -n 's,^\(src/mainboard/[^/]*/[^/]*\)/.*$,\1,p'|sort|uniq); do
+ if [[ ${mobodir} =~ ^src\/mainboard\/.*\/common$ ]]; then
+ continue
+ fi
+
board_info="$mobodir/board_info.txt"
if ! [ -f "$board_info" ]; then
echo "No $board_info found"
diff --git a/util/lint/lint-stable-006-board-name b/util/lint/lint-stable-006-board-name
index b2418a1..cf3b0e2 100755
--- a/util/lint/lint-stable-006-board-name
+++ b/util/lint/lint-stable-006-board-name
@@ -29,6 +29,9 @@
done
for i in src/mainboard/*/*/; do
+ if [[ ${i} =~ ^src\/mainboard\/.*\/common\/$ ]]; then
+ continue
+ fi
if [ -r $i/Kconfig ]; then
if [ ! -r $i/Kconfig.name ]; then
BOARD="$(grep -A2 MAINBOARD_PART_NUMBER $i/Kconfig | tail -1 | cut -f2 -d\")"
--
To view, visit https://review.coreboot.org/c/coreboot/+/37807
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I55c3474c17eacd008fee5f4089da33d4f7d6002a
Gerrit-Change-Number: 37807
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newchange
Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48512 )
Change subject: mb/google/volteer: Clean up romstage.c
......................................................................
mb/google/volteer: Clean up romstage.c
Move the manual calls to fw_config_probe() into the devicetree; the
AUDIO probe is trivial, and the TCSS devices (DMA0, iTBT RP0 & RP1) are
already guarded with probe statements in the baseboard devicetree, so
the code in romstage.c was redundant.
Change-Id: I1d067ff3d181b152c784634ff99202bb2b9202f7
Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
---
M src/mainboard/google/volteer/romstage.c
M src/mainboard/google/volteer/variants/baseboard/devicetree.cb
2 files changed, 7 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/48512/1
diff --git a/src/mainboard/google/volteer/romstage.c b/src/mainboard/google/volteer/romstage.c
index 315ec20..67d3489 100644
--- a/src/mainboard/google/volteer/romstage.c
+++ b/src/mainboard/google/volteer/romstage.c
@@ -22,17 +22,5 @@
};
bool half_populated = gpio_get(GPIO_MEM_CH_SEL);
- /* Disable HDA device if no audio board is present. */
- if (fw_config_probe(FW_CONFIG(AUDIO, NONE)))
- mem_cfg->PchHdaEnable = 0;
-
meminit_ddr(mem_cfg, board_cfg, &spd_info, half_populated);
-
- /* Disable TBT if no USB4 hardware */
- if (!(fw_config_probe(FW_CONFIG(DB_USB, USB4_GEN2)) ||
- fw_config_probe(FW_CONFIG(DB_USB, USB4_GEN3)))) {
- mem_cfg->TcssDma0En = 0;
- mem_cfg->TcssItbtPcie0En = 0;
- mem_cfg->TcssItbtPcie1En = 0;
- }
}
diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb
index 7964885..c61b003 100644
--- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb
@@ -501,6 +501,12 @@
device pnp 0c09.0 on end
end
end
- device ref hda on end
+ device ref hda on
+ probe AUDIO MAX98357_ALC5682I_I2S
+ probe AUDIO MAX98373_ALC5682I_I2S
+ probe AUDIO MAX98373_ALC5682_SNDW
+ probe AUDIO MAX98373_ALC5682I_I2S_UP4
+ probe AUDIO MAX98360_ALC5682I_I2S
+ end
end
end
--
To view, visit https://review.coreboot.org/c/coreboot/+/48512
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1d067ff3d181b152c784634ff99202bb2b9202f7
Gerrit-Change-Number: 48512
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: newchange
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70162 )
Change subject: mb/google/herobrine: Only retrieve sku_id from EC once
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/herobrine/boardid.c:
https://review.coreboot.org/c/coreboot/+/70162/comment/dbef7480_57c1dc78
PS2, Line 28: printk(BIOS_INFO, "BoardID :%d - "
> Also, I put in an early exit like in sku_id because I figured that it wouldn't be useful setting up […]
The compiler should be smart enough to move that array setup into the if-block to avoid extra cycles in the case where it's already cached. But no harm in making it more explicit.
--
To view, visit https://review.coreboot.org/c/coreboot/+/70162
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia787968100baf58a41ccce0cf95ed3ec9ce1758a
Gerrit-Change-Number: 70162
Gerrit-PatchSet: 4
Gerrit-Owner: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Doug Anderson <dianders(a)chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Sudheer Amrabadi <samrabad(a)codeaurora.org>
Gerrit-CC: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com>
Gerrit-CC: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Comment-Date: Wed, 30 Nov 2022 23:27:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen <shchen(a)google.com>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
Julius Werner has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70157 )
Change subject: vboot: Force config file inclusion with CBFS integration
......................................................................
vboot: Force config file inclusion with CBFS integration
CONFIG_VBOOT_CBFS_INTEGRATION images are signed differently than normal
images. futility needs to be able to tell this difference, and it parses
the `config` file included in CBFS to do this. This change codifies that
dependency in Kconfig so that nobody can accidentally break this by
turning off config file inclusion.
Signed-off-by: Julius Werner <jwerner(a)chromium.org>
Change-Id: I2b2d245b850bc65abb4e72f20b4e360312c828f7
---
M src/security/vboot/Kconfig
1 file changed, 17 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/70157/1
diff --git a/src/security/vboot/Kconfig b/src/security/vboot/Kconfig
index 93e1845..9025979 100644
--- a/src/security/vboot/Kconfig
+++ b/src/security/vboot/Kconfig
@@ -40,6 +40,7 @@
default n
depends on VBOOT_SLOTS_RW_A
depends on CBFS_VERIFICATION
+ select INCLUDE_CONFIG_FILE # futility needs this to auto-detect signing type
help
Say yes here to enable cryptographic verification of RW slots CBFS
metadata. This will replace body hash verification.
--
To view, visit https://review.coreboot.org/c/coreboot/+/70157
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b2d245b850bc65abb4e72f20b4e360312c828f7
Gerrit-Change-Number: 70157
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: newchange