Attention is currently required from: Werner Zeh, Jan Samek.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69543 )
Change subject: drivers/i2c/rv3028c7: Add ACPI generation callbacks
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69543/comment/08ed192a_d522e421
PS3, Line 9: Added
Present tense: Add
https://review.coreboot.org/c/coreboot/+/69543/comment/445d79cf_33e37794
PS3, Line 12: added
Ditto.
https://review.coreboot.org/c/coreboot/+/69543/comment/946577e7_832025e3
PS3, Line 19: HID (a proper kernel patch
: is pending).
HID. (A proper kernel patch
is pending.)
--
To view, visit https://review.coreboot.org/c/coreboot/+/69543
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b8cf5c8dc551439755992ff05b6693e91cc3f21
Gerrit-Change-Number: 69543
Gerrit-PatchSet: 3
Gerrit-Owner: Jan Samek <jan.samek(a)siemens.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Johannes Hahn <johannes-hahn(a)siemens.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Uwe Poeche <uwe.poeche(a)siemens.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Jan Samek <jan.samek(a)siemens.com>
Gerrit-Comment-Date: Wed, 16 Nov 2022 13:39:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Werner Zeh, Jan Samek.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69544 )
Change subject: mb/siemens/mc_ehl2/devicetree.cb: Use RV3028 bus_speed instead of dummy i2c device
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69544/comment/1e553543_5ba06a7a
PS4, Line 19: Linux
Please document the used Linux kernel version.
--
To view, visit https://review.coreboot.org/c/coreboot/+/69544
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e269dc67d1fe2a6747fcf3bee224def7b553f08
Gerrit-Change-Number: 69544
Gerrit-PatchSet: 4
Gerrit-Owner: Jan Samek <jan.samek(a)siemens.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Uwe Poeche <uwe.poeche(a)siemens.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Jan Samek <jan.samek(a)siemens.com>
Gerrit-Comment-Date: Wed, 16 Nov 2022 13:38:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Werner Zeh.
Jan Samek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69543 )
Change subject: drivers/i2c/rv3028c7: Add ACPI generation callbacks
......................................................................
Patch Set 3:
(1 comment)
File src/drivers/i2c/rv3028c7/rv3028c7.c:
https://review.coreboot.org/c/coreboot/+/69543/comment/f4218138_ba7b5b12
PS2, Line 199: dev_path(dev)
> OK, agreed.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/69543
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b8cf5c8dc551439755992ff05b6693e91cc3f21
Gerrit-Change-Number: 69543
Gerrit-PatchSet: 3
Gerrit-Owner: Jan Samek <jan.samek(a)siemens.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Johannes Hahn <johannes-hahn(a)siemens.com>
Gerrit-CC: Uwe Poeche <uwe.poeche(a)siemens.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Wed, 16 Nov 2022 13:36:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com>
Comment-In-Reply-To: Jan Samek <jan.samek(a)siemens.com>
Gerrit-MessageType: comment
Attention is currently required from: Werner Zeh.
Hello build bot (Jenkins), Mario Scheithauer, Werner Zeh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69543
to look at the new patch set (#3).
Change subject: drivers/i2c/rv3028c7: Add ACPI generation callbacks
......................................................................
drivers/i2c/rv3028c7: Add ACPI generation callbacks
Added ACPI generation callback to the driver after obtaining the
ACPI HID "MCRY3028" for this device from Microcrystal AG (VID: "MCRY").
Also added I2C bus speed field to the device config structure, which
is a required ACPI entry.
BUG=none
TEST=Disassemble the SSDT table and see whether the device entry
"MC28" is generated correctly. Also check whether the RV3028 driver
in Linux (drivers/rtc/rtc-rv-3028.c) is bound correctly after adding
an ACPI match table to it containing the HID (a proper kernel patch
is pending).
Change-Id: I3b8cf5c8dc551439755992ff05b6693e91cc3f21
Signed-off-by: Jan Samek <jan.samek(a)siemens.com>
---
M src/drivers/i2c/rv3028c7/chip.h
M src/drivers/i2c/rv3028c7/rv3028c7.c
M src/drivers/i2c/rv3028c7/rv3028c7.h
3 files changed, 90 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/69543/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/69543
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b8cf5c8dc551439755992ff05b6693e91cc3f21
Gerrit-Change-Number: 69543
Gerrit-PatchSet: 3
Gerrit-Owner: Jan Samek <jan.samek(a)siemens.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Johannes Hahn <johannes-hahn(a)siemens.com>
Gerrit-CC: Uwe Poeche <uwe.poeche(a)siemens.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Werner Zeh.
Jan Samek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69543 )
Change subject: drivers/i2c/rv3028c7: Add ACPI generation callbacks
......................................................................
Patch Set 2:
(1 comment)
File src/drivers/i2c/rv3028c7/rv3028c7.c:
https://review.coreboot.org/c/coreboot/+/69543/comment/56c2ae2b_4d28fd77
PS2, Line 199: dev_path(dev)
> What about synchronizing the message format with the other logs and use #dev->chip_ops->name' instea […]
OK, agreed.
--
To view, visit https://review.coreboot.org/c/coreboot/+/69543
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b8cf5c8dc551439755992ff05b6693e91cc3f21
Gerrit-Change-Number: 69543
Gerrit-PatchSet: 2
Gerrit-Owner: Jan Samek <jan.samek(a)siemens.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Johannes Hahn <johannes-hahn(a)siemens.com>
Gerrit-CC: Uwe Poeche <uwe.poeche(a)siemens.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Wed, 16 Nov 2022 13:32:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68929 )
Change subject: crossgcc: Upgrade IASL from 20220331 to 20221020
......................................................................
Patch Set 10:
(1 comment)
Patchset:
PS10:
I think, it needs https://review.coreboot.org/c/coreboot/+/69662 to build
--
To view, visit https://review.coreboot.org/c/coreboot/+/68929
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I386a6757a318336bc616091afe0c4ed88cd89583
Gerrit-Change-Number: 68929
Gerrit-PatchSet: 10
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Wed, 16 Nov 2022 13:16:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69699 )
Change subject: Update arm-trusted-firmware submodule to upstream master
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163772):
https://review.coreboot.org/c/coreboot/+/69699/comment/96deb835_96a791d8
PS1, Line 9: Updating from commit id 61fe7826d:
Possible unwrapped commit description (prefer a maximum 72 chars per line)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163772):
https://review.coreboot.org/c/coreboot/+/69699/comment/62ff52da_1df673e2
PS1, Line 12: to commit id fbcbd88eb:
Possible unwrapped commit description (prefer a maximum 72 chars per line)
--
To view, visit https://review.coreboot.org/c/coreboot/+/69699
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I795607cda36588ef26f955b1d1e832a4ae2de749
Gerrit-Change-Number: 69699
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 16 Nov 2022 13:05:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Kyösti Mälkki.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69677 )
Change subject: intel/haswell,lynxpoint: Fix out() parameter order
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
Thanks!
I've spotted one more in `src/soc/intel/broadwell/pch/pmutil.c`. But that seems
to be really dead code. Or was it added to transition to `nb/intel/haswell/`?
--
To view, visit https://review.coreboot.org/c/coreboot/+/69677
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife134ef6d508113e3cd27b6352ee5044aee43744
Gerrit-Change-Number: 69677
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Comment-Date: Wed, 16 Nov 2022 13:03:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment