coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[S] Change in coreboot[master]: mb/google/rex: Enable PD Sync
by Subrata Banik (Code Review) 10 Oct '22

10 Oct '22

Attention is currently required from: Eran Mitrani, Ivy Jian, Eric Lai. Hello build bot (Jenkins), Tarun Tuli, Eran Mitrani, Kapil Porwal, Ivy Jian, Eric Lai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67819 to look at the new patch set (#3). Change subject: mb/google/rex: Enable PD Sync ...................................................................... mb/google/rex: Enable PD Sync This patch enables PD Sync for Rex. BUG=b:248775521 TEST=Able to boot Google/Rex with PD sync enabled. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: I749b5dea481c7546579e97f923f143dd17f831d3 --- M src/mainboard/google/rex/Kconfig 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/67819/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/67819 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I749b5dea481c7546579e97f923f143dd17f831d3 Gerrit-Change-Number: 67819 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/ehl: Fix incorrect access to MAC_MDIO_DATA register
by Werner Zeh (Code Review) 10 Oct '22

10 Oct '22

Attention is currently required from: Mario Scheithauer, Lean Sheng Tan. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68214 ) Change subject: soc/intel/ehl: Fix incorrect access to MAC_MDIO_DATA register ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/68214/comment/f9b3a276_7cbbd568 PS2, Line 9: Function 'setbits16' clears the data register first > setbits16 actually performs an 'OR' operation with the new data and the origin register entry. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/68214 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0212420be770e2ffdabebbfaf5dfbf8d99d25915 Gerrit-Change-Number: 68214 Gerrit-PatchSet: 3 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Mon, 10 Oct 2022 09:47:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: soc/amd/morgana: Add initial commit for new SoC
by Nico Huber (Code Review) 10 Oct '22

10 Oct '22

Attention is currently required from: Martin L Roth, Martin Roth. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68195 ) Change subject: soc/amd/morgana: Add initial commit for new SoC ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/68195/comment/63dcda92_7f1a207b PS2, Line 12: commonization. Did you add TODOs for every file or did you check already which files might need to be changed? To keep track of the compatibility of common code, it would be nice to also add TODOs for the respective Kconfig selects, like it was done in CB:61077. -- To view, visit https://review.coreboot.org/c/coreboot/+/68195 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If92e129db10d41595e1dc18a7c1dfe99d57790cc Gerrit-Change-Number: 68195 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Mon, 10 Oct 2022 09:44:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/dedede/var/beadrix: Update SoC gpio pin of USB camera
by Ivan Chen (Code Review) 10 Oct '22

10 Oct '22

Attention is currently required from: Henry Sun, Simon Yang, Teddy Shih. Ivan Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68129 ) Change subject: mb/google/dedede/var/beadrix: Update SoC gpio pin of USB camera ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/68129 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id00cb85cdad900c03842ad69707966aa62410efd Gerrit-Change-Number: 68129 Gerrit-PatchSet: 2 Gerrit-Owner: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com> Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.com> Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Super Ni <super.ni(a)intel.corp-partner.google.com> Gerrit-Reviewer: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eddy Lu <eddylu(a)ami.corp-partner.google.com> Gerrit-CC: Jack Cheng <jack.cheng(a)ecs.corp-partner.google.com> Gerrit-CC: Raymond Chung <raymondchung(a)ami.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.corp-partner.google.com> Gerrit-Attention: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Comment-Date: Mon, 10 Oct 2022 09:35:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/ocp/deltalake: Clean up includes
by Elyes Haouas (Code Review) 10 Oct '22

10 Oct '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68254 ) Change subject: mb/ocp/deltalake: Clean up includes ...................................................................... mb/ocp/deltalake: Clean up includes Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: If68ce4fef69a2466e76fc7fc504c00ee915e3e36 --- M src/mainboard/ocp/deltalake/ipmi.c M src/mainboard/ocp/deltalake/ipmi.h M src/mainboard/ocp/deltalake/ramstage.c 3 files changed, 26 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/68254/1 diff --git a/src/mainboard/ocp/deltalake/ipmi.c b/src/mainboard/ocp/deltalake/ipmi.c index d990b87..1e553c0 100644 --- a/src/mainboard/ocp/deltalake/ipmi.c +++ b/src/mainboard/ocp/deltalake/ipmi.c @@ -5,6 +5,7 @@ #include <drivers/ipmi/ipmi_ops.h> #include <drivers/ipmi/ocp/ipmi_ocp.h> #include <drivers/vpd/vpd.h> +#include <types.h> #include "ipmi.h" #include "vpd.h" diff --git a/src/mainboard/ocp/deltalake/ipmi.h b/src/mainboard/ocp/deltalake/ipmi.h index 269fc03..0b33ca4 100644 --- a/src/mainboard/ocp/deltalake/ipmi.h +++ b/src/mainboard/ocp/deltalake/ipmi.h @@ -3,7 +3,7 @@ #ifndef DELTALAKE_IPMI_H #define DELTALAKE_IPMI_H -#include <stdint.h> +#include <types.h> #define IPMI_OEM_GET_PCIE_CONFIG 0xf4 #define IPMI_OEM_GET_BOARD_ID 0x37 diff --git a/src/mainboard/ocp/deltalake/ramstage.c b/src/mainboard/ocp/deltalake/ramstage.c index 8d762dc..fb81e10 100644 --- a/src/mainboard/ocp/deltalake/ramstage.c +++ b/src/mainboard/ocp/deltalake/ramstage.c @@ -1,22 +1,26 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <assert.h> +#include <commonlib/bsd/helpers.h> #include <console/console.h> +#include <cpu/cpu.h> +#include <cpxsp_dl_gpio.h> +#include <device/device.h> +#include <device/pci_def.h> +#include <device/pci_ops.h> #include <drivers/ipmi/ipmi_ops.h> #include <drivers/ocp/dmi/ocp_dmi.h> #include <drivers/vpd/vpd.h> -#include <security/intel/txt/txt.h> -#include <soc/ramstage.h> -#include <soc/soc_util.h> -#include <stdio.h> -#include <string.h> -#include <smbios.h> -#include <device/pci_def.h> -#include <device/pci_ops.h> -#include <soc/util.h> #include <hob_iiouds.h> #include <hob_memmap.h> -#include <cpxsp_dl_gpio.h> +#include <security/intel/txt/txt.h> +#include <smbios.h> +#include <soc/ramstage.h> +#include <soc/soc_util.h> +#include <soc/util.h> +#include <stdio.h> +#include <string.h> +#include <types.h> #include "ipmi.h" #include "vpd.h" -- To view, visit https://review.coreboot.org/c/coreboot/+/68254 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If68ce4fef69a2466e76fc7fc504c00ee915e3e36 Gerrit-Change-Number: 68254 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: soc/intel/ehl: Fix incorrect access to MAC_MDIO_DATA register
by Mario Scheithauer (Code Review) 10 Oct '22

10 Oct '22

Attention is currently required from: Mario Scheithauer, Lean Sheng Tan. Hello build bot (Jenkins), Lean Sheng Tan, Werner Zeh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68214 to look at the new patch set (#3). Change subject: soc/intel/ehl: Fix incorrect access to MAC_MDIO_DATA register ...................................................................... soc/intel/ehl: Fix incorrect access to MAC_MDIO_DATA register Function 'setbits16' performs an 'OR' operation with the new data and the origin register entry. This can lead to an incorrect value in the register which can then lead to issues. Change-Id: I0212420be770e2ffdabebbfaf5dfbf8d99d25915 Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com> --- M src/soc/intel/elkhartlake/tsn_gbe.c 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/68214/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/68214 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0212420be770e2ffdabebbfaf5dfbf8d99d25915 Gerrit-Change-Number: 68214 Gerrit-PatchSet: 3 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: util/superiotool/nuvoton.c: Add NCT6687D-W register definitions
by Krystian Hebel (Code Review) 10 Oct '22

10 Oct '22

Attention is currently required from: Michał Żygowski, Felix Held. Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63868 ) Change subject: util/superiotool/nuvoton.c: Add NCT6687D-W register definitions ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I38db1de0f3d3b6de14bcb758afc9804c072c1895 Gerrit-Change-Number: 63868 Gerrit-PatchSet: 6 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 10 Oct 2022 09:18:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: configs/config.msi_ms7d25: Enable CBFS serial and UUID as default
by Krystian Hebel (Code Review) 10 Oct '22

10 Oct '22

Attention is currently required from: Michał Żygowski, Michał Kopeć. Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64640 ) Change subject: configs/config.msi_ms7d25: Enable CBFS serial and UUID as default ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/64640 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic8af889f12617d4ab6a27c6f336276c04f26244c Gerrit-Change-Number: 64640 Gerrit-PatchSet: 9 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Comment-Date: Mon, 10 Oct 2022 09:18:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: drivers/generic/cbfs-uuid: Add driver to include UUID from CBFS
by Krystian Hebel (Code Review) 10 Oct '22

10 Oct '22

Attention is currently required from: Michał Żygowski, Paul Menzel, Angel Pons. Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64639 ) Change subject: drivers/generic/cbfs-uuid: Add driver to include UUID from CBFS ...................................................................... Patch Set 11: (3 comments) File src/drivers/generic/cbfs-uuid/cbfs-uuid.c: https://review.coreboot.org/c/coreboot/+/64639/comment/1fb0d68f_d9e24e5d PS9, Line 11: char uuid_str[UUID_STRLEN + 1] = {0}; > Done, please check. Done File src/drivers/generic/cbfs-uuid/cbfs-uuid.c: https://review.coreboot.org/c/coreboot/+/64639/comment/472758b2_9eef42cf PS10, Line 18: obsolete > Done Done File src/drivers/generic/cbfs-uuid/cbfs-uuid.c: https://review.coreboot.org/c/coreboot/+/64639/comment/49fa7e4b_50ee6305 PS11, Line 11: /* Add 3 more bytes (2 for possible CRLF) and third for NULL char */ Parentheses seems misplaced, how about `Add 3 more bytes: 2 for possible CRLF and third for NULL char` I know, I'm nit-picking 😊 -- To view, visit https://review.coreboot.org/c/coreboot/+/64639 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22f22f4e8742716283d2fcaba4894c06cef3a4bf Gerrit-Change-Number: 64639 Gerrit-PatchSet: 11 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 10 Oct 2022 09:16:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/prodrive/atlas: Print HSID
by Angel Pons (Code Review) 10 Oct '22

10 Oct '22

Attention is currently required from: Christian Walter, Maximilian Brune, Lean Sheng Tan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68224 ) Change subject: mb/prodrive/atlas: Print HSID ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File src/mainboard/prodrive/atlas/gpio.c: https://review.coreboot.org/c/coreboot/+/68224/comment/da851fe3_a13c2dae PS1, Line 10: PAD_CFG_GPI(GPP_A8, NONE, RSMRST), /* HSID_0 */ > I just saw they were already configured in early gpios... […] Ah, probably because *a certain someone* told Sheng to do so 😄 -- To view, visit https://review.coreboot.org/c/coreboot/+/68224 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibb7aac1204bc297d16797cac5b32b119d0a9204b Gerrit-Change-Number: 68224 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Mon, 10 Oct 2022 09:04:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022