coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[S] Change in coreboot[master]: mb/google/glados/var/lars: Set SKU ID based on VPD
by Matt DeVillier (Code Review) 24 Oct '22

24 Oct '22

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68754 ) Change subject: mb/google/glados/var/lars: Set SKU ID based on VPD ...................................................................... mb/google/glados/var/lars: Set SKU ID based on VPD LARS has two variants, LARS and LILI, which are differentiated via the customization_id field in the VPD. To make differentiation easier outside of ChromeOS (ie, for Windows/Linux drivers), set the SKU ID based on VPD so it can be easily read via SMBIOS. Modeled after similar code in google/reef (snappy variant). TEST=build/boot lili variant, verify sku1 populated in SMBIOS tables. Change-Id: I148462b6f86b25fa8db26ea6e1537d1a5e47984b Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/glados/variants/lars/variant.c 1 file changed, 44 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/68754/1 diff --git a/src/mainboard/google/glados/variants/lars/variant.c b/src/mainboard/google/glados/variants/lars/variant.c index a4e42b1..aead670 100644 --- a/src/mainboard/google/glados/variants/lars/variant.c +++ b/src/mainboard/google/glados/variants/lars/variant.c @@ -3,7 +3,9 @@ #include <stdint.h> #include <string.h> #include <baseboard/variant.h> +#include <drivers/vpd/vpd.h> #include <fsp/soc_binding.h> +#include <smbios.h> #define K4E6E304EB_MEM_ID 0x5 @@ -14,6 +16,9 @@ #define MEM_SINGLE_CHANB 0xb #define MEM_SINGLE_CHANC 0xc +#define VPD_KEY_CUSTOMIZATION_ID "customization_id" +#define VPD_CUSTOMIZATION_LEN 32 + void variant_memory_init_params(FSPM_UPD *mupd, const int spd_index) { FSP_M_CONFIG *mem_cfg; @@ -63,3 +68,23 @@ && spd_index != MEM_SINGLE_CHANB && spd_index != MEM_SINGLE_CHANC); } + +/* SKU ID enumeration */ +#define SKU_LARS "sku0" +#define SKU_LILI "sku1" + +const char *smbios_system_sku(void) +{ + if (!CONFIG(VPD)) + return SKU_LARS; + + static char customization_id[VPD_CUSTOMIZATION_LEN]; + if (!vpd_gets(VPD_KEY_CUSTOMIZATION_ID, customization_id, + VPD_CUSTOMIZATION_LEN, VPD_RO)) + return SKU_LARS; + + if (strstr(customization_id, "LILI")) + return SKU_LILI; + + return SKU_LARS; +} -- To view, visit https://review.coreboot.org/c/coreboot/+/68754 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I148462b6f86b25fa8db26ea6e1537d1a5e47984b Gerrit-Change-Number: 68754 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/google/reef: Fix guarding of reading SKU from VPD
by Matt DeVillier (Code Review) 24 Oct '22

24 Oct '22

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68753 ) Change subject: mb/google/reef: Fix guarding of reading SKU from VPD ...................................................................... mb/google/reef: Fix guarding of reading SKU from VPD VPD read depends on CONFIG(VPD), not CONFIG(CHROMEOS). TEST=build/boot snappy, verify SKU set properly in SMBIOS Change-Id: I8aa57f793bd04dbe31f3b49bbff23e05c96592a6 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/reef/variants/snappy/mainboard.c 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/68753/1 diff --git a/src/mainboard/google/reef/variants/snappy/mainboard.c b/src/mainboard/google/reef/variants/snappy/mainboard.c index fc0652c..0b15505 100644 --- a/src/mainboard/google/reef/variants/snappy/mainboard.c +++ b/src/mainboard/google/reef/variants/snappy/mainboard.c @@ -43,7 +43,7 @@ board_sku_num = sku_strapping_value(); - if (!CONFIG(CHROMEOS)) + if (!CONFIG(VPD)) return board_sku_num; if (!vpd_gets(vpd_skuid, vpd_buffer, ARRAY_SIZE(vpd_buffer), VPD_RO_THEN_RW)) -- To view, visit https://review.coreboot.org/c/coreboot/+/68753 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8aa57f793bd04dbe31f3b49bbff23e05c96592a6 Gerrit-Change-Number: 68753 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: arch/x86: x86_64 implies SSE2 support
by Patrick Rudolph (Code Review) 24 Oct '22

24 Oct '22

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44869 ) Change subject: arch/x86: x86_64 implies SSE2 support ...................................................................... arch/x86: x86_64 implies SSE2 support Enable SSE2 when compiling for x86_64. Tested on qemu. Change-Id: I3cdc584c97016e15513df663a54a7bdb549a73e4 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/arch/x86/Kconfig M src/arch/x86/bootblock_crt0.S 2 files changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/44869/1 diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig index d906436..d0e4693 100644 --- a/src/arch/x86/Kconfig +++ b/src/arch/x86/Kconfig @@ -33,22 +33,27 @@ config ARCH_BOOTBLOCK_X86_64 bool select ARCH_X86 + select SSE2 config ARCH_VERSTAGE_X86_64 bool select ARCH_X86 + select SSE2 config ARCH_ROMSTAGE_X86_64 bool select ARCH_X86 + select SSE2 config ARCH_POSTCAR_X86_64 bool default ARCH_ROMSTAGE_X86_64 && POSTCAR_STAGE + select SSE2 config ARCH_RAMSTAGE_X86_64 bool select ARCH_X86 + select SSE2 if ARCH_X86 diff --git a/src/arch/x86/bootblock_crt0.S b/src/arch/x86/bootblock_crt0.S index 9f45413..9e17b7e 100644 --- a/src/arch/x86/bootblock_crt0.S +++ b/src/arch/x86/bootblock_crt0.S @@ -52,9 +52,15 @@ #if CONFIG(SSE) enable_sse: +#if ENV_X86_32 mov %cr4, %eax or $CR4_OSFXSR, %ax mov %eax, %cr4 +#else + mov %cr4, %rax + or $CR4_OSFXSR, %ax + mov %rax, %cr4 +#endif #endif /* CONFIG(SSE) */ /* We're done. Now it's up to platform-specific code */ -- To view, visit https://review.coreboot.org/c/coreboot/+/44869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3cdc584c97016e15513df663a54a7bdb549a73e4 Gerrit-Change-Number: 44869 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: newchange

5 9

[S] Change in coreboot[master]: payloads/edk2: Add the declaration for OBJCOPY
by Lean Sheng Tan (Code Review) 24 Oct '22

24 Oct '22

Attention is currently required from: Sean Rhodes, Martin L Roth, Matt DeVillier, Stefan Reinauer. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68744 ) Change subject: payloads/edk2: Add the declaration for OBJCOPY ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68744 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2e04dfe18df6252261836dcdf98f7e8de65287b5 Gerrit-Change-Number: 68744 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Mon, 24 Oct 2022 13:54:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: 3rdparty/vboot: Upgrade submodule to latest version
by Jakub Czapiga (Code Review) 24 Oct '22

24 Oct '22

Jakub Czapiga has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/68540 ) Change subject: 3rdparty/vboot: Upgrade submodule to latest version ...................................................................... 3rdparty/vboot: Upgrade submodule to latest version Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com> Change-Id: I9a16d6e02cee34140ec375ed6166f47560459140 --- M 3rdparty/vboot 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/68540/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68540 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9a16d6e02cee34140ec375ed6166f47560459140 Gerrit-Change-Number: 68540 Gerrit-PatchSet: 2 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: lib/coreboot_table: Simplify API to set up lb_serial
by build bot (Jenkins) (Code Review) 24 Oct '22

24 Oct '22

Attention is currently required from: Hung-Te Lin, Julius Werner, ron minnich. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68768 ) Change subject: lib/coreboot_table: Simplify API to set up lb_serial ...................................................................... Patch Set 3: (1 comment) File src/lib/coreboot_table.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161159): https://review.coreboot.org/c/coreboot/+/68768/comment/4a2c57b5_68bf4601 PS3, Line 114: lb_add_console(LB_TAG_CONSOLE_SERIAL8250MEM, header);; Statements terminations use 1 semicolon -- To view, visit https://review.coreboot.org/c/coreboot/+/68768 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6c08a88fb5fc035eb28d0becf19471c709c8043d Gerrit-Change-Number: 68768 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Mon, 24 Oct 2022 13:18:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: lib/coreboot_table: Simplify API to set up lb_serial
by Arthur Heymans (Code Review) 24 Oct '22

24 Oct '22

Attention is currently required from: Hung-Te Lin, Julius Werner, ron minnich. Hello Hung-Te Lin, Julius Werner, ron minnich, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68768 to look at the new patch set (#3). Change subject: lib/coreboot_table: Simplify API to set up lb_serial ...................................................................... lib/coreboot_table: Simplify API to set up lb_serial Instead of having callbacks into serial console code to set up the coreboot table have the code provide the struct as a return value. This makes it easier to reuse the information as the return value can be used in a different context (e.g. when filling in a FDT). This also removes boilerplate code to set up lb_console entries by setting entry based on the type in struct lb_uart. Change-Id: I6c08a88fb5fc035eb28d0becf19471c709c8043d Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/drivers/uart/pl011.c M src/drivers/uart/sifive.c M src/drivers/uart/uart8250io.c M src/drivers/uart/uart8250mem.c M src/include/boot/coreboot_tables.h M src/lib/coreboot_table.c M src/mainboard/emulation/qemu-power8/uart.c M src/soc/mediatek/common/uart.c M src/soc/nvidia/tegra124/uart.c M src/soc/nvidia/tegra210/uart.c M src/soc/qualcomm/common/qupv3_uart.c M src/soc/qualcomm/common/uart_bitbang.c M src/soc/qualcomm/ipq40xx/uart.c M src/soc/qualcomm/ipq806x/uart.c M src/soc/qualcomm/qcs405/uart.c M src/soc/samsung/exynos5250/uart.c M src/soc/samsung/exynos5420/uart.c M src/soc/ti/am335x/uart.c 18 files changed, 67 insertions(+), 53 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/68768/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/68768 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6c08a88fb5fc035eb28d0becf19471c709c8043d Gerrit-Change-Number: 68768 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: MAINTAINERS: Add Matt DeVillier to the release team
by Felix Held (Code Review) 24 Oct '22

24 Oct '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68704 ) Change subject: MAINTAINERS: Add Matt DeVillier to the release team ...................................................................... MAINTAINERS: Add Matt DeVillier to the release team Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I6f5c10618edb87d2dc12c14187c4620d8675a443 Reviewed-on: https://review.coreboot.org/c/coreboot/+/68704 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> --- M MAINTAINERS 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved diff --git a/MAINTAINERS b/MAINTAINERS index dc4c3af..131aea6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -992,6 +992,7 @@ M: Jason Glenesk <jason.glenesk(a)gmail.com> M: Angel Pons <th3fanbus(a)gmail.com> M: Martin Roth <gaumless(a)gmail.com> +M: Matt DeVillier <MrChromebox(a)gmail.com> S: Maintained F: Documentation/releases/ F: util/release/ -- To view, visit https://review.coreboot.org/c/coreboot/+/68704 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6f5c10618edb87d2dc12c14187c4620d8675a443 Gerrit-Change-Number: 68704 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: lib/coreboot_table: Simplify API to set up lb_serial
by build bot (Jenkins) (Code Review) 24 Oct '22

24 Oct '22

Attention is currently required from: Hung-Te Lin, Julius Werner, ron minnich. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68768 ) Change subject: lib/coreboot_table: Simplify API to set up lb_serial ...................................................................... Patch Set 2: (1 comment) File src/lib/coreboot_table.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161158): https://review.coreboot.org/c/coreboot/+/68768/comment/f68bdd72_034d27d1 PS2, Line 114: lb_add_console(LB_TAG_CONSOLE_SERIAL8250MEM, header);; Statements terminations use 1 semicolon -- To view, visit https://review.coreboot.org/c/coreboot/+/68768 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6c08a88fb5fc035eb28d0becf19471c709c8043d Gerrit-Change-Number: 68768 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Mon, 24 Oct 2022 13:02:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Update arm-trusted-firmware submodule to upstream master
by Felix Held (Code Review) 24 Oct '22

24 Oct '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68651 ) Change subject: Update arm-trusted-firmware submodule to upstream master ...................................................................... Update arm-trusted-firmware submodule to upstream master Updating from commit id c45d2febb: 2022-10-12 15:56:24 +0200 - (Merge "fix(ufs): retry commands on unit attention" into integration) to commit id 61fe7826d: 2022-10-18 16:20:05 +0200 - (Merge "feat(fvp): build delegated attestation in BL31" into integration) This brings in 10 new commits: 61fe7826d Merge "feat(fvp): build delegated attestation in BL31" into integration cf17f7c45 Merge "chore(rpi3): remove redundant code" into integration 70360382b Merge "docs(maintainers): add NPU driver owners" into integration 60c439435 docs(maintainers): add NPU driver owners e504ce5fa Merge "fix(versal_net): Enable a78 errata workarounds" into integration bcc6e4a02 fix(versal_net): Enable a78 errata workarounds 0271eddb0 feat(fvp): build delegated attestation in BL31 6047ab122 Merge "fix(versal): enable a72 erratum 859971 and 1319367" into integration 769446a68 fix(versal): enable a72 erratum 859971 and 1319367 2594759d2 chore(rpi3): remove redundant code Change-Id: Ic32c0889961f529e1762b208ef118a94369c34e6 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/68651 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Julius Werner <jwerner(a)chromium.org> --- M 3rdparty/arm-trusted-firmware 1 file changed, 32 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved diff --git a/3rdparty/arm-trusted-firmware b/3rdparty/arm-trusted-firmware index c45d2fe..61fe782 160000 --- a/3rdparty/arm-trusted-firmware +++ b/3rdparty/arm-trusted-firmware @@ -1 +1 @@ -Subproject commit c45d2febb98058efa77d812b094bd1456a916c29 +Subproject commit 61fe7826d8ae41c906b2189136a1ae482f91f84a -- To view, visit https://review.coreboot.org/c/coreboot/+/68651 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic32c0889961f529e1762b208ef118a94369c34e6 Gerrit-Change-Number: 68651 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: merged

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022