Attention is currently required from: Johnny Lin, Angel Pons, Tim Chu.
Hello build bot (Jenkins), Johnny Lin, Angel Pons, Tim Chu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/68685
to look at the new patch set (#2).
Change subject: drivers/ipmi/ipmi_kcs_ops.c: accomodate BMC revision being 0
......................................................................
drivers/ipmi/ipmi_kcs_ops.c: accomodate BMC revision being 0
BMC major/minor revision may be 0. Get the value directly from
BMC without checking to accomodate such situation.
Signed-off-by: Tim Chu <Tim.Chu(a)quantatw.com>
Signed-off-by: Jonathan Zhang <jonzhang(a)meta.com>
Change-Id: I0e08c6d02de8f6efceb69b6d6cebad9d61cfd20e
---
M src/drivers/ipmi/ipmi_kcs_ops.c
1 file changed, 17 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/68685/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/68685
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e08c6d02de8f6efceb69b6d6cebad9d61cfd20e
Gerrit-Change-Number: 68685
Gerrit-PatchSet: 2
Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Maxim Polyakov.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/68673
to look at the new patch set (#3).
Change subject: util/intelp2m/fields: Add unit tests
......................................................................
util/intelp2m/fields: Add unit tests
Change-Id: I6330855b1c7463a3093b38c54e6cc06c3409009a
Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com>
---
A util/intelp2m/fields/cb/cb_test.go
A util/intelp2m/fields/fsp/fsp_test.go
A util/intelp2m/fields/raw/raw_test.go
A util/intelp2m/fields/test/suite.go
4 files changed, 204 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/68673/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/68673
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6330855b1c7463a3093b38c54e6cc06c3409009a
Gerrit-Change-Number: 68673
Gerrit-PatchSet: 3
Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Raul Rangel, Jason Nien, Martin Roth, Karthik Ramasubramanian.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67778 )
Change subject: mb/google/skyrim: Implement touchscreen power sequencing
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/skyrim/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/67778/comment/8db59771_7df2937e
PS3, Line 116: /* EN_PP3300_TCHSCR */
: PAD_GPO(GPIO_131, LOW),
: /* TCHSCR_RESET_L */
: PAD_GPO(GPIO_136, LOW),
> When all the touchscreen modules defined in devicetree could not be probed, we can put these GPIOs as NC?
I've thought about that, but not come up with a good idea on how to determine at runtime (which would be necessary for older/existing boards for which we can't backport using FW_CONFIG). My least-worst idea is to create a new i2c touchscreen device driver which contains one or more generic i2c or i2c-hid devices, and could keep track if any present / turn off the GPIOs if none found. But still seems suboptimal to me
--
To view, visit https://review.coreboot.org/c/coreboot/+/67778
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic4d7ac8f951bb94da2216a24dc85a96275c9d449
Gerrit-Change-Number: 67778
Gerrit-PatchSet: 4
Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-CC: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Mon, 24 Oct 2022 21:18:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org>
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Matt DeVillier, Angel Pons.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68754 )
Change subject: mb/google/glados/var/lars: Set SKU ID based on VPD
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/68754
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I148462b6f86b25fa8db26ea6e1537d1a5e47984b
Gerrit-Change-Number: 68754
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Mon, 24 Oct 2022 21:12:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Maxim Polyakov.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/67701
to look at the new patch set (#3).
Change subject: intelp2m/parset: Add unit test
......................................................................
intelp2m/parset: Add unit test
Also add an interface for printing macros to override this in the test
and not create a new gpio file for comparison.
Change-Id: I16c9b4451cd4418b49043a925cb879a982a56461
Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com>
---
M util/intelp2m/main.go
M util/intelp2m/parser/parser.go
A util/intelp2m/parser/parser_test.go
A util/intelp2m/parser/test/inteltool_test.log
4 files changed, 286 insertions(+), 110 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/67701/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/67701
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I16c9b4451cd4418b49043a925cb879a982a56461
Gerrit-Change-Number: 67701
Gerrit-PatchSet: 3
Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Raul Rangel, Jason Nien, Matt DeVillier, Martin Roth.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67778 )
Change subject: mb/google/skyrim: Implement touchscreen power sequencing
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/skyrim/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/67778/comment/ced03567_af0cf4ec
PS3, Line 116: /* EN_PP3300_TCHSCR */
: PAD_GPO(GPIO_131, LOW),
: /* TCHSCR_RESET_L */
: PAD_GPO(GPIO_136, LOW),
> Yeah, I think that sounds fine. I don't think on the AMD platforms we ever had a bit.
I think this definitely makes a good reason to have a FW_CONFIG bit to indicate the presence of touch screen.
An alternate is like Raul mentioned, we should assume that touch screen is present. When all the touchscreen modules defined in devicetree could not be probed, we can put these GPIOs as NC?
--
To view, visit https://review.coreboot.org/c/coreboot/+/67778
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic4d7ac8f951bb94da2216a24dc85a96275c9d449
Gerrit-Change-Number: 67778
Gerrit-PatchSet: 4
Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-CC: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 24 Oct 2022 20:59:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org>
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Sean Rhodes, Martin L Roth, Stefan Reinauer, Arthur Heymans.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68596 )
Change subject: payloads/edk2: Set the correct serial settings for AMD SOCs
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> > because you don't get serial output on Picasso (and forward) without it […]
I agree, but in the meantime this resolves the issue on Zen-based AMD platforms
--
To view, visit https://review.coreboot.org/c/coreboot/+/68596
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70630d21bbdb21f2aa8cbaeb3e842629b97af3ba
Gerrit-Change-Number: 68596
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Mon, 24 Oct 2022 20:05:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment