coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[XL] Change in coreboot[master]: ec/clevo/it5570e: add driver for EC used on various Clevo laptops
by Michael Niewöhner (Code Review) 25 Oct '22

25 Oct '22

Attention is currently required from: Michał Żygowski, Michał Kopeć. Hello build bot (Jenkins), Michał Żygowski, Michał Kopeć, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68791 to look at the new patch set (#3). Change subject: ec/clevo/it5570e: add driver for EC used on various Clevo laptops ...................................................................... ec/clevo/it5570e: add driver for EC used on various Clevo laptops This adds a driver for the ITE IT5570E EC in combination with Clevo vendor EC firmware. The interface is mostly identical on various laptop models. Thus, we have implemented one common driver to support them all. The following features were implemented: - Basics like battery, ac, etc. - Suspend/hibernate support: S0ix, S3*, S4/S5 - Save/restore of keyboard backlight level during S0ix without the need for Clevo vendor software (ControlCenter) - Flexicharger - Fn keys (backlight, volume, airplane etc.) - Various configuration options via Kconfig / CMOS options * Note: S3 support works at least on L140CU (Cometlake), but it's not enabled for this board because S0ix is used. Not implemented, yet: - Type-C UCSI: the EC firmware seems to be buggy (with vendor fw, too) - dGPU support is WIP An example of how this driver can be hooked up by a board can be seen in the follow-up patch, where support for the L140MU is added. Known issue with the touchpad toggle: The touchpad toggle (Fn-F1) has two modes, Ctrl-Alt-F9 mode and keycodes 0xf7/0xf8 mode. Ctrl-Alt-F9 is the native touchpad toggle shortcut on Windows. On Linux this would switch to virtual console 9, if enabled. Thus, one should use the keycodes mode and add udev rules as specified in https://docs.dasharo.com/variants/clevo_nv41/post_install/ . If VT9 is disabled, Ctrl-Alt-F9 mode could be used to set up a keyboard shortcut command toggling the touchpad. Testing the various functionalities of this EC driver was done in the changes hooking up this driver for the boards. Change-Id: Ic8c0bee9002ad9edcd10c83b775fc723744caaa0 Co-authored-by: Michał Kopeć <michal.kopec(a)3mdeb.com> Co-authored-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Co-authored-by: Michael Niewöhner <foss(a)mniewoehner.de> Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- A src/ec/clevo/it5570e/Kconfig A src/ec/clevo/it5570e/Makefile.inc A src/ec/clevo/it5570e/acpi/ac.asl A src/ec/clevo/it5570e/acpi/battery.asl A src/ec/clevo/it5570e/acpi/buttons.asl A src/ec/clevo/it5570e/acpi/common.asl A src/ec/clevo/it5570e/acpi/ec.asl A src/ec/clevo/it5570e/acpi/ec_queries.asl A src/ec/clevo/it5570e/acpi/ec_ram.asl A src/ec/clevo/it5570e/acpi/hid.asl A src/ec/clevo/it5570e/acpi/lid.asl A src/ec/clevo/it5570e/chip.h A src/ec/clevo/it5570e/commands.c A src/ec/clevo/it5570e/commands.h A src/ec/clevo/it5570e/early_init.c A src/ec/clevo/it5570e/early_init.h A src/ec/clevo/it5570e/ec.c A src/ec/clevo/it5570e/ec.h A src/ec/clevo/it5570e/i2ec.c A src/ec/clevo/it5570e/i2ec.h A src/ec/clevo/it5570e/smbios.c A src/ec/clevo/it5570e/smihandler.c A src/ec/clevo/it5570e/smm.h A src/ec/clevo/it5570e/ssdt.c 24 files changed, 2,063 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/68791/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/68791 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic8c0bee9002ad9edcd10c83b775fc723744caaa0 Gerrit-Change-Number: 68791 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/emulation/riscv: Limit DRAM size
by Christian Walter (Code Review) 25 Oct '22

25 Oct '22

Attention is currently required from: Philipp Hug, Arthur Heymans, ron minnich. Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68843 ) Change subject: mb/emulation/riscv: Limit DRAM size ...................................................................... Patch Set 1: (1 comment) File src/mainboard/emulation/qemu-riscv/Kconfig: https://review.coreboot.org/c/coreboot/+/68843/comment/60b6dcc0_e91db4ff PS1, Line 48: # To avoid confusing the dram probing algoritm, avoid large dram sizes (16G - 1m) > 'algoritm' may be misspelled - perhaps 'algorithm'? Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/68843 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib8555de361d1129d3d1995f056518c576f055515 Gerrit-Change-Number: 68843 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Tue, 25 Oct 2022 21:16:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: cpu/x86/mp_init: adjust timeout for 2nd SIPI
by Christian Walter (Code Review) 25 Oct '22

25 Oct '22

Attention is currently required from: Arthur Heymans, Jonathan Zhang, Angel Pons. Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68262 ) Change subject: cpu/x86/mp_init: adjust timeout for 2nd SIPI ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68262 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id958f18bdcb34d76df8aa443161123252524328e Gerrit-Change-Number: 68262 Gerrit-PatchSet: 7 Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 25 Oct 2022 21:14:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/amd/cezanne: Factor out common GPP clk req code
by Robert Zieba (Code Review) 25 Oct '22

25 Oct '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Karthik Ramasubramanian. Robert Zieba has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68138 ) Change subject: soc/amd/cezanne: Factor out common GPP clk req code ...................................................................... Patch Set 8: (1 comment) File src/soc/amd/common/block/pci/Kconfig: https://review.coreboot.org/c/coreboot/+/68138/comment/59a9108c_14620b24 PS6, Line 16: depends on SOC_AMD_COMMON_BLOCK_PCI > Can we `select SOC_AMD_COMMON_BLOCK_PCIE_CLK_REQ` here instead of in every single SOC Kconfig? Unfortunately not as is. Prior to Cezanne platform_descriptors.h doesn't define certain types needed for the clk req code so it'll fail to build. -- To view, visit https://review.coreboot.org/c/coreboot/+/68138 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9a4c72d8e980993c76a1b128f17b65b0db972a03 Gerrit-Change-Number: 68138 Gerrit-PatchSet: 8 Gerrit-Owner: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 25 Oct 2022 21:09:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: crota/overridetree.cb: Update ELAN's touchscreen delay to 150 ms (per...
by Paz Zcharya (Code Review) 25 Oct '22

25 Oct '22

Attention is currently required from: Paz Zcharya, Tim Wawrzynczak. Hello Eran Mitrani, Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68868 to look at the new patch set (#3). Change subject: crota/overridetree.cb: Update ELAN's touchscreen delay to 150 ms (per new uploaded datasheet in AVL) ...................................................................... crota/overridetree.cb: Update ELAN's touchscreen delay to 150 ms (per new uploaded datasheet in AVL) BUG=b:232893949 TEST=Manually checked touchscreen works after reboot and suspend (kernel v5.10) Signed-off-by: Paz Zcharya <pazz(a)google.com> Change-Id: I17e1f7d419637f6dff4049484ce1836ad98017ea --- M src/mainboard/google/brya/variants/crota/overridetree.cb 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/68868/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/68868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17e1f7d419637f6dff4049484ce1836ad98017ea Gerrit-Change-Number: 68868 Gerrit-PatchSet: 3 Gerrit-Owner: Paz Zcharya <pazz(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Paz Zcharya <pazz(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: crota/overridetree.cb: Update ELAN's touchscreen delay to 150 ms (per...
by Eran Mitrani (Code Review) 25 Oct '22

25 Oct '22

Attention is currently required from: Paz Zcharya, Tim Wawrzynczak. Eran Mitrani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68868 ) Change subject: crota/overridetree.cb: Update ELAN's touchscreen delay to 150 ms (per new uploaded datasheet in AVL) ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/68868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17e1f7d419637f6dff4049484ce1836ad98017ea Gerrit-Change-Number: 68868 Gerrit-PatchSet: 2 Gerrit-Owner: Paz Zcharya <pazz(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Paz Zcharya <pazz(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Comment-Date: Tue, 25 Oct 2022 20:59:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: cpu/x86/mp_init: adjust timeout for 2nd SIPI
by Jonathan Zhang (Code Review) 25 Oct '22

25 Oct '22

Jonathan Zhang has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/68786 ) Change subject: cpu/x86/mp_init: adjust timeout for 2nd SIPI ...................................................................... Abandoned this was a mistake. -- To view, visit https://review.coreboot.org/c/coreboot/+/68786 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I29f9aba1d0256b7b3458a78b0b8a8b4b294c4482 Gerrit-Change-Number: 68786 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: crota/overridetree.cb: Update ELAN's touchscreen delay to 150 ms (per...
by Paz Zcharya (Code Review) 25 Oct '22

25 Oct '22

Attention is currently required from: Tim Wawrzynczak. Hello Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68868 to look at the new patch set (#2). Change subject: crota/overridetree.cb: Update ELAN's touchscreen delay to 150 ms (per new uploaded datasheet in AVL) ...................................................................... crota/overridetree.cb: Update ELAN's touchscreen delay to 150 ms (per new uploaded datasheet in AVL) BUG=b:232893949 TEST=Manually checked touchscreen works after reboot and suspend Signed-off-by: Paz Zcharya <pazz(a)google.com> Change-Id: I17e1f7d419637f6dff4049484ce1836ad98017ea --- M src/mainboard/google/brya/variants/crota/overridetree.cb 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/68868/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17e1f7d419637f6dff4049484ce1836ad98017ea Gerrit-Change-Number: 68868 Gerrit-PatchSet: 2 Gerrit-Owner: Paz Zcharya <pazz(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: Update ELAN's touchscreen delay to 150 ms (per new uploaded datasheet...
by Paz Zcharya (Code Review) 25 Oct '22

25 Oct '22

Paz Zcharya has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68868 ) Change subject: Update ELAN's touchscreen delay to 150 ms (per new uploaded datasheet in AVL) ...................................................................... Update ELAN's touchscreen delay to 150 ms (per new uploaded datasheet in AVL) BUG=b:232893949 TEST=Manually checked touchscreen works after reboot and suspend Signed-off-by: Paz Zcharya <pazz(a)google.com> Change-Id: I17e1f7d419637f6dff4049484ce1836ad98017ea --- M src/mainboard/google/brya/variants/crota/overridetree.cb 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/68868/1 diff --git a/src/mainboard/google/brya/variants/crota/overridetree.cb b/src/mainboard/google/brya/variants/crota/overridetree.cb index 245d553..847cf6c 100644 --- a/src/mainboard/google/brya/variants/crota/overridetree.cb +++ b/src/mainboard/google/brya/variants/crota/overridetree.cb @@ -222,7 +222,7 @@ register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C1)" - register "generic.reset_delay_ms" = "300" + register "generic.reset_delay_ms" = "150" register "generic.reset_off_delay_ms" = "1" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)" -- To view, visit https://review.coreboot.org/c/coreboot/+/68868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17e1f7d419637f6dff4049484ce1836ad98017ea Gerrit-Change-Number: 68868 Gerrit-PatchSet: 1 Gerrit-Owner: Paz Zcharya <pazz(a)google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: cpu/x86/mp_init: adjust timeout for 2nd SIPI
by Jonathan Zhang (Code Review) 25 Oct '22

25 Oct '22

Attention is currently required from: Arthur Heymans, Christian Walter, Angel Pons. Hello Arthur Heymans, build bot (Jenkins), Marc Jones, Nico Huber, Christian Walter, Angel Pons, Arthur Heymans, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68262 to look at the new patch set (#7). Change subject: cpu/x86/mp_init: adjust timeout for 2nd SIPI ...................................................................... cpu/x86/mp_init: adjust timeout for 2nd SIPI Adjust timeout for 2nd SIPI to satisfy some to-be-launched server processors. Add a spew print to display how long it takes for the APs to be ready. This is intended to facilitate only troubleshooting and trend analysis. Change-Id: Id958f18bdcb34d76df8aa443161123252524328e Signed-off-by: Jonathan Zhang <jonzhang(a)meta.com> --- M src/cpu/x86/mp_init.c 1 file changed, 20 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/68262/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/68262 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id958f18bdcb34d76df8aa443161123252524328e Gerrit-Change-Number: 68262 Gerrit-PatchSet: 7 Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022