coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[S] Change in qc_blobs[master]: sc7280/qtiseclib: Update qtiseclib blobs binaries and release notes f...
by Bharath N (Code Review) 26 Oct '22

26 Oct '22

Bharath N has uploaded this change for review. ( https://review.coreboot.org/c/qc_blobs/+/68889 ) Change subject: sc7280/qtiseclib: Update qtiseclib blobs binaries and release notes from 63 to 69 ...................................................................... sc7280/qtiseclib: Update qtiseclib blobs binaries and release notes from 63 to 69 TEST=Validated on qualcomm sc7280 development board Signed-off-by: Bharath N <quic_bharn(a)quicinc.com> Change-Id: I3a3bf0f9c6861920e358021332af5f4f8bc7ca71 --- M sc7280/qtiseclib/Release_Notes.txt M sc7280/qtiseclib/libqtisec.a 2 files changed, 31 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/qc_blobs refs/changes/89/68889/1 diff --git a/sc7280/qtiseclib/Release_Notes.txt b/sc7280/qtiseclib/Release_Notes.txt index f491a04..3704a57 100644 --- a/sc7280/qtiseclib/Release_Notes.txt +++ b/sc7280/qtiseclib/Release_Notes.txt @@ -1,3 +1,22 @@ +=================== Release 00069 ================================ +This Release Notes file covers these blobs: + * libqtisec.a + +Version : 00069 + +Release Date : Oct 14, 2022 + +Supported Silicon : SC7280 + +Changes since last version : + * code optimization in sysini + * static analysis fixes + * NOC error scripts + +No special instructions, requirements or dependencies, files must be +present in this folder to be pulled in during coreboot build + +Errata : Nothing to report =================== Release 00063 ================================ This Release Notes file covers these blobs: * libqtisec.a diff --git a/sc7280/qtiseclib/libqtisec.a b/sc7280/qtiseclib/libqtisec.a index 28f623c..de54314 100644 --- a/sc7280/qtiseclib/libqtisec.a +++ b/sc7280/qtiseclib/libqtisec.a Binary files differ -- To view, visit https://review.coreboot.org/c/qc_blobs/+/68889 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: qc_blobs Gerrit-Branch: master Gerrit-Change-Id: I3a3bf0f9c6861920e358021332af5f4f8bc7ca71 Gerrit-Change-Number: 68889 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath N <quic_bharn(a)quicinc.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: mb/google/brask/var/lisbon: Update gpio table
by Kevin Chiu (Code Review) 26 Oct '22

26 Oct '22

Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Ricky Chang. Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68280 ) Change subject: mb/google/brask/var/lisbon: Update gpio table ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/68280 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I531f9ca9f6902d3318e99dadb58a811a4686a6e9 Gerrit-Change-Number: 68280 Gerrit-PatchSet: 3 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Ricky Chang <rickytlchang(a)google.com> Gerrit-Comment-Date: Wed, 26 Oct 2022 08:28:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: console: Add an SoC-specific post-code call
by 9elements QA (Code Review) 26 Oct '22

26 Oct '22

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68545 ) Change subject: console: Add an SoC-specific post-code call ...................................................................... Patch Set 5: Automatic boot test returned (PASS/FAIL/TOTAL): 15 / 1 / 16 FAIL: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES_ and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/130873 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/130872 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/130871 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/130870 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload TianoCore : https://lava.9esec.io/r/130869 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/130868 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload TianoCore : https://lava.9esec.io/r/130867 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/130866 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload TianoCore : https://lava.9esec.io/r/130865 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload SeaBIOS : https://lava.9esec.io/r/130864 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload TianoCore : https://lava.9esec.io/r/130863 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload SeaBIOS : https://lava.9esec.io/r/130862 PASS: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/130861 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/130860 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/130859 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/130858 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/68545 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0369e4362840d7506d301105d8e1e2fd865919f4 Gerrit-Change-Number: 68545 Gerrit-PatchSet: 5 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Wed, 26 Oct 2022 08:27:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/lisbon: Include driver for GL9763E for eMMC boot disk
by Kevin Chiu (Code Review) 26 Oct '22

26 Oct '22

Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68888 ) Change subject: mb/google/brya/var/lisbon: Include driver for GL9763E for eMMC boot disk ...................................................................... mb/google/brya/var/lisbon: Include driver for GL9763E for eMMC boot disk Support GL9763E as a eMMC boot disk BUG=b:246657849 TEST=FW_NAME=lisbon emerge-brask coreboot Signed-off-by: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Change-Id: Ibe579a913225b5241412bbb1b8ea995a5102a3bb --- M src/mainboard/google/brya/Kconfig.name 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/68888/1 diff --git a/src/mainboard/google/brya/Kconfig.name b/src/mainboard/google/brya/Kconfig.name index 9992eea..d7b26da 100644 --- a/src/mainboard/google/brya/Kconfig.name +++ b/src/mainboard/google/brya/Kconfig.name @@ -273,6 +273,7 @@ bool "-> Lisbon" select BOARD_GOOGLE_BASEBOARD_BRASK select DRIVERS_GENESYSLOGIC_GL9750 + select DRIVERS_GENESYSLOGIC_GL9763E config BOARD_GOOGLE_ZYDRON bool "-> Zydron" -- To view, visit https://review.coreboot.org/c/coreboot/+/68888 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe579a913225b5241412bbb1b8ea995a5102a3bb Gerrit-Change-Number: 68888 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: Revert "soc/intel/systemagent.c: Fix memory type reporting"
by Sean Rhodes (Code Review) 26 Oct '22

26 Oct '22

Attention is currently required from: Paul Menzel, Arthur Heymans, Jan Samek. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68879 ) Change subject: Revert "soc/intel/systemagent.c: Fix memory type reporting" ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/68879 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72da99c019241b627ce8b543937364a53a5fe97b Gerrit-Change-Number: 68879 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Jan Samek <jan.samek(a)siemens.com> Gerrit-Comment-Date: Wed, 26 Oct 2022 08:24:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/gaelin: Configure DRIVER_TPM_I2C_BUS
by Derek Huang (Code Review) 26 Oct '22

26 Oct '22

Attention is currently required from: Raymond Chung, Tim Wawrzynczak, Zhuohao Lee. Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68886 ) Change subject: mb/google/brya/gaelin: Configure DRIVER_TPM_I2C_BUS ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/68886 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idaac11111a9ba7df0929267567e4730b2811f5f0 Gerrit-Change-Number: 68886 Gerrit-PatchSet: 2 Gerrit-Owner: Raymond Chung <raymondchung(a)ami.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Raymond Chung <raymondchung(a)ami.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eason Chang <easonchang(a)msi.corp-partner.google.com> Gerrit-CC: Eddy Lu <eddylu(a)ami.corp-partner.google.com> Gerrit-CC: Tony Tung <tonytung(a)msi.corp-partner.google.com> Gerrit-Attention: Raymond Chung <raymondchung(a)ami.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Comment-Date: Wed, 26 Oct 2022 08:17:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/google/brya: Update devicetree setting for lisbon
by Kevin Chiu (Code Review) 26 Oct '22

26 Oct '22

Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Ricky Chang. Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68165 ) Change subject: mb/google/brya: Update devicetree setting for lisbon ...................................................................... Patch Set 4: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/68165 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4268a5b43690a22bb703337fed84b83c45da4ad2 Gerrit-Change-Number: 68165 Gerrit-PatchSet: 4 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Ricky Chang <rickytlchang(a)google.com> Gerrit-Comment-Date: Wed, 26 Oct 2022 08:17:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/lisbon: use i2c1 for TPM for lisbon
by Kevin Chiu (Code Review) 26 Oct '22

26 Oct '22

Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68887 ) Change subject: mb/google/brya/var/lisbon: use i2c1 for TPM for lisbon ...................................................................... mb/google/brya/var/lisbon: use i2c1 for TPM for lisbon This change sets DRIVER_TPM_I2C_BUS to the i2c 1 bus for TPM for the lisbon variant. BUG=b:246657849 TEST=FW_NAME=lisbon emerge-brask coreboot Signed-off-by: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Change-Id: I16be50258db2111d22f7465458873e92f44c7dac --- M src/mainboard/google/brya/Kconfig 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/68887/1 diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index 7b1b783..f54e96b 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -149,6 +149,7 @@ default 0x0 if BOARD_GOOGLE_XIVU default 0x0 if BOARD_GOOGLE_YAVIKS default 0x1 if BOARD_GOOGLE_ZYDRON + default 0x1 if BOARD_GOOGLE_LISBON config DRIVER_TPM_I2C_ADDR hex -- To view, visit https://review.coreboot.org/c/coreboot/+/68887 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I16be50258db2111d22f7465458873e92f44c7dac Gerrit-Change-Number: 68887 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: Revert "soc/intel/systemagent.c: Fix memory type reporting"
by Arthur Heymans (Code Review) 26 Oct '22

26 Oct '22

Attention is currently required from: Paul Menzel, Jan Samek. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68879 ) Change subject: Revert "soc/intel/systemagent.c: Fix memory type reporting" ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/68879/comment/1481f3f9_b51a07a7 PS1, Line 12: > Please mention that it hangs at > > [DEBUG] apm_control: Finalizing SMM. > > and at least some of the known affected systems: > > > mc_ehl2 and sporadic on mc_ehl1 > > prodrive/hermes too, but not APL? No it does not always hang there on other platforms. 'breaking the smihandler' is sufficiently specific to capture all problems. -- To view, visit https://review.coreboot.org/c/coreboot/+/68879 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72da99c019241b627ce8b543937364a53a5fe97b Gerrit-Change-Number: 68879 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jan Samek <jan.samek(a)siemens.com> Gerrit-Comment-Date: Wed, 26 Oct 2022 08:05:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: cpu/x86/mp_init.c: Generate a C header to get start32 offset
by Arthur Heymans (Code Review) 26 Oct '22

26 Oct '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/64625 to look at the new patch set (#7). Change subject: cpu/x86/mp_init.c: Generate a C header to get start32 offset ...................................................................... cpu/x86/mp_init.c: Generate a C header to get start32 offset In the current design the relocatable parameters are used to know the offset of the 32bit startpoint. This requires back and forward interaction between the stub, the loader and the mp init code. This makes the code hard to read. this is static information known at buildtime, so a better way to deal with this is to generate a header that contains this offset. Change-Id: Ic01badd2af11a6e1dbc27c8e928916fedf104b5b Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/x86/Makefile.inc M src/cpu/x86/mp_init.c M src/cpu/x86/smm/smm_module_loader.c M src/cpu/x86/smm/smm_stub.S A src/cpu/x86/smm_start32_offset.h.template M src/include/cpu/x86/smm.h 6 files changed, 45 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/64625/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/64625 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic01badd2af11a6e1dbc27c8e928916fedf104b5b Gerrit-Change-Number: 64625 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022