Attention is currently required from: Paul Menzel, Boris Mittelberg.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56840 )
Change subject: mb/google/dedede: allow MKBP devices
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56840/comment/375ebc95_cbe8fa01
PS2, Line 14: Cq-Depend:chromium:3069163
Nit: Move this into the last paragraph i.e. just above Signed-off-by: line.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56840
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d1f43e4dd56318af4c1d5f5c1c3a2c237a05c5f
Gerrit-Change-Number: 56840
Gerrit-PatchSet: 2
Gerrit-Owner: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Comment-Date: Fri, 06 Aug 2021 22:45:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Karthik Ramasubramanian.
Boris Mittelberg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56840 )
Change subject: mb/google/dedede: allow MKBP devices
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56840/comment/f7457cf2_40683621
PS1, Line 9: Enable MKBP interface for all dedede family to use for buttons and switches
> Please add a dot/period at the end of sentences.
Done
https://review.coreboot.org/c/coreboot/+/56840/comment/a80c1826_2fab1602
PS1, Line 12: TEST=manual test on Madoo
> What (button/switch) did you test exactly?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56840
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d1f43e4dd56318af4c1d5f5c1c3a2c237a05c5f
Gerrit-Change-Number: 56840
Gerrit-PatchSet: 2
Gerrit-Owner: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Fri, 06 Aug 2021 22:41:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Karthik Ramasubramanian, Boris Mittelberg.
Hello build bot (Jenkins), Furquan Shaikh, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56840
to look at the new patch set (#2).
Change subject: mb/google/dedede: allow MKBP devices
......................................................................
mb/google/dedede: allow MKBP devices
Enable MKBP interface for all dedede family to use for buttons and switches.
BUG=b:170966461
TEST=manual test on Madoo:
Volume Up/Down and Power buttons, Tablet Mode switch
Cq-Depend:chromium:3069163
Signed-off-by: Boris Mittelberg <bmbm(a)google.com>
Change-Id: I9d1f43e4dd56318af4c1d5f5c1c3a2c237a05c5f
---
M src/mainboard/google/dedede/variants/baseboard/include/baseboard/ec.h
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/56840/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56840
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d1f43e4dd56318af4c1d5f5c1c3a2c237a05c5f
Gerrit-Change-Number: 56840
Gerrit-PatchSet: 2
Gerrit-Owner: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com>
Gerrit-MessageType: newpatchset
Jack Rosenthal has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56864 )
Change subject: elogtool: add to gitignore
......................................................................
elogtool: add to gitignore
Add the binary output of the new elogtool to the .gitignore, so that
running "make -C util/cbfstool" keeps the tree clean.
Signed-off-by: Jack Rosenthal <jrosenth(a)chromium.org>
Change-Id: I806338a4b33abbc3d55e4edef2736c19d56fa005
---
M util/cbfstool/.gitignore
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/56864/1
diff --git a/util/cbfstool/.gitignore b/util/cbfstool/.gitignore
index a63222a..2de3ccb 100644
--- a/util/cbfstool/.gitignore
+++ b/util/cbfstool/.gitignore
@@ -1,5 +1,6 @@
cbfs-compression-tool
cbfstool
+elogtool
fmaptool
ifittool
ifwitool
--
To view, visit https://review.coreboot.org/c/coreboot/+/56864
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I806338a4b33abbc3d55e4edef2736c19d56fa005
Gerrit-Change-Number: 56864
Gerrit-PatchSet: 1
Gerrit-Owner: Jack Rosenthal <jrosenth(a)chromium.org>
Gerrit-MessageType: newchange
Attention is currently required from: Martin Roth, Karthik Ramasubramanian, Felix Held.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56818 )
Change subject: soc/amd/common/block/spi: Don't update spi speed if EFS is changed
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/common/block/spi/fch_spi.c:
https://review.coreboot.org/c/coreboot/+/56818/comment/16de0e2b_4e351473
PS2, Line 84: if (CONFIG(EM100))
: fch_spi_config_em100_modes();
: else
: fch_spi_config_mb_modes();
> Ok, I think we're all in agreement.
Agreement that these separate calls for em100 need to be dropped and configure read mode, fast speed and alt io speed using EFS and rest using Kconfig?
Let's keep the comment open until that is addressed.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56818
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I278768e361499919666d07e1dd92d83c2390035e
Gerrit-Change-Number: 56818
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Fri, 06 Aug 2021 21:41:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth <martinroth(a)google.com>
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Gerrit-MessageType: comment