coreboot-gerrit August 2021

coreboot-gerrit@coreboot.org

1 participants
4520 discussions

Change in coreboot[master]: mb/system76/oryp6: Drop DIMM_SPD_SIZE
by Felix Singer (Code Review) 07 Aug '21

07 Aug '21

Attention is currently required from: Tim Crawford, Jeremy Soller. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56865 ) Change subject: mb/system76/oryp6: Drop DIMM_SPD_SIZE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56865 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie71a0fea1ff9de6c4f1ce8db2db09bb3cd35d04d Gerrit-Change-Number: 56865 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Comment-Date: Sat, 07 Aug 2021 10:38:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/acer/g43t-am3: Add documentation
by Michael Büchler (Code Review) 07 Aug '21

07 Aug '21

Attention is currently required from: Paul Menzel. Michael Büchler has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56838 ) Change subject: mb/acer/g43t-am3: Add documentation ...................................................................... Patch Set 2: (7 comments) Patchset: PS2: Thank you for having a look. I wrapped the lines to something below 79, I hope that is what you intended. Good point about the board status, I think I can update it this weekend. File Documentation/mainboard/acer/g43t-am3.md: https://review.coreboot.org/c/coreboot/+/56838/comment/40e4f9cb_23ed8f62 PS1, Line 25: There is no serial port. Serial console output is possible by soldering to a point at the corresponding Super I/O pin and patching the mainboard-specific code accordingly. > Please wrap the line. Done https://review.coreboot.org/c/coreboot/+/56838/comment/b761babe_98980e68 PS1, Line 30: > Please mention the payload and OS version. Done. Should I add a note how to boot Windows 10? It needs the VGA BIOS and libgfxinit disabled. I want to test libgfxinit linear framebuffer + TianoCore, but I would have to reduce ME size to fit TianoCore, still on my list. https://review.coreboot.org/c/coreboot/+/56838/comment/4b373504_b893401c PS1, Line 41: + PS/2 mouse and keyboard (needs CONFIG_SEABIOS_PS2_TIMEOUT, tested: 500) > For SeaBIOS payload. […] Yes there it works. I didn't know how to boot from USB with FILO so that's all I can say about that payload. I added these notes in two indented list items, is that okay? https://review.coreboot.org/c/coreboot/+/56838/comment/1a4033ad_a4105355 PS1, Line 49: + DDR3 memory with 512Mx8 chips (G43 limitation) > So it does not work with the vendor firmware either, right? I don't have that particular RAM at hand anymore but I'm pretty sure it doesn't. My 4GB sticks with sixteen 256Mx8 chips already make it fail (it beeps continuously once powered on). Maybe leave it out if it is a chipset limitation, which I think it is without having any good reference? https://review.coreboot.org/c/coreboot/+/56838/comment/ae8e9aec_91539721 PS1, Line 110: ``` : +---+---+ : SPI_CSn <- | x | x | -> VCC : +---+---+ : SPI_MISO <- | x | x | -> HOLDn : +---+---+ : WPn <- | x | x | -> SPI_CLK : +---+---+ : GND <- | x | x | -> SPI_MOSI : +---+---+ : ``` > I’d just indent it by four spaces to mark it up as code block. Done https://review.coreboot.org/c/coreboot/+/56838/comment/cdabe639_88d72f6b PS1, Line 129: During a discussion in #coreboot on IRC, ECS was suspected to be the original designer of this series of mainboards. They have similar models such as the ECS G43T-WM. > Though not important for the rendered output, please continue the line above. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/56838 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0e296b3efbff0260f32badc699f1062f9885fa53 Gerrit-Change-Number: 56838 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Büchler <michael.buechler(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sat, 07 Aug 2021 10:35:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/acer/g43t-am3: Add documentation
by Michael Büchler (Code Review) 07 Aug '21

07 Aug '21

Attention is currently required from: Michael Büchler. Hello build bot (Jenkins), Paul Menzel, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56838 to look at the new patch set (#2). Change subject: mb/acer/g43t-am3: Add documentation ...................................................................... mb/acer/g43t-am3: Add documentation Signed-off-by: Michael Büchler <michael.buechler(a)posteo.net> Change-Id: I0e296b3efbff0260f32badc699f1062f9885fa53 --- A Documentation/mainboard/acer/g43t-am3.md M Documentation/mainboard/index.md 2 files changed, 154 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/56838/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56838 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0e296b3efbff0260f32badc699f1062f9885fa53 Gerrit-Change-Number: 56838 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Büchler <michael.buechler(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michael Büchler <michael.buechler(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: crossgcc: upgrade Expat from 2.2.9 to 2.4.1
by linear (Code Review) 07 Aug '21

07 Aug '21

Attention is currently required from: Paul Menzel. linear has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56868 ) Change subject: crossgcc: upgrade Expat from 2.2.9 to 2.4.1 ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/56868/comment/3081f671_5c74a707 PS1, Line 7: upgrade Expat to version 2.4.1 > Maybe: Update version from 2.4.0 to 2.4. […] Done https://review.coreboot.org/c/coreboot/+/56868/comment/e25cda5e_41f2ae70 PS1, Line 9: versions > Versions Done Patchset: PS1: > Out of curiosity, it’d be great to know if it results in any differences for any board image (BUILD_ […] i can do a build tomorrow. it will be on an aarch64 machine with debian, as that's all i have access to right now that will give me a reasonable build time - i'm not sure if that will affect the result. note that i can't do a build form before the patch, since i cannot build it (the very reason i am making this commit) -- To view, visit https://review.coreboot.org/c/coreboot/+/56868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iec2cf560902dc556a41206d7dcd65c22cf3e1215 Gerrit-Change-Number: 56868 Gerrit-PatchSet: 2 Gerrit-Owner: linear <ky0ko(a)disroot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sat, 07 Aug 2021 10:03:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/system76/oryp6: Drop DIMM_SPD_SIZE
by Paul Menzel (Code Review) 07 Aug '21

07 Aug '21

Attention is currently required from: Tim Crawford, Jeremy Soller. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56865 ) Change subject: mb/system76/oryp6: Drop DIMM_SPD_SIZE ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/56865 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie71a0fea1ff9de6c4f1ce8db2db09bb3cd35d04d Gerrit-Change-Number: 56865 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Comment-Date: Sat, 07 Aug 2021 09:16:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lenovo/x230: introduce FHD variant
by Paul Menzel (Code Review) 07 Aug '21

07 Aug '21

Attention is currently required from: Kilian Neuner, Charles Moyes, Alexander Couzens. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 ) Change subject: lenovo/x230: introduce FHD variant ...................................................................... Patch Set 12: (1 comment) Patchset: PS12: > This is quite a popular hardware mod for Thinkpad x230 laptops. […] A rebase, and test report would be a good start. ;-) -- To view, visit https://review.coreboot.org/c/coreboot/+/28950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Gerrit-Change-Number: 28950 Gerrit-PatchSet: 12 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kilian Neuner <cb(a)9-r.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Richard Slindee Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aleksei Kharlamov <derlafff(a)ya.ru> Gerrit-CC: Charles Moyes <thechuckster(a)gmail.com> Gerrit-CC: Christian Herzog Gerrit-CC: Holger Levsen <holger(a)layer-acht.org> Gerrit-CC: Matthias Wiedhalm Gerrit-CC: Pavel Kovalenko <su(a)nitrocaster.me> Gerrit-CC: Sergey Alirzaev <zl29ah(a)gmail.com> Gerrit-CC: Stanislaw Kaminski <stanislaw.kaminski(a)gmail.com> Gerrit-CC: Tom Hiller <thrilleratplay(a)gmail.com> Gerrit-CC: Tomasz Jan Góralczyk Gerrit-CC: clayton craft Gerrit-CC: nullmark <nullmark(a)googlemail.com> Gerrit-CC: slact Gerrit-Attention: Kilian Neuner <cb(a)9-r.net> Gerrit-Attention: Charles Moyes <thechuckster(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 07 Aug 2021 09:16:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Charles Moyes <thechuckster(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8192: initialize DFD
by Paul Menzel (Code Review) 07 Aug '21

07 Aug '21

Attention is currently required from: Rex-BC Chen. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56797 ) Change subject: soc/mediatek/mt8192: initialize DFD ...................................................................... Patch Set 4: (1 comment) File src/soc/mediatek/mt8192/include/soc/dfd.h: https://review.coreboot.org/c/coreboot/+/56797/comment/9bd8a336_11d966d9 PS4, Line 6: #define CPC_FLOW_CTRL_CFG 0x0C53A814 : #define RESET_ON_KEEP_EN BIT(17) : : /* DFD dump address and size need to be the same as defined in Kernel DTS. */ : #define DFD_DUMP_ADDRESS 0x6A000000 : #define DFD_DUMP_SIZE (1 * MiB) > Where are these – besides `RESET_ON_KEEP_EN` – used? Sorry, missed one hunk [1]. [1]: https://review.coreboot.org/c/coreboot/+/56797/4/src/soc/mediatek/mt8192/so… -- To view, visit https://review.coreboot.org/c/coreboot/+/56797 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39a4391c1d1e832d77b709f8f899bb1c6dcacd69 Gerrit-Change-Number: 56797 Gerrit-PatchSet: 4 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Sat, 07 Aug 2021 09:10:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8192: initialize DFD
by Paul Menzel (Code Review) 07 Aug '21

07 Aug '21

Attention is currently required from: Rex-BC Chen. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56797 ) Change subject: soc/mediatek/mt8192: initialize DFD ...................................................................... Patch Set 4: (3 comments) File src/soc/mediatek/mt8192/Kconfig: https://review.coreboot.org/c/coreboot/+/56797/comment/66a83d42_40cae3a1 PS4, Line 70: This option enables DFD (Design for Debug) settings. Please extend the description in a followup. File src/soc/mediatek/mt8192/dfd.c: https://review.coreboot.org/c/coreboot/+/56797/comment/55899d2d_fb6a3888 PS4, Line 9: printk(BIOS_INFO, "[%s]\n", __func__); This reads like a debug message. File src/soc/mediatek/mt8192/include/soc/dfd.h: https://review.coreboot.org/c/coreboot/+/56797/comment/87482154_381fa153 PS4, Line 6: #define CPC_FLOW_CTRL_CFG 0x0C53A814 : #define RESET_ON_KEEP_EN BIT(17) : : /* DFD dump address and size need to be the same as defined in Kernel DTS. */ : #define DFD_DUMP_ADDRESS 0x6A000000 : #define DFD_DUMP_SIZE (1 * MiB) Where are these – besides `RESET_ON_KEEP_EN` – used? -- To view, visit https://review.coreboot.org/c/coreboot/+/56797 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39a4391c1d1e832d77b709f8f899bb1c6dcacd69 Gerrit-Change-Number: 56797 Gerrit-PatchSet: 4 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Sat, 07 Aug 2021 09:09:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/kconfig: detect ncurses on FreeBSD
by Paul Menzel (Code Review) 07 Aug '21

07 Aug '21

Attention is currently required from: Idwer Vollering. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56677 ) Change subject: util/kconfig: detect ncurses on FreeBSD ...................................................................... Patch Set 6: (1 comment) Patchset: PS4: > Martin, why did you submit it? Should I have given -1 to prevent premature submission. […] It’s not a big deal, as it can be easily reverted/improved, but as the long term goal is to reduce our Kconfig differences in regards to Kconfig upstream, it would be great to have a proper analysis on the failure (and a elaborate description in the patch files in the directory `patches/`. Right now, that would fall on the people wanting to upstream the changes making it even harder. -- To view, visit https://review.coreboot.org/c/coreboot/+/56677 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4344ba2116c0b8618357db4248d993509cbb666e Gerrit-Change-Number: 56677 Gerrit-PatchSet: 6 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Comment-Date: Sat, 07 Aug 2021 09:03:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth <martinroth(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/kconfig: detect ncurses on FreeBSD
by Paul Menzel (Code Review) 07 Aug '21

07 Aug '21

Attention is currently required from: Idwer Vollering. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56677 ) Change subject: util/kconfig: detect ncurses on FreeBSD ...................................................................... Patch Set 6: (1 comment) Patchset: PS4: > It sounds like it doesn't fail so long as HOSTCC is overridden. […] Martin, why did you submit it? Should I have given -1 to prevent premature submission. At least I do not know if Idwer’s comment referred to testing with Kconfig from Linux upstream or with coreboot. -- To view, visit https://review.coreboot.org/c/coreboot/+/56677 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4344ba2116c0b8618357db4248d993509cbb666e Gerrit-Change-Number: 56677 Gerrit-PatchSet: 6 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Comment-Date: Sat, 07 Aug 2021 09:00:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth <martinroth(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2021