Attention is currently required from: Jeremy Soller, Paul Menzel, Angel Pons, Arthur Heymans.
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56888 )
Change subject: mb/system76/*: Add CMOS option table
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56888/comment/e60c1393_47a5789d
PS1, Line 10: providing a generic layout.
> … with the defaults: […]
Done
File src/mainboard/system76/gaze15/cmos.layout:
https://review.coreboot.org/c/coreboot/+/56888/comment/9c70ded7_c26e7b7d
PS1, Line 17: 1 0 Disable
: 1 1 Enable
> Indeed. […]
Removed the unused enum.
Almost every other board in the tree uses these indices for these values, so I kept them consistent.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56888
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie57b0e5713bba8ad46e1a4123a3ddd43e0eea964
Gerrit-Change-Number: 56888
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Tue, 10 Aug 2021 13:19:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Attention is currently required from: Tim Crawford, Jeremy Soller, Arthur Heymans.
Hello build bot (Jenkins), Jeremy Soller, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56888
to look at the new patch set (#2).
Change subject: mb/system76/*: Add CMOS option table
......................................................................
mb/system76/*: Add CMOS option table
System76 uses several custom CMOS values downstream. Reduce our diff by
providing a generic layout with the defaults:
boot_option=Fallback
debug_level=Debug
power_on_after_fail=Enable
Tested on galp3-c, gaze15, oryp5, oryp6. All boards boot multiple times
with USE_OPTION_TABLE selected.
Change-Id: Ie57b0e5713bba8ad46e1a4123a3ddd43e0eea964
Signed-off-by: Tim Crawford <tcrawford(a)system76.com>
---
M src/mainboard/system76/gaze15/Kconfig
A src/mainboard/system76/gaze15/cmos.default
A src/mainboard/system76/gaze15/cmos.layout
M src/mainboard/system76/lemp9/Kconfig
A src/mainboard/system76/lemp9/cmos.default
A src/mainboard/system76/lemp9/cmos.layout
M src/mainboard/system76/oryp5/Kconfig
A src/mainboard/system76/oryp5/cmos.default
A src/mainboard/system76/oryp5/cmos.layout
M src/mainboard/system76/oryp6/Kconfig
A src/mainboard/system76/oryp6/cmos.default
A src/mainboard/system76/oryp6/cmos.layout
M src/mainboard/system76/whl-u/Kconfig
A src/mainboard/system76/whl-u/cmos.default
A src/mainboard/system76/whl-u/cmos.layout
15 files changed, 205 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/56888/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56888
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie57b0e5713bba8ad46e1a4123a3ddd43e0eea964
Gerrit-Change-Number: 56888
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Attention is currently required from: Maxim Polyakov, Jonathan Zhang, Paul Menzel.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56886 )
Change subject: MAINTAINERS: Add Maxim Polyakov as intelp2m maintainer
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56886/comment/901505e6_d83e26db
PS2, Line 7: myself
> Done
Personally, I prefer to use `myself`. My name already appears in the Signed-off-by line and matches that of the commit author, and I feel that `myself` makes it clearer that I'm not adding someone else (when reviewing such a case, I'd wait for the person being added as maintainer to acknowledge the change).
But this isn't a change of mine, so I don't really care. I feel that delaying this change because of such a minute subjective aspect is outright draconian, and needlessly creates friction during reviews.
TL;DR: Yet Another Rant, nothing to be done about it.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56886
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85835712926ca456b108b1d80e6a55f75e604591
Gerrit-Change-Number: 56886
Gerrit-PatchSet: 3
Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Tue, 10 Aug 2021 12:30:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Chen Wisley, Paul Menzel, Tim Wawrzynczak, Wisley Chen.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56893 )
Change subject: mb/google/brya/variants/redrix: add mipi camera support
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/variants/redrix/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56893/comment/28da0cfa_411ccf9a
PS2, Line 128: register "acpi_uid" = "0x50000"
: register "acpi_name" = ""IPU0""
: register "device_type" = "INTEL_ACPI_CAMERA_CIO2"
> Off-topic: This seems to be the same for all mipi_camera entries. […]
I don't think this is something that this patch should address.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56893
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69281f36ddbc1abf9905c8db9287500f9aa995c6
Gerrit-Change-Number: 56893
Gerrit-PatchSet: 3
Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Chen Wisley <wisley.chen(a)quantatw.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 10 Aug 2021 12:08:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Matt DeVillier, Benjamin Doron, Paul Menzel, Angel Pons, Michael Niewöhner.
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56887 )
Change subject: util/intelp2m: Remove non-DWx register analysis support
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56887/comment/50f04b2d_52caeb05
PS3, Line 12: master
> Nit: master branch
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56887
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If5c77ff942a620897c085be4135cb879a0d40a00
Gerrit-Change-Number: 56887
Gerrit-PatchSet: 4
Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-CC: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Comment-Date: Tue, 10 Aug 2021 10:27:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment